1 #include "cyclegraph.h"
6 #include "threads-model.h"
8 /** Initializes a CycleGraph object. */
9 CycleGraph::CycleGraph() :
10 discovered(new HashTable<const CycleNode *, const CycleNode *, uintptr_t, 4, model_malloc, model_calloc, model_free>(16)),
11 queue(new ModelVector<const CycleNode *>()),
17 /** CycleGraph destructor */
18 CycleGraph::~CycleGraph()
25 * Add a CycleNode to the graph, corresponding to a store ModelAction
26 * @param act The write action that should be added
27 * @param node The CycleNode that corresponds to the store
29 void CycleGraph::putNode(const ModelAction *act, CycleNode *node)
31 actionToNode.put(act, node);
32 #if SUPPORT_MOD_ORDER_DUMP
33 nodeList.push_back(node);
38 * Add a CycleNode to the graph, corresponding to a Promise
39 * @param promise The Promise that should be added
40 * @param node The CycleNode that corresponds to the Promise
42 void CycleGraph::putNode(const Promise *promise, CycleNode *node)
44 promiseToNode.put(promise, node);
45 #if SUPPORT_MOD_ORDER_DUMP
46 nodeList.push_back(node);
51 * @brief Remove the Promise node from the graph
52 * @param promise The promise to remove from the graph
54 void CycleGraph::erasePromiseNode(const Promise *promise)
56 promiseToNode.put(promise, NULL);
57 #if SUPPORT_MOD_ORDER_DUMP
58 /* Remove the promise node from nodeList */
59 CycleNode *node = getNode_noCreate(promise);
60 for (unsigned int i = 0; i < nodeList.size(); )
61 if (nodeList[i] == node)
62 nodeList.erase(nodeList.begin() + i);
68 /** @return The corresponding CycleNode, if exists; otherwise NULL */
69 CycleNode * CycleGraph::getNode_noCreate(const ModelAction *act) const
71 return actionToNode.get(act);
74 /** @return The corresponding CycleNode, if exists; otherwise NULL */
75 CycleNode * CycleGraph::getNode_noCreate(const Promise *promise) const
77 return promiseToNode.get(promise);
81 * @brief Returns the CycleNode corresponding to a given ModelAction
83 * Gets (or creates, if none exist) a CycleNode corresponding to a ModelAction
85 * @param action The ModelAction to find a node for
86 * @return The CycleNode paired with this action
88 CycleNode * CycleGraph::getNode(const ModelAction *action)
90 CycleNode *node = getNode_noCreate(action);
92 node = new CycleNode(action);
93 putNode(action, node);
99 * @brief Returns a CycleNode corresponding to a promise
101 * Gets (or creates, if none exist) a CycleNode corresponding to a promised
104 * @param promise The Promise generated by a reader
105 * @return The CycleNode corresponding to the Promise
107 CycleNode * CycleGraph::getNode(const Promise *promise)
109 CycleNode *node = getNode_noCreate(promise);
111 node = new CycleNode(promise);
112 putNode(promise, node);
118 * Resolve/satisfy a Promise with a particular store ModelAction, taking care
119 * of the CycleGraph cleanups, including merging any necessary CycleNodes.
121 * @param promise The Promise to resolve
122 * @param writer The store that will resolve this Promise
123 * @return false if the resolution results in a cycle (or fails in some other
124 * way); true otherwise
126 bool CycleGraph::resolvePromise(const Promise *promise, ModelAction *writer)
128 CycleNode *promise_node = promiseToNode.get(promise);
129 CycleNode *w_node = actionToNode.get(writer);
130 ASSERT(promise_node);
133 return mergeNodes(w_node, promise_node);
134 /* No existing write-node; just convert the promise-node */
135 promise_node->resolvePromise(writer);
136 erasePromiseNode(promise_node->getPromise());
137 putNode(writer, promise_node);
142 * @brief Merge two CycleNodes that represent the same write
144 * Note that this operation cannot be rolled back.
146 * @param w_node The write ModelAction node with which to merge
147 * @param p_node The Promise node to merge. Will be destroyed after this
150 * @return false if the merge cannot succeed; true otherwise
152 bool CycleGraph::mergeNodes(CycleNode *w_node, CycleNode *p_node)
154 ASSERT(!w_node->is_promise());
155 ASSERT(p_node->is_promise());
157 const Promise *promise = p_node->getPromise();
158 if (!promise->is_compatible(w_node->getAction()) ||
159 !promise->same_value(w_node->getAction()))
162 /* Transfer the RMW */
163 CycleNode *promise_rmw = p_node->getRMW();
164 if (promise_rmw && promise_rmw != w_node->getRMW() && w_node->setRMW(promise_rmw))
167 /* Transfer back edges to w_node */
168 while (p_node->getNumBackEdges() > 0) {
169 CycleNode *back = p_node->removeBackEdge();
172 addNodeEdge(back, w_node);
177 /* Transfer forward edges to w_node */
178 while (p_node->getNumEdges() > 0) {
179 CycleNode *forward = p_node->removeEdge();
180 if (forward == w_node)
182 addNodeEdge(w_node, forward);
187 erasePromiseNode(promise);
188 /* Not deleting p_node, to maintain consistency if mergeNodes() fails */
194 * Adds an edge between two CycleNodes.
195 * @param fromnode The edge comes from this CycleNode
196 * @param tonode The edge points to this CycleNode
197 * @return True, if new edge(s) are added; otherwise false
199 bool CycleGraph::addNodeEdge(CycleNode *fromnode, CycleNode *tonode)
201 if (fromnode->addEdge(tonode)) {
202 rollbackvector.push_back(fromnode);
204 hasCycles = checkReachable(tonode, fromnode);
206 return false; /* No new edge */
209 * If the fromnode has a rmwnode that is not the tonode, we should
210 * follow its RMW chain to add an edge at the end, unless we encounter
211 * tonode along the way
213 CycleNode *rmwnode = fromnode->getRMW();
215 while (rmwnode != tonode && rmwnode->getRMW())
216 rmwnode = rmwnode->getRMW();
218 if (rmwnode != tonode) {
219 if (rmwnode->addEdge(tonode)) {
221 hasCycles = checkReachable(tonode, rmwnode);
223 rollbackvector.push_back(rmwnode);
231 * @brief Add an edge between a write and the RMW which reads from it
233 * Handles special case of a RMW action, where the ModelAction rmw reads from
234 * the ModelAction/Promise from. The key differences are:
235 * (1) no write can occur in between the rmw and the from action.
236 * (2) Only one RMW action can read from a given write.
238 * @param from The edge comes from this ModelAction/Promise
239 * @param rmw The edge points to this ModelAction; this action must read from
240 * the ModelAction/Promise from
242 template <typename T>
243 void CycleGraph::addRMWEdge(const T *from, const ModelAction *rmw)
248 CycleNode *fromnode = getNode(from);
249 CycleNode *rmwnode = getNode(rmw);
251 /* We assume that this RMW has no RMW reading from it yet */
252 ASSERT(!rmwnode->getRMW());
254 /* Two RMW actions cannot read from the same write. */
255 if (fromnode->setRMW(rmwnode))
258 rmwrollbackvector.push_back(fromnode);
260 /* Transfer all outgoing edges from the from node to the rmw node */
261 /* This process should not add a cycle because either:
262 * (1) The rmw should not have any incoming edges yet if it is the
264 * (2) the fromnode is the new node and therefore it should not
265 * have any outgoing edges.
267 for (unsigned int i = 0; i < fromnode->getNumEdges(); i++) {
268 CycleNode *tonode = fromnode->getEdge(i);
269 if (tonode != rmwnode) {
270 if (rmwnode->addEdge(tonode))
271 rollbackvector.push_back(rmwnode);
275 addNodeEdge(fromnode, rmwnode);
277 /* Instantiate two forms of CycleGraph::addRMWEdge */
278 template void CycleGraph::addRMWEdge(const ModelAction *from, const ModelAction *rmw);
279 template void CycleGraph::addRMWEdge(const Promise *from, const ModelAction *rmw);
282 * @brief Adds an edge between objects
284 * This function will add an edge between any two objects which can be
285 * associated with a CycleNode. That is, if they have a CycleGraph::getNode
288 * The object to is ordered after the object from.
290 * @param to The edge points to this object, of type T
291 * @param from The edge comes from this object, of type U
292 * @return True, if new edge(s) are added; otherwise false
294 template <typename T, typename U>
295 bool CycleGraph::addEdge(const T *from, const U *to)
300 CycleNode *fromnode = getNode(from);
301 CycleNode *tonode = getNode(to);
303 return addNodeEdge(fromnode, tonode);
305 /* Instantiate four forms of CycleGraph::addEdge */
306 template bool CycleGraph::addEdge(const ModelAction *from, const ModelAction *to);
307 template bool CycleGraph::addEdge(const ModelAction *from, const Promise *to);
308 template bool CycleGraph::addEdge(const Promise *from, const ModelAction *to);
309 template bool CycleGraph::addEdge(const Promise *from, const Promise *to);
311 #if SUPPORT_MOD_ORDER_DUMP
313 static void print_node(FILE *file, const CycleNode *node, int label)
315 if (node->is_promise()) {
316 const Promise *promise = node->getPromise();
317 int idx = model->get_promise_number(promise);
318 fprintf(file, "P%u", idx);
321 fprintf(file, " [label=\"P%d, T", idx);
322 for (unsigned int i = 0 ; i < model->get_num_threads(); i++)
323 if (promise->thread_is_available(int_to_id(i))) {
324 fprintf(file, "%s%u", first ? "": ",", i);
327 fprintf(file, "\"]");
330 const ModelAction *act = node->getAction();
331 modelclock_t idx = act->get_seq_number();
332 fprintf(file, "N%u", idx);
334 fprintf(file, " [label=\"N%u, T%u\"]", idx, act->get_tid());
338 static void print_edge(FILE *file, const CycleNode *from, const CycleNode *to, const char *prop)
340 print_node(file, from, 0);
341 fprintf(file, " -> ");
342 print_node(file, to, 0);
343 if (prop && strlen(prop))
344 fprintf(file, " [%s]", prop);
345 fprintf(file, ";\n");
348 void CycleGraph::dot_print_node(FILE *file, const ModelAction *act)
350 print_node(file, getNode(act), 1);
353 template <typename T, typename U>
354 void CycleGraph::dot_print_edge(FILE *file, const T *from, const U *to, const char *prop)
356 CycleNode *fromnode = getNode(from);
357 CycleNode *tonode = getNode(to);
359 print_edge(file, fromnode, tonode, prop);
361 /* Instantiate two forms of CycleGraph::dot_print_edge */
362 template void CycleGraph::dot_print_edge(FILE *file, const Promise *from, const ModelAction *to, const char *prop);
363 template void CycleGraph::dot_print_edge(FILE *file, const ModelAction *from, const ModelAction *to, const char *prop);
365 void CycleGraph::dumpNodes(FILE *file) const
367 for (unsigned int i = 0; i < nodeList.size(); i++) {
368 CycleNode *n = nodeList[i];
369 print_node(file, n, 1);
370 fprintf(file, ";\n");
372 print_edge(file, n, n->getRMW(), "style=dotted");
373 for (unsigned int j = 0; j < n->getNumEdges(); j++)
374 print_edge(file, n, n->getEdge(j), NULL);
378 void CycleGraph::dumpGraphToFile(const char *filename) const
381 sprintf(buffer, "%s.dot", filename);
382 FILE *file = fopen(buffer, "w");
383 fprintf(file, "digraph %s {\n", filename);
385 fprintf(file, "}\n");
391 * Checks whether one CycleNode can reach another.
392 * @param from The CycleNode from which to begin exploration
393 * @param to The CycleNode to reach
394 * @return True, @a from can reach @a to; otherwise, false
396 bool CycleGraph::checkReachable(const CycleNode *from, const CycleNode *to) const
400 queue->push_back(from);
401 discovered->put(from, from);
402 while (!queue->empty()) {
403 const CycleNode *node = queue->back();
407 for (unsigned int i = 0; i < node->getNumEdges(); i++) {
408 CycleNode *next = node->getEdge(i);
409 if (!discovered->contains(next)) {
410 discovered->put(next, next);
411 queue->push_back(next);
419 * Checks whether one ModelAction/Promise can reach another ModelAction/Promise
420 * @param from The ModelAction or Promise from which to begin exploration
421 * @param to The ModelAction or Promise to reach
422 * @return True, @a from can reach @a to; otherwise, false
424 template <typename T, typename U>
425 bool CycleGraph::checkReachable(const T *from, const U *to) const
427 CycleNode *fromnode = getNode_noCreate(from);
428 CycleNode *tonode = getNode_noCreate(to);
430 if (!fromnode || !tonode)
433 return checkReachable(fromnode, tonode);
435 /* Instantiate four forms of CycleGraph::checkReachable */
436 template bool CycleGraph::checkReachable(const ModelAction *from,
437 const ModelAction *to) const;
438 template bool CycleGraph::checkReachable(const ModelAction *from,
439 const Promise *to) const;
440 template bool CycleGraph::checkReachable(const Promise *from,
441 const ModelAction *to) const;
442 template bool CycleGraph::checkReachable(const Promise *from,
443 const Promise *to) const;
445 /** @return True, if the promise has failed; false otherwise */
446 bool CycleGraph::checkPromise(const ModelAction *fromact, Promise *promise) const
450 CycleNode *from = actionToNode.get(fromact);
452 queue->push_back(from);
453 discovered->put(from, from);
454 while (!queue->empty()) {
455 const CycleNode *node = queue->back();
458 if (node->getPromise() == promise)
460 if (!node->is_promise() &&
461 promise->eliminate_thread(node->getAction()->get_tid()))
464 for (unsigned int i = 0; i < node->getNumEdges(); i++) {
465 CycleNode *next = node->getEdge(i);
466 if (!discovered->contains(next)) {
467 discovered->put(next, next);
468 queue->push_back(next);
475 void CycleGraph::startChanges()
477 ASSERT(rollbackvector.empty());
478 ASSERT(rmwrollbackvector.empty());
479 ASSERT(oldCycles == hasCycles);
482 /** Commit changes to the cyclegraph. */
483 void CycleGraph::commitChanges()
485 rollbackvector.clear();
486 rmwrollbackvector.clear();
487 oldCycles = hasCycles;
490 /** Rollback changes to the previous commit. */
491 void CycleGraph::rollbackChanges()
493 for (unsigned int i = 0; i < rollbackvector.size(); i++)
494 rollbackvector[i]->removeEdge();
496 for (unsigned int i = 0; i < rmwrollbackvector.size(); i++)
497 rmwrollbackvector[i]->clearRMW();
499 hasCycles = oldCycles;
500 rollbackvector.clear();
501 rmwrollbackvector.clear();
504 /** @returns whether a CycleGraph contains cycles. */
505 bool CycleGraph::checkForCycles() const
511 * @brief Constructor for a CycleNode
512 * @param act The ModelAction for this node
514 CycleNode::CycleNode(const ModelAction *act) :
522 * @brief Constructor for a Promise CycleNode
523 * @param promise The Promise which was generated
525 CycleNode::CycleNode(const Promise *promise) :
533 * @param i The index of the edge to return
534 * @returns The a CycleNode edge indexed by i
536 CycleNode * CycleNode::getEdge(unsigned int i) const
541 /** @returns The number of edges leaving this CycleNode */
542 unsigned int CycleNode::getNumEdges() const
547 CycleNode * CycleNode::getBackEdge(unsigned int i) const
549 return back_edges[i];
552 unsigned int CycleNode::getNumBackEdges() const
554 return back_edges.size();
558 * @brief Remove an element from a vector
559 * @param v The vector
560 * @param n The element to remove
561 * @return True if the element was found; false otherwise
563 template <typename T>
564 static bool vector_remove_node(SnapVector<T>& v, const T n)
566 for (unsigned int i = 0; i < v.size(); i++) {
568 v.erase(v.begin() + i);
576 * @brief Remove a (forward) edge from this CycleNode
577 * @return The CycleNode which was popped, if one exists; otherwise NULL
579 CycleNode * CycleNode::removeEdge()
584 CycleNode *ret = edges.back();
586 vector_remove_node(ret->back_edges, this);
591 * @brief Remove a (back) edge from this CycleNode
592 * @return The CycleNode which was popped, if one exists; otherwise NULL
594 CycleNode * CycleNode::removeBackEdge()
596 if (back_edges.empty())
599 CycleNode *ret = back_edges.back();
600 back_edges.pop_back();
601 vector_remove_node(ret->edges, this);
606 * Adds an edge from this CycleNode to another CycleNode.
607 * @param node The node to which we add a directed edge
608 * @return True if this edge is a new edge; false otherwise
610 bool CycleNode::addEdge(CycleNode *node)
612 for (unsigned int i = 0; i < edges.size(); i++)
613 if (edges[i] == node)
615 edges.push_back(node);
616 node->back_edges.push_back(this);
620 /** @returns the RMW CycleNode that reads from the current CycleNode */
621 CycleNode * CycleNode::getRMW() const
627 * Set a RMW action node that reads from the current CycleNode.
628 * @param node The RMW that reads from the current node
629 * @return True, if this node already was read by another RMW; false otherwise
630 * @see CycleGraph::addRMWEdge
632 bool CycleNode::setRMW(CycleNode *node)
641 * Convert a Promise CycleNode into a concrete-valued CycleNode. Should only be
642 * used when there's no existing ModelAction CycleNode for this write.
644 * @param writer The ModelAction which wrote the future value represented by
647 void CycleNode::resolvePromise(const ModelAction *writer)
649 ASSERT(is_promise());
650 ASSERT(promise->is_compatible(writer));
653 ASSERT(!is_promise());