2 * Copyright 2006 Dave Airlie <airlied@linux.ie>
3 * Copyright © 2006-2009 Intel Corporation
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
12 * The above copyright notice and this permission notice (including the next
13 * paragraph) shall be included in all copies or substantial portions of the
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
22 * DEALINGS IN THE SOFTWARE.
25 * Eric Anholt <eric@anholt.net>
26 * Jesse Barnes <jesse.barnes@intel.com>
29 #include <linux/i2c.h>
30 #include <linux/slab.h>
31 #include <linux/delay.h>
36 #include "intel_drv.h"
40 struct intel_hdmi *enc_to_intel_hdmi(struct drm_encoder *encoder)
42 return container_of(encoder, struct intel_hdmi, base.base);
45 static struct intel_hdmi *intel_attached_hdmi(struct drm_connector *connector)
47 return container_of(intel_attached_encoder(connector),
48 struct intel_hdmi, base);
51 void intel_dip_infoframe_csum(struct dip_infoframe *frame)
53 uint8_t *data = (uint8_t *)frame;
60 for (i = 0; i < frame->len + DIP_HEADER_SIZE; i++)
63 frame->checksum = 0x100 - sum;
66 static u32 g4x_infoframe_index(struct dip_infoframe *frame)
68 switch (frame->type) {
70 return VIDEO_DIP_SELECT_AVI;
72 return VIDEO_DIP_SELECT_SPD;
74 DRM_DEBUG_DRIVER("unknown info frame type %d\n", frame->type);
79 static u32 g4x_infoframe_enable(struct dip_infoframe *frame)
81 switch (frame->type) {
83 return VIDEO_DIP_ENABLE_AVI;
85 return VIDEO_DIP_ENABLE_SPD;
87 DRM_DEBUG_DRIVER("unknown info frame type %d\n", frame->type);
92 static void g4x_write_infoframe(struct drm_encoder *encoder,
93 struct dip_infoframe *frame)
95 uint32_t *data = (uint32_t *)frame;
96 struct drm_device *dev = encoder->dev;
97 struct drm_i915_private *dev_priv = dev->dev_private;
98 struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
99 u32 val = I915_READ(VIDEO_DIP_CTL);
100 unsigned i, len = DIP_HEADER_SIZE + frame->len;
102 val &= ~VIDEO_DIP_PORT_MASK;
103 if (intel_hdmi->sdvox_reg == SDVOB)
104 val |= VIDEO_DIP_PORT_B;
105 else if (intel_hdmi->sdvox_reg == SDVOC)
106 val |= VIDEO_DIP_PORT_C;
110 val &= ~(VIDEO_DIP_SELECT_MASK | 0xf); /* clear DIP data offset */
111 val |= g4x_infoframe_index(frame);
113 val &= ~g4x_infoframe_enable(frame);
114 val |= VIDEO_DIP_ENABLE;
116 I915_WRITE(VIDEO_DIP_CTL, val);
118 for (i = 0; i < len; i += 4) {
119 I915_WRITE(VIDEO_DIP_DATA, *data);
123 val |= g4x_infoframe_enable(frame);
124 val &= ~VIDEO_DIP_FREQ_MASK;
125 val |= VIDEO_DIP_FREQ_VSYNC;
127 I915_WRITE(VIDEO_DIP_CTL, val);
130 static void ibx_write_infoframe(struct drm_encoder *encoder,
131 struct dip_infoframe *frame)
133 uint32_t *data = (uint32_t *)frame;
134 struct drm_device *dev = encoder->dev;
135 struct drm_i915_private *dev_priv = dev->dev_private;
136 struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
137 struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
138 int reg = TVIDEO_DIP_CTL(intel_crtc->pipe);
139 unsigned i, len = DIP_HEADER_SIZE + frame->len;
140 u32 val = I915_READ(reg);
142 val &= ~VIDEO_DIP_PORT_MASK;
143 switch (intel_hdmi->sdvox_reg) {
145 val |= VIDEO_DIP_PORT_B;
148 val |= VIDEO_DIP_PORT_C;
151 val |= VIDEO_DIP_PORT_D;
157 intel_wait_for_vblank(dev, intel_crtc->pipe);
159 val &= ~(VIDEO_DIP_SELECT_MASK | 0xf); /* clear DIP data offset */
160 val |= g4x_infoframe_index(frame);
162 val &= ~g4x_infoframe_enable(frame);
163 val |= VIDEO_DIP_ENABLE;
165 I915_WRITE(reg, val);
167 for (i = 0; i < len; i += 4) {
168 I915_WRITE(TVIDEO_DIP_DATA(intel_crtc->pipe), *data);
172 val |= g4x_infoframe_enable(frame);
173 val &= ~VIDEO_DIP_FREQ_MASK;
174 val |= VIDEO_DIP_FREQ_VSYNC;
176 I915_WRITE(reg, val);
179 static void cpt_write_infoframe(struct drm_encoder *encoder,
180 struct dip_infoframe *frame)
182 uint32_t *data = (uint32_t *)frame;
183 struct drm_device *dev = encoder->dev;
184 struct drm_i915_private *dev_priv = dev->dev_private;
185 struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
186 int reg = TVIDEO_DIP_CTL(intel_crtc->pipe);
187 unsigned i, len = DIP_HEADER_SIZE + frame->len;
188 u32 val = I915_READ(reg);
190 intel_wait_for_vblank(dev, intel_crtc->pipe);
192 val &= ~(VIDEO_DIP_SELECT_MASK | 0xf); /* clear DIP data offset */
193 val |= g4x_infoframe_index(frame);
195 /* The DIP control register spec says that we need to update the AVI
196 * infoframe without clearing its enable bit */
197 if (frame->type == DIP_TYPE_AVI)
198 val |= VIDEO_DIP_ENABLE_AVI;
200 val &= ~g4x_infoframe_enable(frame);
202 val |= VIDEO_DIP_ENABLE;
204 I915_WRITE(reg, val);
206 for (i = 0; i < len; i += 4) {
207 I915_WRITE(TVIDEO_DIP_DATA(intel_crtc->pipe), *data);
211 val |= g4x_infoframe_enable(frame);
212 val &= ~VIDEO_DIP_FREQ_MASK;
213 val |= VIDEO_DIP_FREQ_VSYNC;
215 I915_WRITE(reg, val);
218 static void vlv_write_infoframe(struct drm_encoder *encoder,
219 struct dip_infoframe *frame)
221 uint32_t *data = (uint32_t *)frame;
222 struct drm_device *dev = encoder->dev;
223 struct drm_i915_private *dev_priv = dev->dev_private;
224 struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
225 int reg = VLV_TVIDEO_DIP_CTL(intel_crtc->pipe);
226 unsigned i, len = DIP_HEADER_SIZE + frame->len;
227 u32 val = I915_READ(reg);
229 intel_wait_for_vblank(dev, intel_crtc->pipe);
231 val &= ~(VIDEO_DIP_SELECT_MASK | 0xf); /* clear DIP data offset */
232 val |= g4x_infoframe_index(frame);
234 val &= ~g4x_infoframe_enable(frame);
235 val |= VIDEO_DIP_ENABLE;
237 I915_WRITE(reg, val);
239 for (i = 0; i < len; i += 4) {
240 I915_WRITE(VLV_TVIDEO_DIP_DATA(intel_crtc->pipe), *data);
244 val |= g4x_infoframe_enable(frame);
245 val &= ~VIDEO_DIP_FREQ_MASK;
246 val |= VIDEO_DIP_FREQ_VSYNC;
248 I915_WRITE(reg, val);
251 static void hsw_write_infoframe(struct drm_encoder *encoder,
252 struct dip_infoframe *frame)
254 /* Not implemented yet, so avoid doing anything at all.
255 * This is the placeholder for Paulo Zanoni's infoframe writing patch
257 DRM_DEBUG_DRIVER("Attempting to write infoframe on Haswell, this is not implemented yet.\n");
263 static void intel_set_infoframe(struct drm_encoder *encoder,
264 struct dip_infoframe *frame)
266 struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
268 if (!intel_hdmi->has_hdmi_sink)
271 intel_dip_infoframe_csum(frame);
272 intel_hdmi->write_infoframe(encoder, frame);
275 void intel_hdmi_set_avi_infoframe(struct drm_encoder *encoder,
276 struct drm_display_mode *adjusted_mode)
278 struct dip_infoframe avi_if = {
279 .type = DIP_TYPE_AVI,
280 .ver = DIP_VERSION_AVI,
284 if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK)
285 avi_if.body.avi.YQ_CN_PR |= DIP_AVI_PR_2;
287 intel_set_infoframe(encoder, &avi_if);
290 void intel_hdmi_set_spd_infoframe(struct drm_encoder *encoder)
292 struct dip_infoframe spd_if;
294 memset(&spd_if, 0, sizeof(spd_if));
295 spd_if.type = DIP_TYPE_SPD;
296 spd_if.ver = DIP_VERSION_SPD;
297 spd_if.len = DIP_LEN_SPD;
298 strcpy(spd_if.body.spd.vn, "Intel");
299 strcpy(spd_if.body.spd.pd, "Integrated gfx");
300 spd_if.body.spd.sdi = DIP_SPD_PC;
302 intel_set_infoframe(encoder, &spd_if);
305 static void intel_hdmi_mode_set(struct drm_encoder *encoder,
306 struct drm_display_mode *mode,
307 struct drm_display_mode *adjusted_mode)
309 struct drm_device *dev = encoder->dev;
310 struct drm_i915_private *dev_priv = dev->dev_private;
311 struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
312 struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
315 sdvox = SDVO_ENCODING_HDMI | SDVO_BORDER_ENABLE;
316 if (!HAS_PCH_SPLIT(dev))
317 sdvox |= intel_hdmi->color_range;
318 if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
319 sdvox |= SDVO_VSYNC_ACTIVE_HIGH;
320 if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
321 sdvox |= SDVO_HSYNC_ACTIVE_HIGH;
323 if (intel_crtc->bpp > 24)
324 sdvox |= COLOR_FORMAT_12bpc;
326 sdvox |= COLOR_FORMAT_8bpc;
328 /* Required on CPT */
329 if (intel_hdmi->has_hdmi_sink && HAS_PCH_CPT(dev))
330 sdvox |= HDMI_MODE_SELECT;
332 if (intel_hdmi->has_audio) {
333 DRM_DEBUG_DRIVER("Enabling HDMI audio on pipe %c\n",
334 pipe_name(intel_crtc->pipe));
335 sdvox |= SDVO_AUDIO_ENABLE;
336 sdvox |= SDVO_NULL_PACKETS_DURING_VSYNC;
337 intel_write_eld(encoder, adjusted_mode);
340 if (HAS_PCH_CPT(dev))
341 sdvox |= PORT_TRANS_SEL_CPT(intel_crtc->pipe);
342 else if (intel_crtc->pipe == 1)
343 sdvox |= SDVO_PIPE_B_SELECT;
345 I915_WRITE(intel_hdmi->sdvox_reg, sdvox);
346 POSTING_READ(intel_hdmi->sdvox_reg);
348 intel_hdmi_set_avi_infoframe(encoder, adjusted_mode);
349 intel_hdmi_set_spd_infoframe(encoder);
352 static void intel_hdmi_dpms(struct drm_encoder *encoder, int mode)
354 struct drm_device *dev = encoder->dev;
355 struct drm_i915_private *dev_priv = dev->dev_private;
356 struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
358 u32 enable_bits = SDVO_ENABLE;
360 if (intel_hdmi->has_audio)
361 enable_bits |= SDVO_AUDIO_ENABLE;
363 temp = I915_READ(intel_hdmi->sdvox_reg);
365 /* HW workaround, need to toggle enable bit off and on for 12bpc, but
366 * we do this anyway which shows more stable in testing.
368 if (HAS_PCH_SPLIT(dev)) {
369 I915_WRITE(intel_hdmi->sdvox_reg, temp & ~SDVO_ENABLE);
370 POSTING_READ(intel_hdmi->sdvox_reg);
373 if (mode != DRM_MODE_DPMS_ON) {
374 temp &= ~enable_bits;
379 I915_WRITE(intel_hdmi->sdvox_reg, temp);
380 POSTING_READ(intel_hdmi->sdvox_reg);
382 /* HW workaround, need to write this twice for issue that may result
383 * in first write getting masked.
385 if (HAS_PCH_SPLIT(dev)) {
386 I915_WRITE(intel_hdmi->sdvox_reg, temp);
387 POSTING_READ(intel_hdmi->sdvox_reg);
391 static int intel_hdmi_mode_valid(struct drm_connector *connector,
392 struct drm_display_mode *mode)
394 if (mode->clock > 165000)
395 return MODE_CLOCK_HIGH;
396 if (mode->clock < 20000)
397 return MODE_CLOCK_LOW;
399 if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
400 return MODE_NO_DBLESCAN;
405 static bool intel_hdmi_mode_fixup(struct drm_encoder *encoder,
406 struct drm_display_mode *mode,
407 struct drm_display_mode *adjusted_mode)
412 static enum drm_connector_status
413 intel_hdmi_detect(struct drm_connector *connector, bool force)
415 struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
416 struct drm_i915_private *dev_priv = connector->dev->dev_private;
418 enum drm_connector_status status = connector_status_disconnected;
420 intel_hdmi->has_hdmi_sink = false;
421 intel_hdmi->has_audio = false;
422 edid = drm_get_edid(connector,
423 intel_gmbus_get_adapter(dev_priv,
424 intel_hdmi->ddc_bus));
427 if (edid->input & DRM_EDID_INPUT_DIGITAL) {
428 status = connector_status_connected;
429 if (intel_hdmi->force_audio != HDMI_AUDIO_OFF_DVI)
430 intel_hdmi->has_hdmi_sink =
431 drm_detect_hdmi_monitor(edid);
432 intel_hdmi->has_audio = drm_detect_monitor_audio(edid);
434 connector->display_info.raw_edid = NULL;
438 if (status == connector_status_connected) {
439 if (intel_hdmi->force_audio != HDMI_AUDIO_AUTO)
440 intel_hdmi->has_audio =
441 (intel_hdmi->force_audio == HDMI_AUDIO_ON);
447 static int intel_hdmi_get_modes(struct drm_connector *connector)
449 struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
450 struct drm_i915_private *dev_priv = connector->dev->dev_private;
452 /* We should parse the EDID data and find out if it's an HDMI sink so
453 * we can send audio to it.
456 return intel_ddc_get_modes(connector,
457 intel_gmbus_get_adapter(dev_priv,
458 intel_hdmi->ddc_bus));
462 intel_hdmi_detect_audio(struct drm_connector *connector)
464 struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
465 struct drm_i915_private *dev_priv = connector->dev->dev_private;
467 bool has_audio = false;
469 edid = drm_get_edid(connector,
470 intel_gmbus_get_adapter(dev_priv,
471 intel_hdmi->ddc_bus));
473 if (edid->input & DRM_EDID_INPUT_DIGITAL)
474 has_audio = drm_detect_monitor_audio(edid);
476 connector->display_info.raw_edid = NULL;
484 intel_hdmi_set_property(struct drm_connector *connector,
485 struct drm_property *property,
488 struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
489 struct drm_i915_private *dev_priv = connector->dev->dev_private;
492 ret = drm_connector_property_set_value(connector, property, val);
496 if (property == dev_priv->force_audio_property) {
497 enum hdmi_force_audio i = val;
500 if (i == intel_hdmi->force_audio)
503 intel_hdmi->force_audio = i;
505 if (i == HDMI_AUDIO_AUTO)
506 has_audio = intel_hdmi_detect_audio(connector);
508 has_audio = (i == HDMI_AUDIO_ON);
510 if (i == HDMI_AUDIO_OFF_DVI)
511 intel_hdmi->has_hdmi_sink = 0;
513 intel_hdmi->has_audio = has_audio;
517 if (property == dev_priv->broadcast_rgb_property) {
518 if (val == !!intel_hdmi->color_range)
521 intel_hdmi->color_range = val ? SDVO_COLOR_RANGE_16_235 : 0;
528 if (intel_hdmi->base.base.crtc) {
529 struct drm_crtc *crtc = intel_hdmi->base.base.crtc;
530 drm_crtc_helper_set_mode(crtc, &crtc->mode,
538 static void intel_hdmi_destroy(struct drm_connector *connector)
540 drm_sysfs_connector_remove(connector);
541 drm_connector_cleanup(connector);
545 static const struct drm_encoder_helper_funcs intel_hdmi_helper_funcs_hsw = {
546 .dpms = intel_ddi_dpms,
547 .mode_fixup = intel_hdmi_mode_fixup,
548 .prepare = intel_encoder_prepare,
549 .mode_set = intel_ddi_mode_set,
550 .commit = intel_encoder_commit,
553 static const struct drm_encoder_helper_funcs intel_hdmi_helper_funcs = {
554 .dpms = intel_hdmi_dpms,
555 .mode_fixup = intel_hdmi_mode_fixup,
556 .prepare = intel_encoder_prepare,
557 .mode_set = intel_hdmi_mode_set,
558 .commit = intel_encoder_commit,
561 static const struct drm_connector_funcs intel_hdmi_connector_funcs = {
562 .dpms = drm_helper_connector_dpms,
563 .detect = intel_hdmi_detect,
564 .fill_modes = drm_helper_probe_single_connector_modes,
565 .set_property = intel_hdmi_set_property,
566 .destroy = intel_hdmi_destroy,
569 static const struct drm_connector_helper_funcs intel_hdmi_connector_helper_funcs = {
570 .get_modes = intel_hdmi_get_modes,
571 .mode_valid = intel_hdmi_mode_valid,
572 .best_encoder = intel_best_encoder,
575 static const struct drm_encoder_funcs intel_hdmi_enc_funcs = {
576 .destroy = intel_encoder_destroy,
580 intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *connector)
582 intel_attach_force_audio_property(connector);
583 intel_attach_broadcast_rgb_property(connector);
586 void intel_hdmi_init(struct drm_device *dev, int sdvox_reg)
588 struct drm_i915_private *dev_priv = dev->dev_private;
589 struct drm_connector *connector;
590 struct intel_encoder *intel_encoder;
591 struct intel_connector *intel_connector;
592 struct intel_hdmi *intel_hdmi;
595 intel_hdmi = kzalloc(sizeof(struct intel_hdmi), GFP_KERNEL);
599 intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL);
600 if (!intel_connector) {
605 intel_encoder = &intel_hdmi->base;
606 drm_encoder_init(dev, &intel_encoder->base, &intel_hdmi_enc_funcs,
607 DRM_MODE_ENCODER_TMDS);
609 connector = &intel_connector->base;
610 drm_connector_init(dev, connector, &intel_hdmi_connector_funcs,
611 DRM_MODE_CONNECTOR_HDMIA);
612 drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
614 intel_encoder->type = INTEL_OUTPUT_HDMI;
616 connector->polled = DRM_CONNECTOR_POLL_HPD;
617 connector->interlace_allowed = 1;
618 connector->doublescan_allowed = 0;
619 intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
621 /* Set up the DDC bus. */
622 if (sdvox_reg == SDVOB) {
623 intel_encoder->clone_mask = (1 << INTEL_HDMIB_CLONE_BIT);
624 intel_hdmi->ddc_bus = GMBUS_PORT_DPB;
625 dev_priv->hotplug_supported_mask |= HDMIB_HOTPLUG_INT_STATUS;
626 } else if (sdvox_reg == SDVOC) {
627 intel_encoder->clone_mask = (1 << INTEL_HDMIC_CLONE_BIT);
628 intel_hdmi->ddc_bus = GMBUS_PORT_DPC;
629 dev_priv->hotplug_supported_mask |= HDMIC_HOTPLUG_INT_STATUS;
630 } else if (sdvox_reg == HDMIB) {
631 intel_encoder->clone_mask = (1 << INTEL_HDMID_CLONE_BIT);
632 intel_hdmi->ddc_bus = GMBUS_PORT_DPB;
633 dev_priv->hotplug_supported_mask |= HDMIB_HOTPLUG_INT_STATUS;
634 } else if (sdvox_reg == HDMIC) {
635 intel_encoder->clone_mask = (1 << INTEL_HDMIE_CLONE_BIT);
636 intel_hdmi->ddc_bus = GMBUS_PORT_DPC;
637 dev_priv->hotplug_supported_mask |= HDMIC_HOTPLUG_INT_STATUS;
638 } else if (sdvox_reg == HDMID) {
639 intel_encoder->clone_mask = (1 << INTEL_HDMIF_CLONE_BIT);
640 intel_hdmi->ddc_bus = GMBUS_PORT_DPD;
641 dev_priv->hotplug_supported_mask |= HDMID_HOTPLUG_INT_STATUS;
642 } else if (sdvox_reg == DDI_BUF_CTL(PORT_B)) {
643 DRM_DEBUG_DRIVER("LPT: detected output on DDI B\n");
644 intel_encoder->clone_mask = (1 << INTEL_HDMIB_CLONE_BIT);
645 intel_hdmi->ddc_bus = GMBUS_PORT_DPB;
646 intel_hdmi->ddi_port = PORT_B;
647 dev_priv->hotplug_supported_mask |= HDMIB_HOTPLUG_INT_STATUS;
648 } else if (sdvox_reg == DDI_BUF_CTL(PORT_C)) {
649 DRM_DEBUG_DRIVER("LPT: detected output on DDI C\n");
650 intel_encoder->clone_mask = (1 << INTEL_HDMIC_CLONE_BIT);
651 intel_hdmi->ddc_bus = GMBUS_PORT_DPC;
652 intel_hdmi->ddi_port = PORT_C;
653 dev_priv->hotplug_supported_mask |= HDMIC_HOTPLUG_INT_STATUS;
654 } else if (sdvox_reg == DDI_BUF_CTL(PORT_D)) {
655 DRM_DEBUG_DRIVER("LPT: detected output on DDI D\n");
656 intel_encoder->clone_mask = (1 << INTEL_HDMID_CLONE_BIT);
657 intel_hdmi->ddc_bus = GMBUS_PORT_DPD;
658 intel_hdmi->ddi_port = PORT_D;
659 dev_priv->hotplug_supported_mask |= HDMID_HOTPLUG_INT_STATUS;
661 /* If we got an unknown sdvox_reg, things are pretty much broken
662 * in a way that we should let the kernel know about it */
666 intel_hdmi->sdvox_reg = sdvox_reg;
668 if (!HAS_PCH_SPLIT(dev)) {
669 intel_hdmi->write_infoframe = g4x_write_infoframe;
670 I915_WRITE(VIDEO_DIP_CTL, 0);
671 } else if (IS_VALLEYVIEW(dev)) {
672 intel_hdmi->write_infoframe = vlv_write_infoframe;
674 I915_WRITE(VLV_TVIDEO_DIP_CTL(i), 0);
675 } else if (IS_HASWELL(dev)) {
676 /* FIXME: Haswell has a new set of DIP frame registers, but we are
677 * just doing the minimal required for HDMI to work at this stage.
679 intel_hdmi->write_infoframe = hsw_write_infoframe;
681 I915_WRITE(HSW_TVIDEO_DIP_CTL(i), 0);
682 } else if (HAS_PCH_IBX(dev)) {
683 intel_hdmi->write_infoframe = ibx_write_infoframe;
685 I915_WRITE(TVIDEO_DIP_CTL(i), 0);
687 intel_hdmi->write_infoframe = cpt_write_infoframe;
689 I915_WRITE(TVIDEO_DIP_CTL(i), 0);
693 drm_encoder_helper_add(&intel_encoder->base, &intel_hdmi_helper_funcs_hsw);
695 drm_encoder_helper_add(&intel_encoder->base, &intel_hdmi_helper_funcs);
697 intel_hdmi_add_properties(intel_hdmi, connector);
699 intel_connector_attach_encoder(intel_connector, intel_encoder);
700 drm_sysfs_connector_add(connector);
702 /* For G4X desktop chip, PEG_BAND_GAP_DATA 3:0 must first be written
703 * 0xd. Failure to do so will result in spurious interrupts being
704 * generated on the port when a cable is not attached.
706 if (IS_G4X(dev) && !IS_GM45(dev)) {
707 u32 temp = I915_READ(PEG_BAND_GAP_DATA);
708 I915_WRITE(PEG_BAND_GAP_DATA, (temp & ~0xf) | 0xd);