1 //===-- Lint.cpp - Check for common errors in LLVM IR ---------------------===//
3 // The LLVM Compiler Infrastructure
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
8 //===----------------------------------------------------------------------===//
10 // This pass statically checks for common and easily-identified constructs
11 // which produce undefined or likely unintended behavior in LLVM IR.
13 // It is not a guarantee of correctness, in two ways. First, it isn't
14 // comprehensive. There are checks which could be done statically which are
15 // not yet implemented. Some of these are indicated by TODO comments, but
16 // those aren't comprehensive either. Second, many conditions cannot be
17 // checked statically. This pass does no dynamic instrumentation, so it
18 // can't check for all possible problems.
20 // Another limitation is that it assumes all code will be executed. A store
21 // through a null pointer in a basic block which is never reached is harmless,
22 // but this pass will warn about it anyway.
24 // Optimization passes may make conditions that this pass checks for more or
25 // less obvious. If an optimization pass appears to be introducing a warning,
26 // it may be that the optimization pass is merely exposing an existing
27 // condition in the code.
29 // This code may be run before instcombine. In many cases, instcombine checks
30 // for the same kinds of things and turns instructions with undefined behavior
31 // into unreachable (or equivalent). Because of this, this pass makes some
32 // effort to look through bitcasts and so on.
34 //===----------------------------------------------------------------------===//
36 #include "llvm/Analysis/Passes.h"
37 #include "llvm/Analysis/AliasAnalysis.h"
38 #include "llvm/Analysis/Lint.h"
39 #include "llvm/Analysis/ValueTracking.h"
40 #include "llvm/Assembly/Writer.h"
41 #include "llvm/Target/TargetData.h"
42 #include "llvm/Pass.h"
43 #include "llvm/PassManager.h"
44 #include "llvm/IntrinsicInst.h"
45 #include "llvm/Function.h"
46 #include "llvm/Support/CallSite.h"
47 #include "llvm/Support/Debug.h"
48 #include "llvm/Support/InstVisitor.h"
49 #include "llvm/Support/raw_ostream.h"
50 #include "llvm/ADT/STLExtras.h"
55 static unsigned Read = 1;
56 static unsigned Write = 2;
57 static unsigned Callee = 4;
58 static unsigned Branchee = 8;
61 class Lint : public FunctionPass, public InstVisitor<Lint> {
62 friend class InstVisitor<Lint>;
64 void visitFunction(Function &F);
66 void visitCallSite(CallSite CS);
67 void visitMemoryReference(Instruction &I, Value *Ptr, unsigned Align,
68 const Type *Ty, unsigned Flags);
70 void visitCallInst(CallInst &I);
71 void visitInvokeInst(InvokeInst &I);
72 void visitReturnInst(ReturnInst &I);
73 void visitLoadInst(LoadInst &I);
74 void visitStoreInst(StoreInst &I);
75 void visitXor(BinaryOperator &I);
76 void visitSub(BinaryOperator &I);
77 void visitLShr(BinaryOperator &I);
78 void visitAShr(BinaryOperator &I);
79 void visitShl(BinaryOperator &I);
80 void visitSDiv(BinaryOperator &I);
81 void visitUDiv(BinaryOperator &I);
82 void visitSRem(BinaryOperator &I);
83 void visitURem(BinaryOperator &I);
84 void visitAllocaInst(AllocaInst &I);
85 void visitVAArgInst(VAArgInst &I);
86 void visitIndirectBrInst(IndirectBrInst &I);
87 void visitExtractElementInst(ExtractElementInst &I);
88 void visitInsertElementInst(InsertElementInst &I);
89 void visitUnreachableInst(UnreachableInst &I);
97 raw_string_ostream MessagesStr;
99 static char ID; // Pass identification, replacement for typeid
100 Lint() : FunctionPass(&ID), MessagesStr(Messages) {}
102 virtual bool runOnFunction(Function &F);
104 virtual void getAnalysisUsage(AnalysisUsage &AU) const {
105 AU.setPreservesAll();
106 AU.addRequired<AliasAnalysis>();
108 virtual void print(raw_ostream &O, const Module *M) const {}
110 void WriteValue(const Value *V) {
112 if (isa<Instruction>(V)) {
113 MessagesStr << *V << '\n';
115 WriteAsOperand(MessagesStr, V, true, Mod);
120 void WriteType(const Type *T) {
123 WriteTypeSymbolic(MessagesStr, T, Mod);
126 // CheckFailed - A check failed, so print out the condition and the message
127 // that failed. This provides a nice place to put a breakpoint if you want
128 // to see why something is not correct.
129 void CheckFailed(const Twine &Message,
130 const Value *V1 = 0, const Value *V2 = 0,
131 const Value *V3 = 0, const Value *V4 = 0) {
132 MessagesStr << Message.str() << "\n";
139 void CheckFailed(const Twine &Message, const Value *V1,
140 const Type *T2, const Value *V3 = 0) {
141 MessagesStr << Message.str() << "\n";
147 void CheckFailed(const Twine &Message, const Type *T1,
148 const Type *T2 = 0, const Type *T3 = 0) {
149 MessagesStr << Message.str() << "\n";
158 static RegisterPass<Lint>
159 X("lint", "Statically lint-checks LLVM IR", false, true);
161 // Assert - We know that cond should be true, if not print an error message.
162 #define Assert(C, M) \
163 do { if (!(C)) { CheckFailed(M); return; } } while (0)
164 #define Assert1(C, M, V1) \
165 do { if (!(C)) { CheckFailed(M, V1); return; } } while (0)
166 #define Assert2(C, M, V1, V2) \
167 do { if (!(C)) { CheckFailed(M, V1, V2); return; } } while (0)
168 #define Assert3(C, M, V1, V2, V3) \
169 do { if (!(C)) { CheckFailed(M, V1, V2, V3); return; } } while (0)
170 #define Assert4(C, M, V1, V2, V3, V4) \
171 do { if (!(C)) { CheckFailed(M, V1, V2, V3, V4); return; } } while (0)
173 // Lint::run - This is the main Analysis entry point for a
176 bool Lint::runOnFunction(Function &F) {
178 AA = &getAnalysis<AliasAnalysis>();
179 TD = getAnalysisIfAvailable<TargetData>();
181 dbgs() << MessagesStr.str();
186 void Lint::visitFunction(Function &F) {
187 // This isn't undefined behavior, it's just a little unusual, and it's a
188 // fairly common mistake to neglect to name a function.
189 Assert1(F.hasName() || F.hasLocalLinkage(),
190 "Unusual: Unnamed function with non-local linkage", &F);
193 void Lint::visitCallSite(CallSite CS) {
194 Instruction &I = *CS.getInstruction();
195 Value *Callee = CS.getCalledValue();
197 visitMemoryReference(I, Callee, 0, 0, MemRef::Callee);
199 if (Function *F = dyn_cast<Function>(Callee->stripPointerCasts())) {
200 Assert1(CS.getCallingConv() == F->getCallingConv(),
201 "Undefined behavior: Caller and callee calling convention differ",
204 const FunctionType *FT = F->getFunctionType();
205 unsigned NumActualArgs = unsigned(CS.arg_end()-CS.arg_begin());
207 Assert1(FT->isVarArg() ?
208 FT->getNumParams() <= NumActualArgs :
209 FT->getNumParams() == NumActualArgs,
210 "Undefined behavior: Call argument count mismatches callee "
211 "argument count", &I);
213 // TODO: Check argument types (in case the callee was casted)
215 // TODO: Check ABI-significant attributes.
217 // TODO: Check noalias attribute.
219 // TODO: Check sret attribute.
222 if (CS.isCall() && cast<CallInst>(CS.getInstruction())->isTailCall())
223 for (CallSite::arg_iterator AI = CS.arg_begin(), AE = CS.arg_end();
225 Value *Obj = (*AI)->getUnderlyingObject();
226 Assert1(!isa<AllocaInst>(Obj) && !isa<VAArgInst>(Obj),
227 "Undefined behavior: Call with \"tail\" keyword references "
228 "alloca or va_arg", &I);
232 if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(&I))
233 switch (II->getIntrinsicID()) {
236 // TODO: Check more intrinsics
238 case Intrinsic::memcpy: {
239 MemCpyInst *MCI = cast<MemCpyInst>(&I);
240 visitMemoryReference(I, MCI->getSource(), MCI->getAlignment(), 0,
242 visitMemoryReference(I, MCI->getDest(), MCI->getAlignment(), 0,
245 // Check that the memcpy arguments don't overlap. The AliasAnalysis API
246 // isn't expressive enough for what we really want to do. Known partial
247 // overlap is not distinguished from the case where nothing is known.
249 if (const ConstantInt *Len =
250 dyn_cast<ConstantInt>(MCI->getLength()->stripPointerCasts()))
251 if (Len->getValue().isIntN(32))
252 Size = Len->getValue().getZExtValue();
253 Assert1(AA->alias(MCI->getSource(), Size, MCI->getDest(), Size) !=
254 AliasAnalysis::MustAlias,
255 "Undefined behavior: memcpy source and destination overlap", &I);
258 case Intrinsic::memmove: {
259 MemMoveInst *MMI = cast<MemMoveInst>(&I);
260 visitMemoryReference(I, MMI->getSource(), MMI->getAlignment(), 0,
262 visitMemoryReference(I, MMI->getDest(), MMI->getAlignment(), 0,
266 case Intrinsic::memset: {
267 MemSetInst *MSI = cast<MemSetInst>(&I);
268 visitMemoryReference(I, MSI->getDest(), MSI->getAlignment(), 0,
273 case Intrinsic::vastart:
274 Assert1(I.getParent()->getParent()->isVarArg(),
275 "Undefined behavior: va_start called in a non-varargs function",
278 visitMemoryReference(I, CS.getArgument(0), 0, 0,
279 MemRef::Read | MemRef::Write);
281 case Intrinsic::vacopy:
282 visitMemoryReference(I, CS.getArgument(0), 0, 0, MemRef::Write);
283 visitMemoryReference(I, CS.getArgument(1), 0, 0, MemRef::Read);
285 case Intrinsic::vaend:
286 visitMemoryReference(I, CS.getArgument(0), 0, 0,
287 MemRef::Read | MemRef::Write);
290 case Intrinsic::stackrestore:
291 // Stackrestore doesn't read or write memory, but it sets the
292 // stack pointer, which the compiler may read from or write to
293 // at any time, so check it for both readability and writeability.
294 visitMemoryReference(I, CS.getArgument(0), 0, 0,
295 MemRef::Read | MemRef::Write);
300 void Lint::visitCallInst(CallInst &I) {
301 return visitCallSite(&I);
304 void Lint::visitInvokeInst(InvokeInst &I) {
305 return visitCallSite(&I);
308 void Lint::visitReturnInst(ReturnInst &I) {
309 Function *F = I.getParent()->getParent();
310 Assert1(!F->doesNotReturn(),
311 "Unusual: Return statement in function with noreturn attribute",
315 // TODO: Add a length argument and check that the reference is in bounds
316 void Lint::visitMemoryReference(Instruction &I,
317 Value *Ptr, unsigned Align, const Type *Ty,
319 Value *UnderlyingObject = Ptr->getUnderlyingObject();
320 Assert1(!isa<ConstantPointerNull>(UnderlyingObject),
321 "Undefined behavior: Null pointer dereference", &I);
322 Assert1(!isa<UndefValue>(UnderlyingObject),
323 "Undefined behavior: Undef pointer dereference", &I);
325 if (Flags & MemRef::Write) {
326 if (const GlobalVariable *GV = dyn_cast<GlobalVariable>(UnderlyingObject))
327 Assert1(!GV->isConstant(),
328 "Undefined behavior: Write to read-only memory", &I);
329 Assert1(!isa<Function>(UnderlyingObject) &&
330 !isa<BlockAddress>(UnderlyingObject),
331 "Undefined behavior: Write to text section", &I);
333 if (Flags & MemRef::Read) {
334 Assert1(!isa<Function>(UnderlyingObject),
335 "Unusual: Load from function body", &I);
336 Assert1(!isa<BlockAddress>(UnderlyingObject),
337 "Undefined behavior: Load from block address", &I);
339 if (Flags & MemRef::Callee) {
340 Assert1(!isa<BlockAddress>(UnderlyingObject),
341 "Undefined behavior: Call to block address", &I);
343 if (Flags & MemRef::Branchee) {
344 Assert1(!isa<Constant>(UnderlyingObject) ||
345 isa<BlockAddress>(UnderlyingObject),
346 "Undefined behavior: Branch to non-blockaddress", &I);
350 if (Align == 0 && Ty) Align = TD->getABITypeAlignment(Ty);
353 unsigned BitWidth = TD->getTypeSizeInBits(Ptr->getType());
354 APInt Mask = APInt::getAllOnesValue(BitWidth),
355 KnownZero(BitWidth, 0), KnownOne(BitWidth, 0);
356 ComputeMaskedBits(Ptr, Mask, KnownZero, KnownOne, TD);
357 Assert1(!(KnownOne & APInt::getLowBitsSet(BitWidth, Log2_32(Align))),
358 "Undefined behavior: Memory reference address is misaligned", &I);
363 void Lint::visitLoadInst(LoadInst &I) {
364 visitMemoryReference(I, I.getPointerOperand(), I.getAlignment(), I.getType(),
368 void Lint::visitStoreInst(StoreInst &I) {
369 visitMemoryReference(I, I.getPointerOperand(), I.getAlignment(),
370 I.getOperand(0)->getType(), MemRef::Write);
373 void Lint::visitXor(BinaryOperator &I) {
374 Assert1(!isa<UndefValue>(I.getOperand(0)) ||
375 !isa<UndefValue>(I.getOperand(1)),
376 "Undefined result: xor(undef, undef)", &I);
379 void Lint::visitSub(BinaryOperator &I) {
380 Assert1(!isa<UndefValue>(I.getOperand(0)) ||
381 !isa<UndefValue>(I.getOperand(1)),
382 "Undefined result: sub(undef, undef)", &I);
385 void Lint::visitLShr(BinaryOperator &I) {
386 if (ConstantInt *CI =
387 dyn_cast<ConstantInt>(I.getOperand(1)->stripPointerCasts()))
388 Assert1(CI->getValue().ult(cast<IntegerType>(I.getType())->getBitWidth()),
389 "Undefined result: Shift count out of range", &I);
392 void Lint::visitAShr(BinaryOperator &I) {
393 if (ConstantInt *CI =
394 dyn_cast<ConstantInt>(I.getOperand(1)->stripPointerCasts()))
395 Assert1(CI->getValue().ult(cast<IntegerType>(I.getType())->getBitWidth()),
396 "Undefined result: Shift count out of range", &I);
399 void Lint::visitShl(BinaryOperator &I) {
400 if (ConstantInt *CI =
401 dyn_cast<ConstantInt>(I.getOperand(1)->stripPointerCasts()))
402 Assert1(CI->getValue().ult(cast<IntegerType>(I.getType())->getBitWidth()),
403 "Undefined result: Shift count out of range", &I);
406 static bool isZero(Value *V, TargetData *TD) {
407 // Assume undef could be zero.
408 if (isa<UndefValue>(V)) return true;
410 unsigned BitWidth = cast<IntegerType>(V->getType())->getBitWidth();
411 APInt Mask = APInt::getAllOnesValue(BitWidth),
412 KnownZero(BitWidth, 0), KnownOne(BitWidth, 0);
413 ComputeMaskedBits(V, Mask, KnownZero, KnownOne, TD);
414 return KnownZero.isAllOnesValue();
417 void Lint::visitSDiv(BinaryOperator &I) {
418 Assert1(!isZero(I.getOperand(1), TD),
419 "Undefined behavior: Division by zero", &I);
422 void Lint::visitUDiv(BinaryOperator &I) {
423 Assert1(!isZero(I.getOperand(1), TD),
424 "Undefined behavior: Division by zero", &I);
427 void Lint::visitSRem(BinaryOperator &I) {
428 Assert1(!isZero(I.getOperand(1), TD),
429 "Undefined behavior: Division by zero", &I);
432 void Lint::visitURem(BinaryOperator &I) {
433 Assert1(!isZero(I.getOperand(1), TD),
434 "Undefined behavior: Division by zero", &I);
437 void Lint::visitAllocaInst(AllocaInst &I) {
438 if (isa<ConstantInt>(I.getArraySize()))
439 // This isn't undefined behavior, it's just an obvious pessimization.
440 Assert1(&I.getParent()->getParent()->getEntryBlock() == I.getParent(),
441 "Pessimization: Static alloca outside of entry block", &I);
444 void Lint::visitVAArgInst(VAArgInst &I) {
445 visitMemoryReference(I, I.getOperand(0), 0, 0,
446 MemRef::Read | MemRef::Write);
449 void Lint::visitIndirectBrInst(IndirectBrInst &I) {
450 visitMemoryReference(I, I.getAddress(), 0, 0, MemRef::Branchee);
453 void Lint::visitExtractElementInst(ExtractElementInst &I) {
454 if (ConstantInt *CI =
455 dyn_cast<ConstantInt>(I.getIndexOperand()->stripPointerCasts()))
456 Assert1(CI->getValue().ult(I.getVectorOperandType()->getNumElements()),
457 "Undefined result: extractelement index out of range", &I);
460 void Lint::visitInsertElementInst(InsertElementInst &I) {
461 if (ConstantInt *CI =
462 dyn_cast<ConstantInt>(I.getOperand(2)->stripPointerCasts()))
463 Assert1(CI->getValue().ult(I.getType()->getNumElements()),
464 "Undefined result: insertelement index out of range", &I);
467 void Lint::visitUnreachableInst(UnreachableInst &I) {
468 // This isn't undefined behavior, it's merely suspicious.
469 Assert1(&I == I.getParent()->begin() ||
470 prior(BasicBlock::iterator(&I))->mayHaveSideEffects(),
471 "Unusual: unreachable immediately preceded by instruction without "
475 //===----------------------------------------------------------------------===//
476 // Implement the public interfaces to this file...
477 //===----------------------------------------------------------------------===//
479 FunctionPass *llvm::createLintPass() {
483 /// lintFunction - Check a function for errors, printing messages on stderr.
485 void llvm::lintFunction(const Function &f) {
486 Function &F = const_cast<Function&>(f);
487 assert(!F.isDeclaration() && "Cannot lint external functions");
489 FunctionPassManager FPM(F.getParent());
490 Lint *V = new Lint();
495 /// lintModule - Check a module for errors, printing messages on stderr.
497 void llvm::lintModule(const Module &M) {
499 Lint *V = new Lint();
501 PM.run(const_cast<Module&>(M));