1 //===- CleanupGCCOutput.cpp - Cleanup GCC Output ----------------------------=//
3 // This pass is used to cleanup the output of GCC. GCC's output is
4 // unneccessarily gross for a couple of reasons. This pass does the following
5 // things to try to clean it up:
7 // * Eliminate names for GCC types that we know can't be needed by the user.
8 // - Eliminate names for types that are unused in the entire translation unit
9 // but only if they do not name a structure type!
10 // - Replace calls to 'sbyte *%malloc(uint)' and 'void %free(sbyte *)' with
11 // malloc and free instructions.
13 // Note: This code produces dead declarations, it is a good idea to run DCE
16 //===----------------------------------------------------------------------===//
18 #include "llvm/Transforms/CleanupGCCOutput.h"
19 #include "TransformInternals.h"
20 #include "llvm/SymbolTable.h"
21 #include "llvm/DerivedTypes.h"
22 #include "llvm/iOther.h"
23 #include "llvm/iMemory.h"
24 #include "llvm/iTerminators.h"
27 static const Type *PtrArrSByte = 0; // '[sbyte]*' type
28 static const Type *PtrSByte = 0; // 'sbyte*' type
30 // ConvertCallTo - Convert a call to a varargs function with no arg types
31 // specified to a concrete nonvarargs method.
33 static void ConvertCallTo(CallInst *CI, Method *Dest) {
34 const MethodType::ParamTypes &ParamTys =
35 Dest->getMethodType()->getParamTypes();
36 BasicBlock *BB = CI->getParent();
38 // Get an iterator to where we want to insert cast instructions if the
39 // argument types don't agree.
41 BasicBlock::iterator BBI = find(BB->begin(), BB->end(), CI);
42 assert(BBI != BB->end() && "CallInst not in parent block?");
44 assert(CI->getNumOperands()-1 == ParamTys.size()&&
45 "Method calls resolved funny somehow, incompatible number of args");
47 vector<Value*> Params;
49 // Convert all of the call arguments over... inserting cast instructions if
50 // the types are not compatible.
51 for (unsigned i = 1; i < CI->getNumOperands(); ++i) {
52 Value *V = CI->getOperand(i);
54 if (V->getType() != ParamTys[i-1]) { // Must insert a cast...
55 Instruction *Cast = new CastInst(V, ParamTys[i-1]);
56 BBI = BB->getInstList().insert(BBI, Cast)+1;
63 // Replace the old call instruction with a new call instruction that calls
66 ReplaceInstWithInst(BB->getInstList(), BBI, new CallInst(Dest, Params));
70 // PatchUpMethodReferences - Go over the methods that are in the module and
71 // look for methods that have the same name. More often than not, there will
74 // void "foo"(int, int)
75 // because of the way things are declared in C. If this is the case, patch
78 bool CleanupGCCOutput::PatchUpMethodReferences(Module *M) {
79 SymbolTable *ST = M->getSymbolTable();
80 if (!ST) return false;
82 map<string, vector<Method*> > Methods;
84 // Loop over the entries in the symbol table. If an entry is a method pointer,
85 // then add it to the Methods map. We do a two pass algorithm here to avoid
86 // problems with iterators getting invalidated if we did a one pass scheme.
88 for (SymbolTable::iterator I = ST->begin(), E = ST->end(); I != E; ++I)
89 if (const PointerType *PT = dyn_cast<PointerType>(I->first))
90 if (const MethodType *MT = dyn_cast<MethodType>(PT->getValueType())) {
91 SymbolTable::VarMap &Plane = I->second;
92 for (SymbolTable::type_iterator PI = Plane.begin(), PE = Plane.end();
94 const string &Name = PI->first;
95 Method *M = cast<Method>(PI->second);
96 Methods[Name].push_back(M);
100 bool Changed = false;
102 // Now we have a list of all methods with a particular name. If there is more
103 // than one entry in a list, merge the methods together.
105 for (map<string, vector<Method*> >::iterator I = Methods.begin(),
106 E = Methods.end(); I != E; ++I) {
107 vector<Method*> &Methods = I->second;
108 Method *Implementation = 0; // Find the implementation
109 Method *Concrete = 0;
110 for (unsigned i = 0; i < Methods.size(); ) {
111 if (!Methods[i]->isExternal()) { // Found an implementation
112 assert(Implementation == 0 && "Multiple definitions of the same"
113 " method. Case not handled yet!");
114 Implementation = Methods[i];
116 // Ignore methods that are never used so they don't cause spurious
117 // warnings... here we will actually DCE the function so that it isn't
120 if (Methods[i]->use_size() == 0) {
121 M->getMethodList().remove(Methods[i]);
123 Methods.erase(Methods.begin()+i);
128 if (Methods[i] && (!Methods[i]->getMethodType()->isVarArg() ||
129 Methods[i]->getMethodType()->getParamTypes().size())) {
130 if (Concrete) { // Found two different methods types. Can't choose
134 Concrete = Methods[i];
139 if (Methods.size() > 1) { // Found a multiply defined method.
140 // We should find exactly one non-vararg method definition, which is
141 // probably the implementation. Change all of the method definitions
142 // and uses to use it instead.
145 cerr << "Warning: Found methods types that are not compatible:\n";
146 for (unsigned i = 0; i < Methods.size(); ++i) {
147 cerr << "\t" << Methods[i]->getType()->getDescription() << " %"
148 << Methods[i]->getName() << endl;
150 cerr << " No linkage of methods named '" << Methods[0]->getName()
153 for (unsigned i = 0; i < Methods.size(); ++i)
154 if (Methods[i] != Concrete) {
155 Method *Old = Methods[i];
156 assert(Old->getReturnType() == Concrete->getReturnType() &&
157 "Differing return types not handled yet!");
158 assert(Old->getMethodType()->getParamTypes().size() == 0 &&
159 "Cannot handle varargs fn's with specified element types!");
161 // Attempt to convert all of the uses of the old method to the
162 // concrete form of the method. If there is a use of the method
163 // that we don't understand here we punt to avoid making a bad
166 // At this point, we know that the return values are the same for
167 // our two functions and that the Old method has no varargs methods
168 // specified. In otherwords it's just <retty> (...)
170 for (unsigned i = 0; i < Old->use_size(); ) {
171 User *U = *(Old->use_begin()+i);
172 if (CastInst *CI = dyn_cast<CastInst>(U)) {
173 // Convert casts directly
174 assert(CI->getOperand(0) == Old);
175 CI->setOperand(0, Concrete);
177 } else if (CallInst *CI = dyn_cast<CallInst>(U)) {
178 // Can only fix up calls TO the argument, not args passed in.
179 if (CI->getCalledValue() == Old) {
180 ConvertCallTo(CI, Concrete);
183 cerr << "Couldn't cleanup this function call, must be an"
184 << " argument or something!" << CI;
188 cerr << "Cannot convert use of method: " << U << endl;
201 // ShouldNukSymtabEntry - Return true if this module level symbol table entry
202 // should be eliminated.
204 static inline bool ShouldNukeSymtabEntry(const pair<string, Value*> &E) {
205 // Nuke all names for primitive types!
206 if (cast<Type>(E.second)->isPrimitiveType()) return true;
208 // The only types that could contain .'s in the program are things generated
209 // by GCC itself, including "complex.float" and friends. Nuke them too.
210 if (E.first.find('.') != string::npos) return true;
215 // doPassInitialization - For this pass, it removes global symbol table
216 // entries for primitive types. These are never used for linking in GCC and
217 // they make the output uglier to look at, so we nuke them.
219 bool CleanupGCCOutput::doPassInitialization(Module *M) {
220 bool Changed = false;
222 if (PtrArrSByte == 0) {
223 PtrArrSByte = PointerType::get(ArrayType::get(Type::SByteTy));
224 PtrSByte = PointerType::get(Type::SByteTy);
227 if (M->hasSymbolTable()) {
228 SymbolTable *ST = M->getSymbolTable();
230 // Go over the methods that are in the module and look for methods that have
231 // the same name. More often than not, there will be things like:
232 // void "foo"(...) and void "foo"(int, int) because of the way things are
233 // declared in C. If this is the case, patch things up.
235 Changed |= PatchUpMethodReferences(M);
238 // If the module has a symbol table, they might be referring to the malloc
239 // and free functions. If this is the case, grab the method pointers that
240 // the module is using.
242 // Lookup %malloc and %free in the symbol table, for later use. If they
243 // don't exist, or are not external, we do not worry about converting calls
244 // to that function into the appropriate instruction.
246 const PointerType *MallocType = // Get the type for malloc
247 PointerType::get(MethodType::get(PointerType::get(Type::SByteTy),
248 vector<const Type*>(1, Type::UIntTy), false));
249 Malloc = cast_or_null<Method>(ST->lookup(MallocType, "malloc"));
250 if (Malloc && !Malloc->isExternal())
251 Malloc = 0; // Don't mess with locally defined versions of the fn
253 const PointerType *FreeType = // Get the type for free
254 PointerType::get(MethodType::get(Type::VoidTy,
255 vector<const Type*>(1, PointerType::get(Type::SByteTy)), false));
256 Free = cast_or_null<Method>(ST->lookup(FreeType, "free"));
257 if (Free && !Free->isExternal())
258 Free = 0; // Don't mess with locally defined versions of the fn
261 // Check the symbol table for superfluous type entries...
263 // Grab the 'type' plane of the module symbol...
264 SymbolTable::iterator STI = ST->find(Type::TypeTy);
265 if (STI != ST->end()) {
266 // Loop over all entries in the type plane...
267 SymbolTable::VarMap &Plane = STI->second;
268 for (SymbolTable::VarMap::iterator PI = Plane.begin(); PI != Plane.end();)
269 if (ShouldNukeSymtabEntry(*PI)) { // Should we remove this entry?
270 #if MAP_IS_NOT_BRAINDEAD
271 PI = Plane.erase(PI); // STD C++ Map should support this!
273 Plane.erase(PI); // Alas, GCC 2.95.3 doesn't *SIGH*
287 // doOneCleanupPass - Do one pass over the input method, fixing stuff up.
289 bool CleanupGCCOutput::doOneCleanupPass(Method *M) {
290 bool Changed = false;
291 for (Method::iterator MI = M->begin(), ME = M->end(); MI != ME; ++MI) {
292 BasicBlock *BB = *MI;
293 BasicBlock::InstListType &BIL = BB->getInstList();
295 for (BasicBlock::iterator BI = BB->begin(); BI != BB->end();) {
296 Instruction *I = *BI;
298 if (CallInst *CI = dyn_cast<CallInst>(I)) {
299 if (CI->getCalledValue() == Malloc) { // Replace call to malloc?
300 MallocInst *MallocI = new MallocInst(PtrArrSByte, CI->getOperand(1),
303 BI = BIL.insert(BI, MallocI)+1;
304 ReplaceInstWithInst(BIL, BI, new CastInst(MallocI, PtrSByte));
306 continue; // Skip the ++BI
307 } else if (CI->getCalledValue() == Free) { // Replace call to free?
308 ReplaceInstWithInst(BIL, BI, new FreeInst(CI->getOperand(1)));
310 continue; // Skip the ++BI
322 // FixCastsAndPHIs - The LLVM GCC has a tendancy to intermix Cast instructions
323 // in with the PHI nodes. These cast instructions are potentially there for two
324 // different reasons:
326 // 1. The cast could be for an early PHI, and be accidentally inserted before
327 // another PHI node. In this case, the PHI node should be moved to the end
328 // of the PHI nodes in the basic block. We know that it is this case if
329 // the source for the cast is a PHI node in this basic block.
331 // 2. If not #1, the cast must be a source argument for one of the PHI nodes
332 // in the current basic block. If this is the case, the cast should be
333 // lifted into the basic block for the appropriate predecessor.
335 static inline bool FixCastsAndPHIs(BasicBlock *BB) {
336 bool Changed = false;
338 BasicBlock::iterator InsertPos = BB->begin();
340 // Find the end of the interesting instructions...
341 while (isa<PHINode>(*InsertPos) || isa<CastInst>(*InsertPos)) ++InsertPos;
343 // Back the InsertPos up to right after the last PHI node.
344 while (InsertPos != BB->begin() && isa<CastInst>(*(InsertPos-1))) --InsertPos;
346 // No PHI nodes, quick exit.
347 if (InsertPos == BB->begin()) return false;
349 // Loop over all casts trapped between the PHI's...
350 BasicBlock::iterator I = BB->begin();
351 while (I != InsertPos) {
352 if (CastInst *CI = dyn_cast<CastInst>(*I)) { // Fix all cast instructions
353 Value *Src = CI->getOperand(0);
355 // Move the cast instruction to the current insert position...
356 --InsertPos; // New position for cast to go...
357 swap(*InsertPos, *I); // Cast goes down, PHI goes up
359 if (isa<PHINode>(Src) && // Handle case #1
360 cast<PHINode>(Src)->getParent() == BB) {
361 // We're done for case #1
362 } else { // Handle case #2
363 // In case #2, we have to do a few things:
364 // 1. Remove the cast from the current basic block.
365 // 2. Identify the PHI node that the cast is for.
366 // 3. Find out which predecessor the value is for.
367 // 4. Move the cast to the end of the basic block that it SHOULD be
370 // Remove the cast instruction from the basic block. The remove only
371 // invalidates iterators in the basic block that are AFTER the removed
372 // element. Because we just moved the CastInst to the InsertPos, no
373 // iterators get invalidated.
375 BB->getInstList().remove(InsertPos);
377 // Find the PHI node. Since this cast was generated specifically for a
378 // PHI node, there can only be a single PHI node using it.
380 assert(CI->use_size() == 1 && "Exactly one PHI node should use cast!");
381 PHINode *PN = cast<PHINode>(*CI->use_begin());
383 // Find out which operand of the PHI it is...
385 for (i = 0; i < PN->getNumIncomingValues(); ++i)
386 if (PN->getIncomingValue(i) == CI)
388 assert(i != PN->getNumIncomingValues() && "PHI doesn't use cast!");
390 // Get the predecessor the value is for...
391 BasicBlock *Pred = PN->getIncomingBlock(i);
393 // Reinsert the cast right before the terminator in Pred.
394 Pred->getInstList().insert(Pred->end()-1, CI);
405 // RefactorPredecessor - When we find out that a basic block is a repeated
406 // predecessor in a PHI node, we have to refactor the method until there is at
407 // most a single instance of a basic block in any predecessor list.
409 static inline void RefactorPredecessor(BasicBlock *BB, BasicBlock *Pred) {
410 Method *M = BB->getParent();
411 assert(find(BB->pred_begin(), BB->pred_end(), Pred) != BB->pred_end() &&
412 "Pred is not a predecessor of BB!");
414 // Create a new basic block, adding it to the end of the method.
415 BasicBlock *NewBB = new BasicBlock("", M);
417 // Add an unconditional branch to BB to the new block.
418 NewBB->getInstList().push_back(new BranchInst(BB));
420 // Get the terminator that causes a branch to BB from Pred.
421 TerminatorInst *TI = Pred->getTerminator();
423 // Find the first use of BB in the terminator...
424 User::op_iterator OI = find(TI->op_begin(), TI->op_end(), BB);
425 assert(OI != TI->op_end() && "Pred does not branch to BB!!!");
427 // Change the use of BB to point to the new stub basic block
430 // Now we need to loop through all of the PHI nodes in BB and convert their
431 // first incoming value for Pred to reference the new basic block instead.
433 for (BasicBlock::iterator I = BB->begin();
434 PHINode *PN = dyn_cast<PHINode>(*I); ++I) {
435 int BBIdx = PN->getBasicBlockIndex(Pred);
436 assert(BBIdx != -1 && "PHI node doesn't have an entry for Pred!");
438 // The value that used to look like it came from Pred now comes from NewBB
439 PN->setIncomingBlock((unsigned)BBIdx, NewBB);
444 // CheckIncomingValueFor - Make sure that the specified PHI node has an entry
445 // for the provided basic block. If it doesn't, add one and return true.
447 static inline void CheckIncomingValueFor(PHINode *PN, BasicBlock *BB) {
448 if (PN->getBasicBlockIndex(BB) != -1) return; // Already has value
451 const Type *Ty = PN->getType();
453 if (const PointerType *PT = dyn_cast<PointerType>(Ty))
454 NewVal = ConstPoolPointerNull::get(PT);
455 else if (Ty == Type::BoolTy)
456 NewVal = ConstPoolBool::True;
457 else if (Ty == Type::FloatTy || Ty == Type::DoubleTy)
458 NewVal = ConstPoolFP::get(Ty, 42);
459 else if (Ty->isIntegral())
460 NewVal = ConstPoolInt::get(Ty, 42);
462 assert(NewVal && "Unknown PHI node type!");
463 PN->addIncoming(NewVal, BB);
466 // fixLocalProblems - Loop through the method and fix problems with the PHI
467 // nodes in the current method. The two problems that are handled are:
469 // 1. PHI nodes with multiple entries for the same predecessor. GCC sometimes
470 // generates code that looks like this:
472 // bb7: br bool %cond1004, label %bb8, label %bb8
473 // bb8: %reg119 = phi uint [ 0, %bb7 ], [ 1, %bb7 ]
475 // which is completely illegal LLVM code. To compensate for this, we insert
476 // an extra basic block, and convert the code to look like this:
478 // bb7: br bool %cond1004, label %bbX, label %bb8
480 // bb8: %reg119 = phi uint [ 0, %bbX ], [ 1, %bb7 ]
483 // 2. PHI nodes with fewer arguments than predecessors.
484 // These can be generated by GCC if a variable is uninitalized over a path
485 // in the CFG. We fix this by adding an entry for the missing predecessors
486 // that is initialized to either 42 for a numeric/FP value, or null if it's
487 // a pointer value. This problem can be generated by code that looks like
495 static bool fixLocalProblems(Method *M) {
496 bool Changed = false;
497 // Don't use iterators because invalidation gets messy...
498 for (unsigned MI = 0; MI < M->size(); ++MI) {
499 BasicBlock *BB = M->getBasicBlocks()[MI];
501 Changed |= FixCastsAndPHIs(BB);
503 if (isa<PHINode>(BB->front())) {
504 const vector<BasicBlock*> Preds(BB->pred_begin(), BB->pred_end());
506 // Handle Problem #1. Sort the list of predecessors so that it is easy to
507 // decide whether or not duplicate predecessors exist.
508 vector<BasicBlock*> SortedPreds(Preds);
509 sort(SortedPreds.begin(), SortedPreds.end());
511 // Loop over the predecessors, looking for adjacent BB's that are equal.
512 BasicBlock *LastOne = 0;
513 for (unsigned i = 0; i < Preds.size(); ++i) {
514 if (SortedPreds[i] == LastOne) { // Found a duplicate.
515 RefactorPredecessor(BB, SortedPreds[i]);
518 LastOne = SortedPreds[i];
521 // Loop over all of the PHI nodes in the current BB. These PHI nodes are
522 // guaranteed to be at the beginning of the basic block.
524 for (BasicBlock::iterator I = BB->begin();
525 PHINode *PN = dyn_cast<PHINode>(*I); ++I) {
527 // Handle problem #2.
528 if (PN->getNumIncomingValues() != Preds.size()) {
529 assert(PN->getNumIncomingValues() <= Preds.size() &&
530 "Can't handle extra arguments to PHI nodes!");
531 for (unsigned i = 0; i < Preds.size(); ++i)
532 CheckIncomingValueFor(PN, Preds[i]);
544 // doPerMethodWork - This method simplifies the specified method hopefully.
546 bool CleanupGCCOutput::doPerMethodWork(Method *M) {
547 bool Changed = fixLocalProblems(M);
548 while (doOneCleanupPass(M)) Changed = true;