2 # (c) 2001, Dave Jones. (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
5 # (c) 2008,2009, Andy Whitcroft <apw@canonical.com>
6 # Licensed under the terms of the GNU GPL License version 2
15 use Getopt::Long qw(:config no_auto_abbrev);
37 Usage: $P [OPTION]... [FILE]...
42 --no-tree run without a kernel tree
43 --no-signoff do not check for 'Signed-off-by' line
44 --patch treat FILE as patchfile (default)
45 --emacs emacs compile window format
46 --terse one line per report
47 -f, --file treat FILE as regular source file
48 --subjective, --strict enable more subjective tests
49 --root=PATH PATH to the kernel tree root
50 --no-summary suppress the per-file summary
51 --mailback only produce a report in case of warnings/errors
52 --summary-file include the filename in summary
53 --debug KEY=[0|1] turn on/off debugging of KEY, where KEY is one of
54 'values', 'possible', 'type', and 'attr' (default
56 --test-only=WORD report only warnings/errors containing WORD
58 -h, --help, --version display this help and exit
60 When FILE is - read standard input.
67 'q|quiet+' => \$quiet,
69 'signoff!' => \$chk_signoff,
70 'patch!' => \$chk_patch,
74 'subjective!' => \$check,
77 'summary!' => \$summary,
78 'mailback!' => \$mailback,
79 'summary-file!' => \$summary_file,
82 'test-only=s' => \$tst_only,
92 print "$P: no input files\n";
100 for my $key (keys %debug) {
102 eval "\${dbg_$key} = '$debug{$key}';";
106 my $rpt_cleaners = 0;
115 if (!top_of_kernel_tree($root)) {
116 die "$P: $root: --root does not point at a valid tree\n";
119 if (top_of_kernel_tree('.')) {
121 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
122 top_of_kernel_tree($1)) {
127 if (!defined $root) {
128 print "Must be run from the top-level dir. of a kernel tree\n";
133 my $emitted_corrupt = 0;
136 [A-Za-z_][A-Za-z\d_]*
137 (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
139 our $Storage = qr{extern|static|asmlinkage};
151 # Notes to $Attribute:
152 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
157 __(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
158 ____cacheline_aligned|
159 ____cacheline_aligned_in_smp|
160 ____cacheline_internodealigned_in_smp|
164 our $Inline = qr{inline|__always_inline|noinline};
165 our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]};
166 our $Lval = qr{$Ident(?:$Member)*};
168 our $Constant = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*};
169 our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
170 our $Compare = qr{<=|>=|==|!=|<|>};
174 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
182 [\x09\x0A\x0D\x20-\x7E] # ASCII
183 | [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte
184 | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs
185 | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte
186 | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates
187 | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3
188 | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15
189 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
192 our $typeTypedefs = qr{(?x:
193 (?:__)?(?:u|s|be|le)(?:8|16|32|64)|
197 our $logFunctions = qr{(?x:
199 pr_(debug|dbg|vdbg|devel|info|warning|err|notice|alert|crit|emerg|cont)|
200 (dev|netdev|netif)_(printk|dbg|vdbg|info|warn|err|notice|alert|crit|emerg|WARN)|
207 qr{(?:unsigned\s+)?char},
208 qr{(?:unsigned\s+)?short},
209 qr{(?:unsigned\s+)?int},
210 qr{(?:unsigned\s+)?long},
211 qr{(?:unsigned\s+)?long\s+int},
212 qr{(?:unsigned\s+)?long\s+long},
213 qr{(?:unsigned\s+)?long\s+long\s+int},
222 qr{${Ident}_handler},
223 qr{${Ident}_handler_fn},
225 our @modifierList = (
229 our $allowed_asm_includes = qr{(?x:
233 # memory.h: ARM has a custom one
236 my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)";
237 my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)";
238 $Modifier = qr{(?:$Attribute|$Sparse|$mods)};
240 (?:$Modifier\s+|const\s+)*
242 (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)|
246 (?:\s+$Modifier|\s+const)*
250 (?:[\s\*]+\s*const|[\s\*]+|(?:\s*\[\s*\])+)?
251 (?:\s+$Inline|\s+$Modifier)*
253 $Declare = qr{(?:$Storage\s+)?$Type};
257 $chk_signoff = 0 if ($file);
259 my @dep_includes = ();
260 my @dep_functions = ();
261 my $removal = "Documentation/feature-removal-schedule.txt";
262 if ($tree && -f "$root/$removal") {
263 open(my $REMOVE, '<', "$root/$removal") ||
264 die "$P: $removal: open failed - $!\n";
266 if (/^Check:\s+(.*\S)/) {
267 for my $entry (split(/[, ]+/, $1)) {
268 if ($entry =~ m@include/(.*)@) {
269 push(@dep_includes, $1);
271 } elsif ($entry !~ m@/@) {
272 push(@dep_functions, $entry);
283 for my $filename (@ARGV) {
286 open($FILE, '-|', "diff -u /dev/null $filename") ||
287 die "$P: $filename: diff failed - $!\n";
288 } elsif ($filename eq '-') {
289 open($FILE, '<&STDIN');
291 open($FILE, '<', "$filename") ||
292 die "$P: $filename: open failed - $!\n";
294 if ($filename eq '-') {
295 $vname = 'Your patch';
304 if (!process($filename)) {
313 sub top_of_kernel_tree {
317 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
318 "README", "Documentation", "arch", "include", "drivers",
319 "fs", "init", "ipc", "kernel", "lib", "scripts",
322 foreach my $check (@tree_check) {
323 if (! -e $root . '/' . $check) {
335 for my $c (split(//, $str)) {
339 for (; ($n % 8) != 0; $n++) {
351 (my $res = shift) =~ tr/\t/ /c;
358 # Drop the diff line leader and expand tabs
360 $line = expand_tabs($line);
362 # Pick the indent from the front of the line.
363 my ($white) = ($line =~ /^(\s*)/);
365 return (length($line), length($white));
368 my $sanitise_quote = '';
370 sub sanitise_line_reset {
371 my ($in_comment) = @_;
374 $sanitise_quote = '*/';
376 $sanitise_quote = '';
389 # Always copy over the diff marker.
390 $res = substr($line, 0, 1);
392 for ($off = 1; $off < length($line); $off++) {
393 $c = substr($line, $off, 1);
395 # Comments we are wacking completly including the begin
396 # and end, all to $;.
397 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
398 $sanitise_quote = '*/';
400 substr($res, $off, 2, "$;$;");
404 if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') {
405 $sanitise_quote = '';
406 substr($res, $off, 2, "$;$;");
410 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') {
411 $sanitise_quote = '//';
413 substr($res, $off, 2, $sanitise_quote);
418 # A \ in a string means ignore the next character.
419 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
421 substr($res, $off, 2, 'XX');
426 if ($c eq "'" || $c eq '"') {
427 if ($sanitise_quote eq '') {
428 $sanitise_quote = $c;
430 substr($res, $off, 1, $c);
432 } elsif ($sanitise_quote eq $c) {
433 $sanitise_quote = '';
437 #print "c<$c> SQ<$sanitise_quote>\n";
438 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
439 substr($res, $off, 1, $;);
440 } elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") {
441 substr($res, $off, 1, $;);
442 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
443 substr($res, $off, 1, 'X');
445 substr($res, $off, 1, $c);
449 if ($sanitise_quote eq '//') {
450 $sanitise_quote = '';
453 # The pathname on a #include may be surrounded by '<' and '>'.
454 if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
455 my $clean = 'X' x length($1);
456 $res =~ s@\<.*\>@<$clean>@;
458 # The whole of a #error is a string.
459 } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
460 my $clean = 'X' x length($1);
461 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
467 sub ctx_statement_block {
468 my ($linenr, $remain, $off) = @_;
469 my $line = $linenr - 1;
486 @stack = (['', 0]) if ($#stack == -1);
488 #warn "CSB: blk<$blk> remain<$remain>\n";
489 # If we are about to drop off the end, pull in more
492 for (; $remain > 0; $line++) {
493 last if (!defined $lines[$line]);
494 next if ($lines[$line] =~ /^-/);
497 $blk .= $lines[$line] . "\n";
502 # Bail if there is no further context.
503 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
509 $c = substr($blk, $off, 1);
510 $remainder = substr($blk, $off);
512 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
514 # Handle nested #if/#else.
515 if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) {
516 push(@stack, [ $type, $level ]);
517 } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) {
518 ($type, $level) = @{$stack[$#stack - 1]};
519 } elsif ($remainder =~ /^#\s*endif\b/) {
520 ($type, $level) = @{pop(@stack)};
523 # Statement ends at the ';' or a close '}' at the
525 if ($level == 0 && $c eq ';') {
529 # An else is really a conditional as long as its not else if
530 if ($level == 0 && $coff_set == 0 &&
531 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
532 $remainder =~ /^(else)(?:\s|{)/ &&
533 $remainder !~ /^else\s+if\b/) {
534 $coff = $off + length($1) - 1;
536 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
537 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
540 if (($type eq '' || $type eq '(') && $c eq '(') {
544 if ($type eq '(' && $c eq ')') {
546 $type = ($level != 0)? '(' : '';
548 if ($level == 0 && $coff < $soff) {
551 #warn "CSB: mark coff<$coff>\n";
554 if (($type eq '' || $type eq '{') && $c eq '{') {
558 if ($type eq '{' && $c eq '}') {
560 $type = ($level != 0)? '{' : '';
563 if (substr($blk, $off + 1, 1) eq ';') {
571 # We are truly at the end, so shuffle to the next line.
578 my $statement = substr($blk, $soff, $off - $soff + 1);
579 my $condition = substr($blk, $soff, $coff - $soff + 1);
581 #warn "STATEMENT<$statement>\n";
582 #warn "CONDITION<$condition>\n";
584 #print "coff<$coff> soff<$off> loff<$loff>\n";
586 return ($statement, $condition,
587 $line, $remain + 1, $off - $loff + 1, $level);
590 sub statement_lines {
593 # Strip the diff line prefixes and rip blank lines at start and end.
594 $stmt =~ s/(^|\n)./$1/g;
598 my @stmt_lines = ($stmt =~ /\n/g);
600 return $#stmt_lines + 2;
603 sub statement_rawlines {
606 my @stmt_lines = ($stmt =~ /\n/g);
608 return $#stmt_lines + 2;
611 sub statement_block_size {
614 $stmt =~ s/(^|\n)./$1/g;
620 my @stmt_lines = ($stmt =~ /\n/g);
621 my @stmt_statements = ($stmt =~ /;/g);
623 my $stmt_lines = $#stmt_lines + 2;
624 my $stmt_statements = $#stmt_statements + 1;
626 if ($stmt_lines > $stmt_statements) {
629 return $stmt_statements;
633 sub ctx_statement_full {
634 my ($linenr, $remain, $off) = @_;
635 my ($statement, $condition, $level);
639 # Grab the first conditional/block pair.
640 ($statement, $condition, $linenr, $remain, $off, $level) =
641 ctx_statement_block($linenr, $remain, $off);
642 #print "F: c<$condition> s<$statement> remain<$remain>\n";
643 push(@chunks, [ $condition, $statement ]);
644 if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
645 return ($level, $linenr, @chunks);
648 # Pull in the following conditional/block pairs and see if they
649 # could continue the statement.
651 ($statement, $condition, $linenr, $remain, $off, $level) =
652 ctx_statement_block($linenr, $remain, $off);
653 #print "C: c<$condition> s<$statement> remain<$remain>\n";
654 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
656 push(@chunks, [ $condition, $statement ]);
659 return ($level, $linenr, @chunks);
663 my ($linenr, $remain, $outer, $open, $close, $off) = @_;
665 my $start = $linenr - 1;
672 my @stack = ($level);
673 for ($line = $start; $remain > 0; $line++) {
674 next if ($rawlines[$line] =~ /^-/);
677 $blk .= $rawlines[$line];
679 # Handle nested #if/#else.
680 if ($rawlines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
681 push(@stack, $level);
682 } elsif ($rawlines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
683 $level = $stack[$#stack - 1];
684 } elsif ($rawlines[$line] =~ /^.\s*#\s*endif\b/) {
685 $level = pop(@stack);
688 foreach my $c (split(//, $rawlines[$line])) {
689 ##print "C<$c>L<$level><$open$close>O<$off>\n";
695 if ($c eq $close && $level > 0) {
697 last if ($level == 0);
698 } elsif ($c eq $open) {
703 if (!$outer || $level <= 1) {
704 push(@res, $rawlines[$line]);
707 last if ($level == 0);
710 return ($level, @res);
712 sub ctx_block_outer {
713 my ($linenr, $remain) = @_;
715 my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
719 my ($linenr, $remain) = @_;
721 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
725 my ($linenr, $remain, $off) = @_;
727 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
730 sub ctx_block_level {
731 my ($linenr, $remain) = @_;
733 return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
735 sub ctx_statement_level {
736 my ($linenr, $remain, $off) = @_;
738 return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
741 sub ctx_locate_comment {
742 my ($first_line, $end_line) = @_;
744 # Catch a comment on the end of the line itself.
745 my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
746 return $current_comment if (defined $current_comment);
748 # Look through the context and try and figure out if there is a
751 $current_comment = '';
752 for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
753 my $line = $rawlines[$linenr - 1];
755 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
758 if ($line =~ m@/\*@) {
761 if (!$in_comment && $current_comment ne '') {
762 $current_comment = '';
764 $current_comment .= $line . "\n" if ($in_comment);
765 if ($line =~ m@\*/@) {
770 chomp($current_comment);
771 return($current_comment);
773 sub ctx_has_comment {
774 my ($first_line, $end_line) = @_;
775 my $cmt = ctx_locate_comment($first_line, $end_line);
777 ##print "LINE: $rawlines[$end_line - 1 ]\n";
778 ##print "CMMT: $cmt\n";
784 my ($linenr, $cnt) = @_;
786 my $offset = $linenr - 1;
791 $line = $rawlines[$offset++];
792 next if (defined($line) && $line =~ /^-/);
804 while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
807 $coded = sprintf("^%c", unpack('C', $2) + 64);
816 my $av_preprocessor = 0;
822 $av_preprocessor = 0;
824 @av_paren_type = ('E');
825 $av_pend_colon = 'O';
828 sub annotate_values {
829 my ($stream, $type) = @_;
832 my $var = '_' x length($stream);
835 print "$stream\n" if ($dbg_values > 1);
837 while (length($cur)) {
838 @av_paren_type = ('E') if ($#av_paren_type < 0);
839 print " <" . join('', @av_paren_type) .
840 "> <$type> <$av_pending>" if ($dbg_values > 1);
841 if ($cur =~ /^(\s+)/o) {
842 print "WS($1)\n" if ($dbg_values > 1);
843 if ($1 =~ /\n/ && $av_preprocessor) {
844 $type = pop(@av_paren_type);
845 $av_preprocessor = 0;
848 } elsif ($cur =~ /^(\(\s*$Type\s*)\)/) {
849 print "CAST($1)\n" if ($dbg_values > 1);
850 push(@av_paren_type, $type);
853 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
854 print "DECLARE($1)\n" if ($dbg_values > 1);
857 } elsif ($cur =~ /^($Modifier)\s*/) {
858 print "MODIFIER($1)\n" if ($dbg_values > 1);
861 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
862 print "DEFINE($1,$2)\n" if ($dbg_values > 1);
863 $av_preprocessor = 1;
864 push(@av_paren_type, $type);
870 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
871 print "UNDEF($1)\n" if ($dbg_values > 1);
872 $av_preprocessor = 1;
873 push(@av_paren_type, $type);
875 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
876 print "PRE_START($1)\n" if ($dbg_values > 1);
877 $av_preprocessor = 1;
879 push(@av_paren_type, $type);
880 push(@av_paren_type, $type);
883 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
884 print "PRE_RESTART($1)\n" if ($dbg_values > 1);
885 $av_preprocessor = 1;
887 push(@av_paren_type, $av_paren_type[$#av_paren_type]);
891 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
892 print "PRE_END($1)\n" if ($dbg_values > 1);
894 $av_preprocessor = 1;
896 # Assume all arms of the conditional end as this
897 # one does, and continue as if the #endif was not here.
899 push(@av_paren_type, $type);
902 } elsif ($cur =~ /^(\\\n)/o) {
903 print "PRECONT($1)\n" if ($dbg_values > 1);
905 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
906 print "ATTR($1)\n" if ($dbg_values > 1);
910 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
911 print "SIZEOF($1)\n" if ($dbg_values > 1);
917 } elsif ($cur =~ /^(if|while|for)\b/o) {
918 print "COND($1)\n" if ($dbg_values > 1);
922 } elsif ($cur =~/^(case)/o) {
923 print "CASE($1)\n" if ($dbg_values > 1);
924 $av_pend_colon = 'C';
927 } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
928 print "KEYWORD($1)\n" if ($dbg_values > 1);
931 } elsif ($cur =~ /^(\()/o) {
932 print "PAREN('$1')\n" if ($dbg_values > 1);
933 push(@av_paren_type, $av_pending);
937 } elsif ($cur =~ /^(\))/o) {
938 my $new_type = pop(@av_paren_type);
939 if ($new_type ne '_') {
941 print "PAREN('$1') -> $type\n"
942 if ($dbg_values > 1);
944 print "PAREN('$1')\n" if ($dbg_values > 1);
947 } elsif ($cur =~ /^($Ident)\s*\(/o) {
948 print "FUNC($1)\n" if ($dbg_values > 1);
952 } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) {
953 if (defined $2 && $type eq 'C' || $type eq 'T') {
954 $av_pend_colon = 'B';
955 } elsif ($type eq 'E') {
956 $av_pend_colon = 'L';
958 print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
961 } elsif ($cur =~ /^($Ident|$Constant)/o) {
962 print "IDENT($1)\n" if ($dbg_values > 1);
965 } elsif ($cur =~ /^($Assignment)/o) {
966 print "ASSIGN($1)\n" if ($dbg_values > 1);
969 } elsif ($cur =~/^(;|{|})/) {
970 print "END($1)\n" if ($dbg_values > 1);
972 $av_pend_colon = 'O';
974 } elsif ($cur =~/^(,)/) {
975 print "COMMA($1)\n" if ($dbg_values > 1);
978 } elsif ($cur =~ /^(\?)/o) {
979 print "QUESTION($1)\n" if ($dbg_values > 1);
982 } elsif ($cur =~ /^(:)/o) {
983 print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);
985 substr($var, length($res), 1, $av_pend_colon);
986 if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
991 $av_pend_colon = 'O';
993 } elsif ($cur =~ /^(\[)/o) {
994 print "CLOSE($1)\n" if ($dbg_values > 1);
997 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
1000 print "OPV($1)\n" if ($dbg_values > 1);
1007 substr($var, length($res), 1, $variant);
1010 } elsif ($cur =~ /^($Operators)/o) {
1011 print "OP($1)\n" if ($dbg_values > 1);
1012 if ($1 ne '++' && $1 ne '--') {
1016 } elsif ($cur =~ /(^.)/o) {
1017 print "C($1)\n" if ($dbg_values > 1);
1020 $cur = substr($cur, length($1));
1021 $res .= $type x length($1);
1025 return ($res, $var);
1029 my ($possible, $line) = @_;
1030 my $notPermitted = qr{(?:
1045 ^(?:typedef|struct|enum)\b
1047 warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
1048 if ($possible !~ $notPermitted) {
1049 # Check for modifiers.
1050 $possible =~ s/\s*$Storage\s*//g;
1051 $possible =~ s/\s*$Sparse\s*//g;
1052 if ($possible =~ /^\s*$/) {
1054 } elsif ($possible =~ /\s/) {
1055 $possible =~ s/\s*$Type\s*//g;
1056 for my $modifier (split(' ', $possible)) {
1057 if ($modifier !~ $notPermitted) {
1058 warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
1059 push(@modifierList, $modifier);
1064 warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
1065 push(@typeList, $possible);
1069 warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1);
1076 if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) {
1079 my $line = $prefix . $_[0];
1081 $line = (split('\n', $line))[0] . "\n" if ($terse);
1083 push(our @report, $line);
1091 if (report("ERROR: $_[0]\n")) {
1097 if (report("WARNING: $_[0]\n")) {
1103 if ($check && report("CHECK: $_[0]\n")) {
1109 sub check_absolute_file {
1110 my ($absolute, $herecurr) = @_;
1111 my $file = $absolute;
1113 ##print "absolute<$absolute>\n";
1115 # See if any suffix of this path is a path within the tree.
1116 while ($file =~ s@^[^/]*/@@) {
1117 if (-f "$root/$file") {
1118 ##print "file<$file>\n";
1126 # It is, so see if the prefix is acceptable.
1127 my $prefix = $absolute;
1128 substr($prefix, -length($file)) = '';
1130 ##print "prefix<$prefix>\n";
1131 if ($prefix ne ".../") {
1132 WARN("use relative pathname instead of absolute in changelog text\n" . $herecurr);
1137 my $filename = shift;
1143 my $stashrawline="";
1160 # Trace the real file/line as we go.
1166 my $comment_edge = 0;
1170 my $prev_values = 'E';
1173 my %suppress_ifbraces;
1174 my %suppress_whiletrailers;
1175 my %suppress_export;
1177 # Pre-scan the patch sanitizing the lines.
1178 # Pre-scan the patch looking for any __setup documentation.
1180 my @setup_docs = ();
1183 sanitise_line_reset();
1185 foreach my $rawline (@rawlines) {
1189 if ($rawline=~/^\+\+\+\s+(\S+)/) {
1191 if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
1196 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1205 # Guestimate if this is a continuing comment. Run
1206 # the context looking for a comment "edge". If this
1207 # edge is a close comment then we must be in a comment
1211 for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1212 next if (defined $rawlines[$ln - 1] &&
1213 $rawlines[$ln - 1] =~ /^-/);
1215 #print "RAW<$rawlines[$ln - 1]>\n";
1216 last if (!defined $rawlines[$ln - 1]);
1217 if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
1218 $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
1223 if (defined $edge && $edge eq '*/') {
1227 # Guestimate if this is a continuing comment. If this
1228 # is the start of a diff block and this line starts
1229 # ' *' then it is very likely a comment.
1230 if (!defined $edge &&
1231 $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@)
1236 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1237 sanitise_line_reset($in_comment);
1239 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1240 # Standardise the strings and chars within the input to
1241 # simplify matching -- only bother with positive lines.
1242 $line = sanitise_line($rawline);
1244 push(@lines, $line);
1247 $realcnt-- if ($line =~ /^(?:\+| |$)/);
1252 #print "==>$rawline\n";
1253 #print "-->$line\n";
1255 if ($setup_docs && $line =~ /^\+/) {
1256 push(@setup_docs, $line);
1264 foreach my $line (@lines) {
1267 my $rawline = $rawlines[$linenr - 1];
1269 #extract the line range in the file after the patch is applied
1270 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1272 $first_line = $linenr + 1;
1282 %suppress_ifbraces = ();
1283 %suppress_whiletrailers = ();
1284 %suppress_export = ();
1287 # track the line number as we move through the hunk, note that
1288 # new versions of GNU diff omit the leading space on completely
1289 # blank context lines so we need to count that too.
1290 } elsif ($line =~ /^( |\+|$)/) {
1292 $realcnt-- if ($realcnt != 0);
1294 # Measure the line length and indent.
1295 ($length, $indent) = line_stats($rawline);
1297 # Track the previous line.
1298 ($prevline, $stashline) = ($stashline, $line);
1299 ($previndent, $stashindent) = ($stashindent, $indent);
1300 ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1302 #warn "line<$line>\n";
1304 } elsif ($realcnt == 1) {
1308 my $hunk_line = ($realcnt != 0);
1310 #make up the handle for any error we report on this line
1311 $prefix = "$filename:$realline: " if ($emacs && $file);
1312 $prefix = "$filename:$linenr: " if ($emacs && !$file);
1314 $here = "#$linenr: " if (!$file);
1315 $here = "#$realline: " if ($file);
1317 # extract the filename as it passes
1318 if ($line=~/^\+\+\+\s+(\S+)/) {
1320 $realfile =~ s@^([^/]*)/@@;
1323 if (!$file && $tree && $p1_prefix ne '' &&
1324 -e "$root/$p1_prefix") {
1325 WARN("patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
1328 if ($realfile =~ m@^include/asm/@) {
1329 ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1334 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
1336 my $hereline = "$here\n$rawline\n";
1337 my $herecurr = "$here\n$rawline\n";
1338 my $hereprev = "$here\n$prevrawline\n$rawline\n";
1340 $cnt_lines++ if ($realcnt != 0);
1342 #check the patch for a signoff:
1343 if ($line =~ /^\s*signed-off-by:/i) {
1344 # This is a signoff, if ugly, so do not double report.
1346 if (!($line =~ /^\s*Signed-off-by:/)) {
1347 WARN("Signed-off-by: is the preferred form\n" .
1350 if ($line =~ /^\s*signed-off-by:\S/i) {
1351 WARN("space required after Signed-off-by:\n" .
1356 # Check for wrappage within a valid hunk of the file
1357 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
1358 ERROR("patch seems to be corrupt (line wrapped?)\n" .
1359 $herecurr) if (!$emitted_corrupt++);
1362 # Check for absolute kernel paths.
1364 while ($line =~ m{(?:^|\s)(/\S*)}g) {
1367 if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
1368 check_absolute_file($1, $herecurr)) {
1371 check_absolute_file($file, $herecurr);
1376 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1377 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
1378 $rawline !~ m/^$UTF8*$/) {
1379 my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1381 my $blank = copy_spacing($rawline);
1382 my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1383 my $hereptr = "$hereline$ptr\n";
1385 ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1388 # ignore non-hunk lines and lines being removed
1389 next if (!$hunk_line || $line =~ /^-/);
1391 #trailing whitespace
1392 if ($line =~ /^\+.*\015/) {
1393 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1394 ERROR("DOS line endings\n" . $herevet);
1396 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1397 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1398 ERROR("trailing whitespace\n" . $herevet);
1402 # check for Kconfig help text having a real description
1403 # Only applies when adding the entry originally, after that we do not have
1404 # sufficient context to determine whether it is indeed long enough.
1405 if ($realfile =~ /Kconfig/ &&
1406 $line =~ /\+\s*(?:---)?help(?:---)?$/) {
1409 my $ln = $linenr + 1;
1412 while ($cnt > 0 && defined $lines[$ln - 1]) {
1413 $f = $lines[$ln - 1];
1414 $cnt-- if ($lines[$ln - 1] !~ /^-/);
1415 $is_end = $lines[$ln - 1] =~ /^\+/;
1418 next if ($f =~ /^-/);
1422 next if ($f =~ /^$/);
1423 if ($f =~ /^\s*config\s/) {
1429 WARN("please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_end && $length < 4);
1430 #print "is_end<$is_end> length<$length>\n";
1433 # check we are in a valid source file if not then ignore this hunk
1434 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
1437 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
1438 $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
1439 !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ ||
1440 $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
1443 WARN("line over 80 characters\n" . $herecurr);
1446 # check for spaces before a quoted newline
1447 if ($rawline =~ /^.*\".*\s\\n/) {
1448 WARN("unnecessary whitespace before a quoted newline\n" . $herecurr);
1451 # check for adding lines without a newline.
1452 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1453 WARN("adding a line without newline at end of file\n" . $herecurr);
1456 # Blackfin: use hi/lo macros
1457 if ($realfile =~ m@arch/blackfin/.*\.S$@) {
1458 if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
1459 my $herevet = "$here\n" . cat_vet($line) . "\n";
1460 ERROR("use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
1462 if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
1463 my $herevet = "$here\n" . cat_vet($line) . "\n";
1464 ERROR("use the HI() macro, not (... >> 16)\n" . $herevet);
1468 # check we are in a valid source file C or perl if not then ignore this hunk
1469 next if ($realfile !~ /\.(h|c|pl)$/);
1471 # at the beginning of a line any tabs must come first and anything
1472 # more than 8 must use tabs.
1473 if ($rawline =~ /^\+\s* \t\s*\S/ ||
1474 $rawline =~ /^\+\s* \s*/) {
1475 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1476 ERROR("code indent should use tabs where possible\n" . $herevet);
1480 # check for space before tabs.
1481 if ($rawline =~ /^\+/ && $rawline =~ / \t/) {
1482 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1483 WARN("please, no space before tabs\n" . $herevet);
1486 # check for spaces at the beginning of a line.
1488 # 1) within comments
1489 # 2) indented preprocessor commands
1491 if ($rawline =~ /^\+ / && $line !~ /\+ *(?:$;|#|$Ident:)/) {
1492 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1493 WARN("please, no spaces at the start of a line\n" . $herevet);
1496 # check we are in a valid C source file if not then ignore this hunk
1497 next if ($realfile !~ /\.(h|c)$/);
1499 # check for RCS/CVS revision markers
1500 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
1501 WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
1504 # Blackfin: don't use __builtin_bfin_[cs]sync
1505 if ($line =~ /__builtin_bfin_csync/) {
1506 my $herevet = "$here\n" . cat_vet($line) . "\n";
1507 ERROR("use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
1509 if ($line =~ /__builtin_bfin_ssync/) {
1510 my $herevet = "$here\n" . cat_vet($line) . "\n";
1511 ERROR("use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
1514 # Check for potential 'bare' types
1515 my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
1517 if ($realcnt && $line =~ /.\s*\S/) {
1518 ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
1519 ctx_statement_block($linenr, $realcnt, 0);
1520 $stat =~ s/\n./\n /g;
1521 $cond =~ s/\n./\n /g;
1523 # Find the real next line.
1524 $realline_next = $line_nr_next;
1525 if (defined $realline_next &&
1526 (!defined $lines[$realline_next - 1] ||
1527 substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
1534 # Ignore goto labels.
1535 if ($s =~ /$Ident:\*$/s) {
1537 # Ignore functions being called
1538 } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
1540 } elsif ($s =~ /^.\s*else\b/s) {
1542 # declarations always start with types
1543 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
1546 possible($type, "A:" . $s);
1548 # definitions in global scope can only start with types
1549 } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) {
1550 possible($1, "B:" . $s);
1553 # any (foo ... *) is a pointer cast, and foo is a type
1554 while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) {
1555 possible($1, "C:" . $s);
1558 # Check for any sort of function declaration.
1559 # int foo(something bar, other baz);
1560 # void (*store_gdt)(x86_descr_ptr *);
1561 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
1562 my ($name_len) = length($1);
1565 substr($ctx, 0, $name_len + 1, '');
1566 $ctx =~ s/\)[^\)]*$//;
1568 for my $arg (split(/\s*,\s*/, $ctx)) {
1569 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
1571 possible($1, "D:" . $s);
1579 # Checks which may be anchored in the context.
1582 # Check for switch () and associated case and default
1583 # statements should be at the same indent.
1584 if ($line=~/\bswitch\s*\(.*\)/) {
1587 my @ctx = ctx_block_outer($linenr, $realcnt);
1589 for my $ctx (@ctx) {
1590 my ($clen, $cindent) = line_stats($ctx);
1591 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
1592 $indent != $cindent) {
1593 $err .= "$sep$ctx\n";
1600 ERROR("switch and case should be at the same indent\n$hereline$err");
1604 # if/while/etc brace do not go on next line, unless defining a do while loop,
1605 # or if that brace on the next line is for something else
1606 if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
1607 my $pre_ctx = "$1$2";
1609 my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
1610 my $ctx_cnt = $realcnt - $#ctx - 1;
1611 my $ctx = join("\n", @ctx);
1613 my $ctx_ln = $linenr;
1614 my $ctx_skip = $realcnt;
1616 while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
1617 defined $lines[$ctx_ln - 1] &&
1618 $lines[$ctx_ln - 1] =~ /^-/)) {
1619 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
1620 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
1624 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
1625 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
1627 if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
1628 ERROR("that open brace { should be on the previous line\n" .
1629 "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
1631 if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
1632 $ctx =~ /\)\s*\;\s*$/ &&
1633 defined $lines[$ctx_ln - 1])
1635 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
1636 if ($nindent > $indent) {
1637 WARN("trailing semicolon indicates no statements, indent implies otherwise\n" .
1638 "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
1643 # Check relative indent for conditionals and blocks.
1644 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
1645 my ($s, $c) = ($stat, $cond);
1647 substr($s, 0, length($c), '');
1649 # Make sure we remove the line prefixes as we have
1650 # none on the first line, and are going to readd them
1654 # Find out how long the conditional actually is.
1655 my @newlines = ($c =~ /\n/gs);
1656 my $cond_lines = 1 + $#newlines;
1658 # We want to check the first line inside the block
1659 # starting at the end of the conditional, so remove:
1660 # 1) any blank line termination
1661 # 2) any opening brace { on end of the line
1663 my $continuation = 0;
1665 $s =~ s/^.*\bdo\b//;
1667 if ($s =~ s/^\s*\\//) {
1670 if ($s =~ s/^\s*?\n//) {
1675 # Also ignore a loop construct at the end of a
1676 # preprocessor statement.
1677 if (($prevline =~ /^.\s*#\s*define\s/ ||
1678 $prevline =~ /\\\s*$/) && $continuation == 0) {
1684 while ($cond_ptr != $cond_lines) {
1685 $cond_ptr = $cond_lines;
1687 # If we see an #else/#elif then the code
1689 if ($s =~ /^\s*\#\s*(?:else|elif)/) {
1694 # 1) blank lines, they should be at 0,
1695 # 2) preprocessor lines, and
1697 if ($continuation ||
1699 $s =~ /^\s*#\s*?/ ||
1700 $s =~ /^\s*$Ident\s*:/) {
1701 $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0;
1702 if ($s =~ s/^.*?\n//) {
1708 my (undef, $sindent) = line_stats("+" . $s);
1709 my $stat_real = raw_line($linenr, $cond_lines);
1711 # Check if either of these lines are modified, else
1712 # this is not this patch's fault.
1713 if (!defined($stat_real) ||
1714 $stat !~ /^\+/ && $stat_real !~ /^\+/) {
1717 if (defined($stat_real) && $cond_lines > 1) {
1718 $stat_real = "[...]\n$stat_real";
1721 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
1723 if ($check && (($sindent % 8) != 0 ||
1724 ($sindent <= $indent && $s ne ''))) {
1725 WARN("suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
1729 # Track the 'values' across context and added lines.
1730 my $opline = $line; $opline =~ s/^./ /;
1731 my ($curr_values, $curr_vars) =
1732 annotate_values($opline . "\n", $prev_values);
1733 $curr_values = $prev_values . $curr_values;
1735 my $outline = $opline; $outline =~ s/\t/ /g;
1736 print "$linenr > .$outline\n";
1737 print "$linenr > $curr_values\n";
1738 print "$linenr > $curr_vars\n";
1740 $prev_values = substr($curr_values, -1);
1742 #ignore lines not being added
1743 if ($line=~/^[^\+]/) {next;}
1745 # TEST: allow direct testing of the type matcher.
1747 if ($line =~ /^.\s*$Declare\s*$/) {
1748 ERROR("TEST: is type\n" . $herecurr);
1749 } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
1750 ERROR("TEST: is not type ($1 is)\n". $herecurr);
1754 # TEST: allow direct testing of the attribute matcher.
1756 if ($line =~ /^.\s*$Modifier\s*$/) {
1757 ERROR("TEST: is attr\n" . $herecurr);
1758 } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) {
1759 ERROR("TEST: is not attr ($1 is)\n". $herecurr);
1764 # check for initialisation to aggregates open brace on the next line
1765 if ($line =~ /^.\s*{/ &&
1766 $prevline =~ /(?:^|[^=])=\s*$/) {
1767 ERROR("that open brace { should be on the previous line\n" . $hereprev);
1771 # Checks which are anchored on the added line.
1774 # check for malformed paths in #include statements (uses RAW line)
1775 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
1777 if ($path =~ m{//}) {
1778 ERROR("malformed #include filename\n" .
1783 # no C99 // comments
1784 if ($line =~ m{//}) {
1785 ERROR("do not use C99 // comments\n" . $herecurr);
1787 # Remove C99 comments.
1789 $opline =~ s@//.*@@;
1791 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
1792 # the whole statement.
1793 #print "APW <$lines[$realline_next - 1]>\n";
1794 if (defined $realline_next &&
1795 exists $lines[$realline_next - 1] &&
1796 !defined $suppress_export{$realline_next} &&
1797 ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
1798 $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
1802 ^.DEFINE_$Ident\(\Q$name\E\)|
1803 ^.DECLARE_$Ident\(\Q$name\E\)|
1804 ^.LIST_HEAD\(\Q$name\E\)|
1805 ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
1806 \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
1808 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
1809 $suppress_export{$realline_next} = 2;
1811 $suppress_export{$realline_next} = 1;
1814 if (!defined $suppress_export{$linenr} &&
1815 $prevline =~ /^.\s*$/ &&
1816 ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
1817 $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
1818 #print "FOO B <$lines[$linenr - 1]>\n";
1819 $suppress_export{$linenr} = 2;
1821 if (defined $suppress_export{$linenr} &&
1822 $suppress_export{$linenr} == 2) {
1823 WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
1826 # check for global initialisers.
1827 if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
1828 ERROR("do not initialise globals to 0 or NULL\n" .
1831 # check for static initialisers.
1832 if ($line =~ /\bstatic\s.*=\s*(0|NULL|false)\s*;/) {
1833 ERROR("do not initialise statics to 0 or NULL\n" .
1837 # check for new typedefs, only function parameters and sparse annotations
1839 if ($line =~ /\btypedef\s/ &&
1840 $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ &&
1841 $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
1842 $line !~ /\b$typeTypedefs\b/ &&
1843 $line !~ /\b__bitwise(?:__|)\b/) {
1844 WARN("do not add new typedefs\n" . $herecurr);
1847 # * goes on variable not on type
1849 if ($line =~ m{\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\)}) {
1850 my ($from, $to) = ($1, $1);
1852 # Should start with a space.
1853 $to =~ s/^(\S)/ $1/;
1854 # Should not end with a space.
1856 # '*'s should not have spaces between.
1857 while ($to =~ s/\*\s+\*/\*\*/) {
1860 #print "from<$from> to<$to>\n";
1862 ERROR("\"(foo$from)\" should be \"(foo$to)\"\n" . $herecurr);
1864 } elsif ($line =~ m{\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident)}) {
1865 my ($from, $to, $ident) = ($1, $1, $2);
1867 # Should start with a space.
1868 $to =~ s/^(\S)/ $1/;
1869 # Should not end with a space.
1871 # '*'s should not have spaces between.
1872 while ($to =~ s/\*\s+\*/\*\*/) {
1874 # Modifiers should have spaces.
1875 $to =~ s/(\b$Modifier$)/$1 /;
1877 #print "from<$from> to<$to> ident<$ident>\n";
1878 if ($from ne $to && $ident !~ /^$Modifier$/) {
1879 ERROR("\"foo${from}bar\" should be \"foo${to}bar\"\n" . $herecurr);
1883 # # no BUG() or BUG_ON()
1884 # if ($line =~ /\b(BUG|BUG_ON)\b/) {
1885 # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
1886 # print "$herecurr";
1890 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
1891 WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
1894 # printk should use KERN_* levels. Note that follow on printk's on the
1895 # same line do not need a level, so we use the current block context
1896 # to try and find and validate the current printk. In summary the current
1897 # printk includes all preceeding printk's which have no newline on the end.
1898 # we assume the first bad printk is the one to report.
1899 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
1901 for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
1902 #print "CHECK<$lines[$ln - 1]\n";
1903 # we have a preceeding printk if it ends
1904 # with "\n" ignore it, else it is to blame
1905 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
1906 if ($rawlines[$ln - 1] !~ m{\\n"}) {
1913 WARN("printk() should include KERN_ facility level\n" . $herecurr);
1917 # function brace can't be on same line, except for #defines of do while,
1918 # or if closed on same line
1919 if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
1920 !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
1921 ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr);
1924 # open braces for enum, union and struct go on the same line.
1925 if ($line =~ /^.\s*{/ &&
1926 $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
1927 ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);
1930 # missing space after union, struct or enum definition
1931 if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?(?:\s+$Ident)?[=\{]/) {
1932 WARN("missing space after $1 definition\n" . $herecurr);
1935 # check for spacing round square brackets; allowed:
1936 # 1. with a type on the left -- int [] a;
1937 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
1938 # 3. inside a curly brace -- = { [0...10] = 5 }
1939 while ($line =~ /(.*?\s)\[/g) {
1940 my ($where, $prefix) = ($-[1], $1);
1941 if ($prefix !~ /$Type\s+$/ &&
1942 ($where != 0 || $prefix !~ /^.\s+$/) &&
1943 $prefix !~ /{\s+$/) {
1944 ERROR("space prohibited before open square bracket '['\n" . $herecurr);
1948 # check for spaces between functions and their parentheses.
1949 while ($line =~ /($Ident)\s+\(/g) {
1951 my $ctx_before = substr($line, 0, $-[1]);
1952 my $ctx = "$ctx_before$name";
1954 # Ignore those directives where spaces _are_ permitted.
1956 if|for|while|switch|return|case|
1957 volatile|__volatile__|
1958 __attribute__|format|__extension__|
1962 # cpp #define statements have non-optional spaces, ie
1963 # if there is a space between the name and the open
1964 # parenthesis it is simply not a parameter group.
1965 } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
1967 # cpp #elif statement condition may start with a (
1968 } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
1970 # If this whole things ends with a type its most
1971 # likely a typedef for a function.
1972 } elsif ($ctx =~ /$Type$/) {
1975 WARN("space prohibited between function name and open parenthesis '('\n" . $herecurr);
1978 # Check operator spacing.
1979 if (!($line=~/\#\s*include/)) {
1981 <<=|>>=|<=|>=|==|!=|
1982 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
1983 =>|->|<<|>>|<|>|=|!|~|
1984 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
1987 my @elements = split(/($ops|;)/, $opline);
1990 my $blank = copy_spacing($opline);
1992 for (my $n = 0; $n < $#elements; $n += 2) {
1993 $off += length($elements[$n]);
1995 # Pick up the preceeding and succeeding characters.
1996 my $ca = substr($opline, 0, $off);
1998 if (length($opline) >= ($off + length($elements[$n + 1]))) {
1999 $cc = substr($opline, $off + length($elements[$n + 1]));
2001 my $cb = "$ca$;$cc";
2004 $a = 'V' if ($elements[$n] ne '');
2005 $a = 'W' if ($elements[$n] =~ /\s$/);
2006 $a = 'C' if ($elements[$n] =~ /$;$/);
2007 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
2008 $a = 'O' if ($elements[$n] eq '');
2009 $a = 'E' if ($ca =~ /^\s*$/);
2011 my $op = $elements[$n + 1];
2014 if (defined $elements[$n + 2]) {
2015 $c = 'V' if ($elements[$n + 2] ne '');
2016 $c = 'W' if ($elements[$n + 2] =~ /^\s/);
2017 $c = 'C' if ($elements[$n + 2] =~ /^$;/);
2018 $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
2019 $c = 'O' if ($elements[$n + 2] eq '');
2020 $c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/);
2025 my $ctx = "${a}x${c}";
2027 my $at = "(ctx:$ctx)";
2029 my $ptr = substr($blank, 0, $off) . "^";
2030 my $hereptr = "$hereline$ptr\n";
2032 # Pull out the value of this operator.
2033 my $op_type = substr($curr_values, $off + 1, 1);
2035 # Get the full operator variant.
2036 my $opv = $op . substr($curr_vars, $off, 1);
2038 # Ignore operators passed as parameters.
2039 if ($op_type ne 'V' &&
2040 $ca =~ /\s$/ && $cc =~ /^\s*,/) {
2043 # } elsif ($op =~ /^$;+$/) {
2045 # ; should have either the end of line or a space or \ after it
2046 } elsif ($op eq ';') {
2047 if ($ctx !~ /.x[WEBC]/ &&
2048 $cc !~ /^\\/ && $cc !~ /^;/) {
2049 ERROR("space required after that '$op' $at\n" . $hereptr);
2053 } elsif ($op eq '//') {
2057 # : when part of a bitfield
2058 } elsif ($op eq '->' || $opv eq ':B') {
2059 if ($ctx =~ /Wx.|.xW/) {
2060 ERROR("spaces prohibited around that '$op' $at\n" . $hereptr);
2063 # , must have a space on the right.
2064 } elsif ($op eq ',') {
2065 if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
2066 ERROR("space required after that '$op' $at\n" . $hereptr);
2069 # '*' as part of a type definition -- reported already.
2070 } elsif ($opv eq '*_') {
2071 #warn "'*' is part of type\n";
2073 # unary operators should have a space before and
2074 # none after. May be left adjacent to another
2075 # unary operator, or a cast
2076 } elsif ($op eq '!' || $op eq '~' ||
2077 $opv eq '*U' || $opv eq '-U' ||
2078 $opv eq '&U' || $opv eq '&&U') {
2079 if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
2080 ERROR("space required before that '$op' $at\n" . $hereptr);
2082 if ($op eq '*' && $cc =~/\s*$Modifier\b/) {
2083 # A unary '*' may be const
2085 } elsif ($ctx =~ /.xW/) {
2086 ERROR("space prohibited after that '$op' $at\n" . $hereptr);
2089 # unary ++ and unary -- are allowed no space on one side.
2090 } elsif ($op eq '++' or $op eq '--') {
2091 if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
2092 ERROR("space required one side of that '$op' $at\n" . $hereptr);
2094 if ($ctx =~ /Wx[BE]/ ||
2095 ($ctx =~ /Wx./ && $cc =~ /^;/)) {
2096 ERROR("space prohibited before that '$op' $at\n" . $hereptr);
2098 if ($ctx =~ /ExW/) {
2099 ERROR("space prohibited after that '$op' $at\n" . $hereptr);
2103 # << and >> may either have or not have spaces both sides
2104 } elsif ($op eq '<<' or $op eq '>>' or
2105 $op eq '&' or $op eq '^' or $op eq '|' or
2106 $op eq '+' or $op eq '-' or
2107 $op eq '*' or $op eq '/' or
2110 if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
2111 ERROR("need consistent spacing around '$op' $at\n" .
2115 # A colon needs no spaces before when it is
2116 # terminating a case value or a label.
2117 } elsif ($opv eq ':C' || $opv eq ':L') {
2118 if ($ctx =~ /Wx./) {
2119 ERROR("space prohibited before that '$op' $at\n" . $hereptr);
2122 # All the others need spaces both sides.
2123 } elsif ($ctx !~ /[EWC]x[CWE]/) {
2126 # Ignore email addresses <foo@bar>
2128 $cc =~ /^\S+\@\S+>/) ||
2130 $ca =~ /<\S+\@\S+$/))
2136 if (($opv eq ':O' && $ca =~ /\?$/) ||
2137 ($op eq '?' && $cc =~ /^:/)) {
2142 ERROR("spaces required around that '$op' $at\n" . $hereptr);
2145 $off += length($elements[$n + 1]);
2149 # check for multiple assignments
2150 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
2151 CHK("multiple assignments should be avoided\n" . $herecurr);
2154 ## # check for multiple declarations, allowing for a function declaration
2156 ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
2157 ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
2159 ## # Remove any bracketed sections to ensure we do not
2160 ## # falsly report the parameters of functions.
2162 ## while ($ln =~ s/\([^\(\)]*\)//g) {
2164 ## if ($ln =~ /,/) {
2165 ## WARN("declaring multiple variables together should be avoided\n" . $herecurr);
2169 #need space before brace following if, while, etc
2170 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
2172 ERROR("space required before the open brace '{'\n" . $herecurr);
2175 # closing brace should have a space following it when it has anything
2177 if ($line =~ /}(?!(?:,|;|\)))\S/) {
2178 ERROR("space required after that close brace '}'\n" . $herecurr);
2181 # check spacing on square brackets
2182 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
2183 ERROR("space prohibited after that open square bracket '['\n" . $herecurr);
2185 if ($line =~ /\s\]/) {
2186 ERROR("space prohibited before that close square bracket ']'\n" . $herecurr);
2189 # check spacing on parentheses
2190 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
2191 $line !~ /for\s*\(\s+;/) {
2192 ERROR("space prohibited after that open parenthesis '('\n" . $herecurr);
2194 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
2195 $line !~ /for\s*\(.*;\s+\)/ &&
2196 $line !~ /:\s+\)/) {
2197 ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr);
2200 #goto labels aren't indented, allow a single space however
2201 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
2202 !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
2203 WARN("labels should not be indented\n" . $herecurr);
2206 # Return is not a function.
2207 if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
2211 # Flatten any parentheses
2212 $value =~ s/\(/ \(/g;
2213 $value =~ s/\)/\) /g;
2214 while ($value =~ s/\[[^\{\}]*\]/1/ ||
2215 $value !~ /(?:$Ident|-?$Constant)\s*
2217 (?:$Ident|-?$Constant)/x &&
2218 $value =~ s/\([^\(\)]*\)/1/) {
2220 #print "value<$value>\n";
2221 if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
2222 ERROR("return is not a function, parentheses are not required\n" . $herecurr);
2224 } elsif ($spacing !~ /\s+/) {
2225 ERROR("space required before the open parenthesis '('\n" . $herecurr);
2228 # Return of what appears to be an errno should normally be -'ve
2229 if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
2231 if ($name ne 'EOF' && $name ne 'ERROR') {
2232 WARN("return of an errno should typically be -ve (return -$1)\n" . $herecurr);
2236 # Need a space before open parenthesis after if, while etc
2237 if ($line=~/\b(if|while|for|switch)\(/) {
2238 ERROR("space required before the open parenthesis '('\n" . $herecurr);
2241 # Check for illegal assignment in if conditional -- and check for trailing
2242 # statements after the conditional.
2243 if ($line =~ /do\s*(?!{)/) {
2244 my ($stat_next) = ctx_statement_block($line_nr_next,
2245 $remain_next, $off_next);
2246 $stat_next =~ s/\n./\n /g;
2247 ##print "stat<$stat> stat_next<$stat_next>\n";
2249 if ($stat_next =~ /^\s*while\b/) {
2250 # If the statement carries leading newlines,
2251 # then count those as offsets.
2253 ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
2255 statement_rawlines($whitespace) - 1;
2257 $suppress_whiletrailers{$line_nr_next +
2261 if (!defined $suppress_whiletrailers{$linenr} &&
2262 $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
2263 my ($s, $c) = ($stat, $cond);
2265 if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) {
2266 ERROR("do not use assignment in if condition\n" . $herecurr);
2269 # Find out what is on the end of the line after the
2271 substr($s, 0, length($c), '');
2273 $s =~ s/$;//g; # Remove any comments
2274 if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
2275 $c !~ /}\s*while\s*/)
2277 # Find out how long the conditional actually is.
2278 my @newlines = ($c =~ /\n/gs);
2279 my $cond_lines = 1 + $#newlines;
2282 $stat_real = raw_line($linenr, $cond_lines)
2283 . "\n" if ($cond_lines);
2284 if (defined($stat_real) && $cond_lines > 1) {
2285 $stat_real = "[...]\n$stat_real";
2288 ERROR("trailing statements should be on next line\n" . $herecurr . $stat_real);
2292 # Check for bitwise tests written as boolean
2304 WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
2307 # if and else should not have general statements after it
2308 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
2310 $s =~ s/$;//g; # Remove any comments
2311 if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
2312 ERROR("trailing statements should be on next line\n" . $herecurr);
2315 # if should not continue a brace
2316 if ($line =~ /}\s*if\b/) {
2317 ERROR("trailing statements should be on next line\n" .
2320 # case and default should not have general statements after them
2321 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
2323 (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
2327 ERROR("trailing statements should be on next line\n" . $herecurr);
2330 # Check for }<nl>else {, these must be at the same
2331 # indent level to be relevant to each other.
2332 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
2333 $previndent == $indent) {
2334 ERROR("else should follow close brace '}'\n" . $hereprev);
2337 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
2338 $previndent == $indent) {
2339 my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
2341 # Find out what is on the end of the line after the
2343 substr($s, 0, length($c), '');
2346 if ($s =~ /^\s*;/) {
2347 ERROR("while should follow close brace '}'\n" . $hereprev);
2351 #studly caps, commented out until figure out how to distinguish between use of existing and adding new
2352 # if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
2353 # print "No studly caps, use _\n";
2354 # print "$herecurr";
2358 #no spaces allowed after \ in define
2359 if ($line=~/\#\s*define.*\\\s$/) {
2360 WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr);
2363 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
2364 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
2366 my $checkfile = "include/linux/$file";
2367 if (-f "$root/$checkfile" &&
2368 $realfile ne $checkfile &&
2369 $1 !~ /$allowed_asm_includes/)
2371 if ($realfile =~ m{^arch/}) {
2372 CHK("Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2374 WARN("Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2379 # multi-statement macros should be enclosed in a do while loop, grab the
2380 # first statement and ensure its the whole macro if its not enclosed
2381 # in a known good container
2382 if ($realfile !~ m@/vmlinux.lds.h$@ &&
2383 $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
2386 my ($off, $dstat, $dcond, $rest);
2389 my $args = defined($1);
2391 # Find the end of the macro and limit our statement
2393 while ($cnt > 0 && defined $lines[$ln - 1] &&
2394 $lines[$ln - 1] =~ /^(?:-|..*\\$)/)
2396 $ctx .= $rawlines[$ln - 1] . "\n";
2397 $cnt-- if ($lines[$ln - 1] !~ /^-/);
2400 $ctx .= $rawlines[$ln - 1];
2402 ($dstat, $dcond, $ln, $cnt, $off) =
2403 ctx_statement_block($linenr, $ln - $linenr + 1, 0);
2404 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
2405 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
2407 # Extract the remainder of the define (if any) and
2408 # rip off surrounding spaces, and trailing \'s.
2410 while ($off != 0 || ($cnt > 0 && $rest =~ /\\\s*$/)) {
2411 #print "ADDING cnt<$cnt> $off <" . substr($lines[$ln - 1], $off) . "> rest<$rest>\n";
2412 if ($off != 0 || $lines[$ln - 1] !~ /^-/) {
2413 $rest .= substr($lines[$ln - 1], $off) . "\n";
2419 $rest =~ s/\\\n.//g;
2423 # Clean up the original statement.
2425 substr($dstat, 0, length($dcond), '');
2427 $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//;
2430 $dstat =~ s/\\\n.//g;
2431 $dstat =~ s/^\s*//s;
2432 $dstat =~ s/\s*$//s;
2434 # Flatten any parentheses and braces
2435 while ($dstat =~ s/\([^\(\)]*\)/1/ ||
2436 $dstat =~ s/\{[^\{\}]*\}/1/ ||
2437 $dstat =~ s/\[[^\{\}]*\]/1/)
2441 my $exceptions = qr{
2453 #print "REST<$rest> dstat<$dstat>\n";
2455 if ($rest !~ /while\s*\(/ &&
2456 $dstat !~ /$exceptions/)
2458 ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n");
2461 } elsif ($ctx !~ /;/) {
2463 $dstat !~ /^(?:$Ident|-?$Constant)$/ &&
2464 $dstat !~ /$exceptions/ &&
2465 $dstat !~ /^\.$Ident\s*=/ &&
2466 $dstat =~ /$Operators/)
2468 ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n");
2473 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
2474 # all assignments may have only one of the following with an assignment:
2477 # VMLINUX_SYMBOL(...)
2478 if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {
2479 WARN("vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);
2482 # check for redundant bracing round if etc
2483 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
2484 my ($level, $endln, @chunks) =
2485 ctx_statement_full($linenr, $realcnt, 1);
2486 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
2487 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
2488 if ($#chunks > 0 && $level == 0) {
2491 my $herectx = $here . "\n";
2492 my $ln = $linenr - 1;
2493 for my $chunk (@chunks) {
2494 my ($cond, $block) = @{$chunk};
2496 # If the condition carries leading newlines, then count those as offsets.
2497 my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
2498 my $offset = statement_rawlines($whitespace) - 1;
2500 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
2502 # We have looked at and allowed this specific line.
2503 $suppress_ifbraces{$ln + $offset} = 1;
2505 $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
2506 $ln += statement_rawlines($block) - 1;
2508 substr($block, 0, length($cond), '');
2510 $seen++ if ($block =~ /^\s*{/);
2512 #print "cond<$cond> block<$block> allowed<$allowed>\n";
2513 if (statement_lines($cond) > 1) {
2514 #print "APW: ALLOWED: cond<$cond>\n";
2517 if ($block =~/\b(?:if|for|while)\b/) {
2518 #print "APW: ALLOWED: block<$block>\n";
2521 if (statement_block_size($block) > 1) {
2522 #print "APW: ALLOWED: lines block<$block>\n";
2526 if ($seen && !$allowed) {
2527 WARN("braces {} are not necessary for any arm of this statement\n" . $herectx);
2531 if (!defined $suppress_ifbraces{$linenr - 1} &&
2532 $line =~ /\b(if|while|for|else)\b/) {
2535 # Check the pre-context.
2536 if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
2537 #print "APW: ALLOWED: pre<$1>\n";
2541 my ($level, $endln, @chunks) =
2542 ctx_statement_full($linenr, $realcnt, $-[0]);
2544 # Check the condition.
2545 my ($cond, $block) = @{$chunks[0]};
2546 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
2547 if (defined $cond) {
2548 substr($block, 0, length($cond), '');
2550 if (statement_lines($cond) > 1) {
2551 #print "APW: ALLOWED: cond<$cond>\n";
2554 if ($block =~/\b(?:if|for|while)\b/) {
2555 #print "APW: ALLOWED: block<$block>\n";
2558 if (statement_block_size($block) > 1) {
2559 #print "APW: ALLOWED: lines block<$block>\n";
2562 # Check the post-context.
2563 if (defined $chunks[1]) {
2564 my ($cond, $block) = @{$chunks[1]};
2565 if (defined $cond) {
2566 substr($block, 0, length($cond), '');
2568 if ($block =~ /^\s*\{/) {
2569 #print "APW: ALLOWED: chunk-1 block<$block>\n";
2573 if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
2574 my $herectx = $here . "\n";;
2575 my $cnt = statement_rawlines($block);
2577 for (my $n = 0; $n < $cnt; $n++) {
2578 $herectx .= raw_line($linenr, $n) . "\n";;
2581 WARN("braces {} are not necessary for single statement blocks\n" . $herectx);
2585 # don't include deprecated include files (uses RAW line)
2586 for my $inc (@dep_includes) {
2587 if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
2588 ERROR("Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
2592 # don't use deprecated functions
2593 for my $func (@dep_functions) {
2594 if ($line =~ /\b$func\b/) {
2595 ERROR("Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
2599 # no volatiles please
2600 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
2601 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
2602 WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
2605 # SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated
2606 if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) {
2607 ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr);
2611 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
2612 CHK("if this code is redundant consider removing it\n" .
2616 # check for needless kfree() checks
2617 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
2619 if ($line =~ /\bkfree\(\Q$expr\E\);/) {
2620 WARN("kfree(NULL) is safe this check is probably not required\n" . $hereprev);
2623 # check for needless usb_free_urb() checks
2624 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
2626 if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
2627 WARN("usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
2631 # prefer usleep_range over udelay
2632 if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) {
2633 # ignore udelay's < 10, however
2634 if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
2635 CHK("usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
2639 # warn about unexpectedly long msleep's
2640 if ($line =~ /\bmsleep\s*\((\d+)\);/) {
2642 WARN("msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $line);
2646 # warn about #ifdefs in C files
2647 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
2648 # print "#ifdef in C files should be avoided\n";
2649 # print "$herecurr";
2653 # warn about spacing in #ifdefs
2654 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
2655 ERROR("exactly one space required after that #$1\n" . $herecurr);
2658 # check for spinlock_t definitions without a comment.
2659 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
2660 $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
2662 if (!ctx_has_comment($first_line, $linenr)) {
2663 CHK("$1 definition without comment\n" . $herecurr);
2666 # check for memory barriers without a comment.
2667 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
2668 if (!ctx_has_comment($first_line, $linenr)) {
2669 CHK("memory barrier without comment\n" . $herecurr);
2672 # check of hardware specific defines
2673 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
2674 CHK("architecture specific defines should be avoided\n" . $herecurr);
2677 # Check that the storage class is at the beginning of a declaration
2678 if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
2679 WARN("storage class should be at the beginning of the declaration\n" . $herecurr)
2682 # check the location of the inline attribute, that it is between
2683 # storage class and type.
2684 if ($line =~ /\b$Type\s+$Inline\b/ ||
2685 $line =~ /\b$Inline\s+$Storage\b/) {
2686 ERROR("inline keyword should sit between storage class and type\n" . $herecurr);
2689 # Check for __inline__ and __inline, prefer inline
2690 if ($line =~ /\b(__inline__|__inline)\b/) {
2691 WARN("plain inline is preferred over $1\n" . $herecurr);
2694 # check for sizeof(&)
2695 if ($line =~ /\bsizeof\s*\(\s*\&/) {
2696 WARN("sizeof(& should be avoided\n" . $herecurr);
2699 # check for new externs in .c files.
2700 if ($realfile =~ /\.c$/ && defined $stat &&
2701 $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
2703 my $function_name = $1;
2704 my $paren_space = $2;
2707 if (defined $cond) {
2708 substr($s, 0, length($cond), '');
2710 if ($s =~ /^\s*;/ &&
2711 $function_name ne 'uninitialized_var')
2713 WARN("externs should be avoided in .c files\n" . $herecurr);
2716 if ($paren_space =~ /\n/) {
2717 WARN("arguments for function declarations should follow identifier\n" . $herecurr);
2720 } elsif ($realfile =~ /\.c$/ && defined $stat &&
2721 $stat =~ /^.\s*extern\s+/)
2723 WARN("externs should be avoided in .c files\n" . $herecurr);
2726 # checks for new __setup's
2727 if ($rawline =~ /\b__setup\("([^"]*)"/) {
2730 if (!grep(/$name/, @setup_docs)) {
2731 CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
2735 # check for pointless casting of kmalloc return
2736 if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) {
2737 WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
2740 # check for gcc specific __FUNCTION__
2741 if ($line =~ /__FUNCTION__/) {
2742 WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
2745 # check for semaphores used as mutexes
2746 if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) {
2747 WARN("mutexes are preferred for single holder semaphores\n" . $herecurr);
2749 # check for semaphores used as mutexes
2750 if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) {
2751 WARN("consider using a completion\n" . $herecurr);
2754 # recommend strict_strto* over simple_strto*
2755 if ($line =~ /\bsimple_(strto.*?)\s*\(/) {
2756 WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr);
2758 # check for __initcall(), use device_initcall() explicitly please
2759 if ($line =~ /^.\s*__initcall\s*\(/) {
2760 WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
2762 # check for various ops structs, ensure they are const.
2763 my $struct_ops = qr{acpi_dock_ops|
2764 address_space_operations|
2766 block_device_operations|
2771 file_lock_operations|
2781 lock_manager_operations|
2787 pipe_buf_operations|
2788 platform_hibernation_ops|
2789 platform_suspend_ops|
2794 soc_pcmcia_socket_ops|
2800 if ($line !~ /\bconst\b/ &&
2801 $line =~ /\bstruct\s+($struct_ops)\b/) {
2802 WARN("struct $1 should normally be const\n" .
2806 # use of NR_CPUS is usually wrong
2807 # ignore definitions of NR_CPUS and usage to define arrays as likely right
2808 if ($line =~ /\bNR_CPUS\b/ &&
2809 $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
2810 $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
2811 $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
2812 $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
2813 $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
2815 WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
2818 # check for %L{u,d,i} in strings
2820 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
2821 $string = substr($rawline, $-[1], $+[1] - $-[1]);
2822 $string =~ s/%%/__/g;
2823 if ($string =~ /(?<!%)%L[udi]/) {
2824 WARN("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
2829 # whine mightly about in_atomic
2830 if ($line =~ /\bin_atomic\s*\(/) {
2831 if ($realfile =~ m@^drivers/@) {
2832 ERROR("do not use in_atomic in drivers\n" . $herecurr);
2833 } elsif ($realfile !~ m@^kernel/@) {
2834 WARN("use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
2838 # check for lockdep_set_novalidate_class
2839 if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
2840 $line =~ /__lockdep_no_validate__\s*\)/ ) {
2841 if ($realfile !~ m@^kernel/lockdep@ &&
2842 $realfile !~ m@^include/linux/lockdep@ &&
2843 $realfile !~ m@^drivers/base/core@) {
2844 ERROR("lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
2849 # If we have no input at all, then there is nothing to report on
2850 # so just keep quiet.
2851 if ($#rawlines == -1) {
2855 # In mailback mode only produce a report in the negative, for
2856 # things that appear to be patches.
2857 if ($mailback && ($clean == 1 || !$is_patch)) {
2861 # This is not a patch, and we are are in 'no-patch' mode so
2863 if (!$chk_patch && !$is_patch) {
2868 ERROR("Does not appear to be a unified-diff format patch\n");
2870 if ($is_patch && $chk_signoff && $signoff == 0) {
2871 ERROR("Missing Signed-off-by: line(s)\n");
2874 print report_dump();
2875 if ($summary && !($clean == 1 && $quiet == 1)) {
2876 print "$filename " if ($summary_file);
2877 print "total: $cnt_error errors, $cnt_warn warnings, " .
2878 (($check)? "$cnt_chk checks, " : "") .
2879 "$cnt_lines lines checked\n";
2880 print "\n" if ($quiet == 0);
2884 # If there were whitespace errors which cleanpatch can fix
2885 # then suggest that.
2886 if ($rpt_cleaners) {
2887 print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
2888 print " scripts/cleanfile\n\n";
2892 if ($clean == 1 && $quiet == 0) {
2893 print "$vname has no obvious style problems and is ready for submission.\n"
2895 if ($clean == 0 && $quiet == 0) {
2896 print "$vname has style problems, please review. If any of these errors\n";
2897 print "are false positives report them to the maintainer, see\n";
2898 print "CHECKPATCH in MAINTAINERS.\n";