nodestack: revert may_read_from to a normal member variable, not pointer

[model-checker.git] / action.h

diff --git a/action.h b/action.h
index bf5e6c35476693808b301ec6b4f5b9879e39214b..e342e63271d223417e55393d4d8bc941b1d2a0ba 100644 (file)
--- a/action.h
+++ b/action.h
@@ -25,38 +25,43 @@ typedef enum action_type {
 /* Forward declaration */
 class Node;
 class ClockVector;
+
 /**
  * The ModelAction class encapsulates an atomic action.
  */
-
 class ModelAction {
 public:
-       ModelAction(action_type_t type, memory_order order, void *loc, int value);
+       ModelAction(action_type_t type, memory_order order, void *loc, int value = VALUE_NONE);
        ~ModelAction();
-       void print(void);
+       void print(void) const;
 
-       thread_id_t get_tid() { return tid; }
-       action_type get_type() { return type; }
-       memory_order get_mo() { return order; }
-       void * get_location() { return location; }
+       thread_id_t get_tid() const { return tid; }
+       action_type get_type() const { return type; }
+       memory_order get_mo() const { return order; }
+       void * get_location() const { return location; }
        int get_seq_number() const { return seq_number; }
+       int get_value() const { return value; }
 
-       Node * get_node() { return node; }
+       Node * get_node() const { return node; }
        void set_node(Node *n) { node = n; }
-
-       bool is_read();
-       bool is_write();
-       bool is_rmw();
-       bool is_acquire();
-       bool is_release();
-       bool is_seqcst();
-       bool same_var(ModelAction *act);
-       bool same_thread(ModelAction *act);
-       bool is_synchronizing(ModelAction *act);
+       void set_value(int val) { value = val; }
+
+       bool is_read() const;
+       bool is_write() const;
+       bool is_rmw() const;
+       bool is_acquire() const;
+       bool is_release() const;
+       bool is_seqcst() const;
+       bool same_var(const ModelAction *act) const;
+       bool same_thread(const ModelAction *act) const;
+       bool is_synchronizing(const ModelAction *act) const;
 
        void create_cv(ModelAction *parent = NULL);
+       ClockVector * get_cv() const { return cv; }
        void read_from(ModelAction *act);
 
+       bool happens_before(ModelAction *act);
+
        inline bool operator <(const ModelAction& act) const {
                return get_seq_number() < act.get_seq_number();
        }
@@ -79,16 +84,18 @@ private:
        /** The thread id that performed this action. */
        thread_id_t tid;
        
-       /** The value written.  This should probably be something longer. */
+       /** The value read or written (if RMW, then the value written). This
+        * should probably be something longer. */
        int value;
 
+       /** A back reference to a Node in NodeStack, if this ModelAction is
+        * saved on the NodeStack. */
        Node *node;
        
        int seq_number;
 
-       /** The clock vector stored with this action if this action is a
-        *  store release */
-
+       /** The clock vector stored with this action; only needed if this
+        * action is a store release? */
        ClockVector *cv;
 };