powerpc/perf/hv-24x7: Break up single_24x7_request
[firefly-linux-kernel-4.4.55.git] / arch / powerpc / perf / hv-24x7.c
index c185dcfe6271e3f30cf4d95d6fb48eeb1e8af390..46be032f60ad1ce138f81010e65af13300695c8c 100644 (file)
@@ -161,6 +161,7 @@ static char *event_desc(struct hv_24x7_event_data *ev, int *len)
 {
        unsigned nl = be16_to_cpu(ev->event_name_len);
        __be16 *desc_len = (__be16 *)(ev->remainder + nl - 2);
+
        *len = be16_to_cpu(*desc_len) - 2;
        return (char *)ev->remainder + nl;
 }
@@ -171,6 +172,7 @@ static char *event_long_desc(struct hv_24x7_event_data *ev, int *len)
        __be16 *desc_len_ = (__be16 *)(ev->remainder + nl - 2);
        unsigned desc_len = be16_to_cpu(*desc_len_);
        __be16 *long_desc_len = (__be16 *)(ev->remainder + nl + desc_len - 2);
+
        *len = be16_to_cpu(*long_desc_len) - 2;
        return (char *)ev->remainder + nl + desc_len;
 }
@@ -248,14 +250,12 @@ static unsigned long h_get_24x7_catalog_page_(unsigned long phys_4096,
                                              unsigned long index)
 {
        pr_devel("h_get_24x7_catalog_page(0x%lx, %lu, %lu)",
-                       phys_4096,
-                       version,
-                       index);
+                       phys_4096, version, index);
+
        WARN_ON(!IS_ALIGNED(phys_4096, 4096));
+
        return plpar_hcall_norets(H_GET_24X7_CATALOG_PAGE,
-                       phys_4096,
-                       version,
-                       index);
+                       phys_4096, version, index);
 }
 
 static unsigned long h_get_24x7_catalog_page(char page[],
@@ -309,6 +309,7 @@ static ssize_t device_show_string(struct device *dev,
        struct dev_ext_attribute *d;
 
        d = container_of(attr, struct dev_ext_attribute, attr);
+
        return sprintf(buf, "%s\n", (char *)d->var);
 }
 
@@ -323,6 +324,7 @@ static struct attribute *device_str_attr_create_(char *name, char *str)
        attr->attr.attr.name = name;
        attr->attr.attr.mode = 0444;
        attr->attr.show = device_show_string;
+
        return &attr->attr.attr;
 }
 
@@ -396,7 +398,6 @@ static struct attribute *event_to_attr(unsigned ix,
                a_ev_name = kasprintf(GFP_KERNEL, "%.*s%s__%d",
                                (int)event_name_len, ev_name, ev_suffix, nonce);
 
-
        if (!a_ev_name)
                goto out_val;
 
@@ -881,6 +882,7 @@ static ssize_t catalog_read(struct file *filp, struct kobject *kobj,
        uint64_t catalog_version_num = 0;
        void *page = kmem_cache_alloc(hv_page_cache, GFP_USER);
        struct hv_24x7_catalog_page_0 *page_0 = page;
+
        if (!page)
                return -ENOMEM;
 
@@ -985,37 +987,43 @@ static const struct attribute_group *attr_groups[] = {
        NULL,
 };
 
-static unsigned long single_24x7_request(u8 domain, u32 offset, u16 ix,
-                                        u16 lpar, u64 *count)
+static void log_24x7_hcall(struct hv_24x7_request_buffer *request_buffer,
+                       struct hv_24x7_data_result_buffer *result_buffer,
+                       unsigned long ret)
 {
-       unsigned long ret;
-
-       struct hv_24x7_request_buffer *request_buffer;
-       struct hv_24x7_data_result_buffer *result_buffer;
-       struct hv_24x7_result *resb;
        struct hv_24x7_request *req;
 
-       BUILD_BUG_ON(sizeof(*request_buffer) > 4096);
-       BUILD_BUG_ON(sizeof(*result_buffer) > 4096);
+       req = &request_buffer->requests[0];
+       pr_notice_ratelimited("hcall failed: [%d %#x %#x %d] => "
+                       "ret 0x%lx (%ld) detail=0x%x failing ix=%x\n",
+                       req->performance_domain, req->data_offset,
+                       req->starting_ix, req->starting_lpar_ix, ret, ret,
+                       result_buffer->detailed_rc,
+                       result_buffer->failing_request_ix);
+}
 
-       request_buffer = (void *)get_cpu_var(hv_24x7_reqb);
-       result_buffer = (void *)get_cpu_var(hv_24x7_resb);
+/*
+ * Start the process for a new H_GET_24x7_DATA hcall.
+ */
+static void init_24x7_request(struct hv_24x7_request_buffer *request_buffer,
+                       struct hv_24x7_data_result_buffer *result_buffer)
+{
 
        memset(request_buffer, 0, 4096);
        memset(result_buffer, 0, 4096);
 
        request_buffer->interface_version = HV_24X7_IF_VERSION_CURRENT;
-       request_buffer->num_requests = 1;
-
-       req = &request_buffer->requests[0];
+       /* memset above set request_buffer->num_requests to 0 */
+}
 
-       req->performance_domain = domain;
-       req->data_size = cpu_to_be16(8);
-       req->data_offset = cpu_to_be32(offset);
-       req->starting_lpar_ix = cpu_to_be16(lpar),
-       req->max_num_lpars = cpu_to_be16(1);
-       req->starting_ix = cpu_to_be16(ix);
-       req->max_ix = cpu_to_be16(1);
+/*
+ * Commit (i.e perform) the H_GET_24x7_DATA hcall using the data collected
+ * by 'init_24x7_request()' and 'add_event_to_24x7_request()'.
+ */
+static int make_24x7_request(struct hv_24x7_request_buffer *request_buffer,
+                       struct hv_24x7_data_result_buffer *result_buffer)
+{
+       unsigned long ret;
 
        /*
         * NOTE: Due to variable number of array elements in request and
@@ -1026,39 +1034,85 @@ static unsigned long single_24x7_request(u8 domain, u32 offset, u16 ix,
                        virt_to_phys(request_buffer), H24x7_DATA_BUFFER_SIZE,
                        virt_to_phys(result_buffer),  H24x7_DATA_BUFFER_SIZE);
 
-       if (ret) {
-               pr_err_ratelimited("hcall failed: %d %#x %#x %d => "
-                               "0x%lx (%ld) detail=0x%x failing ix=%x\n",
-                               domain, offset, ix, lpar, ret, ret,
-                               result_buffer->detailed_rc,
-                               result_buffer->failing_request_ix);
-               goto out;
-       }
-
-       resb = &result_buffer->results[0];
+       if (ret)
+               log_24x7_hcall(request_buffer, result_buffer, ret);
 
-       *count = be64_to_cpu(resb->elements[0].element_data[0]);
-out:
        return ret;
 }
 
-static unsigned long event_24x7_request(struct perf_event *event, u64 *res)
+/*
+ * Add the given @event to the next slot in the 24x7 request_buffer.
+ *
+ * Note that H_GET_24X7_DATA hcall allows reading several counters'
+ * values in a single HCALL. We expect the caller to add events to the
+ * request buffer one by one, make the HCALL and process the results.
+ */
+static int add_event_to_24x7_request(struct perf_event *event,
+                               struct hv_24x7_request_buffer *request_buffer)
 {
        u16 idx;
-       unsigned domain = event_get_domain(event);
+       int i;
+       struct hv_24x7_request *req;
 
-       if (is_physical_domain(domain))
+       if (request_buffer->num_requests > 254) {
+               pr_devel("Too many requests for 24x7 HCALL %d\n",
+                               request_buffer->num_requests);
+               return -EINVAL;
+       }
+
+       if (is_physical_domain(event_get_domain(event)))
                idx = event_get_core(event);
        else
                idx = event_get_vcpu(event);
 
-       return single_24x7_request(event_get_domain(event),
-                               event_get_offset(event),
-                               idx,
-                               event_get_lpar(event),
-                               res);
+       i = request_buffer->num_requests++;
+       req = &request_buffer->requests[i];
+
+       req->performance_domain = event_get_domain(event);
+       req->data_size = cpu_to_be16(8);
+       req->data_offset = cpu_to_be32(event_get_offset(event));
+       req->starting_lpar_ix = cpu_to_be16(event_get_lpar(event)),
+       req->max_num_lpars = cpu_to_be16(1);
+       req->starting_ix = cpu_to_be16(idx);
+       req->max_ix = cpu_to_be16(1);
+
+       return 0;
+}
+
+static unsigned long single_24x7_request(struct perf_event *event, u64 *count)
+{
+       unsigned long ret;
+       struct hv_24x7_request_buffer *request_buffer;
+       struct hv_24x7_data_result_buffer *result_buffer;
+       struct hv_24x7_result *resb;
+
+       BUILD_BUG_ON(sizeof(*request_buffer) > 4096);
+       BUILD_BUG_ON(sizeof(*result_buffer) > 4096);
+
+       request_buffer = (void *)get_cpu_var(hv_24x7_reqb);
+       result_buffer = (void *)get_cpu_var(hv_24x7_resb);
+
+       init_24x7_request(request_buffer, result_buffer);
+
+       ret = add_event_to_24x7_request(event, request_buffer);
+       if (ret)
+               return ret;
+
+       ret = make_24x7_request(request_buffer, result_buffer);
+       if (ret) {
+               log_24x7_hcall(request_buffer, result_buffer, ret);
+               goto out;
+       }
+
+       /* process result from hcall */
+       resb = &result_buffer->results[0];
+       *count = be64_to_cpu(resb->elements[0].element_data[0]);
+
+out:
+       return ret;
 }
 
+
 static int h_24x7_event_init(struct perf_event *event)
 {
        struct hv_perf_caps caps;
@@ -1126,7 +1180,7 @@ static int h_24x7_event_init(struct perf_event *event)
        }
 
        /* see if the event complains */
-       if (event_24x7_request(event, &ct)) {
+       if (single_24x7_request(event, &ct)) {
                pr_devel("test hcall failed\n");
                return -EIO;
        }
@@ -1138,7 +1192,7 @@ static u64 h_24x7_get_value(struct perf_event *event)
 {
        unsigned long ret;
        u64 ct;
-       ret = event_24x7_request(event, &ct);
+       ret = single_24x7_request(event, &ct);
        if (ret)
                /* We checked this in event init, shouldn't fail here... */
                return 0;
@@ -1146,15 +1200,22 @@ static u64 h_24x7_get_value(struct perf_event *event)
        return ct;
 }
 
-static void h_24x7_event_update(struct perf_event *event)
+static void update_event_count(struct perf_event *event, u64 now)
 {
        s64 prev;
-       u64 now;
-       now = h_24x7_get_value(event);
+
        prev = local64_xchg(&event->hw.prev_count, now);
        local64_add(now - prev, &event->count);
 }
 
+static void h_24x7_event_read(struct perf_event *event)
+{
+       u64 now;
+
+       now = h_24x7_get_value(event);
+       update_event_count(event, now);
+}
+
 static void h_24x7_event_start(struct perf_event *event, int flags)
 {
        if (flags & PERF_EF_RELOAD)
@@ -1163,7 +1224,7 @@ static void h_24x7_event_start(struct perf_event *event, int flags)
 
 static void h_24x7_event_stop(struct perf_event *event, int flags)
 {
-       h_24x7_event_update(event);
+       h_24x7_event_read(event);
 }
 
 static int h_24x7_event_add(struct perf_event *event, int flags)
@@ -1184,7 +1245,7 @@ static struct pmu h_24x7_pmu = {
        .del         = h_24x7_event_stop,
        .start       = h_24x7_event_start,
        .stop        = h_24x7_event_stop,
-       .read        = h_24x7_event_update,
+       .read        = h_24x7_event_read,
 };
 
 static int hv_24x7_init(void)