#include "cyclegraph.h"
#include "action.h"
+#include "common.h"
/** Initializes a CycleGraph object. */
CycleGraph::CycleGraph() :
hasCycles(false),
- oldCycles(false)
+ oldCycles(false),
+ hasRMWViolation(false),
+ oldRMWViolation(false)
{
}
* @param from The edge comes from this ModelAction
*/
void CycleGraph::addEdge(const ModelAction *from, const ModelAction *to) {
+ ASSERT(from);
+ ASSERT(to);
+
CycleNode *fromnode=getNode(from);
CycleNode *tonode=getNode(to);
* action can read from a given write.
*/
void CycleGraph::addRMWEdge(const ModelAction *from, const ModelAction *rmw) {
+ ASSERT(from);
+ ASSERT(rmw);
+
CycleNode *fromnode=getNode(from);
CycleNode *rmwnode=getNode(rmw);
/* Two RMW actions cannot read from the same write. */
if (fromnode->setRMW(rmwnode)) {
- hasCycles=true;
+ hasRMWViolation=true;
} else {
rmwrollbackvector.push_back(fromnode);
}
/* Transfer all outgoing edges from the from node to the rmw node */
- /* This process cannot add a cycle because rmw should not have any
- incoming edges yet.*/
+ /* This process should not add a cycle because either:
+ * (1) The rmw should not have any incoming edges yet if it is the
+ * new node or
+ * (2) the fromnode is the new node and therefore it should not
+ * have any outgoing edges.
+ */
std::vector<CycleNode *> * edges=fromnode->getEdges();
for(unsigned int i=0;i<edges->size();i++) {
CycleNode * tonode=(*edges)[i];
rmwnode->addEdge(tonode);
}
rollbackvector.push_back(fromnode);
+
+ if (!hasCycles) {
+ // With promises we could be setting up a cycle here if we aren't
+ // careful...avoid it..
+ hasCycles=checkReachable(rmwnode, fromnode);
+ }
fromnode->addEdge(rmwnode);
}
return false;
}
+void CycleGraph::startChanges() {
+ ASSERT(rollbackvector.size()==0);
+ ASSERT(rmwrollbackvector.size()==0);
+ ASSERT(oldCycles==hasCycles);
+ ASSERT(oldRMWViolation==hasRMWViolation);
+}
+
/** Commit changes to the cyclegraph. */
void CycleGraph::commitChanges() {
rollbackvector.resize(0);
rmwrollbackvector.resize(0);
oldCycles=hasCycles;
+ oldRMWViolation=hasRMWViolation;
}
/** Rollback changes to the previous commit. */
}
hasCycles = oldCycles;
+ hasRMWViolation = oldRMWViolation;
rollbackvector.resize(0);
rmwrollbackvector.resize(0);
}
return hasCycles;
}
+bool CycleGraph::checkForRMWViolation() {
+ return hasRMWViolation;
+}
+
/**
* Constructor for a CycleNode.
* @param modelaction The ModelAction for this node