some random notes.

[oota-llvm.git] / docs / DeveloperPolicy.html

diff --git a/docs/DeveloperPolicy.html b/docs/DeveloperPolicy.html
index 144c55ac0d8a3ca7b4e1981a461f45993355ff8e..689bcb0783b21150c5c6ce06cd1d26e54c18101d 100644 (file)
--- a/docs/DeveloperPolicy.html
+++ b/docs/DeveloperPolicy.html
@@ -116,6 +116,15 @@
   <em>attachment</em> to the message, not embedded into the text of the
   message.  This ensures that your mailer will not mangle the patch when it 
   sends it (e.g. by making whitespace changes or by wrapping lines).</p>
+  
+  <p><em>For Thunderbird users:</em> Before submitting a patch, please open 
+  <em>Preferences &#8594; Advanced &#8594; General &#8594; Config Editor</em>,
+  find the key <tt>mail.content_disposition_type</tt>, and set its value to
+  <tt>1</tt>. Without this setting, Thunderbird sends your attachment using
+  <tt>Content-Disposition: inline</tt> rather than <tt>Content-Disposition:
+  attachment</tt>. Apple Mail gamely displays such a file inline, making it
+  difficult to work with for reviewers using that program.</p>
+</p>
 </div>
 
 <!-- _______________________________________________________________________ -->
@@ -236,7 +245,8 @@
     <li>The code must not cause regressions on a reasonable subset of llvm-test,
         where "reasonable" depends on the contributor's judgement and the scope
         of the change (more invasive changes require more testing). A reasonable
-        subset is "<tt>llvm-test/MultiSource/Benchmarks</tt>".</li>
+        subset might be something like
+        "<tt>llvm-test/MultiSource/Benchmarks</tt>".</li>
   </ol>
   <p>Additionally, the committer is responsible for addressing any problems
   found in the future that the change is responsible for.  For example:</p>
@@ -418,11 +428,12 @@ Changes</a></div>
   <p>We believe in correct attribution of contributions to 
   their contributors.  However, we do not want the source code to be littered
   with random attributions "this code written by J Random Guy" (this is noisy
-  and distracting.  In practice, the revision control system keeps a perfect
-  history of who change what, and the CREDITS.txt file describes higher-level
-  contributions.</p>
+  and distracting).  In practice, the revision control system keeps a perfect
+  history of who changed what, and the CREDITS.txt file describes higher-level
+  contributions.  If you commit a patch for someone else, please say "patch 
+  contributed by J Random Guy!" in the commit message.</p>
 
-  <p>Overall, please do not add contributor names to the source base.</p>
+  <p>Overall, please do not add contributor names to the source code.</p>
 </div>