[PATCH] EDAC: i82860 cleanup

[firefly-linux-kernel-4.4.55.git] / drivers / edac / i82860_edac.c

diff --git a/drivers/edac/i82860_edac.c b/drivers/edac/i82860_edac.c
index 52596e75f9c24f7de3ab8d4771a5a7b82344ecbc..e832778fc603311e715f1a538691100c7f09edd7 100644 (file)
--- a/drivers/edac/i82860_edac.c
+++ b/drivers/edac/i82860_edac.c
@@ -19,6 +19,14 @@
 #include "edac_mc.h"
 
 
+#define i82860_printk(level, fmt, arg...) \
+    edac_printk(level, "i82860", fmt, ##arg)
+
+
+#define i82860_mc_printk(mci, level, fmt, arg...) \
+    edac_mc_chipset_printk(mci, level, "i82860", fmt, ##arg)
+
+
 #ifndef PCI_DEVICE_ID_INTEL_82860_0
 #define PCI_DEVICE_ID_INTEL_82860_0    0x2531
 #endif                         /* PCI_DEVICE_ID_INTEL_82860_0 */
@@ -54,8 +62,6 @@ static const struct i82860_dev_info i82860_devs[] = {
 static struct pci_dev *mci_pdev = NULL;        /* init dev: in case that AGP code
                                           has already registered driver */
 
-static int i82860_registered = 1;
-
 static void i82860_get_error_info (struct mem_ctl_info *mci,
                struct i82860_error_info *info)
 {
@@ -117,7 +123,7 @@ static void i82860_check(struct mem_ctl_info *mci)
 {
        struct i82860_error_info info;
 
-       debugf1("MC%d: " __FILE__ ": %s()\n", mci->mc_idx, __func__);
+       debugf1("MC%d: %s()\n", mci->mc_idx, __func__);
        i82860_get_error_info(mci, &info);
        i82860_process_error_info(mci, &info, 1);
 }
@@ -143,7 +149,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx)
        if (!mci)
                return -ENOMEM;
 
-       debugf3("MC: " __FILE__ ": %s(): init mci\n", __func__);
+       debugf3("%s(): init mci\n", __func__);
 
        mci->pdev = pdev;
        mci->mtype_cap = MEM_FLAG_DDR;
@@ -154,7 +160,7 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx)
        mci->edac_cap = EDAC_FLAG_SECDED;
        /* adjust FLAGS */
 
-       mci->mod_name = BS_MOD_STR;
+       mci->mod_name = EDAC_MOD_STR;
        mci->mod_ver = "$Revision: 1.1.2.6 $";
        mci->ctl_name = i82860_devs[dev_idx].ctl_name;
        mci->edac_check = i82860_check;
@@ -179,8 +185,8 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx)
 
                cumul_size = (value & I82860_GBA_MASK) <<
                    (I82860_GBA_SHIFT - PAGE_SHIFT);
-               debugf3("MC: " __FILE__ ": %s(): (%d) cumul_size 0x%x\n",
-                       __func__, index, cumul_size);
+               debugf3("%s(): (%d) cumul_size 0x%x\n", __func__, index,
+                       cumul_size);
                if (cumul_size == last_cumul_size)
                        continue;       /* not populated */
 
@@ -198,13 +204,11 @@ static int i82860_probe1(struct pci_dev *pdev, int dev_idx)
        pci_write_bits16(mci->pdev, I82860_ERRSTS, 0x0003, 0x0003);
 
        if (edac_mc_add_mc(mci)) {
-               debugf3("MC: " __FILE__
-                       ": %s(): failed edac_mc_add_mc()\n",
-                       __func__);
+               debugf3("%s(): failed edac_mc_add_mc()\n", __func__);
                edac_mc_free(mci);
        } else {
                /* get this far and it's successful */
-               debugf3("MC: " __FILE__ ": %s(): success\n", __func__);
+               debugf3("%s(): success\n", __func__);
                rc = 0;
        }
        return rc;
@@ -216,9 +220,9 @@ static int __devinit i82860_init_one(struct pci_dev *pdev,
 {
        int rc;
 
-       debugf0("MC: " __FILE__ ": %s()\n", __func__);
+       debugf0("%s()\n", __func__);
 
-       printk(KERN_INFO "i82860 init one\n");
+       i82860_printk(KERN_INFO, "i82860 init one\n");
        if(pci_enable_device(pdev) < 0)
                return -EIO;
        rc = i82860_probe1(pdev, ent->driver_data);
@@ -231,7 +235,7 @@ static void __devexit i82860_remove_one(struct pci_dev *pdev)
 {
        struct mem_ctl_info *mci;
 
-       debugf0(__FILE__ ": %s()\n", __func__);
+       debugf0("%s()\n", __func__);
 
        mci = edac_mc_find_mci_by_pdev(pdev);
        if ((mci != NULL) && (edac_mc_del_mc(mci) == 0))
@@ -247,7 +251,7 @@ static const struct pci_device_id i82860_pci_tbl[] __devinitdata = {
 MODULE_DEVICE_TABLE(pci, i82860_pci_tbl);
 
 static struct pci_driver i82860_driver = {
-       .name = BS_MOD_STR,
+       .name = EDAC_MOD_STR,
        .probe = i82860_init_one,
        .remove = __devexit_p(i82860_remove_one),
        .id_table = i82860_pci_tbl,
@@ -257,37 +261,45 @@ static int __init i82860_init(void)
 {
        int pci_rc;
 
-       debugf3("MC: " __FILE__ ": %s()\n", __func__);
+       debugf3("%s()\n", __func__);
        if ((pci_rc = pci_register_driver(&i82860_driver)) < 0)
-               return pci_rc;
+               goto fail0;
 
        if (!mci_pdev) {
-               i82860_registered = 0;
                mci_pdev = pci_get_device(PCI_VENDOR_ID_INTEL,
                                          PCI_DEVICE_ID_INTEL_82860_0, NULL);
                if (mci_pdev == NULL) {
                        debugf0("860 pci_get_device fail\n");
-                       return -ENODEV;
+                       pci_rc = -ENODEV;
+                       goto fail1;
                }
                pci_rc = i82860_init_one(mci_pdev, i82860_pci_tbl);
                if (pci_rc < 0) {
                        debugf0("860 init fail\n");
-                       pci_dev_put(mci_pdev);
-                       return -ENODEV;
+                       pci_rc = -ENODEV;
+                       goto fail1;
                }
        }
        return 0;
+
+fail1:
+       pci_unregister_driver(&i82860_driver);
+
+fail0:
+       if (mci_pdev != NULL)
+               pci_dev_put(mci_pdev);
+
+       return pci_rc;
 }
 
 static void __exit i82860_exit(void)
 {
-       debugf3("MC: " __FILE__ ": %s()\n", __func__);
+       debugf3("%s()\n", __func__);
 
        pci_unregister_driver(&i82860_driver);
-       if (!i82860_registered) {
-               i82860_remove_one(mci_pdev);
+
+       if (mci_pdev != NULL)
                pci_dev_put(mci_pdev);
-       }
 }
 
 module_init(i82860_init);
@@ -295,5 +307,5 @@ module_exit(i82860_exit);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR
-    ("Red Hat Inc. (http://www.redhat.com.com) Ben Woodard <woodard@redhat.com>");
+    ("Red Hat Inc. (http://www.redhat.com) Ben Woodard <woodard@redhat.com>");
 MODULE_DESCRIPTION("ECC support for Intel 82860 memory hub controllers");