firewire: Implement functionality to stop isochronous DMA contexts.
[firefly-linux-kernel-4.4.55.git] / drivers / firewire / fw-ohci.c
index ac6c018de0dce7f1092ea316a5c6f3dd3f9c166f..c0ab868b9fe47e8ac7ef42693e16db02121c876c 100644 (file)
@@ -45,6 +45,7 @@
 #define descriptor_irq_error           (1 << 4)
 #define descriptor_irq_always          (3 << 4)
 #define descriptor_branch_always       (3 << 2)
+#define descriptor_wait                        (3 << 0)
 
 struct descriptor {
        __le16 req_count;
@@ -55,24 +56,69 @@ struct descriptor {
        __le16 transfer_status;
 } __attribute__((aligned(16)));
 
+struct db_descriptor {
+       __le16 first_size;
+       __le16 control;
+       __le16 second_req_count;
+       __le16 first_req_count;
+       __le32 branch_address;
+       __le16 second_res_count;
+       __le16 first_res_count;
+       __le32 reserved0;
+       __le32 first_buffer;
+       __le32 second_buffer;
+       __le32 reserved1;
+} __attribute__((aligned(16)));
+
+#define control_set(regs)      (regs)
+#define control_clear(regs)    ((regs) + 4)
+#define command_ptr(regs)      ((regs) + 12)
+#define context_match(regs)    ((regs) + 16)
+
+struct ar_buffer {
+       struct descriptor descriptor;
+       struct ar_buffer *next;
+       __le32 data[0];
+};
+
 struct ar_context {
        struct fw_ohci *ohci;
-       struct descriptor descriptor;
-       __le32 buffer[512];
-       dma_addr_t descriptor_bus;
+       struct ar_buffer *current_buffer;
+       struct ar_buffer *last_buffer;
+       void *pointer;
+       u32 regs;
+       struct tasklet_struct tasklet;
+};
+
+struct context;
+
+typedef int (*descriptor_callback_t)(struct context *ctx,
+                                    struct descriptor *d,
+                                    struct descriptor *last);
+struct context {
+       struct fw_ohci *ohci;
+       u32 regs;
+       struct descriptor *buffer;
        dma_addr_t buffer_bus;
+       size_t buffer_size;
+       struct descriptor *head_descriptor;
+       struct descriptor *tail_descriptor;
+       struct descriptor *tail_descriptor_last;
+       struct descriptor *prev_descriptor;
 
-       u32 command_ptr;
-       u32 control_set;
-       u32 control_clear;
+       descriptor_callback_t callback;
 
-       struct tasklet_struct tasklet;
+       struct tasklet_struct tasklet;
 };
+
 
 struct at_context {
        struct fw_ohci *ohci;
        dma_addr_t descriptor_bus;
        dma_addr_t buffer_bus;
+       struct fw_packet *current_packet;
 
        struct list_head list;
 
@@ -82,9 +128,7 @@ struct at_context {
                struct descriptor last;
        } d;
 
-       u32 command_ptr;
-       u32 control_set;
-       u32 control_clear;
+       u32 regs;
 
        struct tasklet_struct tasklet;
 };
@@ -98,18 +142,7 @@ struct at_context {
 
 struct iso_context {
        struct fw_iso_context base;
-       struct tasklet_struct tasklet;
-       u32 control_set;
-       u32 control_clear;
-       u32 command_ptr;
-       u32 context_match;
-
-       struct descriptor *buffer;
-       dma_addr_t buffer_bus;
-       struct descriptor *head_descriptor;
-       struct descriptor *tail_descriptor;
-       struct descriptor *tail_descriptor_last;
-       struct descriptor *prev_descriptor;
+       struct context context;
 };
 
 #define CONFIG_ROM_SIZE 1024
@@ -153,7 +186,12 @@ static inline struct fw_ohci *fw_ohci(struct fw_card *card)
        return container_of(card, struct fw_ohci, card);
 }
 
-#define CONTEXT_CYCLE_MATCH_ENABLE     0x80000000
+#define IT_CONTEXT_CYCLE_MATCH_ENABLE  0x80000000
+#define IR_CONTEXT_BUFFER_FILL         0x80000000
+#define IR_CONTEXT_ISOCH_HEADER                0x40000000
+#define IR_CONTEXT_CYCLE_MATCH_ENABLE  0x20000000
+#define IR_CONTEXT_MULTI_CHANNEL_MODE  0x10000000
+#define IR_CONTEXT_DUAL_BUFFER_MODE    0x08000000
 
 #define CONTEXT_RUN    0x8000
 #define CONTEXT_WAKE   0x1000
@@ -169,6 +207,7 @@ static inline struct fw_ohci *fw_ohci(struct fw_card *card)
 #define OHCI_LOOP_COUNT                        500
 #define OHCI1394_PCI_HCI_Control       0x40
 #define SELF_ID_BUF_SIZE               0x800
+#define OHCI_TCODE_PHY_PACKET          0x0e
 
 static char ohci_driver_name[] = KBUILD_MODNAME;
 
@@ -211,59 +250,97 @@ ohci_update_phy_reg(struct fw_card *card, int addr,
        return 0;
 }
 
-static void ar_context_run(struct ar_context *ctx)
+static int ar_context_add_page(struct ar_context *ctx)
 {
-       reg_write(ctx->ohci, ctx->command_ptr, ctx->descriptor_bus | 1);
-       reg_write(ctx->ohci, ctx->control_set, CONTEXT_RUN);
+       struct device *dev = ctx->ohci->card.device;
+       struct ar_buffer *ab;
+       dma_addr_t ab_bus;
+       size_t offset;
+
+       ab = (struct ar_buffer *) __get_free_page(GFP_ATOMIC);
+       if (ab == NULL)
+               return -ENOMEM;
+
+       ab_bus = dma_map_single(dev, ab, PAGE_SIZE, DMA_BIDIRECTIONAL);
+       if (dma_mapping_error(ab_bus)) {
+               free_page((unsigned long) ab);
+               return -ENOMEM;
+       }
+
+       memset(&ab->descriptor, 0, sizeof ab->descriptor);
+       ab->descriptor.control        = cpu_to_le16(descriptor_input_more |
+                                                   descriptor_status |
+                                                   descriptor_branch_always);
+       offset = offsetof(struct ar_buffer, data);
+       ab->descriptor.req_count      = cpu_to_le16(PAGE_SIZE - offset);
+       ab->descriptor.data_address   = cpu_to_le32(ab_bus + offset);
+       ab->descriptor.res_count      = cpu_to_le16(PAGE_SIZE - offset);
+       ab->descriptor.branch_address = 0;
+
+       dma_sync_single_for_device(dev, ab_bus, PAGE_SIZE, DMA_BIDIRECTIONAL);
+
+       ctx->last_buffer->descriptor.branch_address = ab_bus | 1;
+       ctx->last_buffer->next = ab;
+       ctx->last_buffer = ab;
+
+       reg_write(ctx->ohci, control_set(ctx->regs), CONTEXT_WAKE);
        flush_writes(ctx->ohci);
+
+       return 0;
 }
 
-static void ar_context_tasklet(unsigned long data)
+static __le32 *handle_ar_packet(struct ar_context *ctx, __le32 *buffer)
 {
-       struct ar_context *ctx = (struct ar_context *)data;
        struct fw_ohci *ohci = ctx->ohci;
        struct fw_packet p;
        u32 status, length, tcode;
 
-       /* FIXME: What to do about evt_* errors? */
-       length    = le16_to_cpu(ctx->descriptor.req_count) -
-               le16_to_cpu(ctx->descriptor.res_count) - 4;
-       status    = le32_to_cpu(ctx->buffer[length / 4]);
-
-       p.ack        = ((status >> 16) & 0x1f) - 16;
-       p.speed      = (status >> 21) & 0x7;
-       p.timestamp  = status & 0xffff;
-       p.generation = ohci->request_generation;
-
-       p.header[0] = le32_to_cpu(ctx->buffer[0]);
-       p.header[1] = le32_to_cpu(ctx->buffer[1]);
-       p.header[2] = le32_to_cpu(ctx->buffer[2]);
+       p.header[0] = le32_to_cpu(buffer[0]);
+       p.header[1] = le32_to_cpu(buffer[1]);
+       p.header[2] = le32_to_cpu(buffer[2]);
 
        tcode = (p.header[0] >> 4) & 0x0f;
        switch (tcode) {
        case TCODE_WRITE_QUADLET_REQUEST:
        case TCODE_READ_QUADLET_RESPONSE:
-               p.header[3] = ctx->buffer[3];
+               p.header[3] = (__force __u32) buffer[3];
                p.header_length = 16;
+               p.payload_length = 0;
                break;
 
-       case TCODE_WRITE_BLOCK_REQUEST:
        case TCODE_READ_BLOCK_REQUEST :
+               p.header[3] = le32_to_cpu(buffer[3]);
+               p.header_length = 16;
+               p.payload_length = 0;
+               break;
+
+       case TCODE_WRITE_BLOCK_REQUEST:
        case TCODE_READ_BLOCK_RESPONSE:
        case TCODE_LOCK_REQUEST:
        case TCODE_LOCK_RESPONSE:
-               p.header[3] = le32_to_cpu(ctx->buffer[3]);
+               p.header[3] = le32_to_cpu(buffer[3]);
                p.header_length = 16;
+               p.payload_length = p.header[3] >> 16;
                break;
 
        case TCODE_WRITE_RESPONSE:
        case TCODE_READ_QUADLET_REQUEST:
+       case OHCI_TCODE_PHY_PACKET:
                p.header_length = 12;
+               p.payload_length = 0;
                break;
        }
 
-       p.payload = (void *) ctx->buffer + p.header_length;
-       p.payload_length = length - p.header_length;
+       p.payload = (void *) buffer + p.header_length;
+
+       /* FIXME: What to do about evt_* errors? */
+       length = (p.header_length + p.payload_length + 3) / 4;
+       status = le32_to_cpu(buffer[length]);
+
+       p.ack        = ((status >> 16) & 0x1f) - 16;
+       p.speed      = (status >> 21) & 0x7;
+       p.timestamp  = status & 0xffff;
+       p.generation = ohci->request_generation;
 
        /* The OHCI bus reset handler synthesizes a phy packet with
         * the new generation number when a bus reset happens (see
@@ -274,71 +351,240 @@ static void ar_context_tasklet(unsigned long data)
         * request. */
 
        if (p.ack + 16 == 0x09)
-               ohci->request_generation = (ctx->buffer[2] >> 16) & 0xff;
+               ohci->request_generation = (buffer[2] >> 16) & 0xff;
        else if (ctx == &ohci->ar_request_ctx)
                fw_core_handle_request(&ohci->card, &p);
        else
                fw_core_handle_response(&ohci->card, &p);
 
-       ctx->descriptor.data_address = cpu_to_le32(ctx->buffer_bus);
-       ctx->descriptor.req_count    = cpu_to_le16(sizeof ctx->buffer);
-       ctx->descriptor.res_count    = cpu_to_le16(sizeof ctx->buffer);
+       return buffer + length + 1;
+}
+
+static void ar_context_tasklet(unsigned long data)
+{
+       struct ar_context *ctx = (struct ar_context *)data;
+       struct fw_ohci *ohci = ctx->ohci;
+       struct ar_buffer *ab;
+       struct descriptor *d;
+       void *buffer, *end;
+
+       ab = ctx->current_buffer;
+       d = &ab->descriptor;
+
+       if (d->res_count == 0) {
+               size_t size, rest, offset;
+
+               /* This descriptor is finished and we may have a
+                * packet split across this and the next buffer. We
+                * reuse the page for reassembling the split packet. */
+
+               offset = offsetof(struct ar_buffer, data);
+               dma_unmap_single(ohci->card.device,
+                                ab->descriptor.data_address - offset,
+                                PAGE_SIZE, DMA_BIDIRECTIONAL);
+
+               buffer = ab;
+               ab = ab->next;
+               d = &ab->descriptor;
+               size = buffer + PAGE_SIZE - ctx->pointer;
+               rest = le16_to_cpu(d->req_count) - le16_to_cpu(d->res_count);
+               memmove(buffer, ctx->pointer, size);
+               memcpy(buffer + size, ab->data, rest);
+               ctx->current_buffer = ab;
+               ctx->pointer = (void *) ab->data + rest;
+               end = buffer + size + rest;
+
+               while (buffer < end)
+                       buffer = handle_ar_packet(ctx, buffer);
+
+               free_page((unsigned long)buffer);
+               ar_context_add_page(ctx);
+       } else {
+               buffer = ctx->pointer;
+               ctx->pointer = end =
+                       (void *) ab + PAGE_SIZE - le16_to_cpu(d->res_count);
+
+               while (buffer < end)
+                       buffer = handle_ar_packet(ctx, buffer);
+       }
+}
+
+static int
+ar_context_init(struct ar_context *ctx, struct fw_ohci *ohci, u32 regs)
+{
+       struct ar_buffer ab;
+
+       ctx->regs        = regs;
+       ctx->ohci        = ohci;
+       ctx->last_buffer = &ab;
+       tasklet_init(&ctx->tasklet, ar_context_tasklet, (unsigned long)ctx);
+
+       ar_context_add_page(ctx);
+       ar_context_add_page(ctx);
+       ctx->current_buffer = ab.next;
+       ctx->pointer = ctx->current_buffer->data;
+
+       reg_write(ctx->ohci, command_ptr(ctx->regs), ab.descriptor.branch_address);
+       reg_write(ctx->ohci, control_set(ctx->regs), CONTEXT_RUN);
+       flush_writes(ctx->ohci);
+
+       return 0;
+}
+static void context_tasklet(unsigned long data)
+{
+       struct context *ctx = (struct context *) data;
+       struct fw_ohci *ohci = ctx->ohci;
+       struct descriptor *d, *last;
+       u32 address;
+       int z;
+
+       dma_sync_single_for_cpu(ohci->card.device, ctx->buffer_bus,
+                               ctx->buffer_size, DMA_TO_DEVICE);
+
+       d    = ctx->tail_descriptor;
+       last = ctx->tail_descriptor_last;
 
-       dma_sync_single_for_device(ohci->card.device, ctx->descriptor_bus,
-                                  sizeof ctx->descriptor_bus, DMA_TO_DEVICE);
+       while (last->branch_address != 0) {
+               address = le32_to_cpu(last->branch_address);
+               z = address & 0xf;
+               d = ctx->buffer + (address - ctx->buffer_bus) / sizeof *d;
+               last = (z == 2) ? d : d + z - 1;
 
-       /* FIXME: We stop and restart the ar context here, what if we
-        * stop while a receive is in progress? Maybe we could just
-        * loop the context back to itself and use it in buffer fill
-        * mode as intended... */
+               if (!ctx->callback(ctx, d, last))
+                       break;
 
-       reg_write(ctx->ohci, ctx->control_clear, CONTEXT_RUN);
-       ar_context_run(ctx);
+               ctx->tail_descriptor      = d;
+               ctx->tail_descriptor_last = last;
+       }
 }
 
 static int
-ar_context_init(struct ar_context *ctx, struct fw_ohci *ohci, u32 control_set)
+context_init(struct context *ctx, struct fw_ohci *ohci,
+            size_t buffer_size, u32 regs,
+            descriptor_callback_t callback)
 {
-       ctx->descriptor_bus =
-               dma_map_single(ohci->card.device, &ctx->descriptor,
-                              sizeof ctx->descriptor, DMA_TO_DEVICE);
-       if (ctx->descriptor_bus == 0)
+       ctx->ohci = ohci;
+       ctx->regs = regs;
+       ctx->buffer_size = buffer_size;
+       ctx->buffer = kmalloc(buffer_size, GFP_KERNEL);
+       if (ctx->buffer == NULL)
                return -ENOMEM;
 
-       if (ctx->descriptor_bus & 0xf)
-               fw_notify("descriptor not 16-byte aligned: 0x%08lx\n",
-                         (unsigned long)ctx->descriptor_bus);
+       tasklet_init(&ctx->tasklet, context_tasklet, (unsigned long)ctx);
+       ctx->callback = callback;
 
        ctx->buffer_bus =
                dma_map_single(ohci->card.device, ctx->buffer,
-                              sizeof ctx->buffer, DMA_FROM_DEVICE);
-
-       if (ctx->buffer_bus == 0) {
-               dma_unmap_single(ohci->card.device, ctx->descriptor_bus,
-                                sizeof ctx->descriptor, DMA_TO_DEVICE);
+                              buffer_size, DMA_TO_DEVICE);
+       if (dma_mapping_error(ctx->buffer_bus)) {
+               kfree(ctx->buffer);
                return -ENOMEM;
        }
 
-       memset(&ctx->descriptor, 0, sizeof ctx->descriptor);
-       ctx->descriptor.control      = cpu_to_le16(descriptor_input_more |
-                                                  descriptor_status |
-                                                  descriptor_branch_always);
-       ctx->descriptor.req_count    = cpu_to_le16(sizeof ctx->buffer);
-       ctx->descriptor.data_address = cpu_to_le32(ctx->buffer_bus);
-       ctx->descriptor.res_count    = cpu_to_le16(sizeof ctx->buffer);
-
-       ctx->control_set   = control_set;
-       ctx->control_clear = control_set + 4;
-       ctx->command_ptr   = control_set + 12;
-       ctx->ohci          = ohci;
+       ctx->head_descriptor      = ctx->buffer;
+       ctx->prev_descriptor      = ctx->buffer;
+       ctx->tail_descriptor      = ctx->buffer;
+       ctx->tail_descriptor_last = ctx->buffer;
 
-       tasklet_init(&ctx->tasklet, ar_context_tasklet, (unsigned long)ctx);
+       /* We put a dummy descriptor in the buffer that has a NULL
+        * branch address and looks like it's been sent.  That way we
+        * have a descriptor to append DMA programs to.  Also, the
+        * ring buffer invariant is that it always has at least one
+        * element so that head == tail means buffer full. */
 
-       ar_context_run(ctx);
+       memset(ctx->head_descriptor, 0, sizeof *ctx->head_descriptor);
+       ctx->head_descriptor->control = cpu_to_le16(descriptor_output_last);
+       ctx->head_descriptor->transfer_status = cpu_to_le16(0x8011);
+       ctx->head_descriptor++;
 
        return 0;
 }
 
+ static void
+context_release(struct context *ctx)
+{
+       struct fw_card *card = &ctx->ohci->card;
+
+       dma_unmap_single(card->device, ctx->buffer_bus,
+                        ctx->buffer_size, DMA_TO_DEVICE);
+       kfree(ctx->buffer);
+}
+
+static struct descriptor *
+context_get_descriptors(struct context *ctx, int z, dma_addr_t *d_bus)
+{
+       struct descriptor *d, *tail, *end;
+
+       d = ctx->head_descriptor;
+       tail = ctx->tail_descriptor;
+       end = ctx->buffer + ctx->buffer_size / sizeof(struct descriptor);
+
+       if (d + z <= tail) {
+               goto has_space;
+       } else if (d > tail && d + z <= end) {
+               goto has_space;
+       } else if (d > tail && ctx->buffer + z <= tail) {
+               d = ctx->buffer;
+               goto has_space;
+       }
+
+       return NULL;
+
+ has_space:
+       memset(d, 0, z * sizeof *d);
+       *d_bus = ctx->buffer_bus + (d - ctx->buffer) * sizeof *d;
+
+       return d;
+}
+
+static void context_run(struct context *ctx, u32 extra)
+{
+       struct fw_ohci *ohci = ctx->ohci;
+
+       reg_write(ohci, command_ptr(ctx->regs),
+                 le32_to_cpu(ctx->tail_descriptor_last->branch_address));
+       reg_write(ohci, control_clear(ctx->regs), ~0);
+       reg_write(ohci, control_set(ctx->regs), CONTEXT_RUN | extra);
+       flush_writes(ohci);
+}
+
+static void context_append(struct context *ctx,
+                          struct descriptor *d, int z, int extra)
+{
+       dma_addr_t d_bus;
+
+       d_bus = ctx->buffer_bus + (d - ctx->buffer) * sizeof *d;
+
+       ctx->head_descriptor = d + z + extra;
+       ctx->prev_descriptor->branch_address = cpu_to_le32(d_bus | z);
+       ctx->prev_descriptor = z == 2 ? d : d + z - 1;
+
+       dma_sync_single_for_device(ctx->ohci->card.device, ctx->buffer_bus,
+                                  ctx->buffer_size, DMA_TO_DEVICE);
+
+       reg_write(ctx->ohci, control_set(ctx->regs), CONTEXT_WAKE);
+       flush_writes(ctx->ohci);
+}
+
+static void context_stop(struct context *ctx)
+{
+       u32 reg;
+       int i;
+
+       reg_write(ctx->ohci, control_clear(ctx->regs), CONTEXT_RUN);
+       flush_writes(ctx->ohci);
+
+       for (i = 0; i < 10; i++) {
+               reg = reg_read(ctx->ohci, control_set(ctx->regs));
+               if ((reg & CONTEXT_ACTIVE) == 0)
+                       break;
+
+               fw_notify("context_stop: still active (0x%08x)\n", reg);
+               msleep(1);
+       }
+}
+
 static void
 do_packet_callbacks(struct fw_ohci *ohci, struct list_head *list)
 {
@@ -375,8 +621,8 @@ at_context_setup_packet(struct at_context *ctx, struct list_head *list)
                                                     packet->payload,
                                                     packet->payload_length,
                                                     DMA_TO_DEVICE);
-               if (packet->payload_bus == 0) {
-                       complete_transmission(packet, -ENOMEM, list);
+               if (dma_mapping_error(packet->payload_bus)) {
+                       complete_transmission(packet, RCODE_SEND_ERROR, list);
                        return;
                }
 
@@ -430,15 +676,16 @@ at_context_setup_packet(struct at_context *ctx, struct list_head *list)
 
        /* FIXME: Document how the locking works. */
        if (ohci->generation == packet->generation) {
-               reg_write(ctx->ohci, ctx->command_ptr,
+               reg_write(ctx->ohci, command_ptr(ctx->regs),
                          ctx->descriptor_bus | z);
-               reg_write(ctx->ohci, ctx->control_set,
+               reg_write(ctx->ohci, control_set(ctx->regs),
                          CONTEXT_RUN | CONTEXT_WAKE);
+               ctx->current_packet = packet;
        } else {
                /* We dont return error codes from this function; all
                 * transmission errors are reported through the
                 * callback. */
-               complete_transmission(packet, -ESTALE, list);
+               complete_transmission(packet, RCODE_GENERATION, list);
        }
 }
 
@@ -446,9 +693,9 @@ static void at_context_stop(struct at_context *ctx)
 {
        u32 reg;
 
-       reg_write(ctx->ohci, ctx->control_clear, CONTEXT_RUN);
+       reg_write(ctx->ohci, control_clear(ctx->regs), CONTEXT_RUN);
 
-       reg = reg_read(ctx->ohci, ctx->control_set);
+       reg = reg_read(ctx->ohci, control_set(ctx->regs));
        if (reg & CONTEXT_ACTIVE)
                fw_notify("Tried to stop context, but it is still active "
                          "(0x%08x).\n", reg);
@@ -469,6 +716,12 @@ static void at_context_tasklet(unsigned long data)
 
        at_context_stop(ctx);
 
+       /* If the head of the list isn't the packet that just got
+        * transmitted, the packet got cancelled before we finished
+        * transmitting it. */
+       if (ctx->current_packet != packet)
+               goto skip_to_next;
+
        if (packet->payload_length > 0) {
                dma_unmap_single(ohci->card.device, packet->payload_bus,
                                 packet->payload_length, DMA_TO_DEVICE);
@@ -484,31 +737,32 @@ static void at_context_tasklet(unsigned long data)
                switch (evt) {
                case OHCI1394_evt_timeout:
                        /* Async response transmit timed out. */
-                       complete_transmission(packet, -ETIMEDOUT, &list);
+                       complete_transmission(packet, RCODE_CANCELLED, &list);
                        break;
 
                case OHCI1394_evt_flushed:
                        /* The packet was flushed should give same
                         * error as when we try to use a stale
                         * generation count. */
-                       complete_transmission(packet, -ESTALE, &list);
+                       complete_transmission(packet,
+                                             RCODE_GENERATION, &list);
                        break;
 
                case OHCI1394_evt_missing_ack:
-                       /* This would be a higher level software
-                        * error, it is using a valid (current)
-                        * generation count, but the node is not on
-                        * the bus. */
-                       complete_transmission(packet, -ENODEV, &list);
+                       /* Using a valid (current) generation count,
+                        * but the node is not on the bus or not
+                        * sending acks. */
+                       complete_transmission(packet, RCODE_NO_ACK, &list);
                        break;
 
                default:
-                       complete_transmission(packet, -EIO, &list);
+                       complete_transmission(packet, RCODE_SEND_ERROR, &list);
                        break;
                }
        } else
                complete_transmission(packet, evt - 16, &list);
 
+ skip_to_next:
        /* If more packets are queued, set up the next one. */
        if (!list_empty(&ctx->list))
                at_context_setup_packet(ctx, &list);
@@ -519,20 +773,18 @@ static void at_context_tasklet(unsigned long data)
 }
 
 static int
-at_context_init(struct at_context *ctx, struct fw_ohci *ohci, u32 control_set)
+at_context_init(struct at_context *ctx, struct fw_ohci *ohci, u32 regs)
 {
        INIT_LIST_HEAD(&ctx->list);
 
        ctx->descriptor_bus =
                dma_map_single(ohci->card.device, &ctx->d,
                               sizeof ctx->d, DMA_TO_DEVICE);
-       if (ctx->descriptor_bus == 0)
+       if (dma_mapping_error(ctx->descriptor_bus))
                return -ENOMEM;
 
-       ctx->control_set   = control_set;
-       ctx->control_clear = control_set + 4;
-       ctx->command_ptr   = control_set + 12;
-       ctx->ohci          = ohci;
+       ctx->regs = regs;
+       ctx->ohci = ohci;
 
        tasklet_init(&ctx->tasklet, at_context_tasklet, (unsigned long)ctx);
 
@@ -785,21 +1037,21 @@ static irqreturn_t irq_handler(int irq, void *data)
        if (event & OHCI1394_respTxComplete)
                tasklet_schedule(&ohci->at_response_ctx.tasklet);
 
-       iso_event = reg_read(ohci, OHCI1394_IsoRecvIntEventSet);
+       iso_event = reg_read(ohci, OHCI1394_IsoRecvIntEventClear);
        reg_write(ohci, OHCI1394_IsoRecvIntEventClear, iso_event);
 
        while (iso_event) {
                i = ffs(iso_event) - 1;
-               tasklet_schedule(&ohci->ir_context_list[i].tasklet);
+               tasklet_schedule(&ohci->ir_context_list[i].context.tasklet);
                iso_event &= ~(1 << i);
        }
 
-       iso_event = reg_read(ohci, OHCI1394_IsoXmitIntEventSet);
+       iso_event = reg_read(ohci, OHCI1394_IsoXmitIntEventClear);
        reg_write(ohci, OHCI1394_IsoXmitIntEventClear, iso_event);
 
        while (iso_event) {
                i = ffs(iso_event) - 1;
-               tasklet_schedule(&ohci->it_context_list[i].tasklet);
+               tasklet_schedule(&ohci->it_context_list[i].context.tasklet);
                iso_event &= ~(1 << i);
        }
 
@@ -959,6 +1211,29 @@ static void ohci_send_response(struct fw_card *card, struct fw_packet *packet)
        at_context_transmit(&ohci->at_response_ctx, packet);
 }
 
+static int ohci_cancel_packet(struct fw_card *card, struct fw_packet *packet)
+{
+       struct fw_ohci *ohci = fw_ohci(card);
+       LIST_HEAD(list);
+       unsigned long flags;
+
+       spin_lock_irqsave(&ohci->lock, flags);
+
+       if (packet->ack == 0) {
+               fw_notify("cancelling packet %p (header[0]=%08x)\n",
+                         packet, packet->header[0]);
+
+               complete_transmission(packet, RCODE_CANCELLED, &list);
+       }
+
+       spin_unlock_irqrestore(&ohci->lock, flags);
+
+       do_packet_callbacks(ohci, &list);
+
+       /* Return success if we actually cancelled something. */
+       return list_empty(&list) ? -ENOENT : 0;
+}
+
 static int
 ohci_enable_phys_dma(struct fw_card *card, int node_id, int generation)
 {
@@ -991,73 +1266,66 @@ ohci_enable_phys_dma(struct fw_card *card, int node_id, int generation)
        return retval;
 }
 
-static void ir_context_tasklet(unsigned long data)
+static int handle_ir_packet(struct context *context,
+                           struct descriptor *d,
+                           struct descriptor *last)
 {
-       struct iso_context *ctx = (struct iso_context *)data;
-
-       (void)ctx;
+       struct iso_context *ctx =
+               container_of(context, struct iso_context, context);
+       struct db_descriptor *db = (struct db_descriptor *) d;
+       if (db->first_res_count > 0 && db->second_res_count > 0)
+               /* This descriptor isn't done yet, stop iteration. */
+               return 0;
+
+       if (le16_to_cpu(db->control) & descriptor_irq_always)
+               /* FIXME: we should pass payload address here. */
+               ctx->base.callback(&ctx->base,
+                                  0, 0,
+                                  ctx->base.callback_data);
+
+       return 1;
 }
 
 #define ISO_BUFFER_SIZE (64 * 1024)
 
-static void flush_iso_context(struct iso_context *ctx)
-{
-       struct fw_ohci *ohci = fw_ohci(ctx->base.card);
-       struct descriptor *d, *last;
-       u32 address;
-       int z;
-
-       dma_sync_single_for_cpu(ohci->card.device, ctx->buffer_bus,
-                               ISO_BUFFER_SIZE, DMA_TO_DEVICE);
-
-       d    = ctx->tail_descriptor;
-       last = ctx->tail_descriptor_last;
-
-       while (last->branch_address != 0 && last->transfer_status != 0) {
-               address = le32_to_cpu(last->branch_address);
-               z = address & 0xf;
-               d = ctx->buffer + (address - ctx->buffer_bus) / sizeof *d;
-
-               if (z == 2)
-                       last = d;
-               else
-                       last = d + z - 1;
-
-               if (le16_to_cpu(last->control) & descriptor_irq_always)
-                       ctx->base.callback(&ctx->base,
-                                          0, le16_to_cpu(last->res_count),
-                                          ctx->base.callback_data);
-       }
-
-       ctx->tail_descriptor      = d;
-       ctx->tail_descriptor_last = last;
-}
-
-static void it_context_tasklet(unsigned long data)
+static int handle_it_packet(struct context *context,
+                           struct descriptor *d,
+                           struct descriptor *last)
 {
-       struct iso_context *ctx = (struct iso_context *)data;
-
-       flush_iso_context(ctx);
+       struct iso_context *ctx =
+               container_of(context, struct iso_context, context);
+       if (last->transfer_status == 0)
+               /* This descriptor isn't done yet, stop iteration. */
+               return 0;
+
+       if (le16_to_cpu(last->control) & descriptor_irq_always)
+               ctx->base.callback(&ctx->base,
+                                  0, le16_to_cpu(last->res_count),
+                                  ctx->base.callback_data);
+
+       return 1;
 }
 
-static struct fw_iso_context *ohci_allocate_iso_context(struct fw_card *card,
-                                                       int type)
+static struct fw_iso_context *
+ohci_allocate_iso_context(struct fw_card *card, int type)
 {
        struct fw_ohci *ohci = fw_ohci(card);
        struct iso_context *ctx, *list;
-       void (*tasklet) (unsigned long data);
-       u32 *mask;
+       descriptor_callback_t callback;
+       u32 *mask, regs;
        unsigned long flags;
-       int index;
+       int index, retval;
 
        if (type == FW_ISO_CONTEXT_TRANSMIT) {
                mask = &ohci->it_context_mask;
                list = ohci->it_context_list;
-               tasklet = it_context_tasklet;
+               callback = handle_it_packet;
        } else {
-               mask = &ohci->ir_context_mask;
-               list = ohci->ir_context_list;
-               tasklet = ir_context_tasklet;
+               mask = &ohci->ir_context_mask;
+               list = ohci->ir_context_list;
+               callback = handle_ir_packet;
        }
 
        spin_lock_irqsave(&ohci->lock, flags);
@@ -1069,60 +1337,69 @@ static struct fw_iso_context *ohci_allocate_iso_context(struct fw_card *card,
        if (index < 0)
                return ERR_PTR(-EBUSY);
 
+       if (type == FW_ISO_CONTEXT_TRANSMIT)
+               regs = OHCI1394_IsoXmitContextBase(index);
+       else
+               regs = OHCI1394_IsoRcvContextBase(index);
        ctx = &list[index];
        memset(ctx, 0, sizeof *ctx);
-       tasklet_init(&ctx->tasklet, tasklet, (unsigned long)ctx);
-
-       ctx->buffer = kmalloc(ISO_BUFFER_SIZE, GFP_KERNEL);
-       if (ctx->buffer == NULL) {
+       retval = context_init(&ctx->context, ohci, ISO_BUFFER_SIZE,
+                             regs, callback);
+       if (retval < 0) {
                spin_lock_irqsave(&ohci->lock, flags);
                *mask |= 1 << index;
                spin_unlock_irqrestore(&ohci->lock, flags);
-               return ERR_PTR(-ENOMEM);
+               return ERR_PTR(retval);
        }
 
-       ctx->buffer_bus =
-           dma_map_single(card->device, ctx->buffer,
-                          ISO_BUFFER_SIZE, DMA_TO_DEVICE);
+       return &ctx->base;
+}
 
-       ctx->head_descriptor      = ctx->buffer;
-       ctx->prev_descriptor      = ctx->buffer;
-       ctx->tail_descriptor      = ctx->buffer;
-       ctx->tail_descriptor_last = ctx->buffer;
+static int ohci_start_iso(struct fw_iso_context *base, s32 cycle)
+{
+       struct iso_context *ctx = container_of(base, struct iso_context, base);
+       struct fw_ohci *ohci = ctx->context.ohci;
+       u32 cycle_match = 0;
+       int index;
 
-       /* We put a dummy descriptor in the buffer that has a NULL
-        * branch address and looks like it's been sent.  That way we
-        * have a descriptor to append DMA programs to.  Also, the
-        * ring buffer invariant is that it always has at least one
-        * element so that head == tail means buffer full. */
+       if (ctx->base.type == FW_ISO_CONTEXT_TRANSMIT) {
+               index = ctx - ohci->it_context_list;
+               if (cycle > 0)
+                       cycle_match = IT_CONTEXT_CYCLE_MATCH_ENABLE |
+                               (cycle & 0x7fff) << 16;
+               
+               reg_write(ohci, OHCI1394_IsoXmitIntEventClear, 1 << index);
+               reg_write(ohci, OHCI1394_IsoXmitIntMaskSet, 1 << index);
+               context_run(&ctx->context, cycle_match);
+       } else {
+               index = ctx - ohci->ir_context_list;
 
-       memset(ctx->head_descriptor, 0, sizeof *ctx->head_descriptor);
-       ctx->head_descriptor->control = cpu_to_le16(descriptor_output_last);
-       ctx->head_descriptor->transfer_status = cpu_to_le16(0x8011);
-       ctx->head_descriptor++;
+               reg_write(ohci, OHCI1394_IsoRecvIntEventClear, 1 << index);
+               reg_write(ohci, OHCI1394_IsoRecvIntMaskSet, 1 << index);
+               reg_write(ohci, context_match(ctx->context.regs),
+                         0xf0000000 | ctx->base.channel);
+               context_run(&ctx->context, IR_CONTEXT_DUAL_BUFFER_MODE);
+       }
 
-       return &ctx->base;
+       return 0;
 }
 
-static int ohci_send_iso(struct fw_iso_context *base, s32 cycle)
+static int ohci_stop_iso(struct fw_iso_context *base)
 {
-       struct iso_context *ctx = (struct iso_context *)base;
-       struct fw_ohci *ohci = fw_ohci(ctx->base.card);
-       u32 cycle_match = 0;
+       struct fw_ohci *ohci = fw_ohci(base->card);
+       struct iso_context *ctx = container_of(base, struct iso_context, base);
        int index;
 
-       index = ctx - ohci->it_context_list;
-       if (cycle > 0)
-               cycle_match = CONTEXT_CYCLE_MATCH_ENABLE |
-                       (cycle & 0x7fff) << 16;
-
-       reg_write(ohci, OHCI1394_IsoXmitIntMaskSet, 1 << index);
-       reg_write(ohci, OHCI1394_IsoXmitCommandPtr(index),
-                 le32_to_cpu(ctx->tail_descriptor_last->branch_address));
-       reg_write(ohci, OHCI1394_IsoXmitContextControlClear(index), ~0);
-       reg_write(ohci, OHCI1394_IsoXmitContextControlSet(index),
-                 CONTEXT_RUN | cycle_match);
+       if (ctx->base.type == FW_ISO_CONTEXT_TRANSMIT) {
+               index = ctx - ohci->it_context_list;
+               reg_write(ohci, OHCI1394_IsoXmitIntMaskClear, 1 << index);
+       } else {
+               index = ctx - ohci->ir_context_list;
+               reg_write(ohci, OHCI1394_IsoRecvIntMaskClear, 1 << index);
+       }
        flush_writes(ohci);
+       context_stop(&ctx->context);
 
        return 0;
 }
@@ -1130,55 +1407,46 @@ static int ohci_send_iso(struct fw_iso_context *base, s32 cycle)
 static void ohci_free_iso_context(struct fw_iso_context *base)
 {
        struct fw_ohci *ohci = fw_ohci(base->card);
-       struct iso_context *ctx = (struct iso_context *)base;
+       struct iso_context *ctx = container_of(base, struct iso_context, base);
        unsigned long flags;
        int index;
 
-       flush_iso_context(ctx);
+       ohci_stop_iso(base);
+       context_release(&ctx->context);
 
        spin_lock_irqsave(&ohci->lock, flags);
 
        if (ctx->base.type == FW_ISO_CONTEXT_TRANSMIT) {
                index = ctx - ohci->it_context_list;
-               reg_write(ohci, OHCI1394_IsoXmitContextControlClear(index), ~0);
-               reg_write(ohci, OHCI1394_IsoXmitIntMaskClear, 1 << index);
                ohci->it_context_mask |= 1 << index;
        } else {
                index = ctx - ohci->ir_context_list;
-               reg_write(ohci, OHCI1394_IsoRcvContextControlClear(index), ~0);
-               reg_write(ohci, OHCI1394_IsoRecvIntMaskClear, 1 << index);
                ohci->ir_context_mask |= 1 << index;
        }
-       flush_writes(ohci);
-
-       dma_unmap_single(ohci->card.device, ctx->buffer_bus,
-                        ISO_BUFFER_SIZE, DMA_TO_DEVICE);
 
        spin_unlock_irqrestore(&ohci->lock, flags);
 }
 
 static int
-ohci_queue_iso(struct fw_iso_context *base,
-              struct fw_iso_packet *packet, void *payload)
+ohci_queue_iso_transmit(struct fw_iso_context *base,
+                       struct fw_iso_packet *packet,
+                       struct fw_iso_buffer *buffer,
+                       unsigned long payload)
 {
-       struct iso_context *ctx = (struct iso_context *)base;
-       struct fw_ohci *ohci = fw_ohci(ctx->base.card);
-       struct descriptor *d, *end, *last, *tail, *pd;
+       struct iso_context *ctx = container_of(base, struct iso_context, base);
+       struct descriptor *d, *last, *pd;
        struct fw_iso_packet *p;
        __le32 *header;
-       dma_addr_t d_bus;
+       dma_addr_t d_bus, page_bus;
        u32 z, header_z, payload_z, irq;
        u32 payload_index, payload_end_index, next_page_index;
-       int index, page, end_page, i, length, offset;
+       int page, end_page, i, length, offset;
 
        /* FIXME: Cycle lost behavior should be configurable: lose
         * packet, retransmit or terminate.. */
 
        p = packet;
-       payload_index = payload - ctx->base.buffer;
-       d = ctx->head_descriptor;
-       tail = ctx->tail_descriptor;
-       end = ctx->buffer + ISO_BUFFER_SIZE / sizeof(struct descriptor);
+       payload_index = payload;
 
        if (p->skip)
                z = 1;
@@ -1199,21 +1467,9 @@ ohci_queue_iso(struct fw_iso_context *base,
        /* Get header size in number of descriptors. */
        header_z = DIV_ROUND_UP(p->header_length, sizeof *d);
 
-       if (d + z + header_z <= tail) {
-               goto has_space;
-       } else if (d > tail && d + z + header_z <= end) {
-               goto has_space;
-       } else if (d > tail && ctx->buffer + z + header_z <= tail) {
-               d = ctx->buffer;
-               goto has_space;
-       }
-
-       /* No space in buffer */
-       return -1;
-
- has_space:
-       memset(d, 0, (z + header_z) * sizeof *d);
-       d_bus = ctx->buffer_bus + (d - ctx->buffer) * sizeof *d;
+       d = context_get_descriptors(&ctx->context, z + header_z, &d_bus);
+       if (d == NULL)
+               return -ENOMEM;
 
        if (!p->skip) {
                d[0].control   = cpu_to_le16(descriptor_key_immediate);
@@ -1245,38 +1501,105 @@ ohci_queue_iso(struct fw_iso_context *base,
                length             =
                        min(next_page_index, payload_end_index) - payload_index;
                pd[i].req_count    = cpu_to_le16(length);
-               pd[i].data_address = cpu_to_le32(ctx->base.pages[page] + offset);
+
+               page_bus = page_private(buffer->pages[page]);
+               pd[i].data_address = cpu_to_le32(page_bus + offset);
 
                payload_index += length;
        }
 
-       if (z == 2)
-               last = d;
-       else
-               last = d + z - 1;
-
        if (p->interrupt)
                irq = descriptor_irq_always;
        else
                irq = descriptor_no_irq;
 
-       last->control = cpu_to_le16(descriptor_output_last |
-                                   descriptor_status |
-                                   descriptor_branch_always |
-                                   irq);
+       last = z == 2 ? d : d + z - 1;
+       last->control |= cpu_to_le16(descriptor_output_last |
+                                    descriptor_status |
+                                    descriptor_branch_always |
+                                    irq);
 
-       dma_sync_single_for_device(ohci->card.device, ctx->buffer_bus,
-                                  ISO_BUFFER_SIZE, DMA_TO_DEVICE);
+       context_append(&ctx->context, d, z, header_z);
 
-       ctx->head_descriptor = d + z + header_z;
-       ctx->prev_descriptor->branch_address = cpu_to_le32(d_bus | z);
-       ctx->prev_descriptor = last;
+       return 0;
+}
 
-       index = ctx - ohci->it_context_list;
-       reg_write(ohci, OHCI1394_IsoXmitContextControlSet(index), CONTEXT_WAKE);
-       flush_writes(ohci);
+static int
+ohci_queue_iso_receive(struct fw_iso_context *base,
+                      struct fw_iso_packet *packet,
+                      struct fw_iso_buffer *buffer,
+                      unsigned long payload)
+{
+       struct iso_context *ctx = container_of(base, struct iso_context, base);
+       struct db_descriptor *db = NULL;
+       struct descriptor *d;
+       struct fw_iso_packet *p;
+       dma_addr_t d_bus, page_bus;
+       u32 z, header_z, length, rest;
+       int page, offset;
+       /* FIXME: Cycle lost behavior should be configurable: lose
+        * packet, retransmit or terminate.. */
 
-       return 0;
+       p = packet;
+       z = 2;
+
+       /* Get header size in number of descriptors. */
+       header_z = DIV_ROUND_UP(p->header_length, sizeof *d);
+       page     = payload >> PAGE_SHIFT;
+       offset   = payload & ~PAGE_MASK;
+       rest     = p->payload_length;
+
+       /* FIXME: OHCI 1.0 doesn't support dual buffer receive */
+       /* FIXME: handle descriptor_wait */
+       /* FIXME: make packet-per-buffer/dual-buffer a context option */
+       while (rest > 0) {
+               d = context_get_descriptors(&ctx->context,
+                                           z + header_z, &d_bus);
+               if (d == NULL)
+                       return -ENOMEM;
+
+               db = (struct db_descriptor *) d;
+               db->control = cpu_to_le16(descriptor_status |
+                                         descriptor_branch_always);
+               db->first_size = cpu_to_le16(ctx->base.header_size);
+               db->first_req_count = cpu_to_le16(p->header_length);
+               db->second_req_count = cpu_to_le16(p->payload_length);
+               db->first_res_count = cpu_to_le16(db->first_req_count);
+               db->second_res_count = cpu_to_le16(db->second_req_count);
+
+               db->first_buffer = cpu_to_le32(d_bus + sizeof *db);
+               
+               if (offset + rest < PAGE_SIZE)
+                       length = rest;
+               else
+                       length = PAGE_SIZE - offset;
+
+               page_bus = page_private(buffer->pages[page]);
+               db->second_buffer = cpu_to_le32(page_bus + offset);
+
+               context_append(&ctx->context, d, z, header_z);
+               offset = (offset + length) & ~PAGE_MASK;
+               rest -= length;
+               page++;
+       }
+
+       if (p->interrupt)
+               db->control |= cpu_to_le16(descriptor_irq_always);
+       return 0;
+ }
+static int
+ohci_queue_iso(struct fw_iso_context *base,
+              struct fw_iso_packet *packet,
+              struct fw_iso_buffer *buffer,
+              unsigned long payload)
+{
+       if (base->type == FW_ISO_CONTEXT_TRANSMIT)
+               return ohci_queue_iso_transmit(base, packet, buffer, payload);
+       else
+               return ohci_queue_iso_receive(base, packet, buffer, payload);
 }
 
 static const struct fw_card_driver ohci_driver = {
@@ -1286,12 +1609,14 @@ static const struct fw_card_driver ohci_driver = {
        .set_config_rom         = ohci_set_config_rom,
        .send_request           = ohci_send_request,
        .send_response          = ohci_send_response,
+       .cancel_packet          = ohci_cancel_packet,
        .enable_phys_dma        = ohci_enable_phys_dma,
 
        .allocate_iso_context   = ohci_allocate_iso_context,
        .free_iso_context       = ohci_free_iso_context,
        .queue_iso              = ohci_queue_iso,
-       .send_iso               = ohci_send_iso,
+       .start_iso              = ohci_start_iso,
+       .stop_iso               = ohci_stop_iso,
 };
 
 static int software_reset(struct fw_ohci *ohci)