Merge tag 'drm-intel-fixes-2015-07-15' into drm-intel-next-queued
[firefly-linux-kernel-4.4.55.git] / drivers / gpu / drm / i915 / intel_atomic.c
index 0aeced82201e44a831d8ca2f08e67574fa9a8783..e2531cf59266e77208c766b36c5291d4a939a825 100644 (file)
 #include <drm/drm_plane_helper.h>
 #include "intel_drv.h"
 
-
-/**
- * intel_atomic_check - validate state object
- * @dev: drm device
- * @state: state to validate
- */
-int intel_atomic_check(struct drm_device *dev,
-                      struct drm_atomic_state *state)
-{
-       int nplanes = dev->mode_config.num_total_plane;
-       int ncrtcs = dev->mode_config.num_crtc;
-       int nconnectors = dev->mode_config.num_connector;
-       enum pipe nuclear_pipe = INVALID_PIPE;
-       struct intel_crtc *nuclear_crtc = NULL;
-       struct intel_crtc_state *crtc_state = NULL;
-       int ret;
-       int i;
-       bool not_nuclear = false;
-
-       to_intel_atomic_state(state)->cdclk = to_i915(dev)->cdclk_freq;
-
-       /*
-        * FIXME:  At the moment, we only support "nuclear pageflip" on a
-        * single CRTC.  Cross-crtc updates will be added later.
-        */
-       for (i = 0; i < nplanes; i++) {
-               struct intel_plane *plane = to_intel_plane(state->planes[i]);
-               if (!plane)
-                       continue;
-
-               if (nuclear_pipe == INVALID_PIPE) {
-                       nuclear_pipe = plane->pipe;
-               } else if (nuclear_pipe != plane->pipe) {
-                       DRM_DEBUG_KMS("i915 only support atomic plane operations on a single CRTC at the moment\n");
-                       return -EINVAL;
-               }
-       }
-
-       /*
-        * FIXME:  We only handle planes for now; make sure there are no CRTC's
-        * or connectors involved.
-        */
-       state->allow_modeset = false;
-       for (i = 0; i < ncrtcs; i++) {
-               struct intel_crtc *crtc = to_intel_crtc(state->crtcs[i]);
-               if (crtc)
-                       memset(&crtc->atomic, 0, sizeof(crtc->atomic));
-               if (crtc && crtc->pipe != nuclear_pipe)
-                       not_nuclear = true;
-               if (crtc && crtc->pipe == nuclear_pipe) {
-                       nuclear_crtc = crtc;
-                       crtc_state = to_intel_crtc_state(state->crtc_states[i]);
-               }
-       }
-       for (i = 0; i < nconnectors; i++)
-               if (state->connectors[i] != NULL)
-                       not_nuclear = true;
-
-       if (not_nuclear) {
-               DRM_DEBUG_KMS("i915 only supports atomic plane operations at the moment\n");
-               return -EINVAL;
-       }
-
-       if (crtc_state &&
-           crtc_state->quirks & PIPE_CONFIG_QUIRK_INITIAL_PLANES) {
-               ret = drm_atomic_add_affected_planes(state, &nuclear_crtc->base);
-               if (ret)
-                       return ret;
-       }
-
-       ret = drm_atomic_helper_check_planes(dev, state);
-       if (ret)
-               return ret;
-
-       return ret;
-}
-
-
-/**
- * intel_atomic_commit - commit validated state object
- * @dev: DRM device
- * @state: the top-level driver state object
- * @async: asynchronous commit
- *
- * This function commits a top-level state object that has been validated
- * with drm_atomic_helper_check().
- *
- * FIXME:  Atomic modeset support for i915 is not yet complete.  At the moment
- * we can only handle plane-related operations and do not yet support
- * asynchronous commit.
- *
- * RETURNS
- * Zero for success or -errno.
- */
-int intel_atomic_commit(struct drm_device *dev,
-                       struct drm_atomic_state *state,
-                       bool async)
-{
-       struct drm_crtc_state *crtc_state;
-       struct drm_crtc *crtc;
-       int ret;
-       int i;
-
-       if (async) {
-               DRM_DEBUG_KMS("i915 does not yet support async commit\n");
-               return -EINVAL;
-       }
-
-       ret = drm_atomic_helper_prepare_planes(dev, state);
-       if (ret)
-               return ret;
-
-       /* Point of no return */
-       drm_atomic_helper_swap_state(dev, state);
-
-       for_each_crtc_in_state(state, crtc, crtc_state, i) {
-               to_intel_crtc(crtc)->config = to_intel_crtc_state(crtc->state);
-
-               drm_atomic_helper_commit_planes_on_crtc(crtc_state);
-       }
-
-       /* FIXME: This function should eventually call __intel_set_mode when needed */
-
-       drm_atomic_helper_wait_for_vblanks(dev, state);
-       drm_atomic_helper_cleanup_planes(dev, state);
-       drm_atomic_state_free(state);
-
-       return 0;
-}
-
 /**
  * intel_connector_atomic_get_property - fetch connector property value
  * @connector: connector to fetch property for
@@ -272,17 +142,12 @@ int intel_atomic_setup_scalers(struct drm_device *dev,
        struct drm_plane *plane = NULL;
        struct intel_plane *intel_plane;
        struct intel_plane_state *plane_state = NULL;
-       struct intel_crtc_scaler_state *scaler_state;
-       struct drm_atomic_state *drm_state;
+       struct intel_crtc_scaler_state *scaler_state =
+               &crtc_state->scaler_state;
+       struct drm_atomic_state *drm_state = crtc_state->base.state;
        int num_scalers_need;
        int i, j;
 
-       if (INTEL_INFO(dev)->gen < 9 || !intel_crtc || !crtc_state)
-               return 0;
-
-       scaler_state = &crtc_state->scaler_state;
-       drm_state = crtc_state->base.state;
-
        num_scalers_need = hweight32(scaler_state->scaler_users);
        DRM_DEBUG_KMS("crtc_state = %p need = %d avail = %d scaler_users = 0x%x\n",
                crtc_state, num_scalers_need, intel_crtc->num_scalers,
@@ -325,10 +190,6 @@ int intel_atomic_setup_scalers(struct drm_device *dev,
                        scaler_id = &scaler_state->scaler_id;
                } else {
                        name = "PLANE";
-                       idx = plane->base.id;
-
-                       if (!drm_state)
-                               continue;
 
                        /* plane scaler case: assign as a plane scaler */
                        /* find the plane that set the bit as scaler_user */
@@ -359,6 +220,7 @@ int intel_atomic_setup_scalers(struct drm_device *dev,
                        }
 
                        intel_plane = to_intel_plane(plane);
+                       idx = plane->base.id;
 
                        /* plane on different crtc cannot be a scaler user of this crtc */
                        if (WARN_ON(intel_plane->pipe != intel_crtc->pipe)) {