Merge tag 'lsk-v4.4-16.06-android'
[firefly-linux-kernel-4.4.55.git] / drivers / staging / comedi / drivers / adl_pci9111.c
index 6247fdcedcbf9d7da47f0947fff4c1cae965db1c..01d2ee931b28eedb9a1c4aa073b71720d88cbfae 100644 (file)
@@ -1,85 +1,61 @@
 /*
-
-comedi/drivers/adl_pci9111.c
-
-Hardware driver for PCI9111 ADLink cards:
-
-PCI-9111HR
-
-Copyright (C) 2002-2005 Emmanuel Pacaud <emmanuel.pacaud@univ-poitiers.fr>
-
-This program is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2 of the License, or
-(at your option) any later version.
-
-This program is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-GNU General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with this program; if not, write to the Free Software
-Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-*/
+ * adl_pci9111.c
+ * Hardware driver for PCI9111 ADLink cards: PCI-9111HR
+ * Copyright (C) 2002-2005 Emmanuel Pacaud <emmanuel.pacaud@univ-poitiers.fr>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
 
 /*
-Driver: adl_pci9111
-Description: Adlink PCI-9111HR
-Author: Emmanuel Pacaud <emmanuel.pacaud@univ-poitiers.fr>
-Devices: [ADLink] PCI-9111HR (adl_pci9111)
-Status: experimental
-
-Supports:
-
-       - ai_insn read
-       - ao_insn read/write
-       - di_insn read
-       - do_insn read/write
-       - ai_do_cmd mode with the following sources:
-
-       - start_src             TRIG_NOW
-       - scan_begin_src        TRIG_FOLLOW     TRIG_TIMER      TRIG_EXT
-       - convert_src                           TRIG_TIMER      TRIG_EXT
-       - scan_end_src          TRIG_COUNT
-       - stop_src              TRIG_COUNT      TRIG_NONE
-
-The scanned channels must be consecutive and start from 0. They must
-all have the same range and aref.
-
-Configuration options: not applicable, uses PCI auto config
-*/
+ * Driver: adl_pci9111
+ * Description: Adlink PCI-9111HR
+ * Devices: [ADLink] PCI-9111HR (adl_pci9111)
+ * Author: Emmanuel Pacaud <emmanuel.pacaud@univ-poitiers.fr>
+ * Status: experimental
+ *
+ * Configuration options: not applicable, uses PCI auto config
+ *
+ * Supports:
+ * - ai_insn read
+ * - ao_insn read/write
+ * - di_insn read
+ * - do_insn read/write
+ * - ai_do_cmd mode with the following sources:
+ *     - start_src             TRIG_NOW
+ *     - scan_begin_src        TRIG_FOLLOW     TRIG_TIMER      TRIG_EXT
+ *     - convert_src                           TRIG_TIMER      TRIG_EXT
+ *     - scan_end_src          TRIG_COUNT
+ *     - stop_src              TRIG_COUNT      TRIG_NONE
+ *
+ * The scanned channels must be consecutive and start from 0. They must
+ * all have the same range and aref.
+ */
 
 /*
-CHANGELOG:
-
-2005/02/17 Extend AI streaming capabilities. Now, scan_begin_arg can be
-a multiple of chanlist_len*convert_arg.
-2002/02/19 Fixed the two's complement conversion in pci9111_(hr_)ai_get_data.
-2002/02/18 Added external trigger support for analog input.
-
-TODO:
-
-       - Really test implemented functionality.
-       - Add support for the PCI-9111DG with a probe routine to identify
-         the card type (perhaps with the help of the channel number readback
-         of the A/D Data register).
-       - Add external multiplexer support.
-
-*/
+ * TODO:
+ * - Really test implemented functionality.
+ * - Add support for the PCI-9111DG with a probe routine to identify
+ *   the card type (perhaps with the help of the channel number readback
+ *   of the A/D Data register).
+ * - Add external multiplexer support.
+ */
 
-#include <linux/pci.h>
+#include <linux/module.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
 
-#include "../comedidev.h"
+#include "../comedi_pci.h"
 
-#include "8253.h"
 #include "plx9052.h"
-#include "comedi_fc.h"
-
-#define PCI9111_DRIVER_NAME    "adl_pci9111"
-#define PCI9111_HR_DEVICE_ID   0x9111
+#include "comedi_8254.h"
 
 #define PCI9111_FIFO_HALF_SIZE 512
 
@@ -87,9 +63,6 @@ TODO:
 
 #define PCI9111_RANGE_SETTING_DELAY            10
 #define PCI9111_AI_INSTANT_READ_UDELAY_US      2
-#define PCI9111_AI_INSTANT_READ_TIMEOUT                100
-
-#define PCI9111_8254_CLOCK_PERIOD_NS           500
 
 /*
  * IO address map and bit defines
@@ -100,23 +73,24 @@ TODO:
 #define PCI9111_EDIO_REG               0x04
 #define PCI9111_AI_CHANNEL_REG         0x06
 #define PCI9111_AI_RANGE_STAT_REG      0x08
-#define PCI9111_AI_STAT_AD_BUSY                (1 << 7)
-#define PCI9111_AI_STAT_FF_FF          (1 << 6)
-#define PCI9111_AI_STAT_FF_HF          (1 << 5)
-#define PCI9111_AI_STAT_FF_EF          (1 << 4)
-#define PCI9111_AI_RANGE_MASK          (7 << 0)
+#define PCI9111_AI_STAT_AD_BUSY                BIT(7)
+#define PCI9111_AI_STAT_FF_FF          BIT(6)
+#define PCI9111_AI_STAT_FF_HF          BIT(5)
+#define PCI9111_AI_STAT_FF_EF          BIT(4)
+#define PCI9111_AI_RANGE(x)            (((x) & 0x7) << 0)
+#define PCI9111_AI_RANGE_MASK          PCI9111_AI_RANGE(7)
 #define PCI9111_AI_TRIG_CTRL_REG       0x0a
-#define PCI9111_AI_TRIG_CTRL_TRGEVENT  (1 << 5)
-#define PCI9111_AI_TRIG_CTRL_POTRG     (1 << 4)
-#define PCI9111_AI_TRIG_CTRL_PTRG      (1 << 3)
-#define PCI9111_AI_TRIG_CTRL_ETIS      (1 << 2)
-#define PCI9111_AI_TRIG_CTRL_TPST      (1 << 1)
-#define PCI9111_AI_TRIG_CTRL_ASCAN     (1 << 0)
+#define PCI9111_AI_TRIG_CTRL_TRGEVENT  BIT(5)
+#define PCI9111_AI_TRIG_CTRL_POTRG     BIT(4)
+#define PCI9111_AI_TRIG_CTRL_PTRG      BIT(3)
+#define PCI9111_AI_TRIG_CTRL_ETIS      BIT(2)
+#define PCI9111_AI_TRIG_CTRL_TPST      BIT(1)
+#define PCI9111_AI_TRIG_CTRL_ASCAN     BIT(0)
 #define PCI9111_INT_CTRL_REG           0x0c
-#define PCI9111_INT_CTRL_ISC2          (1 << 3)
-#define PCI9111_INT_CTRL_FFEN          (1 << 2)
-#define PCI9111_INT_CTRL_ISC1          (1 << 1)
-#define PCI9111_INT_CTRL_ISC0          (1 << 0)
+#define PCI9111_INT_CTRL_ISC2          BIT(3)
+#define PCI9111_INT_CTRL_FFEN          BIT(2)
+#define PCI9111_INT_CTRL_ISC1          BIT(1)
+#define PCI9111_INT_CTRL_ISC0          BIT(0)
 #define PCI9111_SOFT_TRIG_REG          0x0e
 #define PCI9111_8254_BASE_REG          0x40
 #define PCI9111_INT_CLR_REG            0x48
@@ -130,8 +104,7 @@ TODO:
                                 PLX9052_INTCSR_LI2STAT)
 
 static const struct comedi_lrange pci9111_ai_range = {
-       5,
-       {
+       5, {
                BIP_RANGE(10),
                BIP_RANGE(5),
                BIP_RANGE(2.5),
@@ -143,38 +116,29 @@ static const struct comedi_lrange pci9111_ai_range = {
 struct pci9111_private_data {
        unsigned long lcr_io_base;
 
-       int stop_counter;
-       int stop_is_none;
-
        unsigned int scan_delay;
-       unsigned int chanlist_len;
        unsigned int chunk_counter;
        unsigned int chunk_num_samples;
 
-       int ao_readback;
-
-       unsigned int div1;
-       unsigned int div2;
-
-       short ai_bounce_buffer[2 * PCI9111_FIFO_HALF_SIZE];
+       unsigned short ai_bounce_buffer[2 * PCI9111_FIFO_HALF_SIZE];
 };
 
 static void plx9050_interrupt_control(unsigned long io_base,
-                                     bool LINTi1_enable,
-                                     bool LINTi1_active_high,
-                                     bool LINTi2_enable,
-                                     bool LINTi2_active_high,
+                                     bool int1_enable,
+                                     bool int1_active_high,
+                                     bool int2_enable,
+                                     bool int2_active_high,
                                      bool interrupt_enable)
 {
        int flags = 0;
 
-       if (LINTi1_enable)
+       if (int1_enable)
                flags |= PLX9052_INTCSR_LI1ENAB;
-       if (LINTi1_active_high)
+       if (int1_active_high)
                flags |= PLX9052_INTCSR_LI1POL;
-       if (LINTi2_enable)
+       if (int2_enable)
                flags |= PLX9052_INTCSR_LI2ENAB;
-       if (LINTi2_active_high)
+       if (int2_active_high)
                flags |= PLX9052_INTCSR_LI2POL;
 
        if (interrupt_enable)
@@ -183,83 +147,6 @@ static void plx9050_interrupt_control(unsigned long io_base,
        outb(flags, io_base + PLX9052_INTCSR);
 }
 
-static void pci9111_timer_set(struct comedi_device *dev)
-{
-       struct pci9111_private_data *dev_private = dev->private;
-       unsigned long timer_base = dev->iobase + PCI9111_8254_BASE_REG;
-
-       i8254_set_mode(timer_base, 1, 0, I8254_MODE0 | I8254_BINARY);
-       i8254_set_mode(timer_base, 1, 1, I8254_MODE2 | I8254_BINARY);
-       i8254_set_mode(timer_base, 1, 2, I8254_MODE2 | I8254_BINARY);
-
-       udelay(1);
-
-       i8254_write(timer_base, 1, 2, dev_private->div2);
-       i8254_write(timer_base, 1, 1, dev_private->div1);
-}
-
-enum pci9111_trigger_sources {
-       software,
-       timer_pacer,
-       external
-};
-
-static void pci9111_trigger_source_set(struct comedi_device *dev,
-                                      enum pci9111_trigger_sources source)
-{
-       int flags;
-
-       /* Read the current trigger mode control bits */
-       flags = inb(dev->iobase + PCI9111_AI_TRIG_CTRL_REG);
-       /* Mask off the EITS and TPST bits */
-       flags &= 0x9;
-
-       switch (source) {
-       case software:
-               break;
-
-       case timer_pacer:
-               flags |= PCI9111_AI_TRIG_CTRL_TPST;
-               break;
-
-       case external:
-               flags |= PCI9111_AI_TRIG_CTRL_ETIS;
-               break;
-       }
-
-       outb(flags, dev->iobase + PCI9111_AI_TRIG_CTRL_REG);
-}
-
-static void pci9111_pretrigger_set(struct comedi_device *dev, bool pretrigger)
-{
-       int flags;
-
-       /* Read the current trigger mode control bits */
-       flags = inb(dev->iobase + PCI9111_AI_TRIG_CTRL_REG);
-       /* Mask off the PTRG bit */
-       flags &= 0x7;
-
-       if (pretrigger)
-               flags |= PCI9111_AI_TRIG_CTRL_PTRG;
-
-       outb(flags, dev->iobase + PCI9111_AI_TRIG_CTRL_REG);
-}
-
-static void pci9111_autoscan_set(struct comedi_device *dev, bool autoscan)
-{
-       int flags;
-
-       /* Read the current trigger mode control bits */
-       flags = inb(dev->iobase + PCI9111_AI_TRIG_CTRL_REG);
-       /* Mask off the ASCAN bit */
-       flags &= 0xe;
-
-       if (autoscan)
-               flags |= PCI9111_AI_TRIG_CTRL_ASCAN;
-
-       outb(flags, dev->iobase + PCI9111_AI_TRIG_CTRL_REG);
-}
-
 enum pci9111_ISC0_sources {
        irq_on_eoc,
        irq_on_fifo_half_full
@@ -312,258 +199,199 @@ static int pci9111_ai_cancel(struct comedi_device *dev,
        plx9050_interrupt_control(dev_private->lcr_io_base, true, true, true,
                                  true, false);
 
-       pci9111_trigger_source_set(dev, software);
-
-       pci9111_autoscan_set(dev, false);
+       /* disable A/D triggers (software trigger mode) and auto scan off */
+       outb(0, dev->iobase + PCI9111_AI_TRIG_CTRL_REG);
 
        pci9111_fifo_reset(dev);
 
        return 0;
 }
 
+static int pci9111_ai_check_chanlist(struct comedi_device *dev,
+                                    struct comedi_subdevice *s,
+                                    struct comedi_cmd *cmd)
+{
+       unsigned int range0 = CR_RANGE(cmd->chanlist[0]);
+       unsigned int aref0 = CR_AREF(cmd->chanlist[0]);
+       int i;
+
+       for (i = 1; i < cmd->chanlist_len; i++) {
+               unsigned int chan = CR_CHAN(cmd->chanlist[i]);
+               unsigned int range = CR_RANGE(cmd->chanlist[i]);
+               unsigned int aref = CR_AREF(cmd->chanlist[i]);
+
+               if (chan != i) {
+                       dev_dbg(dev->class_dev,
+                               "entries in chanlist must be consecutive channels,counting upwards from 0\n");
+                       return -EINVAL;
+               }
+
+               if (range != range0) {
+                       dev_dbg(dev->class_dev,
+                               "entries in chanlist must all have the same gain\n");
+                       return -EINVAL;
+               }
+
+               if (aref != aref0) {
+                       dev_dbg(dev->class_dev,
+                               "entries in chanlist must all have the same reference\n");
+                       return -EINVAL;
+               }
+       }
+
+       return 0;
+}
+
 static int pci9111_ai_do_cmd_test(struct comedi_device *dev,
                                  struct comedi_subdevice *s,
                                  struct comedi_cmd *cmd)
 {
-       struct pci9111_private_data *dev_private = dev->private;
-       int tmp;
-       int error = 0;
-       int range, reference;
-       int i;
+       int err = 0;
+       unsigned int arg;
 
        /* Step 1 : check if triggers are trivially valid */
 
-       error |= cfc_check_trigger_src(&cmd->start_src, TRIG_NOW);
-       error |= cfc_check_trigger_src(&cmd->scan_begin_src,
+       err |= comedi_check_trigger_src(&cmd->start_src, TRIG_NOW);
+       err |= comedi_check_trigger_src(&cmd->scan_begin_src,
                                        TRIG_TIMER | TRIG_FOLLOW | TRIG_EXT);
-       error |= cfc_check_trigger_src(&cmd->convert_src,
+       err |= comedi_check_trigger_src(&cmd->convert_src,
                                        TRIG_TIMER | TRIG_EXT);
-       error |= cfc_check_trigger_src(&cmd->scan_end_src, TRIG_COUNT);
-       error |= cfc_check_trigger_src(&cmd->stop_src,
+       err |= comedi_check_trigger_src(&cmd->scan_end_src, TRIG_COUNT);
+       err |= comedi_check_trigger_src(&cmd->stop_src,
                                        TRIG_COUNT | TRIG_NONE);
 
-       if (error)
+       if (err)
                return 1;
 
        /* Step 2a : make sure trigger sources are unique */
 
-       error |= cfc_check_trigger_is_unique(cmd->scan_begin_src);
-       error |= cfc_check_trigger_is_unique(cmd->convert_src);
-       error |= cfc_check_trigger_is_unique(cmd->stop_src);
+       err |= comedi_check_trigger_is_unique(cmd->scan_begin_src);
+       err |= comedi_check_trigger_is_unique(cmd->convert_src);
+       err |= comedi_check_trigger_is_unique(cmd->stop_src);
 
        /* Step 2b : and mutually compatible */
 
-       if ((cmd->convert_src == TRIG_TIMER) &&
-           !((cmd->scan_begin_src == TRIG_TIMER) ||
-             (cmd->scan_begin_src == TRIG_FOLLOW)))
-               error |= -EINVAL;
-       if ((cmd->convert_src == TRIG_EXT) &&
-           !((cmd->scan_begin_src == TRIG_EXT) ||
-             (cmd->scan_begin_src == TRIG_FOLLOW)))
-               error |= -EINVAL;
+       if (cmd->scan_begin_src != TRIG_FOLLOW) {
+               if (cmd->scan_begin_src != cmd->convert_src)
+                       err |= -EINVAL;
+       }
 
-       if (error)
+       if (err)
                return 2;
 
        /* Step 3: check if arguments are trivially valid */
 
-       error |= cfc_check_trigger_arg_is(&cmd->start_arg, 0);
+       err |= comedi_check_trigger_arg_is(&cmd->start_arg, 0);
 
-       if (cmd->convert_src == TRIG_TIMER)
-               error |= cfc_check_trigger_arg_min(&cmd->convert_arg,
+       if (cmd->convert_src == TRIG_TIMER) {
+               err |= comedi_check_trigger_arg_min(&cmd->convert_arg,
                                        PCI9111_AI_ACQUISITION_PERIOD_MIN_NS);
-       else    /* TRIG_EXT */
-               error |= cfc_check_trigger_arg_is(&cmd->convert_arg, 0);
+       } else {        /* TRIG_EXT */
+               err |= comedi_check_trigger_arg_is(&cmd->convert_arg, 0);
+       }
 
-       if (cmd->scan_begin_src == TRIG_TIMER)
-               error |= cfc_check_trigger_arg_min(&cmd->scan_begin_arg,
+       if (cmd->scan_begin_src == TRIG_TIMER) {
+               err |= comedi_check_trigger_arg_min(&cmd->scan_begin_arg,
                                        PCI9111_AI_ACQUISITION_PERIOD_MIN_NS);
-       else    /* TRIG_FOLLOW || TRIG_EXT */
-               error |= cfc_check_trigger_arg_is(&cmd->scan_begin_arg, 0);
+       } else {        /* TRIG_FOLLOW || TRIG_EXT */
+               err |= comedi_check_trigger_arg_is(&cmd->scan_begin_arg, 0);
+       }
 
-       error |= cfc_check_trigger_arg_is(&cmd->scan_end_arg,
-                                         cmd->chanlist_len);
+       err |= comedi_check_trigger_arg_is(&cmd->scan_end_arg,
+                                          cmd->chanlist_len);
 
        if (cmd->stop_src == TRIG_COUNT)
-               error |= cfc_check_trigger_arg_min(&cmd->stop_arg, 1);
+               err |= comedi_check_trigger_arg_min(&cmd->stop_arg, 1);
        else    /* TRIG_NONE */
-               error |= cfc_check_trigger_arg_is(&cmd->stop_arg, 0);
+               err |= comedi_check_trigger_arg_is(&cmd->stop_arg, 0);
 
-       if (error)
+       if (err)
                return 3;
 
-       /*  Step 4 : fix up any arguments */
+       /* Step 4: fix up any arguments */
 
        if (cmd->convert_src == TRIG_TIMER) {
-               tmp = cmd->convert_arg;
-               i8253_cascade_ns_to_timer_2div(PCI9111_8254_CLOCK_PERIOD_NS,
-                                              &dev_private->div1,
-                                              &dev_private->div2,
-                                              &cmd->convert_arg,
-                                              cmd->flags & TRIG_ROUND_MASK);
-               if (tmp != cmd->convert_arg)
-                       error++;
+               arg = cmd->convert_arg;
+               comedi_8254_cascade_ns_to_timer(dev->pacer, &arg, cmd->flags);
+               err |= comedi_check_trigger_arg_is(&cmd->convert_arg, arg);
        }
-       /*  There's only one timer on this card, so the scan_begin timer must */
-       /*  be a multiple of chanlist_len*convert_arg */
 
+       /*
+        * There's only one timer on this card, so the scan_begin timer
+        * must be a multiple of chanlist_len*convert_arg
+        */
        if (cmd->scan_begin_src == TRIG_TIMER) {
+               arg = cmd->chanlist_len * cmd->convert_arg;
 
-               unsigned int scan_begin_min;
-               unsigned int scan_begin_arg;
-               unsigned int scan_factor;
-
-               scan_begin_min = cmd->chanlist_len * cmd->convert_arg;
-
-               if (cmd->scan_begin_arg != scan_begin_min) {
-                       if (scan_begin_min < cmd->scan_begin_arg) {
-                               scan_factor =
-                                   cmd->scan_begin_arg / scan_begin_min;
-                               scan_begin_arg = scan_factor * scan_begin_min;
-                               if (cmd->scan_begin_arg != scan_begin_arg) {
-                                       cmd->scan_begin_arg = scan_begin_arg;
-                                       error++;
-                               }
-                       } else {
-                               cmd->scan_begin_arg = scan_begin_min;
-                               error++;
-                       }
-               }
+               if (arg < cmd->scan_begin_arg)
+                       arg *= (cmd->scan_begin_arg / arg);
+
+               err |= comedi_check_trigger_arg_is(&cmd->scan_begin_arg, arg);
        }
 
-       if (error)
+       if (err)
                return 4;
 
-       /*  Step 5 : check channel list */
-
-       if (cmd->chanlist) {
-
-               range = CR_RANGE(cmd->chanlist[0]);
-               reference = CR_AREF(cmd->chanlist[0]);
-
-               if (cmd->chanlist_len > 1) {
-                       for (i = 0; i < cmd->chanlist_len; i++) {
-                               if (CR_CHAN(cmd->chanlist[i]) != i) {
-                                       comedi_error(dev,
-                                                    "entries in chanlist must be consecutive "
-                                                    "channels,counting upwards from 0\n");
-                                       error++;
-                               }
-                               if (CR_RANGE(cmd->chanlist[i]) != range) {
-                                       comedi_error(dev,
-                                                    "entries in chanlist must all have the same gain\n");
-                                       error++;
-                               }
-                               if (CR_AREF(cmd->chanlist[i]) != reference) {
-                                       comedi_error(dev,
-                                                    "entries in chanlist must all have the same reference\n");
-                                       error++;
-                               }
-                       }
-               }
-       }
+       /* Step 5: check channel list if it exists */
+       if (cmd->chanlist && cmd->chanlist_len > 0)
+               err |= pci9111_ai_check_chanlist(dev, s, cmd);
 
-       if (error)
+       if (err)
                return 5;
 
        return 0;
-
 }
 
 static int pci9111_ai_do_cmd(struct comedi_device *dev,
                             struct comedi_subdevice *s)
 {
        struct pci9111_private_data *dev_private = dev->private;
-       struct comedi_cmd *async_cmd = &s->async->cmd;
+       struct comedi_cmd *cmd = &s->async->cmd;
+       unsigned int last_chan = CR_CHAN(cmd->chanlist[cmd->chanlist_len - 1]);
+       unsigned int range0 = CR_RANGE(cmd->chanlist[0]);
+       unsigned int trig = 0;
 
-       if (!dev->irq) {
-               comedi_error(dev,
-                            "no irq assigned for PCI9111, cannot do hardware conversion");
-               return -1;
-       }
        /*  Set channel scan limit */
        /*  PCI9111 allows only scanning from channel 0 to channel n */
        /*  TODO: handle the case of an external multiplexer */
 
-       if (async_cmd->chanlist_len > 1) {
-               outb(async_cmd->chanlist_len - 1,
-                       dev->iobase + PCI9111_AI_CHANNEL_REG);
-               pci9111_autoscan_set(dev, true);
-       } else {
-               outb(CR_CHAN(async_cmd->chanlist[0]),
-                       dev->iobase + PCI9111_AI_CHANNEL_REG);
-               pci9111_autoscan_set(dev, false);
-       }
+       if (cmd->chanlist_len > 1)
+               trig |= PCI9111_AI_TRIG_CTRL_ASCAN;
 
-       /*  Set gain */
-       /*  This is the same gain on every channel */
+       outb(last_chan, dev->iobase + PCI9111_AI_CHANNEL_REG);
 
-       outb(CR_RANGE(async_cmd->chanlist[0]) & PCI9111_AI_RANGE_MASK,
-               dev->iobase + PCI9111_AI_RANGE_STAT_REG);
-
-       /* Set counter */
-
-       switch (async_cmd->stop_src) {
-       case TRIG_COUNT:
-               dev_private->stop_counter =
-                   async_cmd->stop_arg * async_cmd->chanlist_len;
-               dev_private->stop_is_none = 0;
-               break;
-
-       case TRIG_NONE:
-               dev_private->stop_counter = 0;
-               dev_private->stop_is_none = 1;
-               break;
-
-       default:
-               comedi_error(dev, "Invalid stop trigger");
-               return -1;
-       }
+       /*  Set gain - all channels use the same range */
+       outb(PCI9111_AI_RANGE(range0), dev->iobase + PCI9111_AI_RANGE_STAT_REG);
 
        /*  Set timer pacer */
-
        dev_private->scan_delay = 0;
-       switch (async_cmd->convert_src) {
-       case TRIG_TIMER:
-               pci9111_trigger_source_set(dev, software);
-               pci9111_timer_set(dev);
+       if (cmd->convert_src == TRIG_TIMER) {
+               trig |= PCI9111_AI_TRIG_CTRL_TPST;
+               comedi_8254_update_divisors(dev->pacer);
+               comedi_8254_pacer_enable(dev->pacer, 1, 2, true);
                pci9111_fifo_reset(dev);
                pci9111_interrupt_source_set(dev, irq_on_fifo_half_full,
                                             irq_on_timer_tick);
-               pci9111_trigger_source_set(dev, timer_pacer);
                plx9050_interrupt_control(dev_private->lcr_io_base, true, true,
                                          false, true, true);
 
-               if (async_cmd->scan_begin_src == TRIG_TIMER) {
-                       dev_private->scan_delay =
-                               (async_cmd->scan_begin_arg /
-                                (async_cmd->convert_arg *
-                                 async_cmd->chanlist_len)) - 1;
+               if (cmd->scan_begin_src == TRIG_TIMER) {
+                       dev_private->scan_delay = (cmd->scan_begin_arg /
+                               (cmd->convert_arg * cmd->chanlist_len)) - 1;
                }
-
-               break;
-
-       case TRIG_EXT:
-
-               pci9111_trigger_source_set(dev, external);
+       } else {        /* TRIG_EXT */
+               trig |= PCI9111_AI_TRIG_CTRL_ETIS;
                pci9111_fifo_reset(dev);
                pci9111_interrupt_source_set(dev, irq_on_fifo_half_full,
                                             irq_on_timer_tick);
                plx9050_interrupt_control(dev_private->lcr_io_base, true, true,
                                          false, true, true);
-
-               break;
-
-       default:
-               comedi_error(dev, "Invalid convert trigger");
-               return -1;
        }
+       outb(trig, dev->iobase + PCI9111_AI_TRIG_CTRL_REG);
 
-       dev_private->stop_counter *= (1 + dev_private->scan_delay);
-       dev_private->chanlist_len = async_cmd->chanlist_len;
        dev_private->chunk_counter = 0;
-       dev_private->chunk_num_samples =
-           dev_private->chanlist_len * (1 + dev_private->scan_delay);
+       dev_private->chunk_num_samples = cmd->chanlist_len *
+                                        (1 + dev_private->scan_delay);
 
        return 0;
 }
@@ -573,23 +401,68 @@ static void pci9111_ai_munge(struct comedi_device *dev,
                             unsigned int num_bytes,
                             unsigned int start_chan_index)
 {
-       short *array = data;
+       unsigned short *array = data;
        unsigned int maxdata = s->maxdata;
        unsigned int invert = (maxdata + 1) >> 1;
        unsigned int shift = (maxdata == 0xffff) ? 0 : 4;
-       unsigned int num_samples = num_bytes / sizeof(short);
+       unsigned int num_samples = comedi_bytes_to_samples(s, num_bytes);
        unsigned int i;
 
        for (i = 0; i < num_samples; i++)
                array[i] = ((array[i] >> shift) & maxdata) ^ invert;
 }
 
+static void pci9111_handle_fifo_half_full(struct comedi_device *dev,
+                                         struct comedi_subdevice *s)
+{
+       struct pci9111_private_data *devpriv = dev->private;
+       struct comedi_cmd *cmd = &s->async->cmd;
+       unsigned short *buf = devpriv->ai_bounce_buffer;
+       unsigned int samples;
+
+       samples = comedi_nsamples_left(s, PCI9111_FIFO_HALF_SIZE);
+       insw(dev->iobase + PCI9111_AI_FIFO_REG, buf, samples);
+
+       if (devpriv->scan_delay < 1) {
+               comedi_buf_write_samples(s, buf, samples);
+       } else {
+               unsigned int pos = 0;
+               unsigned int to_read;
+
+               while (pos < samples) {
+                       if (devpriv->chunk_counter < cmd->chanlist_len) {
+                               to_read = cmd->chanlist_len -
+                                         devpriv->chunk_counter;
+
+                               if (to_read > samples - pos)
+                                       to_read = samples - pos;
+
+                               comedi_buf_write_samples(s, buf + pos, to_read);
+                       } else {
+                               to_read = devpriv->chunk_num_samples -
+                                         devpriv->chunk_counter;
+
+                               if (to_read > samples - pos)
+                                       to_read = samples - pos;
+                       }
+
+                       pos += to_read;
+                       devpriv->chunk_counter += to_read;
+
+                       if (devpriv->chunk_counter >=
+                           devpriv->chunk_num_samples)
+                               devpriv->chunk_counter = 0;
+               }
+       }
+}
+
 static irqreturn_t pci9111_interrupt(int irq, void *p_device)
 {
        struct comedi_device *dev = p_device;
        struct pci9111_private_data *dev_private = dev->private;
        struct comedi_subdevice *s = dev->read_subdev;
        struct comedi_async *async;
+       struct comedi_cmd *cmd;
        unsigned int status;
        unsigned long irq_flags;
        unsigned char intcsr;
@@ -601,6 +474,7 @@ static irqreturn_t pci9111_interrupt(int irq, void *p_device)
        }
 
        async = s->async;
+       cmd = &async->cmd;
 
        spin_lock_irqsave(&dev->spinlock, irq_flags);
 
@@ -623,102 +497,44 @@ static irqreturn_t pci9111_interrupt(int irq, void *p_device)
                /* '0' means FIFO is full, data may have been lost */
                if (!(status & PCI9111_AI_STAT_FF_FF)) {
                        spin_unlock_irqrestore(&dev->spinlock, irq_flags);
-                       comedi_error(dev, PCI9111_DRIVER_NAME " fifo overflow");
+                       dev_dbg(dev->class_dev, "fifo overflow\n");
                        outb(0, dev->iobase + PCI9111_INT_CLR_REG);
-                       pci9111_ai_cancel(dev, s);
-                       async->events |= COMEDI_CB_ERROR | COMEDI_CB_EOA;
-                       comedi_event(dev, s);
+                       async->events |= COMEDI_CB_ERROR;
+                       comedi_handle_events(dev, s);
 
                        return IRQ_HANDLED;
                }
 
                /* '0' means FIFO is half-full */
-               if (!(status & PCI9111_AI_STAT_FF_HF)) {
-                       unsigned int num_samples;
-                       unsigned int bytes_written = 0;
-
-                       num_samples =
-                           PCI9111_FIFO_HALF_SIZE >
-                           dev_private->stop_counter
-                           && !dev_private->
-                           stop_is_none ? dev_private->stop_counter :
-                           PCI9111_FIFO_HALF_SIZE;
-                       insw(dev->iobase + PCI9111_AI_FIFO_REG,
-                            dev_private->ai_bounce_buffer, num_samples);
-
-                       if (dev_private->scan_delay < 1) {
-                               bytes_written =
-                                   cfc_write_array_to_buffer(s,
-                                                             dev_private->
-                                                             ai_bounce_buffer,
-                                                             num_samples *
-                                                             sizeof(short));
-                       } else {
-                               int position = 0;
-                               int to_read;
-
-                               while (position < num_samples) {
-                                       if (dev_private->chunk_counter <
-                                           dev_private->chanlist_len) {
-                                               to_read =
-                                                   dev_private->chanlist_len -
-                                                   dev_private->chunk_counter;
-
-                                               if (to_read >
-                                                   num_samples - position)
-                                                       to_read =
-                                                           num_samples -
-                                                           position;
-
-                                               bytes_written +=
-                                                   cfc_write_array_to_buffer
-                                                   (s,
-                                                    dev_private->ai_bounce_buffer
-                                                    + position,
-                                                    to_read * sizeof(short));
-                                       } else {
-                                               to_read =
-                                                   dev_private->chunk_num_samples
-                                                   -
-                                                   dev_private->chunk_counter;
-                                               if (to_read >
-                                                   num_samples - position)
-                                                       to_read =
-                                                           num_samples -
-                                                           position;
-
-                                               bytes_written +=
-                                                   sizeof(short) * to_read;
-                                       }
-
-                                       position += to_read;
-                                       dev_private->chunk_counter += to_read;
-
-                                       if (dev_private->chunk_counter >=
-                                           dev_private->chunk_num_samples)
-                                               dev_private->chunk_counter = 0;
-                               }
-                       }
-
-                       dev_private->stop_counter -=
-                           bytes_written / sizeof(short);
-               }
+               if (!(status & PCI9111_AI_STAT_FF_HF))
+                       pci9111_handle_fifo_half_full(dev, s);
        }
 
-       if ((dev_private->stop_counter == 0) && (!dev_private->stop_is_none)) {
+       if (cmd->stop_src == TRIG_COUNT && async->scans_done >= cmd->stop_arg)
                async->events |= COMEDI_CB_EOA;
-               pci9111_ai_cancel(dev, s);
-       }
 
        outb(0, dev->iobase + PCI9111_INT_CLR_REG);
 
        spin_unlock_irqrestore(&dev->spinlock, irq_flags);
 
-       comedi_event(dev, s);
+       comedi_handle_events(dev, s);
 
        return IRQ_HANDLED;
 }
 
+static int pci9111_ai_eoc(struct comedi_device *dev,
+                         struct comedi_subdevice *s,
+                         struct comedi_insn *insn,
+                         unsigned long context)
+{
+       unsigned int status;
+
+       status = inb(dev->iobase + PCI9111_AI_RANGE_STAT_REG);
+       if (status & PCI9111_AI_STAT_FF_EF)
+               return 0;
+       return -EBUSY;
+}
+
 static int pci9111_ai_insn_read(struct comedi_device *dev,
                                struct comedi_subdevice *s,
                                struct comedi_insn *insn, unsigned int *data)
@@ -729,15 +545,15 @@ static int pci9111_ai_insn_read(struct comedi_device *dev,
        unsigned int invert = (maxdata + 1) >> 1;
        unsigned int shift = (maxdata == 0xffff) ? 0 : 4;
        unsigned int status;
-       int timeout;
+       int ret;
        int i;
 
        outb(chan, dev->iobase + PCI9111_AI_CHANNEL_REG);
 
        status = inb(dev->iobase + PCI9111_AI_RANGE_STAT_REG);
        if ((status & PCI9111_AI_RANGE_MASK) != range) {
-               outb(range & PCI9111_AI_RANGE_MASK,
-                       dev->iobase + PCI9111_AI_RANGE_STAT_REG);
+               outb(PCI9111_AI_RANGE(range),
+                    dev->iobase + PCI9111_AI_RANGE_STAT_REG);
        }
 
        pci9111_fifo_reset(dev);
@@ -746,22 +562,12 @@ static int pci9111_ai_insn_read(struct comedi_device *dev,
                /* Generate a software trigger */
                outb(0, dev->iobase + PCI9111_SOFT_TRIG_REG);
 
-               timeout = PCI9111_AI_INSTANT_READ_TIMEOUT;
-
-               while (timeout--) {
-                       status = inb(dev->iobase + PCI9111_AI_RANGE_STAT_REG);
-                       /* '1' means FIFO is not empty */
-                       if (status & PCI9111_AI_STAT_FF_EF)
-                               goto conversion_done;
+               ret = comedi_timeout(dev, s, insn, pci9111_ai_eoc, 0);
+               if (ret) {
+                       pci9111_fifo_reset(dev);
+                       return ret;
                }
 
-               comedi_error(dev, "A/D read timeout");
-               data[i] = 0;
-               pci9111_fifo_reset(dev);
-               return -ETIME;
-
-conversion_done:
-
                data[i] = inw(dev->iobase + PCI9111_AI_FIFO_REG);
                data[i] = ((data[i] >> shift) & maxdata) ^ invert;
        }
@@ -774,29 +580,15 @@ static int pci9111_ao_insn_write(struct comedi_device *dev,
                                 struct comedi_insn *insn,
                                 unsigned int *data)
 {
-       struct pci9111_private_data *dev_private = dev->private;
-       unsigned int val = 0;
+       unsigned int chan = CR_CHAN(insn->chanspec);
+       unsigned int val = s->readback[chan];
        int i;
 
        for (i = 0; i < insn->n; i++) {
                val = data[i];
                outw(val, dev->iobase + PCI9111_AO_REG);
        }
-       dev_private->ao_readback = val;
-
-       return insn->n;
-}
-
-static int pci9111_ao_insn_read(struct comedi_device *dev,
-                               struct comedi_subdevice *s,
-                               struct comedi_insn *insn,
-                               unsigned int *data)
-{
-       struct pci9111_private_data *dev_private = dev->private;
-       int i;
-
-       for (i = 0; i < insn->n; i++)
-               data[i] = dev_private->ao_readback;
+       s->readback[chan] = val;
 
        return insn->n;
 }
@@ -816,15 +608,8 @@ static int pci9111_do_insn_bits(struct comedi_device *dev,
                                struct comedi_insn *insn,
                                unsigned int *data)
 {
-       unsigned int mask = data[0];
-       unsigned int bits = data[1];
-
-       if (mask) {
-               s->state &= ~mask;
-               s->state |= (bits & mask);
-
+       if (comedi_dio_update_state(s, data))
                outw(s->state, dev->iobase + PCI9111_DIO_REG);
-       }
 
        data[1] = s->state;
 
@@ -839,30 +624,23 @@ static int pci9111_reset(struct comedi_device *dev)
        plx9050_interrupt_control(dev_private->lcr_io_base, true, true, true,
                                  true, false);
 
-       pci9111_trigger_source_set(dev, software);
-       pci9111_pretrigger_set(dev, false);
-       pci9111_autoscan_set(dev, false);
-
-       /* Reset 8254 chip */
-       dev_private->div1 = 0;
-       dev_private->div2 = 0;
-       pci9111_timer_set(dev);
+       /* disable A/D triggers (software trigger mode) and auto scan off */
+       outb(0, dev->iobase + PCI9111_AI_TRIG_CTRL_REG);
 
        return 0;
 }
 
 static int pci9111_auto_attach(struct comedi_device *dev,
-                                        unsigned long context_unused)
+                              unsigned long context_unused)
 {
        struct pci_dev *pcidev = comedi_to_pci_dev(dev);
        struct pci9111_private_data *dev_private;
        struct comedi_subdevice *s;
        int ret;
 
-       dev_private = kzalloc(sizeof(*dev_private), GFP_KERNEL);
+       dev_private = comedi_alloc_devpriv(dev, sizeof(*dev_private));
        if (!dev_private)
                return -ENOMEM;
-       dev->private = dev_private;
 
        ret = comedi_pci_enable(dev);
        if (ret)
@@ -872,31 +650,38 @@ static int pci9111_auto_attach(struct comedi_device *dev,
 
        pci9111_reset(dev);
 
-       if (pcidev->irq > 0) {
-               ret = request_irq(dev->irq, pci9111_interrupt,
+       if (pcidev->irq) {
+               ret = request_irq(pcidev->irq, pci9111_interrupt,
                                  IRQF_SHARED, dev->board_name, dev);
-               if (ret)
-                       return ret;
-               dev->irq = pcidev->irq;
+               if (ret == 0)
+                       dev->irq = pcidev->irq;
        }
 
+       dev->pacer = comedi_8254_init(dev->iobase + PCI9111_8254_BASE_REG,
+                                     I8254_OSC_BASE_2MHZ, I8254_IO16, 0);
+       if (!dev->pacer)
+               return -ENOMEM;
+
        ret = comedi_alloc_subdevices(dev, 4);
        if (ret)
                return ret;
 
        s = &dev->subdevices[0];
-       dev->read_subdev = s;
        s->type         = COMEDI_SUBD_AI;
-       s->subdev_flags = SDF_READABLE | SDF_COMMON | SDF_CMD_READ;
+       s->subdev_flags = SDF_READABLE | SDF_COMMON;
        s->n_chan       = 16;
        s->maxdata      = 0xffff;
-       s->len_chanlist = 16;
        s->range_table  = &pci9111_ai_range;
-       s->cancel       = pci9111_ai_cancel;
        s->insn_read    = pci9111_ai_insn_read;
-       s->do_cmdtest   = pci9111_ai_do_cmd_test;
-       s->do_cmd       = pci9111_ai_do_cmd;
-       s->munge        = pci9111_ai_munge;
+       if (dev->irq) {
+               dev->read_subdev = s;
+               s->subdev_flags |= SDF_CMD_READ;
+               s->len_chanlist = s->n_chan;
+               s->do_cmdtest   = pci9111_ai_do_cmd_test;
+               s->do_cmd       = pci9111_ai_do_cmd;
+               s->cancel       = pci9111_ai_cancel;
+               s->munge        = pci9111_ai_munge;
+       }
 
        s = &dev->subdevices[1];
        s->type         = COMEDI_SUBD_AO;
@@ -906,7 +691,10 @@ static int pci9111_auto_attach(struct comedi_device *dev,
        s->len_chanlist = 1;
        s->range_table  = &range_bipolar10;
        s->insn_write   = pci9111_ao_insn_write;
-       s->insn_read    = pci9111_ao_insn_read;
+
+       ret = comedi_alloc_subdev_readback(s);
+       if (ret)
+               return ret;
 
        s = &dev->subdevices[2];
        s->type         = COMEDI_SUBD_DI;
@@ -918,14 +706,12 @@ static int pci9111_auto_attach(struct comedi_device *dev,
 
        s = &dev->subdevices[3];
        s->type         = COMEDI_SUBD_DO;
-       s->subdev_flags = SDF_READABLE | SDF_WRITABLE;
+       s->subdev_flags = SDF_WRITABLE;
        s->n_chan       = 16;
        s->maxdata      = 1;
        s->range_table  = &range_digital;
        s->insn_bits    = pci9111_do_insn_bits;
 
-       dev_info(dev->class_dev, "%s attached\n", dev->board_name);
-
        return 0;
 }
 
@@ -933,9 +719,7 @@ static void pci9111_detach(struct comedi_device *dev)
 {
        if (dev->iobase)
                pci9111_reset(dev);
-       if (dev->irq != 0)
-               free_irq(dev->irq, dev);
-       comedi_pci_disable(dev);
+       comedi_pci_detach(dev);
 }
 
 static struct comedi_driver adl_pci9111_driver = {
@@ -952,8 +736,8 @@ static int pci9111_pci_probe(struct pci_dev *dev,
                                      id->driver_data);
 }
 
-static DEFINE_PCI_DEVICE_TABLE(pci9111_pci_table) = {
-       { PCI_DEVICE(PCI_VENDOR_ID_ADLINK, PCI9111_HR_DEVICE_ID) },
+static const struct pci_device_id pci9111_pci_table[] = {
+       { PCI_DEVICE(PCI_VENDOR_ID_ADLINK, 0x9111) },
        /* { PCI_DEVICE(PCI_VENDOR_ID_ADLINK, PCI9111_HG_DEVICE_ID) }, */
        { 0 }
 };