Staging: dt3155_drv.c: dereference dt3155_status[]
[firefly-linux-kernel-4.4.55.git] / drivers / staging / dt3155 / dt3155_drv.c
index 7ac2c6d8e9a33b343122959d6ff2b2a25a5c69c8..6d35a6f1982aeb375268b3bd17cb1e0f68314c68 100644 (file)
@@ -63,8 +63,9 @@ extern void printques(int);
 #include <linux/types.h>
 #include <linux/poll.h>
 #include <linux/sched.h>
+#include <linux/smp_lock.h>
+#include <linux/io.h>
 
-#include <asm/io.h>
 #include <asm/uaccess.h>
 
 #include "dt3155.h"
@@ -94,10 +95,7 @@ int dt3155_errno = 0;
 #endif
 
 /* wait queue for interrupts */
-wait_queue_head_t dt3155_read_wait_queue[ MAXBOARDS ];
-
-#define DT_3155_SUCCESS 0
-#define DT_3155_FAILURE -EIO
+wait_queue_head_t dt3155_read_wait_queue[MAXBOARDS];
 
 /* set to dynamicaly allocate, but it is tunable: */
 /* insmod DT_3155 dt3155 dt3155_major=XX */
@@ -111,18 +109,16 @@ int dt3155_major = 0;
 /* Global structures and variables */
 
 /* Status of each device */
-struct dt3155_status_s dt3155_status[ MAXBOARDS ];
+struct dt3155_status dt3155_status[MAXBOARDS];
 
 /* kernel logical address of the board */
-u8 *dt3155_lbase[ MAXBOARDS ] = { NULL
+static void __iomem *dt3155_lbase[MAXBOARDS] = { NULL
 #if MAXBOARDS == 2
                                      , NULL
 #endif
 };
-/* DT3155 registers              */
-u8 *dt3155_bbase = NULL;                 /* kernel logical address of the *
-                                          * buffer region                 */
-u32  dt3155_dev_open[ MAXBOARDS ] = {0
+
+u32  dt3155_dev_open[MAXBOARDS] = {0
 #if MAXBOARDS == 2
                                       , 0
 #endif
@@ -139,22 +135,25 @@ u32 unique_tag = 0;;
  */
 static void quick_stop (int minor)
 {
+  struct dt3155_status *dts = &dt3155_status[minor];
+  struct dt3155_fbuffer *fb = &dts->fbuffer;
+
   // TODO: scott was here
 #if 1
-  ReadMReg((dt3155_lbase[ minor ] + INT_CSR), int_csr_r.reg);
+  int_csr_r.reg = readl(dt3155_lbase[minor] + INT_CSR);
   /* disable interrupts */
   int_csr_r.fld.FLD_END_EVE_EN = 0;
   int_csr_r.fld.FLD_END_ODD_EN = 0;
-  WriteMReg((dt3155_lbase[ minor ] + INT_CSR), int_csr_r.reg );
+  writel(int_csr_r.reg, dt3155_lbase[minor] + INT_CSR);
 
-  dt3155_status[ minor ].state &= ~(DT3155_STATE_STOP|0xff);
+  dts->state &= ~(DT3155_STATE_STOP|0xff);
   /* mark the system stopped: */
-  dt3155_status[ minor ].state |= DT3155_STATE_IDLE;
-  dt3155_fbuffer[ minor ]->stop_acquire = 0;
-  dt3155_fbuffer[ minor ]->even_stopped = 0;
+  dts->state |= DT3155_STATE_IDLE;
+  fb->stop_acquire = 0;
+  fb->even_stopped = 0;
 #else
-  dt3155_status[minor].state |= DT3155_STATE_STOP;
-  dt3155_status[minor].fbuffer.stop_acquire = 1;
+  dts->state |= DT3155_STATE_STOP;
+  fb->stop_acquire = 1;
 #endif
 
 }
@@ -167,16 +166,19 @@ static void quick_stop (int minor)
  * - Assumes irq's are disabled, via SA_INTERRUPT flag
  * being set in request_irq() call from init_module()
  *****************************************************/
-static inline void dt3155_isr( int irq, void *dev_id, struct pt_regs *regs )
+static void dt3155_isr(int irq, void *dev_id, struct pt_regs *regs)
 {
   int    minor = -1;
   int    index;
   unsigned long flags;
   u32 buffer_addr;
+  void __iomem *mmio;
+  struct dt3155_status *dts;
+  struct dt3155_fbuffer *fb;
 
   /* find out who issued the interrupt */
-  for ( index = 0; index < ndevices; index++ ) {
-    if( dev_id == (void*) &dt3155_status[ index ])
+  for (index = 0; index < ndevices; index++) {
+    if(dev_id == (void*) &dt3155_status[index])
       {
        minor = index;
        break;
@@ -184,15 +186,19 @@ static inline void dt3155_isr( int irq, void *dev_id, struct pt_regs *regs )
   }
 
   /* hopefully we should not get here */
-  if ( minor < 0 || minor >= MAXBOARDS ) {
+  if (minor < 0 || minor >= MAXBOARDS) {
     printk(KERN_ERR "dt3155_isr called with invalid dev_id\n");
     return;
   }
 
+  mmio = dt3155_lbase[minor];
+  dts = &dt3155_status[minor];
+  fb = &dts->fbuffer;
+
   /* Check for corruption and set a flag if so */
-  ReadMReg( (dt3155_lbase[ minor ] + CSR1), csr1_r.reg );
+  csr1_r.reg = readl(mmio + CSR1);
 
-  if ( (csr1_r.fld.FLD_CRPT_EVE) || (csr1_r.fld.FLD_CRPT_ODD) )
+  if ((csr1_r.fld.FLD_CRPT_EVE) || (csr1_r.fld.FLD_CRPT_ODD))
     {
       /* TODO: this should probably stop acquisition */
       /* and set some flags so that dt3155_read      */
@@ -202,27 +208,26 @@ static inline void dt3155_isr( int irq, void *dev_id, struct pt_regs *regs )
       return;
     }
 
-  ReadMReg((dt3155_lbase[ minor ] + INT_CSR), int_csr_r.reg);
+  int_csr_r.reg = readl(mmio + INT_CSR);
 
   /* Handle the even field ... */
   if (int_csr_r.fld.FLD_END_EVE)
     {
-      if ( (dt3155_status[ minor ].state & DT3155_STATE_MODE) ==
-          DT3155_STATE_FLD )
+      if ((dts->state & DT3155_STATE_MODE) == DT3155_STATE_FLD)
        {
-         dt3155_fbuffer[ minor ]->frame_count++;
+         fb->frame_count++;
        }
 
-      ReadI2C(dt3155_lbase[ minor ], EVEN_CSR, &i2c_even_csr.reg);
+      ReadI2C(mmio, EVEN_CSR, &i2c_even_csr.reg);
 
       /* Clear the interrupt? */
       int_csr_r.fld.FLD_END_EVE = 1;
 
       /* disable the interrupt if last field */
-      if (dt3155_fbuffer[ minor ]->stop_acquire)
+      if (fb->stop_acquire)
        {
          printk("dt3155:  even stopped.\n");
-         dt3155_fbuffer[ minor ]->even_stopped = 1;
+         fb->even_stopped = 1;
          if (i2c_even_csr.fld.SNGL_EVE)
            {
              int_csr_r.fld.FLD_END_EVE_EN = 0;
@@ -233,78 +238,71 @@ static inline void dt3155_isr( int irq, void *dev_id, struct pt_regs *regs )
            }
        }
 
-      WriteMReg( (dt3155_lbase[ minor ] + INT_CSR), int_csr_r.reg );
+      writel(int_csr_r.reg, mmio + INT_CSR);
 
       /* Set up next DMA if we are doing FIELDS */
-      if ( (dt3155_status[ minor ].state & DT3155_STATE_MODE ) ==
-          DT3155_STATE_FLD)
+      if ((dts->state & DT3155_STATE_MODE) == DT3155_STATE_FLD)
        {
          /* GCS (Aug 2, 2002) -- In field mode, dma the odd field
             into the lower half of the buffer */
-         const u32 stride =  dt3155_status[ minor ].config.cols;
-         buffer_addr = dt3155_fbuffer[ minor ]->
-           frame_info[ dt3155_fbuffer[ minor ]->active_buf ].addr
-           + (DT3155_MAX_ROWS / 2) * stride;
+         const u32 stride =  dts->config.cols;
+         buffer_addr = fb->frame_info[fb->active_buf].addr +
+                       (DT3155_MAX_ROWS / 2) * stride;
          local_save_flags(flags);
          local_irq_disable();
-         wake_up_interruptible( &dt3155_read_wait_queue[ minor ] );
+         wake_up_interruptible(&dt3155_read_wait_queue[minor]);
 
          /* Set up the DMA address for the next field */
          local_irq_restore(flags);
-         WriteMReg((dt3155_lbase[ minor ] + ODD_DMA_START), buffer_addr);
+         writel(buffer_addr, mmio + ODD_DMA_START);
        }
 
       /* Check for errors. */
       i2c_even_csr.fld.DONE_EVE = 1;
-      if ( i2c_even_csr.fld.ERROR_EVE )
+      if (i2c_even_csr.fld.ERROR_EVE)
        dt3155_errno = DT_ERR_OVERRUN;
 
-      WriteI2C( dt3155_lbase[ minor ], EVEN_CSR, i2c_even_csr.reg );
+      WriteI2C(mmio, EVEN_CSR, i2c_even_csr.reg);
 
       /* Note that we actually saw an even field meaning  */
       /* that subsequent odd field complete the frame     */
-      dt3155_fbuffer[ minor ]->even_happened = 1;
+      fb->even_happened = 1;
 
       /* recording the time that the even field finished, this should be */
       /* about time in the middle of the frame */
-      do_gettimeofday( &(dt3155_fbuffer[ minor ]->
-                        frame_info[ dt3155_fbuffer[ minor ]->
-                                    active_buf ].time) );
+      do_gettimeofday(&fb->frame_info[fb->active_buf].time);
       return;
     }
 
   /* ... now handle the odd field */
-  if ( int_csr_r.fld.FLD_END_ODD )
+  if (int_csr_r.fld.FLD_END_ODD)
     {
-      ReadI2C( dt3155_lbase[ minor ], ODD_CSR, &i2c_odd_csr.reg );
+      ReadI2C(mmio, ODD_CSR, &i2c_odd_csr.reg);
 
       /* Clear the interrupt? */
       int_csr_r.fld.FLD_END_ODD = 1;
 
-      if (dt3155_fbuffer[ minor ]->even_happened ||
-         (dt3155_status[ minor ].state & DT3155_STATE_MODE) ==
-         DT3155_STATE_FLD)
+      if (fb->even_happened ||
+         (dts->state & DT3155_STATE_MODE) == DT3155_STATE_FLD)
        {
-         dt3155_fbuffer[ minor ]->frame_count++;
+         fb->frame_count++;
        }
 
-      if ( dt3155_fbuffer[ minor ]->stop_acquire &&
-          dt3155_fbuffer[ minor ]->even_stopped )
+      if (fb->stop_acquire && fb->even_stopped)
        {
          printk(KERN_DEBUG "dt3155:  stopping odd..\n");
-         if ( i2c_odd_csr.fld.SNGL_ODD )
+         if (i2c_odd_csr.fld.SNGL_ODD)
            {
              /* disable interrupts */
              int_csr_r.fld.FLD_END_ODD_EN = 0;
-             dt3155_status[ minor ].state &= ~(DT3155_STATE_STOP|0xff);
+             dts->state &= ~(DT3155_STATE_STOP|0xff);
 
              /* mark the system stopped: */
-             dt3155_status[ minor ].state |= DT3155_STATE_IDLE;
-             dt3155_fbuffer[ minor ]->stop_acquire = 0;
-             dt3155_fbuffer[ minor ]->even_stopped = 0;
+             dts->state |= DT3155_STATE_IDLE;
+             fb->stop_acquire = 0;
+             fb->even_stopped = 0;
 
-             printk(KERN_DEBUG "dt3155:  state is now %x\n",
-                    dt3155_status[minor].state);
+             printk(KERN_DEBUG "dt3155:  state is now %x\n", dts->state);
            }
          else
            {
@@ -312,104 +310,95 @@ static inline void dt3155_isr( int irq, void *dev_id, struct pt_regs *regs )
            }
        }
 
-      WriteMReg( (dt3155_lbase[ minor ] + INT_CSR), int_csr_r.reg );
+      writel(int_csr_r.reg, mmio + INT_CSR);
 
       /* if the odd field has been acquired, then     */
       /* change the next dma location for both fields */
       /* and wake up the process if sleeping          */
-      if ( dt3155_fbuffer[ minor ]->even_happened ||
-          (dt3155_status[ minor ].state & DT3155_STATE_MODE) ==
-          DT3155_STATE_FLD )
+      if (fb->even_happened ||
+          (dts->state & DT3155_STATE_MODE) == DT3155_STATE_FLD)
        {
 
          local_save_flags(flags);
          local_irq_disable();
 
 #ifdef DEBUG_QUES_B
-         printques( minor );
+         printques(minor);
 #endif
-         if ( dt3155_fbuffer[ minor ]->nbuffers > 2 )
+         if (fb->nbuffers > 2)
            {
-             if ( !are_empty_buffers( minor ) )
+             if (!are_empty_buffers(minor))
                {
                  /* The number of active + locked buffers is
                   * at most 2, and since there are none empty, there
                   * must be at least nbuffers-2 ready buffers.
                   * This is where we 'drop frames', oldest first. */
-                 push_empty( pop_ready( minor ),  minor );
+                 push_empty(pop_ready(minor),  minor);
                }
 
              /* The ready_que can't be full, since we know
               * there is one active buffer right now, so it's safe
               * to push the active buf on the ready_que. */
-             push_ready( minor, dt3155_fbuffer[ minor ]->active_buf );
+             push_ready(minor, fb->active_buf);
              /* There's at least 1 empty -- make it active */
-             dt3155_fbuffer[ minor ]->active_buf = pop_empty( minor );
-             dt3155_fbuffer[ minor ]->
-               frame_info[ dt3155_fbuffer[ minor ]->
-                           active_buf ].tag = ++unique_tag;
+             fb->active_buf = pop_empty(minor);
+             fb->frame_info[fb->active_buf].tag = ++unique_tag;
            }
          else /* nbuffers == 2, special case */
            { /* There is 1 active buffer.
               * If there is a locked buffer, keep the active buffer
               * the same -- that means we drop a frame.
               */
-             if ( dt3155_fbuffer[ minor ]->locked_buf < 0 )
+             if (fb->locked_buf < 0)
                {
-                 push_ready( minor,
-                             dt3155_fbuffer[ minor ]->active_buf );
-                 if (are_empty_buffers( minor ) )
+                 push_ready(minor, fb->active_buf);
+                 if (are_empty_buffers(minor))
                    {
-                     dt3155_fbuffer[ minor ]->active_buf =
-                       pop_empty( minor );
+                     fb->active_buf = pop_empty(minor);
                    }
                  else
                    { /* no empty or locked buffers, so use a readybuf */
-                     dt3155_fbuffer[ minor ]->active_buf =
-                       pop_ready( minor );
+                     fb->active_buf = pop_ready(minor);
                    }
                }
            }
 
 #ifdef DEBUG_QUES_B
-         printques( minor );
+         printques(minor);
 #endif
 
-         dt3155_fbuffer[ minor ]->even_happened = 0;
+         fb->even_happened = 0;
 
-         wake_up_interruptible( &dt3155_read_wait_queue[ minor ] );
+         wake_up_interruptible(&dt3155_read_wait_queue[minor]);
 
          local_irq_restore(flags);
        }
 
 
       /* Set up the DMA address for the next frame/field */
-      buffer_addr = dt3155_fbuffer[ minor ]->
-       frame_info[ dt3155_fbuffer[ minor ]->active_buf ].addr;
-      if ( (dt3155_status[ minor ].state & DT3155_STATE_MODE) ==
-          DT3155_STATE_FLD )
+      buffer_addr = fb->frame_info[fb->active_buf].addr;
+      if ((dts->state & DT3155_STATE_MODE) == DT3155_STATE_FLD)
        {
-         WriteMReg((dt3155_lbase[ minor ] + EVEN_DMA_START), buffer_addr);
+         writel(buffer_addr, mmio + EVEN_DMA_START);
        }
       else
        {
-         WriteMReg((dt3155_lbase[ minor ] + EVEN_DMA_START), buffer_addr);
+         writel(buffer_addr, mmio + EVEN_DMA_START);
 
-         WriteMReg((dt3155_lbase[ minor ] + ODD_DMA_START), buffer_addr
-                   + dt3155_status[ minor ].config.cols);
+         writel(buffer_addr + dts->config.cols, mmio + ODD_DMA_START);
        }
 
       /* Do error checking */
       i2c_odd_csr.fld.DONE_ODD = 1;
-      if ( i2c_odd_csr.fld.ERROR_ODD )
+      if (i2c_odd_csr.fld.ERROR_ODD)
        dt3155_errno = DT_ERR_OVERRUN;
 
-      WriteI2C(dt3155_lbase[ minor ], ODD_CSR, i2c_odd_csr.reg );
+      WriteI2C(mmio, ODD_CSR, i2c_odd_csr.reg);
 
       return;
     }
   /* If we get here, the Odd Field wasn't it either... */
-  printk( "neither even nor odd.  shared perhaps?\n");
+  printk("neither even nor odd.  shared perhaps?\n");
 }
 
 /*****************************************************
@@ -420,43 +409,37 @@ static inline void dt3155_isr( int irq, void *dev_id, struct pt_regs *regs )
  *****************************************************/
 static void dt3155_init_isr(int minor)
 {
-  const u32 stride =  dt3155_status[ minor ].config.cols;
+  struct dt3155_status *dts = &dt3155_status[minor];
+  struct dt3155_fbuffer *fb = &dts->fbuffer;
+  const u32 stride = dts->config.cols;
+  void __iomem *mmio = dt3155_lbase[minor];
 
-  switch (dt3155_status[ minor ].state & DT3155_STATE_MODE)
+  switch (dts->state & DT3155_STATE_MODE)
     {
     case DT3155_STATE_FLD:
       {
-       even_dma_start_r  = dt3155_status[ minor ].
-         fbuffer.frame_info[ dt3155_status[ minor ].fbuffer.active_buf ].addr;
+       even_dma_start_r  = fb->frame_info[fb->active_buf].addr;
        even_dma_stride_r = 0;
        odd_dma_stride_r  = 0;
 
-       WriteMReg((dt3155_lbase[ minor ] + EVEN_DMA_START),
-                 even_dma_start_r);
-       WriteMReg((dt3155_lbase[ minor ] + EVEN_DMA_STRIDE),
-                 even_dma_stride_r);
-       WriteMReg((dt3155_lbase[ minor ] + ODD_DMA_STRIDE),
-                 odd_dma_stride_r);
+       writel(even_dma_start_r, mmio + EVEN_DMA_START);
+       writel(even_dma_stride_r, mmio + EVEN_DMA_STRIDE);
+       writel(odd_dma_stride_r, mmio + ODD_DMA_STRIDE);
        break;
       }
 
     case DT3155_STATE_FRAME:
     default:
       {
-       even_dma_start_r  = dt3155_status[ minor ].
-         fbuffer.frame_info[ dt3155_status[ minor ].fbuffer.active_buf ].addr;
+       even_dma_start_r  = fb->frame_info[fb->active_buf].addr;
        odd_dma_start_r   =  even_dma_start_r + stride;
        even_dma_stride_r =  stride;
        odd_dma_stride_r  =  stride;
 
-       WriteMReg((dt3155_lbase[ minor ] + EVEN_DMA_START),
-                 even_dma_start_r);
-       WriteMReg((dt3155_lbase[ minor ] + ODD_DMA_START),
-                 odd_dma_start_r);
-       WriteMReg((dt3155_lbase[ minor ] + EVEN_DMA_STRIDE),
-                 even_dma_stride_r);
-       WriteMReg((dt3155_lbase[ minor ] + ODD_DMA_STRIDE),
-                 odd_dma_stride_r);
+       writel(even_dma_start_r, mmio + EVEN_DMA_START);
+       writel(odd_dma_start_r, mmio + ODD_DMA_START);
+       writel(even_dma_stride_r, mmio + EVEN_DMA_STRIDE);
+       writel(odd_dma_stride_r, mmio + ODD_DMA_STRIDE);
        break;
       }
     }
@@ -464,9 +447,9 @@ static void dt3155_init_isr(int minor)
   /* 50/60 Hz should be set before this point but let's make sure it is */
   /* right anyway */
 
-  ReadI2C(dt3155_lbase[ minor ], CSR2, &i2c_csr2.reg);
+  ReadI2C(mmio, CSR2, &i2c_csr2.reg);
   i2c_csr2.fld.HZ50 = FORMAT50HZ;
-  WriteI2C(dt3155_lbase[ minor ], CSR2, i2c_csr2.reg);
+  WriteI2C(mmio, CSR2, i2c_csr2.reg);
 
   /* enable busmaster chip, clear flags */
 
@@ -486,7 +469,7 @@ static void dt3155_init_isr(int minor)
   csr1_r.fld.FLD_CRPT_EVE   = 1; /* writing a 1 clears flags */
   csr1_r.fld.FLD_CRPT_ODD   = 1;
 
-  WriteMReg((dt3155_lbase[ minor ] + CSR1),csr1_r.reg);
+  writel(csr1_r.reg, mmio + CSR1);
 
   /* Enable interrupts at the end of each field */
 
@@ -495,14 +478,14 @@ static void dt3155_init_isr(int minor)
   int_csr_r.fld.FLD_END_ODD_EN = 1;
   int_csr_r.fld.FLD_START_EN = 0;
 
-  WriteMReg((dt3155_lbase[ minor ] + INT_CSR), int_csr_r.reg);
+  writel(int_csr_r.reg, mmio + INT_CSR);
 
   /* start internal BUSY bits */
 
-  ReadI2C(dt3155_lbase[ minor ], CSR2, &i2c_csr2.reg);
+  ReadI2C(mmio, CSR2, &i2c_csr2.reg);
   i2c_csr2.fld.BUSY_ODD  = 1;
   i2c_csr2.fld.BUSY_EVE  = 1;
-  WriteI2C(dt3155_lbase[ minor ], CSR2, i2c_csr2.reg);
+  WriteI2C(mmio, CSR2, i2c_csr2.reg);
 
   /* Now its up to the interrupt routine!! */
 
@@ -520,8 +503,11 @@ static int dt3155_ioctl(struct inode *inode,
                        unsigned long arg)
 {
   int minor = MINOR(inode->i_rdev); /* What device are we ioctl()'ing? */
+  void __user *up = (void __user *)arg;
+  struct dt3155_status *dts = &dt3155_status[minor];
+  struct dt3155_fbuffer *fb = &dts->fbuffer;
 
-  if ( minor >= MAXBOARDS || minor < 0 )
+  if (minor >= MAXBOARDS || minor < 0)
     return -ENODEV;
 
   /* make sure it is valid command */
@@ -541,12 +527,12 @@ static int dt3155_ioctl(struct inode *inode,
     {
     case DT3155_SET_CONFIG:
       {
-       if (dt3155_status[minor].state != DT3155_STATE_IDLE)
+       if (dts->state != DT3155_STATE_IDLE)
          return -EBUSY;
 
        {
-         struct dt3155_config_s tmp;
-         if (copy_from_user((void *)&tmp, (void *) arg, sizeof(tmp)))
+         struct dt3155_config tmp;
+         if (copy_from_user(&tmp, up, sizeof(tmp)))
              return -EFAULT;
          /* check for valid settings */
          if (tmp.rows > DT3155_MAX_ROWS ||
@@ -558,59 +544,55 @@ static int dt3155_ioctl(struct inode *inode,
            {
              return -EINVAL;
            }
-         dt3155_status[minor].config = tmp;
+         dts->config = tmp;
        }
        return 0;
       }
     case DT3155_GET_CONFIG:
       {
-       if (copy_to_user((void *) arg, (void *) &dt3155_status[minor],
-                    sizeof(dt3155_status_t) ))
+       if (copy_to_user(up, dts, sizeof(*dts)))
            return -EFAULT;
        return 0;
       }
     case DT3155_FLUSH: /* Flushes the buffers -- ensures fresh data */
       {
-       if (dt3155_status[minor].state != DT3155_STATE_IDLE)
+       if (dts->state != DT3155_STATE_IDLE)
          return -EBUSY;
        return dt3155_flush(minor);
       }
     case DT3155_STOP:
       {
-       if (dt3155_status[minor].state & DT3155_STATE_STOP ||
-           dt3155_status[minor].fbuffer.stop_acquire)
+       if (dts->state & DT3155_STATE_STOP || fb->stop_acquire)
          return -EBUSY;
 
-       if (dt3155_status[minor].state == DT3155_STATE_IDLE)
+       if (dts->state == DT3155_STATE_IDLE)
          return 0;
 
        quick_stop(minor);
-       if (copy_to_user((void *) arg, (void *) &dt3155_status[minor],
-                    sizeof(dt3155_status_t)))
+       if (copy_to_user(up, dts, sizeof(*dts)))
            return -EFAULT;
        return 0;
       }
     case DT3155_START:
       {
-       if (dt3155_status[minor].state != DT3155_STATE_IDLE)
+       if (dts->state != DT3155_STATE_IDLE)
          return -EBUSY;
 
-       dt3155_status[minor].fbuffer.stop_acquire = 0;
-       dt3155_status[minor].fbuffer.frame_count = 0;
+       fb->stop_acquire = 0;
+       fb->frame_count = 0;
 
        /* Set the MODE in the status -- we default to FRAME */
-       if (dt3155_status[minor].config.acq_mode == DT3155_MODE_FIELD)
+       if (dts->config.acq_mode == DT3155_MODE_FIELD)
          {
-           dt3155_status[minor].state = DT3155_STATE_FLD;
+           dts->state = DT3155_STATE_FLD;
          }
        else
          {
-           dt3155_status[minor].state = DT3155_STATE_FRAME;
+           dts->state = DT3155_STATE_FRAME;
          }
 
        dt3155_init_isr(minor);
-       if (copy_to_user( (void *) arg, (void *) &dt3155_status[minor],
-                     sizeof(dt3155_status_t)))
+       if (copy_to_user(up, dts, sizeof(*dts)))
            return -EFAULT;
        return 0;
       }
@@ -639,7 +621,8 @@ static int dt3155_ioctl(struct inode *inode,
 static int dt3155_mmap (struct file * file, struct vm_area_struct * vma)
 {
   /* which device are we mmapping? */
-  int                          minor = MINOR(file->f_dentry->d_inode->i_rdev);
+  int minor = MINOR(file->f_dentry->d_inode->i_rdev);
+  struct dt3155_status *dts = &dt3155_status[minor];
   unsigned long        offset;
   offset = vma->vm_pgoff << PAGE_SHIFT;
 
@@ -650,10 +633,10 @@ static int dt3155_mmap (struct file * file, struct vm_area_struct * vma)
   vma->vm_flags |= VM_RESERVED;
 
   /* they are mapping the registers or the buffer */
-  if ((offset == dt3155_status[minor].reg_addr &&
+  if ((offset == dts->reg_addr &&
        vma->vm_end - vma->vm_start == PCI_PAGE_SIZE) ||
-      (offset == dt3155_status[minor].mem_addr &&
-       vma->vm_end - vma->vm_start == dt3155_status[minor].mem_size))
+      (offset == dts->mem_addr &&
+       vma->vm_end - vma->vm_start == dts->mem_size))
     {
       if (remap_pfn_range(vma,
                        vma->vm_start,
@@ -681,36 +664,38 @@ static int dt3155_mmap (struct file * file, struct vm_area_struct * vma)
  * MOD_INC_USE_COUNT make sure that the driver memory is not freed
  * while the device is in use.
  *****************************************************/
-static int dt3155_open( struct inode* inode, struct file* filep)
+static int dt3155_open(struct inode* inode, struct file* filep)
 {
   int minor = MINOR(inode->i_rdev); /* what device are we opening? */
-  if (dt3155_dev_open[ minor ]) {
+  struct dt3155_status *dts = &dt3155_status[minor];
+
+  if (dt3155_dev_open[minor]) {
     printk ("DT3155:  Already opened by another process.\n");
     return -EBUSY;
   }
 
-  if (dt3155_status[ minor ].device_installed==0)
+  if (dts->device_installed==0)
     {
       printk("DT3155 Open Error: No such device dt3155 minor number %d\n",
             minor);
       return -EIO;
     }
 
-  if (dt3155_status[ minor ].state != DT3155_STATE_IDLE) {
+  if (dts->state != DT3155_STATE_IDLE) {
     printk ("DT3155:  Not in idle state (state = %x)\n",
-           dt3155_status[ minor ].state);
+           dts->state);
     return -EBUSY;
   }
 
   printk("DT3155: Device opened.\n");
 
-  dt3155_dev_open[ minor ] = 1 ;
+  dt3155_dev_open[minor] = 1 ;
 
-  dt3155_flush( minor );
+  dt3155_flush(minor);
 
   /* Disable ALL interrupts */
   int_csr_r.reg = 0;
-  WriteMReg( (dt3155_lbase[ minor ] + INT_CSR), int_csr_r.reg );
+  writel(int_csr_r.reg, dt3155_lbase[minor] + INT_CSR);
 
   init_waitqueue_head(&(dt3155_read_wait_queue[minor]));
 
@@ -724,20 +709,20 @@ static int dt3155_open( struct inode* inode, struct file* filep)
  * Now decrement the use count.
  *
  *****************************************************/
-static int dt3155_close( struct inode *inode, struct file *filep)
+static int dt3155_close(struct inode *inode, struct file *filep)
 {
-  int minor;
+  int minor = MINOR(inode->i_rdev); /* which device are we closing */
+  struct dt3155_status *dts = &dt3155_status[minor];
 
-  minor = MINOR(inode->i_rdev); /* which device are we closing */
-  if (!dt3155_dev_open[ minor ])
+  if (!dt3155_dev_open[minor])
     {
       printk("DT3155: attempt to CLOSE a not OPEN device\n");
     }
   else
     {
-      dt3155_dev_open[ minor ] = 0;
+      dt3155_dev_open[minor] = 0;
 
-      if (dt3155_status[ minor ].state != DT3155_STATE_IDLE)
+      if (dts->state != DT3155_STATE_IDLE)
        {
          quick_stop(minor);
        }
@@ -756,11 +741,13 @@ static ssize_t dt3155_read(struct file *filep, char __user *buf,
   int          minor = MINOR(filep->f_dentry->d_inode->i_rdev);
   u32          offset;
   int          frame_index;
-  frame_info_t *frame_info_p;
+  struct dt3155_status *dts = &dt3155_status[minor];
+  struct dt3155_fbuffer *fb = &dts->fbuffer;
+  struct frame_info    *frame_info;
 
   /* TODO: this should check the error flag and */
   /*   return an error on hardware failures */
-  if (count != sizeof(dt3155_read_t))
+  if (count != sizeof(struct dt3155_read))
     {
       printk("DT3155 ERROR (NJC): count is not right\n");
       return -EINVAL;
@@ -774,14 +761,14 @@ static ssize_t dt3155_read(struct file *filep, char __user *buf,
    * Note that if the driver is not opened in non_blocking mode,
    * and the device is idle, then it could sit here forever! */
 
-  /*  if (dt3155_status[minor].state == DT3155_STATE_IDLE)*/
+  /*  if (dts->state == DT3155_STATE_IDLE)*/
   /*    return -EBUSY;*/
 
   /* non-blocking reads should return if no data */
   if (filep->f_flags & O_NDELAY)
     {
       if ((frame_index = dt3155_get_ready_buffer(minor)) < 0) {
-       /*printk( "dt3155:  no buffers available (?)\n");*/
+       /*printk("dt3155:  no buffers available (?)\n");*/
        /*              printques(minor); */
        return -EAGAIN;
       }
@@ -806,21 +793,21 @@ static ssize_t dt3155_read(struct file *filep, char __user *buf,
        }
     }
 
-  frame_info_p = &dt3155_status[minor].fbuffer.frame_info[frame_index];
+  frame_info = &fb->frame_info[frame_index];
 
   /* make this an offset */
-  offset = frame_info_p->addr - dt3155_status[minor].mem_addr;
+  offset = frame_info->addr - dts->mem_addr;
 
-  put_user(offset, (unsigned int *) buf);
+  put_user(offset, (unsigned int __user *)buf);
   buf += sizeof(u32);
-  put_user( dt3155_status[minor].fbuffer.frame_count, (unsigned int *) buf);
+  put_user(fb->frame_count, (unsigned int __user *)buf);
   buf += sizeof(u32);
-  put_user(dt3155_status[minor].state, (unsigned int *) buf);
+  put_user(dts->state, (unsigned int __user *)buf);
   buf += sizeof(u32);
-  if (copy_to_user(buf, frame_info_p, sizeof(frame_info_t)))
+  if (copy_to_user(buf, frame_info, sizeof(*frame_info)))
       return -EFAULT;
 
-  return sizeof(dt3155_read_t);
+  return sizeof(struct dt3155_read);
 }
 
 static unsigned int dt3155_poll (struct file * filp, poll_table *wait)
@@ -835,6 +822,17 @@ static unsigned int dt3155_poll (struct file * filp, poll_table *wait)
   return 0;
 }
 
+static long
+dt3155_unlocked_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
+{
+       int ret;
+
+       lock_kernel();
+       ret = dt3155_ioctl(file->f_path.dentry->d_inode, file, cmd, arg);
+       unlock_kernel();
+
+       return ret;
+}
 
 /*****************************************************
  * file operations supported by DT3155 driver
@@ -842,12 +840,12 @@ static unsigned int dt3155_poll (struct file * filp, poll_table *wait)
  *  register_chrdev
  *****************************************************/
 static struct file_operations dt3155_fops = {
-  read:                dt3155_read,
-  ioctl:               dt3155_ioctl,
-  mmap:                dt3155_mmap,
-  poll:           dt3155_poll,
-  open:                dt3155_open,
-  release:     dt3155_close
+       .read           = dt3155_read,
+       .unlocked_ioctl = dt3155_unlocked_ioctl,
+       .mmap           = dt3155_mmap,
+       .poll           = dt3155_poll,
+       .open           = dt3155_open,
+       .release        = dt3155_close
 };
 
 
@@ -859,6 +857,7 @@ static struct file_operations dt3155_fops = {
 static int find_PCI (void)
 {
   struct pci_dev *pci_dev = NULL;
+  struct dt3155_status *dts;
   int error, pci_index = 0;
   unsigned short rev_device;
   unsigned long base;
@@ -867,7 +866,7 @@ static int find_PCI (void)
   while ((pci_dev = pci_get_device
          (DT3155_VENDORID, DT3155_DEVICEID, pci_dev)) != NULL)
     {
-      pci_index ++;
+      dts = &dt3155_status[pci_index++];
 
       /* Is it really there? */
       if ((error =
@@ -889,7 +888,7 @@ static int find_PCI (void)
 
       /* Now, just go out and make sure that this/these device(s) is/are
         actually mapped into the kernel address space */
-      if ((error = pci_read_config_dword( pci_dev, PCI_BASE_ADDRESS_0,
+      if ((error = pci_read_config_dword(pci_dev, PCI_BASE_ADDRESS_0,
                                          (u32 *) &base)))
        {
          printk("DT3155: Was not able to find device \n");
@@ -897,43 +896,43 @@ static int find_PCI (void)
        }
 
       DT_3155_DEBUG_MSG("DT3155: Base address 0 for device is %lx \n", base);
-      dt3155_status[pci_index-1].reg_addr = base;
+      dts->reg_addr = base;
 
       /* Remap the base address to a logical address through which we
        * can access it. */
-      dt3155_lbase[ pci_index - 1 ] = ioremap(base,PCI_PAGE_SIZE);
-      dt3155_status[ pci_index - 1 ].reg_addr = base;
+      dt3155_lbase[pci_index - 1] = ioremap(base, PCI_PAGE_SIZE);
+      dts->reg_addr = base;
       DT_3155_DEBUG_MSG("DT3155: New logical address is %p \n",
                        dt3155_lbase[pci_index-1]);
-      if ( !dt3155_lbase[pci_index-1] )
+      if (!dt3155_lbase[pci_index-1])
        {
          printk("DT3155: Unable to remap control registers\n");
          goto err;
        }
 
-      if ( (error = pci_read_config_byte( pci_dev, PCI_INTERRUPT_LINE, &irq)) )
+      if ((error = pci_read_config_byte(pci_dev, PCI_INTERRUPT_LINE, &irq)))
        {
          printk("DT3155: Was not able to find device \n");
          goto err;
        }
 
       DT_3155_DEBUG_MSG("DT3155: IRQ is %d \n",irq);
-      dt3155_status[ pci_index-1 ].irq = irq;
+      dts->irq = irq;
       /* Set flag: kth device found! */
-      dt3155_status[ pci_index-1 ].device_installed = 1;
+      dts->device_installed = 1;
       printk("DT3155: Installing device %d w/irq %d and address %p\n",
             pci_index,
-            dt3155_status[pci_index-1].irq,
+            dts->irq,
             dt3155_lbase[pci_index-1]);
 
     }
   ndevices = pci_index;
 
-  return DT_3155_SUCCESS;
+  return 0;
 
 err:
   pci_dev_put(pci_dev);
-  return DT_3155_FAILURE;
+  return -EIO;
 }
 
 u32 allocatorAddr = 0;
@@ -943,91 +942,98 @@ u32 allocatorAddr = 0;
  *****************************************************/
 int init_module(void)
 {
+  struct dt3155_status *dts;
   int index;
   int rcode = 0;
-  char *devname[ MAXBOARDS ];
+  char *devname[MAXBOARDS];
 
-  devname[ 0 ] = "dt3155a";
+  devname[0] = "dt3155a";
 #if MAXBOARDS == 2
-  devname[ 1 ] = "dt3155b";
+  devname[1] = "dt3155b";
 #endif
 
   printk("DT3155: Loading module...\n");
 
   /* Register the device driver */
-  rcode = register_chrdev( dt3155_major, "dt3155", &dt3155_fops );
-  if( rcode < 0 )
+  rcode = register_chrdev(dt3155_major, "dt3155", &dt3155_fops);
+  if(rcode < 0)
     {
-      printk( KERN_INFO "DT3155: register_chrdev failed \n");
+      printk(KERN_INFO "DT3155: register_chrdev failed \n");
       return rcode;
     }
 
-  if( dt3155_major == 0 )
+  if(dt3155_major == 0)
     dt3155_major = rcode; /* dynamic */
 
 
   /* init the status variables.                     */
   /* DMA memory is taken care of in setup_buffers() */
-  for ( index = 0; index < MAXBOARDS; index++ )
+  for (index = 0; index < MAXBOARDS; index++)
     {
-      dt3155_status[ index ].config.acq_mode   = DT3155_MODE_FRAME;
-      dt3155_status[ index ].config.continuous = DT3155_ACQ;
-      dt3155_status[ index ].config.cols       = DT3155_MAX_COLS;
-      dt3155_status[ index ].config.rows       = DT3155_MAX_ROWS;
-      dt3155_status[ index ].state = DT3155_STATE_IDLE;
+      dts = &dt3155_status[index];
+
+      dts->config.acq_mode   = DT3155_MODE_FRAME;
+      dts->config.continuous = DT3155_ACQ;
+      dts->config.cols       = DT3155_MAX_COLS;
+      dts->config.rows       = DT3155_MAX_ROWS;
+      dts->state = DT3155_STATE_IDLE;
 
       /* find_PCI() will check if devices are installed; */
       /* first assume they're not:                       */
-      dt3155_status[ index ].mem_addr          = 0;
-      dt3155_status[ index ].mem_size          = 0;
-      dt3155_status[ index ].state             = DT3155_STATE_IDLE;
-      dt3155_status[ index ].device_installed  = 0;
+      dts->mem_addr          = 0;
+      dts->mem_size          = 0;
+      dts->state             = DT3155_STATE_IDLE;
+      dts->device_installed  = 0;
     }
 
   /* Now let's find the hardware.  find_PCI() will set ndevices to the
    * number of cards found in this machine. */
     {
-      if ( (rcode = find_PCI()) !=  DT_3155_SUCCESS )
+      if ((rcode = find_PCI()) != 0)
        {
          printk("DT3155 error: find_PCI() failed to find dt3155 board(s)\n");
-         unregister_chrdev( dt3155_major, "dt3155" );
+         unregister_chrdev(dt3155_major, "dt3155");
          return rcode;
        }
     }
 
   /* Ok, time to setup the frame buffers */
-  if( (rcode = dt3155_setup_buffers(&allocatorAddr)) < 0 )
+  if((rcode = dt3155_setup_buffers(&allocatorAddr)) < 0)
     {
       printk("DT3155: Error: setting up buffer not large enough.");
-      unregister_chrdev( dt3155_major, "dt3155" );
+      unregister_chrdev(dt3155_major, "dt3155");
       return rcode;
     }
 
   /* If we are this far, then there is enough RAM */
   /* for the buffers: Print the configuration.    */
-  for(  index = 0;  index < ndevices;  index++ )
+  for( index = 0;  index < ndevices;  index++)
     {
+      dts = &dt3155_status[index];
+
       printk("DT3155: Device = %d; acq_mode = %d; "
             "continuous = %d; cols = %d; rows = %d;\n",
             index ,
-            dt3155_status[ index ].config.acq_mode,
-            dt3155_status[ index ].config.continuous,
-            dt3155_status[ index ].config.cols,
-            dt3155_status[ index ].config.rows);
+            dts->config.acq_mode,
+            dts->config.continuous,
+            dts->config.cols,
+            dts->config.rows);
       printk("DT3155: m_addr = 0x%x; m_size = %ld; "
             "state = %d; device_installed = %d\n",
-            dt3155_status[ index ].mem_addr,
-            (long int)dt3155_status[ index ].mem_size,
-            dt3155_status[ index ].state,
-            dt3155_status[ index ].device_installed);
+            dts->mem_addr,
+            (long int)dts->mem_size,
+            dts->state,
+            dts->device_installed);
     }
 
   /* Disable ALL interrupts */
   int_csr_r.reg = 0;
-  for(  index = 0;  index < ndevices;  index++ )
+  for( index = 0;  index < ndevices;  index++)
     {
-      WriteMReg( (dt3155_lbase[ index ] + INT_CSR), int_csr_r.reg );
-      if( dt3155_status[ index ].device_installed )
+      dts = &dt3155_status[index];
+
+      writel(int_csr_r.reg, dt3155_lbase[index] + INT_CSR);
+      if(dts->device_installed)
        {
          /*
           * This driver *looks* like it can handle sharing interrupts,
@@ -1036,14 +1042,14 @@ int init_module(void)
           * as a reminder in case any problems arise. (SS)
           */
          /* in older kernels flags are: SA_SHIRQ | SA_INTERRUPT */
-         rcode = request_irq( dt3155_status[ index ].irq, (void *)dt3155_isr,
-                              IRQF_SHARED | IRQF_DISABLED, devname[ index ],
-                              (void*) &dt3155_status[index]);
-         if( rcode < 0 )
+         rcode = request_irq(dts->irq, (void *)dt3155_isr,
+                              IRQF_SHARED | IRQF_DISABLED, devname[index],
+                              (void *)dts);
+         if(rcode < 0)
            {
              printk("DT3155: minor %d request_irq failed for IRQ %d\n",
-                    index, dt3155_status[index].irq);
-             unregister_chrdev( dt3155_major, "dt3155" );
+                    index, dts->irq);
+             unregister_chrdev(dt3155_major, "dt3155");
              return rcode;
            }
        }
@@ -1060,6 +1066,7 @@ int init_module(void)
  *****************************************************/
 void cleanup_module(void)
 {
+  struct dt3155_status *dts;
   int index;
 
   printk("DT3155:  cleanup_module called\n");
@@ -1072,15 +1079,16 @@ void cleanup_module(void)
   allocator_cleanup();
 #endif
 
-  unregister_chrdev( dt3155_major, "dt3155" );
+  unregister_chrdev(dt3155_major, "dt3155");
 
-  for( index = 0; index < ndevices; index++ )
+  for(index = 0; index < ndevices; index++)
     {
-      if( dt3155_status[ index ].device_installed == 1 )
+      dts = &dt3155_status[index];
+      if(dts->device_installed == 1)
        {
-         printk( "DT3155: Freeing irq %d for device %d\n",
-                 dt3155_status[ index ].irq, index );
-         free_irq( dt3155_status[ index ].irq, (void*)&dt3155_status[index] );
+         printk("DT3155: Freeing irq %d for device %d\n",
+                 dts->irq, index);
+         free_irq(dts->irq, (void *)dts);
        }
     }
 }