Staging: hv: Get rid of the forward declaration of blkvsc_open()
[firefly-linux-kernel-4.4.55.git] / drivers / staging / hv / blkvsc_drv.c
index 838567defb98ef4b0e53f2773179ac02c250708c..797bcdbd2a51f517f076abe85eef60e60bf0afe0 100644 (file)
@@ -72,9 +72,6 @@ struct blkvsc_request {
        /* The group this request is part of. Maybe null */
        struct blkvsc_request_group *group;
 
-       wait_queue_head_t wevent;
-       int cond;
-
        int write;
        sector_t sector_start;
        unsigned long sector_count;
@@ -109,6 +106,7 @@ struct block_device_context {
        int users;
 };
 
+static DEFINE_MUTEX(blkvsc_mutex);
 
 static const char *g_blk_driver_name = "blkvsc";
 
@@ -187,16 +185,102 @@ static int blk_vsc_initialize(struct hv_driver *driver)
        return ret;
 }
 
+
+static int blkvsc_submit_request(struct blkvsc_request *blkvsc_req,
+                       void (*request_completion)(struct hv_storvsc_request *))
+{
+       struct block_device_context *blkdev = blkvsc_req->dev;
+       struct hv_device *device_ctx = blkdev->device_ctx;
+       struct hv_driver *drv =
+                       drv_to_hv_drv(device_ctx->device.driver);
+       struct storvsc_driver_object *storvsc_drv_obj =
+                       drv->priv;
+       struct hv_storvsc_request *storvsc_req;
+       struct vmscsi_request *vm_srb;
+       int ret;
+
+       DPRINT_DBG(BLKVSC_DRV, "blkvsc_submit_request() - "
+                  "req %p type %s start_sector %lu count %ld offset %d "
+                  "len %d\n", blkvsc_req,
+                  (blkvsc_req->write) ? "WRITE" : "READ",
+                  (unsigned long) blkvsc_req->sector_start,
+                  blkvsc_req->sector_count,
+                  blkvsc_req->request.data_buffer.offset,
+                  blkvsc_req->request.data_buffer.len);
+#if 0
+       for (i = 0; i < (blkvsc_req->request.data_buffer.len >> 12); i++) {
+               DPRINT_DBG(BLKVSC_DRV, "blkvsc_submit_request() - "
+                          "req %p pfn[%d] %llx\n",
+                          blkvsc_req, i,
+                          blkvsc_req->request.data_buffer.pfn_array[i]);
+       }
+#endif
+
+       storvsc_req = &blkvsc_req->request;
+       vm_srb = &storvsc_req->vstor_packet.vm_srb;
+
+       vm_srb->data_in = blkvsc_req->write ? WRITE_TYPE : READ_TYPE;
+
+       storvsc_req->on_io_completion = request_completion;
+       storvsc_req->context = blkvsc_req;
+
+       vm_srb->port_number = blkdev->port;
+       vm_srb->path_id = blkdev->path;
+       vm_srb->target_id = blkdev->target;
+       vm_srb->lun = 0;         /* this is not really used at all */
+
+       vm_srb->cdb_length = blkvsc_req->cmd_len;
+
+       memcpy(vm_srb->cdb, blkvsc_req->cmnd, vm_srb->cdb_length);
+
+       storvsc_req->sense_buffer = blkvsc_req->sense_buffer;
+
+       ret = storvsc_drv_obj->on_io_request(blkdev->device_ctx,
+                                          &blkvsc_req->request);
+       if (ret == 0)
+               blkdev->num_outstanding_reqs++;
+
+       return ret;
+}
+
+
+static unsigned int blkvsc_check_events(struct gendisk *gd,
+                                       unsigned int clearing)
+{
+       DPRINT_DBG(BLKVSC_DRV, "- enter\n");
+       return DISK_EVENT_MEDIA_CHANGE;
+}
+
+
+static int blkvsc_open(struct block_device *bdev, fmode_t mode)
+{
+       struct block_device_context *blkdev = bdev->bd_disk->private_data;
+
+       DPRINT_DBG(BLKVSC_DRV, "- users %d disk %s\n", blkdev->users,
+                  blkdev->gd->disk_name);
+
+       mutex_lock(&blkvsc_mutex);
+       spin_lock(&blkdev->lock);
+
+       if (!blkdev->users && blkdev->device_type == DVD_TYPE) {
+               spin_unlock(&blkdev->lock);
+               check_disk_change(bdev);
+               spin_lock(&blkdev->lock);
+       }
+
+       blkdev->users++;
+
+       spin_unlock(&blkdev->lock);
+       mutex_unlock(&blkvsc_mutex);
+       return 0;
+}
+
 /* Static decl */
-static DEFINE_MUTEX(blkvsc_mutex);
 static int blkvsc_probe(struct device *dev);
 static int blkvsc_remove(struct device *device);
 static void blkvsc_shutdown(struct device *device);
 
-static int blkvsc_open(struct block_device *bdev,  fmode_t mode);
 static int blkvsc_release(struct gendisk *disk, fmode_t mode);
-static unsigned int blkvsc_check_events(struct gendisk *gd,
-                                       unsigned int clearing);
 static int blkvsc_revalidate_disk(struct gendisk *gd);
 static int blkvsc_getgeo(struct block_device *bd, struct hd_geometry *hg);
 static int blkvsc_ioctl(struct block_device *bd, fmode_t mode,
@@ -205,8 +289,6 @@ static void blkvsc_request(struct request_queue *queue);
 static void blkvsc_request_completion(struct hv_storvsc_request *request);
 static int blkvsc_do_request(struct block_device_context *blkdev,
                             struct request *req);
-static int blkvsc_submit_request(struct blkvsc_request *blkvsc_req,
-               void (*request_completion)(struct hv_storvsc_request *));
 static void blkvsc_init_rw(struct blkvsc_request *blkvsc_req);
 static void blkvsc_cmd_completion(struct hv_storvsc_request *request);
 static int blkvsc_do_inquiry(struct block_device_context *blkdev);
@@ -517,7 +599,7 @@ static int blkvsc_do_flush(struct block_device_context *blkdev)
                return -ENOMEM;
 
        memset(blkvsc_req, 0, sizeof(struct blkvsc_request));
-       init_waitqueue_head(&blkvsc_req->wevent);
+       init_completion(&blkvsc_req->request.wait_event);
        blkvsc_req->dev = blkdev;
        blkvsc_req->req = NULL;
        blkvsc_req->write = 0;
@@ -529,14 +611,9 @@ static int blkvsc_do_flush(struct block_device_context *blkdev)
        blkvsc_req->cmnd[0] = SYNCHRONIZE_CACHE;
        blkvsc_req->cmd_len = 10;
 
-       /*
-        * Set this here since the completion routine may be invoked and
-        * completed before we return
-        */
-       blkvsc_req->cond = 0;
        blkvsc_submit_request(blkvsc_req, blkvsc_cmd_completion);
 
-       wait_event_interruptible(blkvsc_req->wevent, blkvsc_req->cond);
+       wait_for_completion_interruptible(&blkvsc_req->request.wait_event);
 
        kmem_cache_free(blkvsc_req->dev->request_pool, blkvsc_req);
 
@@ -564,12 +641,13 @@ static int blkvsc_do_inquiry(struct block_device_context *blkdev)
                return -ENOMEM;
        }
 
-       init_waitqueue_head(&blkvsc_req->wevent);
+       init_completion(&blkvsc_req->request.wait_event);
        blkvsc_req->dev = blkdev;
        blkvsc_req->req = NULL;
        blkvsc_req->write = 0;
 
-       blkvsc_req->request.data_buffer.pfn_array[0] = page_to_pfn(page_buf);
+       blkvsc_req->request.data_buffer.pfn_array[0] =
+       page_to_pfn(page_buf);
        blkvsc_req->request.data_buffer.offset = 0;
        blkvsc_req->request.data_buffer.len = 64;
 
@@ -579,18 +657,12 @@ static int blkvsc_do_inquiry(struct block_device_context *blkdev)
        blkvsc_req->cmnd[4] = 64;
        blkvsc_req->cmd_len = 6;
 
-       /*
-        * Set this here since the completion routine may be invoked and
-        * completed before we return
-        */
-       blkvsc_req->cond = 0;
-
        blkvsc_submit_request(blkvsc_req, blkvsc_cmd_completion);
 
-       DPRINT_DBG(BLKVSC_DRV, "waiting %p to complete - cond %d\n",
-                  blkvsc_req, blkvsc_req->cond);
+       DPRINT_DBG(BLKVSC_DRV, "waiting %p to complete\n",
+                  blkvsc_req);
 
-       wait_event_interruptible(blkvsc_req->wevent, blkvsc_req->cond);
+       wait_for_completion_interruptible(&blkvsc_req->request.wait_event);
 
        buf = kmap(page_buf);
 
@@ -633,6 +705,7 @@ static int blkvsc_do_read_capacity(struct block_device_context *blkdev)
        struct page *page_buf;
        unsigned char *buf;
        struct scsi_sense_hdr sense_hdr;
+       struct vmscsi_request *vm_srb;
 
        DPRINT_DBG(BLKVSC_DRV, "blkvsc_do_read_capacity()\n");
 
@@ -651,33 +724,29 @@ static int blkvsc_do_read_capacity(struct block_device_context *blkdev)
                return -ENOMEM;
        }
 
-       init_waitqueue_head(&blkvsc_req->wevent);
+       vm_srb = &blkvsc_req->request.vstor_packet.vm_srb;
+       init_completion(&blkvsc_req->request.wait_event);
        blkvsc_req->dev = blkdev;
        blkvsc_req->req = NULL;
        blkvsc_req->write = 0;
 
-       blkvsc_req->request.data_buffer.pfn_array[0] = page_to_pfn(page_buf);
+       blkvsc_req->request.data_buffer.pfn_array[0] =
+       page_to_pfn(page_buf);
        blkvsc_req->request.data_buffer.offset = 0;
        blkvsc_req->request.data_buffer.len = 8;
 
        blkvsc_req->cmnd[0] = READ_CAPACITY;
        blkvsc_req->cmd_len = 16;
 
-       /*
-        * Set this here since the completion routine may be invoked
-        * and completed before we return
-        */
-       blkvsc_req->cond = 0;
-
        blkvsc_submit_request(blkvsc_req, blkvsc_cmd_completion);
 
-       DPRINT_DBG(BLKVSC_DRV, "waiting %p to complete - cond %d\n",
-                  blkvsc_req, blkvsc_req->cond);
+       DPRINT_DBG(BLKVSC_DRV, "waiting %p to complete\n",
+                  blkvsc_req);
 
-       wait_event_interruptible(blkvsc_req->wevent, blkvsc_req->cond);
+       wait_for_completion_interruptible(&blkvsc_req->request.wait_event);
 
        /* check error */
-       if (blkvsc_req->request.status) {
+       if (vm_srb->scsi_status) {
                scsi_normalize_sense(blkvsc_req->sense_buffer,
                                     SCSI_SENSE_BUFFERSIZE, &sense_hdr);
 
@@ -710,6 +779,7 @@ static int blkvsc_do_read_capacity16(struct block_device_context *blkdev)
        struct page *page_buf;
        unsigned char *buf;
        struct scsi_sense_hdr sense_hdr;
+       struct vmscsi_request *vm_srb;
 
        DPRINT_DBG(BLKVSC_DRV, "blkvsc_do_read_capacity16()\n");
 
@@ -722,18 +792,20 @@ static int blkvsc_do_read_capacity16(struct block_device_context *blkdev)
                return -ENOMEM;
 
        memset(blkvsc_req, 0, sizeof(struct blkvsc_request));
+       vm_srb = &blkvsc_req->request.vstor_packet.vm_srb;
        page_buf = alloc_page(GFP_KERNEL);
        if (!page_buf) {
                kmem_cache_free(blkvsc_req->dev->request_pool, blkvsc_req);
                return -ENOMEM;
        }
 
-       init_waitqueue_head(&blkvsc_req->wevent);
+       init_completion(&blkvsc_req->request.wait_event);
        blkvsc_req->dev = blkdev;
        blkvsc_req->req = NULL;
        blkvsc_req->write = 0;
 
-       blkvsc_req->request.data_buffer.pfn_array[0] = page_to_pfn(page_buf);
+       blkvsc_req->request.data_buffer.pfn_array[0] =
+       page_to_pfn(page_buf);
        blkvsc_req->request.data_buffer.offset = 0;
        blkvsc_req->request.data_buffer.len = 12;
 
@@ -744,17 +816,16 @@ static int blkvsc_do_read_capacity16(struct block_device_context *blkdev)
         * Set this here since the completion routine may be invoked
         * and completed before we return
         */
-       blkvsc_req->cond = 0;
 
        blkvsc_submit_request(blkvsc_req, blkvsc_cmd_completion);
 
-       DPRINT_DBG(BLKVSC_DRV, "waiting %p to complete - cond %d\n",
-                  blkvsc_req, blkvsc_req->cond);
+       DPRINT_DBG(BLKVSC_DRV, "waiting %p to complete\n",
+                  blkvsc_req);
 
-       wait_event_interruptible(blkvsc_req->wevent, blkvsc_req->cond);
+       wait_for_completion_interruptible(&blkvsc_req->request.wait_event);
 
        /* check error */
-       if (blkvsc_req->request.status) {
+       if (vm_srb->scsi_status) {
                scsi_normalize_sense(blkvsc_req->sense_buffer,
                                     SCSI_SENSE_BUFFERSIZE, &sense_hdr);
                if (sense_hdr.asc == 0x3A) {
@@ -905,66 +976,10 @@ static void blkvsc_init_rw(struct blkvsc_request *blkvsc_req)
        }
 }
 
-static int blkvsc_submit_request(struct blkvsc_request *blkvsc_req,
-                       void (*request_completion)(struct hv_storvsc_request *))
-{
-       struct block_device_context *blkdev = blkvsc_req->dev;
-       struct hv_device *device_ctx = blkdev->device_ctx;
-       struct hv_driver *drv =
-                       drv_to_hv_drv(device_ctx->device.driver);
-       struct storvsc_driver_object *storvsc_drv_obj =
-                       drv->priv;
-       struct hv_storvsc_request *storvsc_req;
-       struct vmscsi_request *vm_srb;
-       int ret;
-
-       DPRINT_DBG(BLKVSC_DRV, "blkvsc_submit_request() - "
-                  "req %p type %s start_sector %lu count %ld offset %d "
-                  "len %d\n", blkvsc_req,
-                  (blkvsc_req->write) ? "WRITE" : "READ",
-                  (unsigned long) blkvsc_req->sector_start,
-                  blkvsc_req->sector_count,
-                  blkvsc_req->request.data_buffer.offset,
-                  blkvsc_req->request.data_buffer.len);
-#if 0
-       for (i = 0; i < (blkvsc_req->request.data_buffer.len >> 12); i++) {
-               DPRINT_DBG(BLKVSC_DRV, "blkvsc_submit_request() - "
-                          "req %p pfn[%d] %llx\n",
-                          blkvsc_req, i,
-                          blkvsc_req->request.data_buffer.pfn_array[i]);
-       }
-#endif
-
-       storvsc_req = &blkvsc_req->request;
-       vm_srb = &storvsc_req->extension.vstor_packet.vm_srb;
-
-       vm_srb->data_in = blkvsc_req->write ? WRITE_TYPE : READ_TYPE;
-
-       storvsc_req->on_io_completion = request_completion;
-       storvsc_req->context = blkvsc_req;
-
-       vm_srb->port_number = blkdev->port;
-       vm_srb->path_id = blkdev->path;
-       vm_srb->target_id = blkdev->target;
-       vm_srb->lun = 0;         /* this is not really used at all */
-
-       vm_srb->cdb_length = blkvsc_req->cmd_len;
-
-       memcpy(vm_srb->cdb, blkvsc_req->cmnd, vm_srb->cdb_length);
-
-       storvsc_req->sense_buffer = blkvsc_req->sense_buffer;
-
-       ret = storvsc_drv_obj->on_io_request(blkdev->device_ctx,
-                                          &blkvsc_req->request);
-       if (ret == 0)
-               blkdev->num_outstanding_reqs++;
-
-       return ret;
-}
 
 /*
  * We break the request into 1 or more blkvsc_requests and submit
- * them.  If we cant submit them all, we put them on the
+ * them.  If we can't submit them all, we put them on the
  * pending_list. The blkvsc_request() will work on the pending_list.
  */
 static int blkvsc_do_request(struct block_device_context *blkdev,
@@ -1052,10 +1067,11 @@ static int blkvsc_do_request(struct block_device_context *blkdev,
 
                                        blkvsc_req->dev = blkdev;
                                        blkvsc_req->req = req;
-                                       blkvsc_req->request.data_buffer.offset
-                                               = bvec->bv_offset;
-                                       blkvsc_req->request.data_buffer.len
-                                               = 0;
+                                       blkvsc_req->request.
+                                       data_buffer.offset
+                                       = bvec->bv_offset;
+                                       blkvsc_req->request.
+                                       data_buffer.len = 0;
 
                                        /* Add to the group */
                                        blkvsc_req->group = group;
@@ -1142,19 +1158,20 @@ static void blkvsc_cmd_completion(struct hv_storvsc_request *request)
        struct block_device_context *blkdev =
                        (struct block_device_context *)blkvsc_req->dev;
        struct scsi_sense_hdr sense_hdr;
+       struct vmscsi_request *vm_srb;
 
        DPRINT_DBG(BLKVSC_DRV, "blkvsc_cmd_completion() - req %p\n",
                   blkvsc_req);
 
+       vm_srb = &blkvsc_req->request.vstor_packet.vm_srb;
        blkdev->num_outstanding_reqs--;
 
-       if (blkvsc_req->request.status)
+       if (vm_srb->scsi_status)
                if (scsi_normalize_sense(blkvsc_req->sense_buffer,
                                         SCSI_SENSE_BUFFERSIZE, &sense_hdr))
                        scsi_print_sense_hdr("blkvsc", &sense_hdr);
 
-       blkvsc_req->cond = 1;
-       wake_up_interruptible(&blkvsc_req->wevent);
+       complete(&blkvsc_req->request.wait_event);
 }
 
 static void blkvsc_request_completion(struct hv_storvsc_request *request)
@@ -1165,6 +1182,7 @@ static void blkvsc_request_completion(struct hv_storvsc_request *request)
                        (struct block_device_context *)blkvsc_req->dev;
        unsigned long flags;
        struct blkvsc_request *comp_req, *tmp;
+       struct vmscsi_request *vm_srb;
 
        /* ASSERT(blkvsc_req->group); */
 
@@ -1201,8 +1219,10 @@ static void blkvsc_request_completion(struct hv_storvsc_request *request)
 
                        list_del(&comp_req->req_entry);
 
+                       vm_srb =
+                       &comp_req->request.vstor_packet.vm_srb;
                        if (!__blk_end_request(comp_req->req,
-                               (!comp_req->request.status ? 0 : -EIO),
+                               (!vm_srb->scsi_status ? 0 : -EIO),
                                comp_req->sector_count * blkdev->sector_size)) {
                                /*
                                 * All the sectors have been xferred ie the
@@ -1231,6 +1251,7 @@ static int blkvsc_cancel_pending_reqs(struct block_device_context *blkdev)
 {
        struct blkvsc_request *pend_req, *tmp;
        struct blkvsc_request *comp_req, *tmp2;
+       struct vmscsi_request *vm_srb;
 
        int ret = 0;
 
@@ -1259,8 +1280,11 @@ static int blkvsc_cancel_pending_reqs(struct block_device_context *blkdev)
                        list_del(&comp_req->req_entry);
 
                        if (comp_req->req) {
+                               vm_srb =
+                               &comp_req->request.vstor_packet.
+                               vm_srb;
                                ret = __blk_end_request(comp_req->req,
-                                       (!comp_req->request.status ? 0 : -EIO),
+                                       (!vm_srb->scsi_status ? 0 : -EIO),
                                        comp_req->sector_count *
                                        blkdev->sector_size);
 
@@ -1366,29 +1390,6 @@ static void blkvsc_request(struct request_queue *queue)
        }
 }
 
-static int blkvsc_open(struct block_device *bdev, fmode_t mode)
-{
-       struct block_device_context *blkdev = bdev->bd_disk->private_data;
-
-       DPRINT_DBG(BLKVSC_DRV, "- users %d disk %s\n", blkdev->users,
-                  blkdev->gd->disk_name);
-
-       mutex_lock(&blkvsc_mutex);
-       spin_lock(&blkdev->lock);
-
-       if (!blkdev->users && blkdev->device_type == DVD_TYPE) {
-               spin_unlock(&blkdev->lock);
-               check_disk_change(bdev);
-               spin_lock(&blkdev->lock);
-       }
-
-       blkdev->users++;
-
-       spin_unlock(&blkdev->lock);
-       mutex_unlock(&blkvsc_mutex);
-       return 0;
-}
-
 static int blkvsc_release(struct gendisk *disk, fmode_t mode)
 {
        struct block_device_context *blkdev = disk->private_data;
@@ -1411,13 +1412,6 @@ static int blkvsc_release(struct gendisk *disk, fmode_t mode)
        return 0;
 }
 
-static unsigned int blkvsc_check_events(struct gendisk *gd,
-                                       unsigned int clearing)
-{
-       DPRINT_DBG(BLKVSC_DRV, "- enter\n");
-       return DISK_EVENT_MEDIA_CHANGE;
-}
-
 static int blkvsc_revalidate_disk(struct gendisk *gd)
 {
        struct block_device_context *blkdev = gd->private_data;