/*
- * Copyright 2012 Facebook, Inc.
+ * Copyright 2016 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* limitations under the License.
*/
-#include "folly/Arena.h"
-#include "folly/StlAllocator.h"
+#include <folly/Arena.h>
+#include <folly/Memory.h>
+#include <folly/portability/GTest.h>
#include <set>
#include <vector>
#include <glog/logging.h>
-#include <gtest/gtest.h>
using namespace folly;
+static_assert(IsArenaAllocator<SysArena>::value, "");
+
TEST(Arena, SizeSanity) {
std::set<size_t*> allocatedItems;
size_t* ptr = static_cast<size_t*>(arena.allocate(sizeof(long)));
allocatedItems.insert(ptr);
minimum_size += requestedBlockSize;
- maximum_size += goodMallocSize(requestedBlockSize + 1);
+ maximum_size += goodMallocSize(requestedBlockSize + SysArena::kBlockOverhead);
EXPECT_TRUE(arena.totalSize() >= minimum_size);
EXPECT_TRUE(arena.totalSize() <= maximum_size);
VLOG(4) << minimum_size << " < " << arena.totalSize() << " < "
allocatedItems.insert(ptr);
}
minimum_size += 10 * requestedBlockSize;
- maximum_size += 10 * goodMallocSize(requestedBlockSize + 1);
+ maximum_size += 10 * goodMallocSize(requestedBlockSize
+ + SysArena::kBlockOverhead);
EXPECT_TRUE(arena.totalSize() >= minimum_size);
EXPECT_TRUE(arena.totalSize() <= maximum_size);
VLOG(4) << minimum_size << " < " << arena.totalSize() << " < "
ptr = static_cast<size_t*>(arena.allocate(10 * requestedBlockSize));
allocatedItems.insert(ptr);
minimum_size += 10 * requestedBlockSize;
- maximum_size += goodMallocSize(10 * requestedBlockSize + 1);
+ maximum_size += goodMallocSize(10 * requestedBlockSize
+ + SysArena::kBlockOverhead);
EXPECT_TRUE(arena.totalSize() >= minimum_size);
EXPECT_TRUE(arena.totalSize() <= maximum_size);
VLOG(4) << minimum_size << " < " << arena.totalSize() << " < "
<< maximum_size;
}
+TEST(Arena, BytesUsedSanity) {
+ static const size_t smallChunkSize = 1024;
+ static const size_t blockSize = goodMallocSize(16 * smallChunkSize);
+ const size_t bigChunkSize = blockSize - 4 * smallChunkSize;
+
+ size_t bytesUsed = 0;
+
+ SysArena arena(blockSize);
+ EXPECT_EQ(arena.bytesUsed(), bytesUsed);
+
+ // Insert 2 small chunks
+ arena.allocate(smallChunkSize);
+ arena.allocate(smallChunkSize);
+ bytesUsed += 2 * smallChunkSize;
+ EXPECT_EQ(arena.bytesUsed(), bytesUsed);
+ EXPECT_TRUE(arena.totalSize() >= blockSize);
+ EXPECT_TRUE(arena.totalSize() <= 2 * blockSize);
+
+ // Insert big chunk, should still fit in one block
+ arena.allocate(bigChunkSize);
+ bytesUsed += bigChunkSize;
+ EXPECT_EQ(arena.bytesUsed(), bytesUsed);
+ EXPECT_TRUE(arena.totalSize() >= blockSize);
+ EXPECT_TRUE(arena.totalSize() <= 2 * blockSize);
+
+ // Insert big chunk once more, should trigger new block allocation
+ arena.allocate(bigChunkSize);
+ bytesUsed += bigChunkSize;
+ EXPECT_EQ(arena.bytesUsed(), bytesUsed);
+ EXPECT_TRUE(arena.totalSize() >= 2 * blockSize);
+ EXPECT_TRUE(arena.totalSize() <= 3 * blockSize);
+
+ // Test that bytesUsed() accounts for alignment
+ static const size_t tinyChunkSize = 7;
+ arena.allocate(tinyChunkSize);
+ EXPECT_TRUE(arena.bytesUsed() >= bytesUsed + tinyChunkSize);
+ size_t delta = arena.bytesUsed() - bytesUsed;
+ EXPECT_EQ(delta & (delta - 1), 0);
+}
+
TEST(Arena, Vector) {
static const size_t requestedBlockSize = 64;
SysArena arena(requestedBlockSize);
}
}
+TEST(Arena, SizeLimit) {
+ static const size_t requestedBlockSize = sizeof(size_t);
+ static const size_t maxSize = 10 * requestedBlockSize;
+
+ SysArena arena(requestedBlockSize, maxSize);
+
+ void* a = arena.allocate(sizeof(size_t));
+ EXPECT_TRUE(a != nullptr);
+ EXPECT_THROW(arena.allocate(maxSize + 1), std::bad_alloc);
+}
+
+TEST(Arena, MoveArena) {
+ SysArena arena(sizeof(size_t) * 2);
+ arena.allocate(sizeof(size_t));
+ auto totalSize = arena.totalSize();
+ auto bytesUsed = arena.bytesUsed();
+
+ SysArena moved(std::move(arena));
+ EXPECT_EQ(totalSize, moved.totalSize());
+ EXPECT_EQ(bytesUsed, moved.bytesUsed());
+}
+
int main(int argc, char *argv[]) {
testing::InitGoogleTest(&argc, argv);
- google::ParseCommandLineFlags(&argc, &argv, true);
+ gflags::ParseCommandLineFlags(&argc, &argv, true);
auto ret = RUN_ALL_TESTS();
return ret;
}