[PATCH] swsusp: Fix mark_free_pages
[firefly-linux-kernel-4.4.55.git] / kernel / power / snapshot.c
index 3d9284100b22105e5323adf37c3ab4aff46e4391..4afb7900002bafc7e8d07a9db3c141db4dfa975a 100644 (file)
@@ -39,90 +39,8 @@ static unsigned int nr_copy_pages;
 static unsigned int nr_meta_pages;
 static unsigned long *buffer;
 
-struct arch_saveable_page {
-       unsigned long start;
-       unsigned long end;
-       char *data;
-       struct arch_saveable_page *next;
-};
-static struct arch_saveable_page *arch_pages;
-
-int swsusp_add_arch_pages(unsigned long start, unsigned long end)
-{
-       struct arch_saveable_page *tmp;
-
-       while (start < end) {
-               tmp = kzalloc(sizeof(struct arch_saveable_page), GFP_KERNEL);
-               if (!tmp)
-                       return -ENOMEM;
-               tmp->start = start;
-               tmp->end = ((start >> PAGE_SHIFT) + 1) << PAGE_SHIFT;
-               if (tmp->end > end)
-                       tmp->end = end;
-               tmp->next = arch_pages;
-               start = tmp->end;
-               arch_pages = tmp;
-       }
-       return 0;
-}
-
-static unsigned int count_arch_pages(void)
-{
-       unsigned int count = 0;
-       struct arch_saveable_page *tmp = arch_pages;
-       while (tmp) {
-               count++;
-               tmp = tmp->next;
-       }
-       return count;
-}
-
-static int save_arch_mem(void)
-{
-       char *kaddr;
-       struct arch_saveable_page *tmp = arch_pages;
-       int offset;
-
-       pr_debug("swsusp: Saving arch specific memory");
-       while (tmp) {
-               tmp->data = (char *)__get_free_page(GFP_ATOMIC);
-               if (!tmp->data)
-                       return -ENOMEM;
-               offset = tmp->start - (tmp->start & PAGE_MASK);
-               /* arch pages might haven't a 'struct page' */
-               kaddr = kmap_atomic_pfn(tmp->start >> PAGE_SHIFT, KM_USER0);
-               memcpy(tmp->data + offset, kaddr + offset,
-                       tmp->end - tmp->start);
-               kunmap_atomic(kaddr, KM_USER0);
-
-               tmp = tmp->next;
-       }
-       return 0;
-}
-
-static int restore_arch_mem(void)
-{
-       char *kaddr;
-       struct arch_saveable_page *tmp = arch_pages;
-       int offset;
-
-       while (tmp) {
-               if (!tmp->data)
-                       continue;
-               offset = tmp->start - (tmp->start & PAGE_MASK);
-               kaddr = kmap_atomic_pfn(tmp->start >> PAGE_SHIFT, KM_USER0);
-               memcpy(kaddr + offset, tmp->data + offset,
-                       tmp->end - tmp->start);
-               kunmap_atomic(kaddr, KM_USER0);
-               free_page((long)tmp->data);
-               tmp->data = NULL;
-               tmp = tmp->next;
-       }
-       return 0;
-}
-
 #ifdef CONFIG_HIGHMEM
-static unsigned int count_highmem_pages(void)
+unsigned int count_highmem_pages(void)
 {
        struct zone *zone;
        unsigned long zone_pfn;
@@ -199,7 +117,7 @@ static int save_highmem_zone(struct zone *zone)
        return 0;
 }
 
-static int save_highmem(void)
+int save_highmem(void)
 {
        struct zone *zone;
        int res = 0;
@@ -216,7 +134,7 @@ static int save_highmem(void)
        return 0;
 }
 
-static int restore_highmem(void)
+int restore_highmem(void)
 {
        printk("swsusp: Restoring Highmem\n");
        while (highmem_copy) {
@@ -238,30 +156,7 @@ static inline int save_highmem(void) {return 0;}
 static inline int restore_highmem(void) {return 0;}
 #endif
 
-unsigned int count_special_pages(void)
-{
-       return count_arch_pages() + count_highmem_pages();
-}
-
-int save_special_mem(void)
-{
-       int ret;
-       ret = save_arch_mem();
-       if (!ret)
-               ret = save_highmem();
-       return ret;
-}
-
-int restore_special_mem(void)
-{
-       int ret;
-       ret = restore_arch_mem();
-       if (!ret)
-               ret = restore_highmem();
-       return ret;
-}
-
-static int pfn_is_nosave(unsigned long pfn)
+static inline int pfn_is_nosave(unsigned long pfn)
 {
        unsigned long nosave_begin_pfn = __pa(&__nosave_begin) >> PAGE_SHIFT;
        unsigned long nosave_end_pfn = PAGE_ALIGN(__pa(&__nosave_end)) >> PAGE_SHIFT;
@@ -272,70 +167,77 @@ static int pfn_is_nosave(unsigned long pfn)
  *     saveable - Determine whether a page should be cloned or not.
  *     @pfn:   The page
  *
- *     We save a page if it's Reserved, and not in the range of pages
- *     statically defined as 'unsaveable', or if it isn't reserved, and
- *     isn't part of a free chunk of pages.
+ *     We save a page if it isn't Nosave, and is not in the range of pages
+ *     statically defined as 'unsaveable', and it
+ *     isn't part of a free chunk of pages.
  */
 
-static int saveable(struct zone *zone, unsigned long *zone_pfn)
+static struct page *saveable_page(unsigned long pfn)
 {
-       unsigned long pfn = *zone_pfn + zone->zone_start_pfn;
        struct page *page;
 
        if (!pfn_valid(pfn))
-               return 0;
+               return NULL;
 
        page = pfn_to_page(pfn);
+
        if (PageNosave(page))
-               return 0;
+               return NULL;
        if (PageReserved(page) && pfn_is_nosave(pfn))
-               return 0;
+               return NULL;
        if (PageNosaveFree(page))
-               return 0;
+               return NULL;
 
-       return 1;
+       return page;
 }
 
 unsigned int count_data_pages(void)
 {
        struct zone *zone;
-       unsigned long zone_pfn;
+       unsigned long pfn, max_zone_pfn;
        unsigned int n = 0;
 
        for_each_zone (zone) {
                if (is_highmem(zone))
                        continue;
                mark_free_pages(zone);
-               for (zone_pfn = 0; zone_pfn < zone->spanned_pages; ++zone_pfn)
-                       n += saveable(zone, &zone_pfn);
+               max_zone_pfn = zone->zone_start_pfn + zone->spanned_pages;
+               for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++)
+                       n += !!saveable_page(pfn);
        }
        return n;
 }
 
+static inline void copy_data_page(long *dst, long *src)
+{
+       int n;
+
+       /* copy_page and memcpy are not usable for copying task structs. */
+       for (n = PAGE_SIZE / sizeof(long); n; n--)
+               *dst++ = *src++;
+}
+
 static void copy_data_pages(struct pbe *pblist)
 {
        struct zone *zone;
-       unsigned long zone_pfn;
-       struct pbe *pbe, *p;
+       unsigned long pfn, max_zone_pfn;
+       struct pbe *pbe;
 
        pbe = pblist;
        for_each_zone (zone) {
                if (is_highmem(zone))
                        continue;
                mark_free_pages(zone);
-               /* This is necessary for swsusp_free() */
-               for_each_pb_page (p, pblist)
-                       SetPageNosaveFree(virt_to_page(p));
-               for_each_pbe (p, pblist)
-                       SetPageNosaveFree(virt_to_page(p->address));
-               for (zone_pfn = 0; zone_pfn < zone->spanned_pages; ++zone_pfn) {
-                       if (saveable(zone, &zone_pfn)) {
-                               struct page *page;
-                               page = pfn_to_page(zone_pfn + zone->zone_start_pfn);
+               max_zone_pfn = zone->zone_start_pfn + zone->spanned_pages;
+               for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++) {
+                       struct page *page = saveable_page(pfn);
+
+                       if (page) {
+                               void *ptr = page_address(page);
+
                                BUG_ON(!pbe);
-                               pbe->orig_address = (unsigned long)page_address(page);
-                               /* copy_page is not usable for copying task structs. */
-                               memcpy((void *)pbe->address, (void *)pbe->orig_address, PAGE_SIZE);
+                               copy_data_page((void *)pbe->address, ptr);
+                               pbe->orig_address = (unsigned long)ptr;
                                pbe = pbe->next;
                        }
                }
@@ -412,7 +314,7 @@ static unsigned int unsafe_pages;
  *     and we count them using unsafe_pages
  */
 
-static inline void *alloc_image_page(gfp_t gfp_mask, int safe_needed)
+static void *alloc_image_page(gfp_t gfp_mask, int safe_needed)
 {
        void *res;
 
@@ -481,13 +383,14 @@ static struct pbe *alloc_pagedir(unsigned int nr_pages, gfp_t gfp_mask,
 void swsusp_free(void)
 {
        struct zone *zone;
-       unsigned long zone_pfn;
+       unsigned long pfn, max_zone_pfn;
 
        for_each_zone(zone) {
-               for (zone_pfn = 0; zone_pfn < zone->spanned_pages; ++zone_pfn)
-                       if (pfn_valid(zone_pfn + zone->zone_start_pfn)) {
-                               struct page *page;
-                               page = pfn_to_page(zone_pfn + zone->zone_start_pfn);
+               max_zone_pfn = zone->zone_start_pfn + zone->spanned_pages;
+               for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++)
+                       if (pfn_valid(pfn)) {
+                               struct page *page = pfn_to_page(pfn);
+
                                if (PageNosave(page) && PageNosaveFree(page)) {
                                        ClearPageNosave(page);
                                        ClearPageNosaveFree(page);
@@ -651,7 +554,7 @@ static inline struct pbe *pack_orig_addresses(unsigned long *buf, struct pbe *pb
 
 int snapshot_read_next(struct snapshot_handle *handle, size_t count)
 {
-       if (handle->page > nr_meta_pages + nr_copy_pages)
+       if (handle->cur > nr_meta_pages + nr_copy_pages)
                return 0;
        if (!buffer) {
                /* This makes the buffer be freed by swsusp_free() */
@@ -664,8 +567,8 @@ int snapshot_read_next(struct snapshot_handle *handle, size_t count)
                handle->buffer = buffer;
                handle->pbe = pagedir_nosave;
        }
-       if (handle->prev < handle->page) {
-               if (handle->page <= nr_meta_pages) {
+       if (handle->prev < handle->cur) {
+               if (handle->cur <= nr_meta_pages) {
                        handle->pbe = pack_orig_addresses(buffer, handle->pbe);
                        if (!handle->pbe)
                                handle->pbe = pagedir_nosave;
@@ -673,15 +576,15 @@ int snapshot_read_next(struct snapshot_handle *handle, size_t count)
                        handle->buffer = (void *)handle->pbe->address;
                        handle->pbe = handle->pbe->next;
                }
-               handle->prev = handle->page;
+               handle->prev = handle->cur;
        }
-       handle->buf_offset = handle->page_offset;
-       if (handle->page_offset + count >= PAGE_SIZE) {
-               count = PAGE_SIZE - handle->page_offset;
-               handle->page_offset = 0;
-               handle->page++;
+       handle->buf_offset = handle->cur_offset;
+       if (handle->cur_offset + count >= PAGE_SIZE) {
+               count = PAGE_SIZE - handle->cur_offset;
+               handle->cur_offset = 0;
+               handle->cur++;
        } else {
-               handle->page_offset += count;
+               handle->cur_offset += count;
        }
        handle->offset += count;
        return count;
@@ -696,7 +599,7 @@ int snapshot_read_next(struct snapshot_handle *handle, size_t count)
 static int mark_unsafe_pages(struct pbe *pblist)
 {
        struct zone *zone;
-       unsigned long zone_pfn;
+       unsigned long pfn, max_zone_pfn;
        struct pbe *p;
 
        if (!pblist) /* a sanity check */
@@ -704,10 +607,10 @@ static int mark_unsafe_pages(struct pbe *pblist)
 
        /* Clear page flags */
        for_each_zone (zone) {
-               for (zone_pfn = 0; zone_pfn < zone->spanned_pages; ++zone_pfn)
-                       if (pfn_valid(zone_pfn + zone->zone_start_pfn))
-                               ClearPageNosaveFree(pfn_to_page(zone_pfn +
-                                       zone->zone_start_pfn));
+               max_zone_pfn = zone->zone_start_pfn + zone->spanned_pages;
+               for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++)
+                       if (pfn_valid(pfn))
+                               ClearPageNosaveFree(pfn_to_page(pfn));
        }
 
        /* Mark orig addresses */
@@ -916,7 +819,7 @@ int snapshot_write_next(struct snapshot_handle *handle, size_t count)
 {
        int error = 0;
 
-       if (handle->prev && handle->page > nr_meta_pages + nr_copy_pages)
+       if (handle->prev && handle->cur > nr_meta_pages + nr_copy_pages)
                return 0;
        if (!buffer) {
                /* This makes the buffer be freed by swsusp_free() */
@@ -926,13 +829,16 @@ int snapshot_write_next(struct snapshot_handle *handle, size_t count)
        }
        if (!handle->offset)
                handle->buffer = buffer;
-       if (handle->prev < handle->page) {
+       handle->sync_read = 1;
+       if (handle->prev < handle->cur) {
                if (!handle->prev) {
-                       error = load_header(handle, (struct swsusp_info *)buffer);
+                       error = load_header(handle,
+                                       (struct swsusp_info *)buffer);
                        if (error)
                                return error;
                } else if (handle->prev <= nr_meta_pages) {
-                       handle->pbe = unpack_orig_addresses(buffer, handle->pbe);
+                       handle->pbe = unpack_orig_addresses(buffer,
+                                                       handle->pbe);
                        if (!handle->pbe) {
                                error = prepare_image(handle);
                                if (error)
@@ -940,20 +846,22 @@ int snapshot_write_next(struct snapshot_handle *handle, size_t count)
                                handle->pbe = pagedir_nosave;
                                handle->last_pbe = NULL;
                                handle->buffer = get_buffer(handle);
+                               handle->sync_read = 0;
                        }
                } else {
                        handle->pbe = handle->pbe->next;
                        handle->buffer = get_buffer(handle);
+                       handle->sync_read = 0;
                }
-               handle->prev = handle->page;
+               handle->prev = handle->cur;
        }
-       handle->buf_offset = handle->page_offset;
-       if (handle->page_offset + count >= PAGE_SIZE) {
-               count = PAGE_SIZE - handle->page_offset;
-               handle->page_offset = 0;
-               handle->page++;
+       handle->buf_offset = handle->cur_offset;
+       if (handle->cur_offset + count >= PAGE_SIZE) {
+               count = PAGE_SIZE - handle->cur_offset;
+               handle->cur_offset = 0;
+               handle->cur++;
        } else {
-               handle->page_offset += count;
+               handle->cur_offset += count;
        }
        handle->offset += count;
        return count;
@@ -962,5 +870,5 @@ int snapshot_write_next(struct snapshot_handle *handle, size_t count)
 int snapshot_image_loaded(struct snapshot_handle *handle)
 {
        return !(!handle->pbe || handle->pbe->next || !nr_copy_pages ||
-               handle->page <= nr_meta_pages + nr_copy_pages);
+               handle->cur <= nr_meta_pages + nr_copy_pages);
 }