[mips] Marked up instructions added in MIPS-IV and tested that IAS for -mcpu=mips...

[oota-llvm.git] / lib / Object / YAML.cpp

diff --git a/lib/Object/YAML.cpp b/lib/Object/YAML.cpp
index e63bd5df27ccabd030b84ec495544b1af78cc491..61e9da30395970221b36e7fcd2cb0a5fd62c45a1 100644 (file)
--- a/lib/Object/YAML.cpp
+++ b/lib/Object/YAML.cpp
@@ -13,7 +13,9 @@
 //===----------------------------------------------------------------------===//
 
 #include "llvm/Object/YAML.h"
+#include "llvm/ADT/StringExtras.h"
 #include "llvm/Support/raw_ostream.h"
+#include <cctype>
 
 using namespace llvm;
 using namespace object::yaml;
@@ -23,14 +25,6 @@ void yaml::ScalarTraits<object::yaml::BinaryRef>::output(
   Val.writeAsHex(Out);
 }
 
-// Can't find this anywhere else in the codebase (clang has one, but it has
-// some baggage). Deduplicate as required.
-static bool isHexDigit(uint8_t C) {
-  return ('0' <= C && C <= '9') ||
-         ('A' <= C && C <= 'F') ||
-         ('a' <= C && C <= 'f');
-}
-
 StringRef yaml::ScalarTraits<object::yaml::BinaryRef>::input(
     StringRef Scalar, void *, object::yaml::BinaryRef &Val) {
   if (Scalar.size() % 2 != 0)
@@ -38,7 +32,7 @@ StringRef yaml::ScalarTraits<object::yaml::BinaryRef>::input(
   // TODO: Can we improve YAMLIO to permit a more accurate diagnostic here?
   // (e.g. a caret pointing to the offending character).
   for (unsigned I = 0, N = Scalar.size(); I != N; ++I)
-    if (!isHexDigit(Scalar[I]))
+    if (!isxdigit(Scalar[I]))
       return "BinaryRef hex string must contain only hex digits.";
   Val = object::yaml::BinaryRef(Scalar);
   return StringRef();
@@ -57,6 +51,8 @@ void BinaryRef::writeAsBinary(raw_ostream &OS) const {
 }
 
 void BinaryRef::writeAsHex(raw_ostream &OS) const {
+  if (binary_size() == 0)
+    return;
   if (DataIsHexString) {
     OS.write((const char *)Data.data(), Data.size());
     return;