-//===- ADCE.cpp - Code to perform agressive dead code elimination ---------===//
+//===- ADCE.cpp - Code to perform aggressive dead code elimination --------===//
//
-// This file implements "agressive" dead code elimination. ADCE is DCe where
+// This file implements "aggressive" dead code elimination. ADCE is DCe where
// values are assumed to be dead until proven otherwise. This is similar to
// SCCP, except applied to the liveness of values.
//
//===----------------------------------------------------------------------===//
-#include "llvm/Optimizations/DCE.h"
-#include "llvm/Instruction.h"
+#include "llvm/Transforms/Scalar.h"
+#include "llvm/Transforms/Utils/Local.h"
#include "llvm/Type.h"
#include "llvm/Analysis/Dominators.h"
-#include "llvm/Support/STLExtras.h"
-#include "llvm/Support/DepthFirstIterator.h"
-#include "llvm/Analysis/Writer.h"
#include "llvm/iTerminators.h"
-#include <set>
+#include "llvm/iPHINode.h"
+#include "llvm/Constant.h"
+#include "llvm/Support/CFG.h"
+#include "Support/STLExtras.h"
+#include "Support/DepthFirstIterator.h"
+#include "Support/StatisticReporter.h"
#include <algorithm>
+#include <iostream>
+using std::cerr;
+using std::vector;
-#define DEBUG_ADCE 1
+static Statistic<> NumBlockRemoved("adce\t\t- Number of basic blocks removed");
+static Statistic<> NumInstRemoved ("adce\t\t- Number of instructions removed");
+
+namespace {
//===----------------------------------------------------------------------===//
// ADCE Class
//
-// This class does all of the work of Agressive Dead Code Elimination.
+// This class does all of the work of Aggressive Dead Code Elimination.
// It's public interface consists of a constructor and a doADCE() method.
//
-class ADCE {
- Method *M; // The method that we are working on...
- vector<Instruction*> WorkList; // Instructions that just became live
- set<Instruction*> LiveSet; // The set of live instructions
- bool MadeChanges;
+class ADCE : public FunctionPass {
+ Function *Func; // The function that we are working on
+ std::vector<Instruction*> WorkList; // Instructions that just became live
+ std::set<Instruction*> LiveSet; // The set of live instructions
//===--------------------------------------------------------------------===//
// The public interface for this class
//
public:
- // ADCE Ctor - Save the method to operate on...
- inline ADCE(Method *m) : M(m), MadeChanges(false) {}
+ // Execute the Aggressive Dead Code Elimination Algorithm
+ //
+ virtual bool runOnFunction(Function &F) {
+ Func = &F;
+ bool Changed = doADCE();
+ assert(WorkList.empty());
+ LiveSet.clear();
+ return Changed;
+ }
+ // getAnalysisUsage - We require post dominance frontiers (aka Control
+ // Dependence Graph)
+ virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+ AU.addRequired(PostDominatorTree::ID);
+ AU.addRequired(PostDominanceFrontier::ID);
+ }
- // doADCE() - Run the Agressive Dead Code Elimination algorithm, returning
- // true if the method was modified.
- bool doADCE();
//===--------------------------------------------------------------------===//
// The implementation of this class
//
private:
+ // doADCE() - Run the Aggressive Dead Code Elimination algorithm, returning
+ // true if the function was modified.
+ //
+ bool doADCE();
+
+ void markBlockAlive(BasicBlock *BB);
+
inline void markInstructionLive(Instruction *I) {
if (LiveSet.count(I)) return;
-#ifdef DEBUG_ADCE
- cerr << "Insn Live: " << I;
-#endif
+ DEBUG(cerr << "Insn Live: " << I);
LiveSet.insert(I);
WorkList.push_back(I);
}
inline void markTerminatorLive(const BasicBlock *BB) {
-#ifdef DEBUG_ADCE
- cerr << "Terminat Live: " << BB->getTerminator();
-#endif
+ DEBUG(cerr << "Terminat Live: " << BB->getTerminator());
markInstructionLive((Instruction*)BB->getTerminator());
}
-
- // fixupCFG - Walk the CFG in depth first order, eliminating references to
- // dead blocks.
- //
- BasicBlock *fixupCFG(BasicBlock *Head, set<BasicBlock*> &VisitedBlocks,
- const set<BasicBlock*> &AliveBlocks);
};
+ RegisterOpt<ADCE> X("adce", "Aggressive Dead Code Elimination");
+} // End of anonymous namespace
+Pass *createAggressiveDCEPass() { return new ADCE(); }
-// doADCE() - Run the Agressive Dead Code Elimination algorithm, returning
-// true if the method was modified.
-//
-bool ADCE::doADCE() {
- // Compute the control dependence graph... Note that this has a side effect
- // on the CFG: a new return bb is added and all returns are merged here.
+void ADCE::markBlockAlive(BasicBlock *BB) {
+ // Mark the basic block as being newly ALIVE... and mark all branches that
+ // this block is control dependant on as being alive also...
//
- cfg::DominanceFrontier CDG(cfg::DominatorSet(M, true));
+ PostDominanceFrontier &CDG = getAnalysis<PostDominanceFrontier>();
+
+ PostDominanceFrontier::const_iterator It = CDG.find(BB);
+ if (It != CDG.end()) {
+ // Get the blocks that this node is control dependant on...
+ const PostDominanceFrontier::DomSetType &CDB = It->second;
+ for_each(CDB.begin(), CDB.end(), // Mark all their terminators as live
+ bind_obj(this, &ADCE::markTerminatorLive));
+ }
+
+ // If this basic block is live, then the terminator must be as well!
+ markTerminatorLive(BB);
+}
-#ifdef DEBUG_ADCE
- cerr << "Method: " << M;
-#endif
- // Iterate over all of the instructions in the method, eliminating trivially
+// doADCE() - Run the Aggressive Dead Code Elimination algorithm, returning
+// true if the function was modified.
+//
+bool ADCE::doADCE() {
+ bool MadeChanges = false;
+
+ // Iterate over all of the instructions in the function, eliminating trivially
// dead instructions, and marking instructions live that are known to be
// needed. Perform the walk in depth first order so that we avoid marking any
// instructions live in basic blocks that are unreachable. These blocks will
// be eliminated later, along with the instructions inside.
//
- for (df_iterator<Method*> BBI = df_begin(M),
- BBE = df_end(M);
+ for (df_iterator<Function*> BBI = df_begin(Func), BBE = df_end(Func);
BBI != BBE; ++BBI) {
BasicBlock *BB = *BBI;
for (BasicBlock::iterator II = BB->begin(), EI = BB->end(); II != EI; ) {
- Instruction *I = *II;
-
- if (I->hasSideEffects() || I->getOpcode() == Instruction::Ret) {
- markInstructionLive(I);
+ if (II->hasSideEffects() || II->getOpcode() == Instruction::Ret) {
+ markInstructionLive(II);
+ ++II; // Increment the inst iterator if the inst wasn't deleted
+ } else if (isInstructionTriviallyDead(II)) {
+ // Remove the instruction from it's basic block...
+ II = BB->getInstList().erase(II);
+ ++NumInstRemoved;
+ MadeChanges = true;
} else {
- // Check to see if anything is trivially dead
- if (I->use_size() == 0 && I->getType() != Type::VoidTy) {
- // Remove the instruction from it's basic block...
- delete BB->getInstList().remove(II);
- MadeChanges = true;
- continue; // Don't increment the iterator past the current slot
- }
+ ++II; // Increment the inst iterator if the inst wasn't deleted
}
-
- ++II; // Increment the inst iterator if the inst wasn't deleted
}
}
-#ifdef DEBUG_ADCE
- cerr << "Processing work list\n";
-#endif
+ DEBUG(cerr << "Processing work list\n");
// AliveBlocks - Set of basic blocks that we know have instructions that are
// alive in them...
//
- set<BasicBlock*> AliveBlocks;
+ std::set<BasicBlock*> AliveBlocks;
// Process the work list of instructions that just became live... if they
// became live, then that means that all of their operands are neccesary as
WorkList.pop_back();
BasicBlock *BB = I->getParent();
- if (AliveBlocks.count(BB) == 0) { // Basic block not alive yet...
- // Mark the basic block as being newly ALIVE... and mark all branches that
- // this block is control dependant on as being alive also...
- //
- AliveBlocks.insert(BB); // Block is now ALIVE!
- cfg::DominanceFrontier::const_iterator It = CDG.find(BB);
- if (It != CDG.end()) {
- // Get the blocks that this node is control dependant on...
- const cfg::DominanceFrontier::DomSetType &CDB = It->second;
- for_each(CDB.begin(), CDB.end(), // Mark all their terminators as live
- bind_obj(this, &ADCE::markTerminatorLive));
- }
-
- // If this basic block is live, then the terminator must be as well!
- markTerminatorLive(BB);
+ if (!AliveBlocks.count(BB)) { // Basic block not alive yet...
+ AliveBlocks.insert(BB); // Block is now ALIVE!
+ markBlockAlive(BB); // Make it so now!
}
+ // PHI nodes are a special case, because the incoming values are actually
+ // defined in the predecessor nodes of this block, meaning that the PHI
+ // makes the predecessors alive.
+ //
+ if (PHINode *PN = dyn_cast<PHINode>(I))
+ for (pred_iterator PI = pred_begin(BB), PE = pred_end(BB); PI != PE; ++PI)
+ if (!AliveBlocks.count(*PI)) {
+ AliveBlocks.insert(BB); // Block is now ALIVE!
+ markBlockAlive(*PI);
+ }
+
// Loop over all of the operands of the live instruction, making sure that
// they are known to be alive as well...
//
- for (unsigned op = 0, End = I->getNumOperands(); op != End; ++op) {
+ for (unsigned op = 0, End = I->getNumOperands(); op != End; ++op)
if (Instruction *Operand = dyn_cast<Instruction>(I->getOperand(op)))
markInstructionLive(Operand);
- }
}
-#ifdef DEBUG_ADCE
- cerr << "Current Method: X = Live\n";
- for (Method::inst_iterator IL = M->inst_begin(); IL != M->inst_end(); ++IL) {
- if (LiveSet.count(*IL)) cerr << "X ";
- cerr << *IL;
+ if (DebugFlag) {
+ cerr << "Current Function: X = Live\n";
+ for (Function::iterator I = Func->begin(), E = Func->end(); I != E; ++I)
+ for (BasicBlock::iterator BI = I->begin(), BE = I->end(); BI != BE; ++BI){
+ if (LiveSet.count(BI)) cerr << "X ";
+ cerr << *BI;
+ }
}
-#endif
- // After the worklist is processed, recursively walk the CFG in depth first
- // order, patching up references to dead blocks...
+ // Find the first postdominator of the entry node that is alive. Make it the
+ // new entry node...
//
- set<BasicBlock*> VisitedBlocks;
- BasicBlock *EntryBlock = fixupCFG(M->front(), VisitedBlocks, AliveBlocks);
- if (EntryBlock && EntryBlock != M->front()) {
- if (EntryBlock->front()->isPHINode()) {
- // Cannot make the first block be a block with a PHI node in it! Instead,
- // strip the first basic block of the method to contain no instructions,
- // then add a simple branch to the "real" entry node...
- //
- BasicBlock *E = M->front();
- if (!E->front()->isTerminator() || // Check for an actual change...
- ((TerminatorInst*)E->front())->getNumSuccessors() != 1 ||
- ((TerminatorInst*)E->front())->getSuccessor(0) != EntryBlock) {
- E->getInstList().delete_all(); // Delete all instructions in block
- E->getInstList().push_back(new BranchInst(EntryBlock));
- MadeChanges = true;
+ PostDominatorTree &DT = getAnalysis<PostDominatorTree>();
+
+ // If there are some blocks dead...
+ if (AliveBlocks.size() != Func->size()) {
+ // Insert a new entry node to eliminate the entry node as a special case.
+ BasicBlock *NewEntry = new BasicBlock();
+ NewEntry->getInstList().push_back(new BranchInst(&Func->front()));
+ Func->getBasicBlockList().push_front(NewEntry);
+ AliveBlocks.insert(NewEntry); // This block is always alive!
+
+ // Loop over all of the alive blocks in the function. If any successor
+ // blocks are not alive, we adjust the outgoing branches to branch to the
+ // first live postdominator of the live block, adjusting any PHI nodes in
+ // the block to reflect this.
+ //
+ for (Function::iterator I = Func->begin(), E = Func->end(); I != E; ++I)
+ if (AliveBlocks.count(I)) {
+ BasicBlock *BB = I;
+ TerminatorInst *TI = BB->getTerminator();
+
+ // Loop over all of the successors, looking for ones that are not alive
+ for (unsigned i = 0, e = TI->getNumSuccessors(); i != e; ++i)
+ if (!AliveBlocks.count(TI->getSuccessor(i))) {
+ // Scan up the postdominator tree, looking for the first
+ // postdominator that is alive, and the last postdominator that is
+ // dead...
+ //
+ PostDominatorTree::Node *LastNode = DT[TI->getSuccessor(i)];
+ PostDominatorTree::Node *NextNode = LastNode->getIDom();
+ while (!AliveBlocks.count(NextNode->getNode())) {
+ LastNode = NextNode;
+ NextNode = NextNode->getIDom();
+ }
+
+ // Get the basic blocks that we need...
+ BasicBlock *LastDead = LastNode->getNode();
+ BasicBlock *NextAlive = NextNode->getNode();
+
+ // Make the conditional branch now go to the next alive block...
+ TI->getSuccessor(i)->removePredecessor(BB);
+ TI->setSuccessor(i, NextAlive);
+
+ // If there are PHI nodes in NextAlive, we need to add entries to
+ // the PHI nodes for the new incoming edge. The incoming values
+ // should be identical to the incoming values for LastDead.
+ //
+ for (BasicBlock::iterator II = NextAlive->begin();
+ PHINode *PN = dyn_cast<PHINode>(&*II); ++II) {
+ // Get the incoming value for LastDead...
+ int OldIdx = PN->getBasicBlockIndex(LastDead);
+ assert(OldIdx != -1 && "LastDead is not a pred of NextAlive!");
+ Value *InVal = PN->getIncomingValue(OldIdx);
+
+ // Add an incoming value for BB now...
+ PN->addIncoming(InVal, BB);
+ }
+ }
+
+ // Now loop over all of the instructions in the basic block, telling
+ // dead instructions to drop their references. This is so that the next
+ // sweep over the program can safely delete dead instructions without
+ // other dead instructions still refering to them.
+ //
+ for (BasicBlock::iterator I = BB->begin(), E = --BB->end(); I != E; ++I)
+ if (!LiveSet.count(I)) // Is this instruction alive?
+ I->dropAllReferences(); // Nope, drop references...
}
- AliveBlocks.insert(E);
-
- // Next we need to change any PHI nodes in the entry block to refer to the
- // new predecessor node...
-
-
- } else {
- // We need to move the new entry block to be the first bb of the method.
- Method::iterator EBI = find(M->begin(), M->end(), EntryBlock);
- swap(*EBI, *M->begin()); // Exchange old location with start of method
- MadeChanges = true;
- }
}
- // Now go through and tell dead blocks to drop all of their references so they
- // can be safely deleted.
+ // Loop over all of the basic blocks in the function, dropping references of
+ // the dead basic blocks
//
- for (Method::iterator BI = M->begin(), BE = M->end(); BI != BE; ++BI) {
- BasicBlock *BB = *BI;
+ for (Function::iterator BB = Func->begin(), E = Func->end(); BB != E; ++BB) {
if (!AliveBlocks.count(BB)) {
+ // Remove all outgoing edges from this basic block and convert the
+ // terminator into a return instruction.
+ vector<BasicBlock*> Succs(succ_begin(BB), succ_end(BB));
+
+ if (!Succs.empty()) {
+ // Loop over all of the successors, removing this block from PHI node
+ // entries that might be in the block...
+ while (!Succs.empty()) {
+ Succs.back()->removePredecessor(BB);
+ Succs.pop_back();
+ }
+
+ // Delete the old terminator instruction...
+ BB->getInstList().pop_back();
+ const Type *RetTy = Func->getReturnType();
+ Instruction *New = new ReturnInst(RetTy != Type::VoidTy ?
+ Constant::getNullValue(RetTy) : 0);
+ BB->getInstList().push_back(New);
+ }
+
BB->dropAllReferences();
+ ++NumBlockRemoved;
+ MadeChanges = true;
}
}
- // Now loop through all of the blocks and delete them. We can safely do this
- // now because we know that there are no references to dead blocks (because
- // they have dropped all of their references...
+ // Now loop through all of the blocks and delete the dead ones. We can safely
+ // do this now because we know that there are no references to dead blocks
+ // (because they have dropped all of their references... we also remove dead
+ // instructions from alive blocks.
//
- for (Method::iterator BI = M->begin(); BI != M->end();) {
- if (!AliveBlocks.count(*BI)) {
- delete M->getBasicBlocks().remove(BI);
- MadeChanges = true;
- continue; // Don't increment iterator
+ for (Function::iterator BI = Func->begin(); BI != Func->end(); )
+ if (!AliveBlocks.count(BI))
+ BI = Func->getBasicBlockList().erase(BI);
+ else {
+ for (BasicBlock::iterator II = BI->begin(); II != --BI->end(); )
+ if (!LiveSet.count(II)) { // Is this instruction alive?
+ // Nope... remove the instruction from it's basic block...
+ II = BI->getInstList().erase(II);
+ ++NumInstRemoved;
+ MadeChanges = true;
+ } else {
+ ++II;
+ }
+
+ ++BI; // Increment iterator...
}
- ++BI; // Increment iterator...
- }
return MadeChanges;
}
-
-
-// fixupCFG - Walk the CFG in depth first order, eliminating references to
-// dead blocks:
-// If the BB is alive (in AliveBlocks):
-// 1. Eliminate all dead instructions in the BB
-// 2. Recursively traverse all of the successors of the BB:
-// - If the returned successor is non-null, update our terminator to
-// reference the returned BB
-// 3. Return 0 (no update needed)
-//
-// If the BB is dead (not in AliveBlocks):
-// 1. Add the BB to the dead set
-// 2. Recursively traverse all of the successors of the block:
-// - Only one shall return a nonnull value (or else this block should have
-// been in the alive set).
-// 3. Return the nonnull child, or 0 if no non-null children.
-//
-BasicBlock *ADCE::fixupCFG(BasicBlock *BB, set<BasicBlock*> &VisitedBlocks,
- const set<BasicBlock*> &AliveBlocks) {
- if (VisitedBlocks.count(BB)) return 0; // Revisiting a node? No update.
- VisitedBlocks.insert(BB); // We have now visited this node!
-
-#ifdef DEBUG_ADCE
- cerr << "Fixing up BB: " << BB;
-#endif
-
- if (AliveBlocks.count(BB)) { // Is the block alive?
- // Yes it's alive: loop through and eliminate all dead instructions in block
- for (BasicBlock::iterator II = BB->begin(); II != BB->end()-1; ) {
- Instruction *I = *II;
- if (!LiveSet.count(I)) { // Is this instruction alive?
- // Nope... remove the instruction from it's basic block...
- delete BB->getInstList().remove(II);
- MadeChanges = true;
- continue; // Don't increment II
- }
- ++II;
- }
-
- // Recursively traverse successors of this basic block.
- BasicBlock::succ_iterator SI = BB->succ_begin(), SE = BB->succ_end();
- for (; SI != SE; ++SI) {
- BasicBlock *Succ = *SI;
- BasicBlock *Repl = fixupCFG(Succ, VisitedBlocks, AliveBlocks);
- if (Repl && Repl != Succ) { // We have to replace the successor
- Succ->replaceAllUsesWith(Repl);
- MadeChanges = true;
- }
- }
- return BB;
- } else { // Otherwise the block is dead...
- BasicBlock *ReturnBB = 0; // Default to nothing live down here
-
- // Recursively traverse successors of this basic block.
- BasicBlock::succ_iterator SI = BB->succ_begin(), SE = BB->succ_end();
- for (; SI != SE; ++SI) {
- BasicBlock *RetBB = fixupCFG(*SI, VisitedBlocks, AliveBlocks);
- if (RetBB) {
- assert(ReturnBB == 0 && "One one live child allowed!");
- ReturnBB = RetBB;
- }
- }
- return ReturnBB; // Return the result of traversal
- }
-}
-
-
-
-// DoADCE - Execute the Agressive Dead Code Elimination Algorithm
-//
-bool opt::DoADCE(Method *M) {
- if (M->isExternal()) return false;
- ADCE DCE(M);
- return DCE.doADCE();
-}