// This file defines the function verifier interface, that can be used for some
// sanity checking of input to the system.
//
-// Note that this does not provide full 'java style' security and verifications,
-// instead it just tries to ensure that code is well formed.
+// Note that this does not provide full `Java style' security and verifications,
+// instead it just tries to ensure that code is well-formed.
//
-// * Both of a binary operator's parameters are the same type
+// * Both of a binary operator's parameters are of the same type
// * Verify that the indices of mem access instructions match other operands
-// * Verify that arithmetic and other things are only performed on first class
+// * Verify that arithmetic and other things are only performed on first-class
// types. Verify that shifts & logicals only happen on integrals f.e.
-// . All of the constants in a switch statement are of the correct type
+// * All of the constants in a switch statement are of the correct type
// * The code is in valid SSA form
-// . It should be illegal to put a label into any other type (like a structure)
+// * It should be illegal to put a label into any other type (like a structure)
// or to return one. [except constant arrays!]
// * Only phi nodes can be self referential: 'add int %0, %0 ; <int>:0' is bad
// * PHI nodes must have an entry for each predecessor, with no extras.
// * All basic blocks should only end with terminator insts, not contain them
// * The entry node to a function must not have predecessors
// * All Instructions must be embedded into a basic block
-// . Function's cannot take a void typed parameter
+// * Functions cannot take a void-typed parameter
// * Verify that a function's argument list agrees with it's declared type.
// * It is illegal to specify a name for a void value.
// * It is illegal to have a internal global value with no initializer
#include "llvm/Analysis/Dominators.h"
#include "llvm/Support/CFG.h"
#include "llvm/Support/InstVisitor.h"
-#include "Support/STLExtras.h"
+#include "llvm/ADT/STLExtras.h"
#include <algorithm>
+#include <iostream>
#include <sstream>
using namespace llvm;
DominatorSet *DS; // Dominator set, caution can be null!
std::stringstream msgs; // A stringstream to collect messages
+ /// InstInThisBlock - when verifying a basic block, keep track of all of the
+ /// instructions we have seen so far. This allows us to do efficient
+ /// dominance checks for the case when an instruction has an operand that is
+ /// an instruction in the same block.
+ std::set<Instruction*> InstsInThisBlock;
+
Verifier()
: Broken(false), RealPass(true), action(AbortProcessAction),
DS(0), msgs( std::ios_base::app | std::ios_base::out ) {}
// Get dominator information if we are being run by PassManager
if (RealPass) DS = &getAnalysis<DominatorSet>();
visit(F);
+ InstsInThisBlock.clear();
// If this is a real pass, in a pass manager, we must abort before
// returning back to the pass manager, or else the pass manager may try to
for (Module::giterator I = M.gbegin(), E = M.gend(); I != E; ++I)
visitGlobalValue(*I);
-
-
// If the module is broken, abort at this time.
abortIfBroken();
return false;
// verifyBasicBlock - Verify that a basic block is well formed...
//
void Verifier::visitBasicBlock(BasicBlock &BB) {
+ InstsInThisBlock.clear();
+
// Check constraints that this basic block imposes on all of the PHI nodes in
// it.
if (isa<PHINode>(BB.front())) {
"Select values must have identical types!", &SI);
Assert1(SI.getTrueValue()->getType() == SI.getType(),
"Select values must have same type as select instruction!", &SI);
+ visitInstruction(SI);
}
Assert1(B.getType() == B.getOperand(0)->getType(),
"Arithmetic operators must have same type for operands and result!",
&B);
- Assert1(B.getType()->isInteger() || B.getType()->isFloatingPoint(),
- "Arithmetic operators must have integer or fp type!", &B);
+ Assert1(B.getType()->isInteger() || B.getType()->isFloatingPoint() ||
+ isa<PackedType>(B.getType()),
+ "Arithmetic operators must have integer, fp, or packed type!", &B);
}
visitInstruction(B);
else if (OpBlock == BB) {
// If they are in the same basic block, make sure that the definition
// comes before the use.
- Assert2(DS->dominates(Op, &I) ||
+ Assert2(InstsInThisBlock.count(Op) ||
!DS->dominates(&BB->getParent()->getEntryBlock(), BB),
"Instruction does not dominate all uses!", Op, &I);
}
}
}
}
+ InstsInThisBlock.insert(&I);
}
/// visitIntrinsicFunction - Allow intrinsics to be verified in different ways.
"Illegal # arguments for intrinsic function!", IF);
Assert1(FT->getParamType(0)->isFirstClassType(),
"First argument not a first class type!", IF);
- Assert1(FT->getParamType(1)->getPrimitiveID() == Type::PointerTyID,
+ Assert1(isa<PointerType>(FT->getParamType(1)),
"Second argument not a pointer!", IF);
NumArgs = 2;
break;
break;
}
- case Intrinsic::isunordered: NumArgs = 2; break;
+ case Intrinsic::isunordered:
+ Assert1(FT->getNumParams() == 2,
+ "Illegal # arguments for intrinsic function!", IF);
+ Assert1(FT->getReturnType() == Type::BoolTy,
+ "Return type is not bool!", IF);
+ Assert1(FT->getParamType(0) == FT->getParamType(1),
+ "Arguments must be of the same type!", IF);
+ Assert1(FT->getParamType(0)->isFloatingPoint(),
+ "Argument is not a floating point type!", IF);
+ NumArgs = 2;
+ break;
case Intrinsic::setjmp: NumArgs = 1; break;
case Intrinsic::longjmp: NumArgs = 2; break;
case Intrinsic::gcroot:
Assert1(FT->getNumParams() == 2,
"Illegal # arguments for intrinsic function!", IF);
- Assert1(isa<Constant>(CI.getOperand(2)) ||
- isa<GlobalValue>(CI.getOperand(2)),
+ Assert1(isa<Constant>(CI.getOperand(2)),
"Second argument to llvm.gcroot must be a constant!", &CI);
NumArgs = 2;
break;
- case Intrinsic::gcread: NumArgs = 1; break;
- case Intrinsic::gcwrite: NumArgs = 2; break;
+ case Intrinsic::gcread: NumArgs = 2; break;
+ case Intrinsic::gcwrite: NumArgs = 3; break;
case Intrinsic::dbg_stoppoint: NumArgs = 4; break;
case Intrinsic::dbg_region_start:NumArgs = 1; break;
projects / oota-llvm.git / blobdiff