Merge branch 'wm8974-upstream' into for-2.6.32
[firefly-linux-kernel-4.4.55.git] / tools / perf / builtin-report.c
index 82fa93b4db9996d3af08d72b71934053107d70ef..5eb5566f0c95426dd3f5c4c3cf196faf55080fbd 100644 (file)
@@ -36,45 +36,65 @@ static int          show_mask = SHOW_KERNEL | SHOW_USER | SHOW_HV;
 
 static int             dump_trace = 0;
 #define dprintf(x...)  do { if (dump_trace) printf(x); } while (0)
+#define cdprintf(x...) do { if (dump_trace) color_fprintf(stdout, color, x); } while (0)
 
 static int             verbose;
+#define eprintf(x...)  do { if (verbose) fprintf(stderr, x); } while (0)
+
 static int             full_paths;
 
 static unsigned long   page_size;
 static unsigned long   mmap_window = 32;
 
+static char            default_parent_pattern[] = "^sys_|^do_page_fault";
+static char            *parent_pattern = default_parent_pattern;
+static regex_t         parent_regex;
+
+static int             exclude_other = 1;
+
 struct ip_event {
        struct perf_event_header header;
-       __u64 ip;
-       __u32 pid, tid;
-       __u64 period;
+       u64 ip;
+       u32 pid, tid;
+       unsigned char __more_data[];
+};
+
+struct ip_callchain {
+       u64 nr;
+       u64 ips[0];
 };
 
 struct mmap_event {
        struct perf_event_header header;
-       __u32 pid, tid;
-       __u64 start;
-       __u64 len;
-       __u64 pgoff;
+       u32 pid, tid;
+       u64 start;
+       u64 len;
+       u64 pgoff;
        char filename[PATH_MAX];
 };
 
 struct comm_event {
        struct perf_event_header header;
-       __u32 pid, tid;
+       u32 pid, tid;
        char comm[16];
 };
 
 struct fork_event {
        struct perf_event_header header;
-       __u32 pid, ppid;
+       u32 pid, ppid;
 };
 
 struct period_event {
        struct perf_event_header header;
-       __u64 time;
-       __u64 id;
-       __u64 sample_period;
+       u64 time;
+       u64 id;
+       u64 sample_period;
+};
+
+struct lost_event {
+       struct perf_event_header header;
+       u64 id;
+       u64 lost;
 };
 
 typedef union event_union {
@@ -84,6 +104,7 @@ typedef union event_union {
        struct comm_event               comm;
        struct fork_event               fork;
        struct period_event             period;
+       struct lost_event               lost;
 } event_t;
 
 static LIST_HEAD(dsos);
@@ -119,15 +140,11 @@ static struct dso *dsos__findnew(const char *name)
 
        nr = dso__load(dso, NULL, verbose);
        if (nr < 0) {
-               if (verbose)
-                       fprintf(stderr, "Failed to open: %s\n", name);
+               eprintf("Failed to open: %s\n", name);
                goto out_delete_dso;
        }
-       if (!nr && verbose) {
-               fprintf(stderr,
-               "No symbols found in: %s, maybe install a debug package?\n",
-                               name);
-       }
+       if (!nr)
+               eprintf("No symbols found in: %s, maybe install a debug package?\n", name);
 
        dsos__add(dso);
 
@@ -146,7 +163,7 @@ static void dsos__fprintf(FILE *fp)
                dso__fprintf(pos, fp);
 }
 
-static struct symbol *vdso__find_symbol(struct dso *dso, __u64 ip)
+static struct symbol *vdso__find_symbol(struct dso *dso, u64 ip)
 {
        return dso__find_symbol(kernel_dso, ip);
 }
@@ -193,19 +210,19 @@ static int strcommon(const char *pathname)
 
 struct map {
        struct list_head node;
-       __u64    start;
-       __u64    end;
-       __u64    pgoff;
-       __u64    (*map_ip)(struct map *, __u64);
+       u64      start;
+       u64      end;
+       u64      pgoff;
+       u64      (*map_ip)(struct map *, u64);
        struct dso       *dso;
 };
 
-static __u64 map__map_ip(struct map *map, __u64 ip)
+static u64 map__map_ip(struct map *map, u64 ip)
 {
        return ip - map->start + map->pgoff;
 }
 
-static __u64 vdso__map_ip(struct map *map, __u64 ip)
+static u64 vdso__map_ip(struct map *map, u64 ip)
 {
        return ip;
 }
@@ -412,7 +429,7 @@ static int thread__fork(struct thread *self, struct thread *parent)
        return 0;
 }
 
-static struct map *thread__find_map(struct thread *self, __u64 ip)
+static struct map *thread__find_map(struct thread *self, u64 ip)
 {
        struct map *pos;
 
@@ -453,10 +470,11 @@ struct hist_entry {
        struct map       *map;
        struct dso       *dso;
        struct symbol    *sym;
-       __u64            ip;
+       struct symbol    *parent;
+       u64              ip;
        char             level;
 
-       __u64            count;
+       u64              count;
 };
 
 /*
@@ -473,6 +491,16 @@ struct sort_entry {
        size_t  (*print)(FILE *fp, struct hist_entry *);
 };
 
+static int64_t cmp_null(void *l, void *r)
+{
+       if (!l && !r)
+               return 0;
+       else if (!l)
+               return -1;
+       else
+               return 1;
+}
+
 /* --sort pid */
 
 static int64_t
@@ -507,14 +535,8 @@ sort__comm_collapse(struct hist_entry *left, struct hist_entry *right)
        char *comm_l = left->thread->comm;
        char *comm_r = right->thread->comm;
 
-       if (!comm_l || !comm_r) {
-               if (!comm_l && !comm_r)
-                       return 0;
-               else if (!comm_l)
-                       return -1;
-               else
-                       return 1;
-       }
+       if (!comm_l || !comm_r)
+               return cmp_null(comm_l, comm_r);
 
        return strcmp(comm_l, comm_r);
 }
@@ -540,14 +562,8 @@ sort__dso_cmp(struct hist_entry *left, struct hist_entry *right)
        struct dso *dso_l = left->dso;
        struct dso *dso_r = right->dso;
 
-       if (!dso_l || !dso_r) {
-               if (!dso_l && !dso_r)
-                       return 0;
-               else if (!dso_l)
-                       return -1;
-               else
-                       return 1;
-       }
+       if (!dso_l || !dso_r)
+               return cmp_null(dso_l, dso_r);
 
        return strcmp(dso_l->name, dso_r->name);
 }
@@ -558,7 +574,7 @@ sort__dso_print(FILE *fp, struct hist_entry *self)
        if (self->dso)
                return fprintf(fp, "%-25s", self->dso->name);
 
-       return fprintf(fp, "%016llx         ", (__u64)self->ip);
+       return fprintf(fp, "%016llx         ", (u64)self->ip);
 }
 
 static struct sort_entry sort_dso = {
@@ -572,7 +588,7 @@ static struct sort_entry sort_dso = {
 static int64_t
 sort__sym_cmp(struct hist_entry *left, struct hist_entry *right)
 {
-       __u64 ip_l, ip_r;
+       u64 ip_l, ip_r;
 
        if (left->sym == right->sym)
                return 0;
@@ -589,13 +605,13 @@ sort__sym_print(FILE *fp, struct hist_entry *self)
        size_t ret = 0;
 
        if (verbose)
-               ret += fprintf(fp, "%#018llx  ", (__u64)self->ip);
+               ret += fprintf(fp, "%#018llx  ", (u64)self->ip);
 
        if (self->sym) {
                ret += fprintf(fp, "[%c] %s",
                        self->dso == kernel_dso ? 'k' : '.', self->sym->name);
        } else {
-               ret += fprintf(fp, "%#016llx", (__u64)self->ip);
+               ret += fprintf(fp, "%#016llx", (u64)self->ip);
        }
 
        return ret;
@@ -607,7 +623,38 @@ static struct sort_entry sort_sym = {
        .print  = sort__sym_print,
 };
 
+/* --sort parent */
+
+static int64_t
+sort__parent_cmp(struct hist_entry *left, struct hist_entry *right)
+{
+       struct symbol *sym_l = left->parent;
+       struct symbol *sym_r = right->parent;
+
+       if (!sym_l || !sym_r)
+               return cmp_null(sym_l, sym_r);
+
+       return strcmp(sym_l->name, sym_r->name);
+}
+
+static size_t
+sort__parent_print(FILE *fp, struct hist_entry *self)
+{
+       size_t ret = 0;
+
+       ret += fprintf(fp, "%-20s", self->parent ? self->parent->name : "[other]");
+
+       return ret;
+}
+
+static struct sort_entry sort_parent = {
+       .header = "Parent symbol       ",
+       .cmp    = sort__parent_cmp,
+       .print  = sort__parent_print,
+};
+
 static int sort__need_collapse = 0;
+static int sort__has_parent = 0;
 
 struct sort_dimension {
        char                    *name;
@@ -620,6 +667,7 @@ static struct sort_dimension sort_dimensions[] = {
        { .name = "comm",       .entry = &sort_comm,    },
        { .name = "dso",        .entry = &sort_dso,     },
        { .name = "symbol",     .entry = &sort_sym,     },
+       { .name = "parent",     .entry = &sort_parent,  },
 };
 
 static LIST_HEAD(hist_entry__sort_list);
@@ -640,6 +688,19 @@ static int sort_dimension__add(char *tok)
                if (sd->entry->collapse)
                        sort__need_collapse = 1;
 
+               if (sd->entry == &sort_parent) {
+                       int ret = regcomp(&parent_regex, parent_pattern, REG_EXTENDED);
+                       if (ret) {
+                               char err[BUFSIZ];
+
+                               regerror(ret, &parent_regex, err, sizeof(err));
+                               fprintf(stderr, "Invalid regex: %s\n%s",
+                                       parent_pattern, err);
+                               exit(-1);
+                       }
+                       sort__has_parent = 1;
+               }
+
                list_add_tail(&sd->entry->list, &hist_entry__sort_list);
                sd->taken = 1;
 
@@ -684,11 +745,14 @@ hist_entry__collapse(struct hist_entry *left, struct hist_entry *right)
 }
 
 static size_t
-hist_entry__fprintf(FILE *fp, struct hist_entry *self, __u64 total_samples)
+hist_entry__fprintf(FILE *fp, struct hist_entry *self, u64 total_samples)
 {
        struct sort_entry *se;
        size_t ret;
 
+       if (exclude_other && !self->parent)
+               return 0;
+
        if (total_samples) {
                double percent = self->count * 100.0 / total_samples;
                char *color = PERF_COLOR_NORMAL;
@@ -711,6 +775,9 @@ hist_entry__fprintf(FILE *fp, struct hist_entry *self, __u64 total_samples)
                ret = fprintf(fp, "%12Ld ", self->count);
 
        list_for_each_entry(se, &hist_entry__sort_list, list) {
+               if (exclude_other && (se == &sort_parent))
+                       continue;
+
                fprintf(fp, "  ");
                ret += se->print(fp, self);
        }
@@ -720,13 +787,73 @@ hist_entry__fprintf(FILE *fp, struct hist_entry *self, __u64 total_samples)
        return ret;
 }
 
+/*
+ *
+ */
+
+static struct symbol *
+resolve_symbol(struct thread *thread, struct map **mapp,
+              struct dso **dsop, u64 *ipp)
+{
+       struct dso *dso = dsop ? *dsop : NULL;
+       struct map *map = mapp ? *mapp : NULL;
+       uint64_t ip = *ipp;
+
+       if (!thread)
+               return NULL;
+
+       if (dso)
+               goto got_dso;
+
+       if (map)
+               goto got_map;
+
+       map = thread__find_map(thread, ip);
+       if (map != NULL) {
+               if (mapp)
+                       *mapp = map;
+got_map:
+               ip = map->map_ip(map, ip);
+               *ipp  = ip;
+
+               dso = map->dso;
+       } else {
+               /*
+                * If this is outside of all known maps,
+                * and is a negative address, try to look it
+                * up in the kernel dso, as it might be a
+                * vsyscall (which executes in user-mode):
+                */
+               if ((long long)ip < 0)
+               dso = kernel_dso;
+       }
+       dprintf(" ...... dso: %s\n", dso ? dso->name : "<not found>");
+
+       if (dsop)
+               *dsop = dso;
+
+       if (!dso)
+               return NULL;
+got_dso:
+       return dso->find_symbol(dso, ip);
+}
+
+static int call__match(struct symbol *sym)
+{
+       if (sym->name && !regexec(&parent_regex, sym->name, 0, NULL, 0))
+               return 1;
+
+       return 0;
+}
+
 /*
  * collect histogram counts
  */
 
 static int
 hist_entry__add(struct thread *thread, struct map *map, struct dso *dso,
-               struct symbol *sym, __u64 ip, char level, __u64 count)
+               struct symbol *sym, u64 ip, struct ip_callchain *chain,
+               char level, u64 count)
 {
        struct rb_node **p = &hist.rb_node;
        struct rb_node *parent = NULL;
@@ -739,9 +866,41 @@ hist_entry__add(struct thread *thread, struct map *map, struct dso *dso,
                .ip     = ip,
                .level  = level,
                .count  = count,
+               .parent = NULL,
        };
        int cmp;
 
+       if (sort__has_parent && chain) {
+               u64 context = PERF_CONTEXT_MAX;
+               int i;
+
+               for (i = 0; i < chain->nr; i++) {
+                       u64 ip = chain->ips[i];
+                       struct dso *dso = NULL;
+                       struct symbol *sym;
+
+                       if (ip >= PERF_CONTEXT_MAX) {
+                               context = ip;
+                               continue;
+                       }
+
+                       switch (context) {
+                       case PERF_CONTEXT_KERNEL:
+                               dso = kernel_dso;
+                               break;
+                       default:
+                               break;
+                       }
+
+                       sym = resolve_symbol(thread, NULL, &dso, &ip);
+
+                       if (sym && call__match(sym)) {
+                               entry.parent = sym;
+                               break;
+                       }
+               }
+       }
+
        while (*p != NULL) {
                parent = *p;
                he = rb_entry(parent, struct hist_entry, rb_node);
@@ -873,7 +1032,7 @@ static void output__resort(void)
        }
 }
 
-static size_t output__fprintf(FILE *fp, __u64 total_samples)
+static size_t output__fprintf(FILE *fp, u64 total_samples)
 {
        struct hist_entry *pos;
        struct sort_entry *se;
@@ -882,18 +1041,24 @@ static size_t output__fprintf(FILE *fp, __u64 total_samples)
 
        fprintf(fp, "\n");
        fprintf(fp, "#\n");
-       fprintf(fp, "# (%Ld samples)\n", (__u64)total_samples);
+       fprintf(fp, "# (%Ld samples)\n", (u64)total_samples);
        fprintf(fp, "#\n");
 
        fprintf(fp, "# Overhead");
-       list_for_each_entry(se, &hist_entry__sort_list, list)
+       list_for_each_entry(se, &hist_entry__sort_list, list) {
+               if (exclude_other && (se == &sort_parent))
+                       continue;
                fprintf(fp, "  %s", se->header);
+       }
        fprintf(fp, "\n");
 
        fprintf(fp, "# ........");
        list_for_each_entry(se, &hist_entry__sort_list, list) {
                int i;
 
+               if (exclude_other && (se == &sort_parent))
+                       continue;
+
                fprintf(fp, "  ");
                for (i = 0; i < strlen(se->header); i++)
                        fprintf(fp, ".");
@@ -907,7 +1072,8 @@ static size_t output__fprintf(FILE *fp, __u64 total_samples)
                ret += hist_entry__fprintf(fp, pos, total_samples);
        }
 
-       if (!strcmp(sort_order, default_sort_order)) {
+       if (sort_order == default_sort_order &&
+                       parent_pattern == default_parent_pattern) {
                fprintf(fp, "#\n");
                fprintf(fp, "# (For more details, try: perf report --sort comm,dso,symbol)\n");
                fprintf(fp, "#\n");
@@ -932,7 +1098,21 @@ static unsigned long total = 0,
                     total_mmap = 0,
                     total_comm = 0,
                     total_fork = 0,
-                    total_unknown = 0;
+                    total_unknown = 0,
+                    total_lost = 0;
+
+static int validate_chain(struct ip_callchain *chain, event_t *event)
+{
+       unsigned int chain_size;
+
+       chain_size = event->header.size;
+       chain_size -= (unsigned long)&event->ip.__more_data - (unsigned long)event;
+
+       if (chain->nr*sizeof(u64) > chain_size)
+               return -1;
+
+       return 0;
+}
 
 static int
 process_overflow_event(event_t *event, unsigned long offset, unsigned long head)
@@ -941,12 +1121,16 @@ process_overflow_event(event_t *event, unsigned long offset, unsigned long head)
        int show = 0;
        struct dso *dso = NULL;
        struct thread *thread = threads__findnew(event->ip.pid);
-       __u64 ip = event->ip.ip;
-       __u64 period = 1;
+       u64 ip = event->ip.ip;
+       u64 period = 1;
        struct map *map = NULL;
+       void *more_data = event->ip.__more_data;
+       struct ip_callchain *chain = NULL;
 
-       if (event->header.type & PERF_SAMPLE_PERIOD)
-               period = event->ip.period;
+       if (event->header.type & PERF_SAMPLE_PERIOD) {
+               period = *(u64 *)more_data;
+               more_data += sizeof(u64);
+       }
 
        dprintf("%p [%p]: PERF_EVENT (IP, %d): %d: %p period: %Ld\n",
                (void *)(offset + head),
@@ -956,10 +1140,28 @@ process_overflow_event(event_t *event, unsigned long offset, unsigned long head)
                (void *)(long)ip,
                (long long)period);
 
+       if (event->header.type & PERF_SAMPLE_CALLCHAIN) {
+               int i;
+
+               chain = (void *)more_data;
+
+               dprintf("... chain: nr:%Lu\n", chain->nr);
+
+               if (validate_chain(chain, event) < 0) {
+                       eprintf("call-chain problem with event, skipping it.\n");
+                       return 0;
+               }
+
+               if (dump_trace) {
+                       for (i = 0; i < chain->nr; i++)
+                               dprintf("..... %2d: %016Lx\n", i, chain->ips[i]);
+               }
+       }
+
        dprintf(" ... thread: %s:%d\n", thread->comm, thread->pid);
 
        if (thread == NULL) {
-               fprintf(stderr, "problem processing %d event, skipping it.\n",
+               eprintf("problem processing %d event, skipping it.\n",
                        event->header.type);
                return -1;
        }
@@ -977,22 +1179,6 @@ process_overflow_event(event_t *event, unsigned long offset, unsigned long head)
                show = SHOW_USER;
                level = '.';
 
-               map = thread__find_map(thread, ip);
-               if (map != NULL) {
-                       ip = map->map_ip(map, ip);
-                       dso = map->dso;
-               } else {
-                       /*
-                        * If this is outside of all known maps,
-                        * and is a negative address, try to look it
-                        * up in the kernel dso, as it might be a
-                        * vsyscall (which executes in user-mode):
-                        */
-                       if ((long long)ip < 0)
-                               dso = kernel_dso;
-               }
-               dprintf(" ...... dso: %s\n", dso ? dso->name : "<not found>");
-
        } else {
                show = SHOW_HV;
                level = 'H';
@@ -1000,14 +1186,10 @@ process_overflow_event(event_t *event, unsigned long offset, unsigned long head)
        }
 
        if (show & show_mask) {
-               struct symbol *sym = NULL;
-
-               if (dso)
-                       sym = dso->find_symbol(dso, ip);
+               struct symbol *sym = resolve_symbol(thread, &map, &dso, &ip);
 
-               if (hist_entry__add(thread, map, dso, sym, ip, level, period)) {
-                       fprintf(stderr,
-               "problem incrementing symbol count, skipping event\n");
+               if (hist_entry__add(thread, map, dso, sym, ip, chain, level, period)) {
+                       eprintf("problem incrementing symbol count, skipping event\n");
                        return -1;
                }
        }
@@ -1095,9 +1277,61 @@ process_period_event(event_t *event, unsigned long offset, unsigned long head)
        return 0;
 }
 
+static int
+process_lost_event(event_t *event, unsigned long offset, unsigned long head)
+{
+       dprintf("%p [%p]: PERF_EVENT_LOST: id:%Ld: lost:%Ld\n",
+               (void *)(offset + head),
+               (void *)(long)(event->header.size),
+               event->lost.id,
+               event->lost.lost);
+
+       total_lost += event->lost.lost;
+
+       return 0;
+}
+
+static void trace_event(event_t *event)
+{
+       unsigned char *raw_event = (void *)event;
+       char *color = PERF_COLOR_BLUE;
+       int i, j;
+
+       if (!dump_trace)
+               return;
+
+       dprintf(".");
+       cdprintf("\n. ... raw event: size %d bytes\n", event->header.size);
+
+       for (i = 0; i < event->header.size; i++) {
+               if ((i & 15) == 0) {
+                       dprintf(".");
+                       cdprintf("  %04x: ", i);
+               }
+
+               cdprintf(" %02x", raw_event[i]);
+
+               if (((i & 15) == 15) || i == event->header.size-1) {
+                       cdprintf("  ");
+                       for (j = 0; j < 15-(i & 15); j++)
+                               cdprintf("   ");
+                       for (j = 0; j < (i & 15); j++) {
+                               if (isprint(raw_event[i-15+j]))
+                                       cdprintf("%c", raw_event[i-15+j]);
+                               else
+                                       cdprintf(".");
+                       }
+                       cdprintf("\n");
+               }
+       }
+       dprintf(".\n");
+}
+
 static int
 process_event(event_t *event, unsigned long offset, unsigned long head)
 {
+       trace_event(event);
+
        if (event->header.misc & PERF_EVENT_MISC_OVERFLOW)
                return process_overflow_event(event, offset, head);
 
@@ -1113,6 +1347,10 @@ process_event(event_t *event, unsigned long offset, unsigned long head)
 
        case PERF_EVENT_PERIOD:
                return process_period_event(event, offset, head);
+
+       case PERF_EVENT_LOST:
+               return process_lost_event(event, offset, head);
+
        /*
         * We dont process them right now but they are fine:
         */
@@ -1128,11 +1366,13 @@ process_event(event_t *event, unsigned long offset, unsigned long head)
        return 0;
 }
 
+static struct perf_file_header         file_header;
+
 static int __cmd_report(void)
 {
        int ret, rc = EXIT_FAILURE;
        unsigned long offset = 0;
-       unsigned long head = 0;
+       unsigned long head = sizeof(file_header);
        struct stat stat;
        event_t *event;
        uint32_t size;
@@ -1160,6 +1400,17 @@ static int __cmd_report(void)
                exit(0);
        }
 
+       if (read(input, &file_header, sizeof(file_header)) == -1) {
+               perror("failed to read file headers");
+               exit(-1);
+       }
+
+       if (sort__has_parent &&
+           !(file_header.sample_type & PERF_SAMPLE_CALLCHAIN)) {
+               fprintf(stderr, "selected --sort parent, but no callchain data\n");
+               exit(-1);
+       }
+
        if (load_kernel() < 0) {
                perror("failed to load kernel symbols");
                return EXIT_FAILURE;
@@ -1204,7 +1455,7 @@ more:
 
        size = event->header.size;
 
-       dprintf("%p [%p]: event: %d\n",
+       dprintf("\n%p [%p]: event: %d\n",
                        (void *)(offset + head),
                        (void *)(long)event->header.size,
                        event->header.type);
@@ -1231,9 +1482,13 @@ more:
 
        head += size;
 
+       if (offset + head >= sizeof(file_header) + file_header.data_size)
+               goto done;
+
        if (offset + head < stat.st_size)
                goto more;
 
+done:
        rc = EXIT_SUCCESS;
        close(input);
 
@@ -1241,6 +1496,7 @@ more:
        dprintf("    mmap events: %10ld\n", total_mmap);
        dprintf("    comm events: %10ld\n", total_comm);
        dprintf("    fork events: %10ld\n", total_fork);
+       dprintf("    lost events: %10ld\n", total_lost);
        dprintf(" unknown events: %10ld\n", total_unknown);
 
        if (dump_trace)
@@ -1273,9 +1529,13 @@ static const struct option options[] = {
                    "dump raw trace in ASCII"),
        OPT_STRING('k', "vmlinux", &vmlinux, "file", "vmlinux pathname"),
        OPT_STRING('s', "sort", &sort_order, "key[,key2...]",
-                  "sort by key(s): pid, comm, dso, symbol. Default: pid,symbol"),
+                  "sort by key(s): pid, comm, dso, symbol, parent"),
        OPT_BOOLEAN('P', "full-paths", &full_paths,
                    "Don't shorten the pathnames taking into account the cwd"),
+       OPT_STRING('p', "parent", &parent_pattern, "regex",
+                  "regex filter to identify parent, see: '--sort parent'"),
+       OPT_BOOLEAN('x', "exclude-other", &exclude_other,
+                   "Only display entries with parent-match"),
        OPT_END()
 };
 
@@ -1304,6 +1564,11 @@ int cmd_report(int argc, const char **argv, const char *prefix)
 
        setup_sorting();
 
+       if (parent_pattern != default_parent_pattern)
+               sort_dimension__add("parent");
+       else
+               exclude_other = 0;
+
        /*
         * Any (unrecognized) arguments left?
         */