Changed AES to CTR mode
[iotcloud.git] / version2 / src / java / iotcloud / CloudComm.java
index 5e60e3c4b90f1cd82f6d88a501b662af1f95b8d2..d0a514d30cd5a3f12ce3c13efcf69b6e4873ebe1 100644 (file)
@@ -6,6 +6,7 @@ import java.util.Arrays;
 import javax.crypto.*;
 import javax.crypto.spec.*;
 import java.security.SecureRandom;
+import java.nio.ByteBuffer;
 
 /**
  * This class provides a communication API to the webserver.  It also
@@ -18,13 +19,13 @@ import java.security.SecureRandom;
 class CloudComm {
        private static final int SALT_SIZE = 8;
        private static final int TIMEOUT_MILLIS = 2000; // 100
+       public static final int IV_SIZE = 16;
 
        /** Sets the size for the HMAC. */
        static final int HMAC_SIZE = 32;
 
        private String baseurl;
-       private Cipher encryptCipher;
-       private Cipher decryptCipher;
+       private SecretKeySpec key;
        private Mac mac;
        private String password;
        private SecureRandom random;
@@ -104,14 +105,10 @@ class CloudComm {
                }
 
                try {
-                       SecretKeySpec key = initKey();
+                       key = initKey();
                        password = null; // drop password
                        mac = Mac.getInstance("HmacSHA256");
                        mac.init(key);
-                       encryptCipher = Cipher.getInstance("AES/ECB/PKCS5Padding");
-                       encryptCipher.init(Cipher.ENCRYPT_MODE, key);
-                       decryptCipher = Cipher.getInstance("AES/ECB/PKCS5Padding");
-                       decryptCipher.init(Cipher.DECRYPT_MODE, key);
                } catch (Exception e) {
                        e.printStackTrace();
                        throw new Error("Failed To Initialize Ciphers");
@@ -140,8 +137,13 @@ class CloudComm {
                        byte[] saltTmp = new byte[SALT_SIZE];
                        random.nextBytes(saltTmp);
 
+                       for (int i = 0; i < SALT_SIZE; i++) {
+                               System.out.println((int)saltTmp[i] & 255);
+                       }
+
+
                        URL url = new URL(baseurl + "?req=setsalt");
-                       
+
                        timer.startTime();
                        URLConnection con = url.openConnection();
                        HttpURLConnection http = (HttpURLConnection) con;
@@ -151,13 +153,13 @@ class CloudComm {
                        http.setDoOutput(true);
                        http.setConnectTimeout(TIMEOUT_MILLIS);
 
-                       
+
                        http.connect();
 
                        OutputStream os = http.getOutputStream();
                        os.write(saltTmp);
                        os.flush();
-                       
+
                        int responsecode = http.getResponseCode();
                        if (responsecode != HttpURLConnection.HTTP_OK) {
                                // TODO: Remove this print
@@ -195,7 +197,7 @@ class CloudComm {
                        http.setConnectTimeout(TIMEOUT_MILLIS);
                        http.setReadTimeout(TIMEOUT_MILLIS);
 
-                       
+
                        http.connect();
                        timer.endTime();
                } catch (SocketTimeoutException e) {
@@ -242,6 +244,56 @@ class CloudComm {
                }
        }
 
+       private byte[] createIV(long machineId, long localSequenceNumber) {
+               ByteBuffer buffer = ByteBuffer.allocate(IV_SIZE);
+               buffer.putLong(machineId);
+               buffer.putLong(localSequenceNumber);
+               return buffer.array();
+
+       }
+
+       private byte[] encryptSlotAndPrependIV(byte[] rawData, byte[] ivBytes) {
+               try {
+                       IvParameterSpec ivSpec = new IvParameterSpec(ivBytes);
+                       Cipher cipher = Cipher.getInstance("AES/CTR/PKCS5Padding");
+                       cipher.init(Cipher.ENCRYPT_MODE, key, ivSpec);
+
+                       byte[] encryptedBytes = cipher.doFinal(rawData);
+
+                       byte[] bytes = new byte[encryptedBytes.length + IV_SIZE];
+                       System.arraycopy(ivBytes, 0, bytes, 0, ivBytes.length);
+                       System.arraycopy(encryptedBytes, 0, bytes, IV_SIZE, encryptedBytes.length);
+
+                       return bytes;
+
+               } catch (Exception e) {
+                       e.printStackTrace();
+                       throw new Error("Failed To Encrypt");
+               }
+       }
+
+
+       private byte[] stripIVAndDecryptSlot(byte[] rawData) {
+               try {
+                       byte[] ivBytes = new byte[IV_SIZE];
+                       byte[] encryptedBytes = new byte[rawData.length - IV_SIZE];
+                       System.arraycopy(rawData, 0, ivBytes, 0, IV_SIZE);
+                       System.arraycopy(rawData, IV_SIZE, encryptedBytes, 0 , encryptedBytes.length);
+
+                       IvParameterSpec ivSpec = new IvParameterSpec(ivBytes);
+
+                       Cipher cipher = Cipher.getInstance("AES/CTR/PKCS5Padding");
+                       cipher.init(Cipher.DECRYPT_MODE, key, ivSpec);
+
+                       return cipher.doFinal(encryptedBytes);
+
+               } catch (Exception e) {
+                       e.printStackTrace();
+                       throw new Error("Failed To Decrypt");
+               }
+       }
+
+
        /*
         * API for putting a slot into the queue.  Returns null on success.
         * On failure, the server will send slots with newer sequence
@@ -261,11 +313,17 @@ class CloudComm {
                        }
 
                        long sequencenumber = slot.getSequenceNumber();
-                       byte[] bytes = slot.encode(mac);
-                       bytes = encryptCipher.doFinal(bytes);
+                       byte[] slotBytes = slot.encode(mac);
+                       // slotBytes = encryptCipher.doFinal(slotBytes);
+
+                       // byte[] iVBytes = slot.getSlotCryptIV();
 
+                       // byte[] bytes = new byte[slotBytes.length + IV_SIZE];
+                       // System.arraycopy(iVBytes, 0, bytes, 0, iVBytes.length);
+                       // System.arraycopy(slotBytes, 0, bytes, IV_SIZE, slotBytes.length);
 
 
+                       byte[] bytes = encryptSlotAndPrependIV(slotBytes, slot.getSlotCryptIV());
 
                        url = buildRequest(true, sequencenumber, max);
 
@@ -311,19 +369,15 @@ class CloudComm {
                        dis.readFully(resptype);
                        timer.endTime();
 
-                       if (Arrays.equals(resptype, "getslot".getBytes()))
-                       {       
+                       if (Arrays.equals(resptype, "getslot".getBytes())) {
                                return processSlots(dis);
-                       }
-                       else if (Arrays.equals(resptype, "putslot".getBytes()))
-                       {
+                       } else if (Arrays.equals(resptype, "putslot".getBytes())) {
                                return null;
-                       }
-                       else
+                       } else
                                throw new Error("Bad response to putslot");
 
                } catch (SocketTimeoutException e) {
-                               timer.endTime();
+                       timer.endTime();
                        throw new ServerException("putSlot failed", ServerException.TypeInputTimeout);
                } catch (Exception e) {
                        // e.printStackTrace();
@@ -356,7 +410,7 @@ class CloudComm {
                        http.setConnectTimeout(TIMEOUT_MILLIS);
                        http.setReadTimeout(TIMEOUT_MILLIS);
 
-                       
+
 
                        http.connect();
                        timer.endTime();
@@ -375,12 +429,12 @@ class CloudComm {
                }
 
                try {
-                       
+
                        timer.startTime();
-                       InputStream is = http.getInputStream(); 
+                       InputStream is = http.getInputStream();
                        DataInputStream dis = new DataInputStream(is);
                        byte[] resptype = new byte[7];
-                       
+
                        dis.readFully(resptype);
                        timer.endTime();
 
@@ -412,10 +466,17 @@ class CloudComm {
 
                for (int i = 0; i < numberofslots; i++) {
 
-                       byte[] data = new byte[sizesofslots[i]];
-                       dis.readFully(data);
+                       byte[] rawData = new byte[sizesofslots[i]];
+                       dis.readFully(rawData);
+
+
+                       // byte[] data = new byte[rawData.length - IV_SIZE];
+                       // System.arraycopy(rawData, IV_SIZE, data, 0, data.length);
 
-                       data = decryptCipher.doFinal(data);
+
+                       byte[] data = stripIVAndDecryptSlot(rawData);
+
+                       // data = decryptCipher.doFinal(data);
 
                        slots[i] = Slot.decode(table, data, mac);
                }
@@ -423,13 +484,12 @@ class CloudComm {
                return slots;
        }
 
-       public byte[] sendLocalData(byte[] sendData, String host, int port) {
+       public byte[] sendLocalData(byte[] sendData, long localSequenceNumber, String host, int port) {
 
                if (salt == null) {
                        return null;
                }
                try {
-
                        System.out.println("Passing Locally");
 
                        mac.update(sendData);
@@ -440,7 +500,9 @@ class CloudComm {
 
                        // Encrypt the data for sending
                        // byte[] encryptedData = encryptCipher.doFinal(totalData);
-                       byte[] encryptedData = encryptCipher.doFinal(totalData);
+                       // byte[] encryptedData = encryptCipher.doFinal(totalData);
+                       byte[] iv = createIV(table.getMachineId(), table.getLocalSequenceNumber());
+                       byte[] encryptedData = encryptSlotAndPrependIV(totalData, iv);
 
                        // Open a TCP socket connection to a local device
                        Socket socket = new Socket(host, port);
@@ -461,7 +523,9 @@ class CloudComm {
 
                        timer.endTime();
 
-                       returnData = decryptCipher.doFinal(returnData);
+                       // returnData = decryptCipher.doFinal(returnData);
+                       returnData = stripIVAndDecryptSlot(returnData);
+                       // returnData = decryptCipher.doFinal(returnData);
 
                        // We are done with this socket
                        socket.close();
@@ -478,15 +542,9 @@ class CloudComm {
                        System.arraycopy(returnData, 0, returnData2, 0, returnData2.length);
 
                        return returnData2;
-               } catch (SocketTimeoutException e) {
-
-               } catch (BadPaddingException e) {
-
-               } catch (IllegalBlockSizeException e) {
-
-               } catch (UnknownHostException e) {
-
-               } catch (IOException e) {
+               } catch (Exception e) {
+                       e.printStackTrace();
+                       // throw new Error("Local comms failure...");
 
                }
 
@@ -524,7 +582,8 @@ class CloudComm {
                                timer.endTime();
 
                                // Decrypt the data
-                               readData = decryptCipher.doFinal(readData);
+                               // readData = decryptCipher.doFinal(readData);
+                               readData = stripIVAndDecryptSlot(readData);
 
                                mac.update(readData, 0, readData.length - HMAC_SIZE);
                                byte[] genmac = mac.doFinal();
@@ -541,6 +600,7 @@ class CloudComm {
                                // byte[] sendData = table.acceptDataFromLocal(readData);
                                byte[] sendData = table.acceptDataFromLocal(returnData);
 
+
                                mac.update(sendData);
                                byte[] realmac = mac.doFinal();
                                byte[] totalData = new byte[sendData.length + realmac.length];
@@ -548,7 +608,9 @@ class CloudComm {
                                System.arraycopy(realmac, 0, totalData, sendData.length, realmac.length);
 
                                // Encrypt the data for sending
-                               byte[] encryptedData = encryptCipher.doFinal(totalData);
+                               // byte[] encryptedData = encryptCipher.doFinal(totalData);
+                               byte[] iv = createIV(table.getMachineId(), table.getLocalSequenceNumber());
+                               byte[] encryptedData = encryptSlotAndPrependIV(totalData, iv);
 
 
                                timer.startTime();
@@ -559,15 +621,7 @@ class CloudComm {
 
                                // close the socket
                                socket.close();
-                       } catch (SocketTimeoutException e) {
-
-                       } catch (BadPaddingException e) {
-
-                       } catch (IllegalBlockSizeException e) {
-
-                       } catch (UnknownHostException e) {
-
-                       } catch (IOException e) {
+                       } catch (Exception e) {
 
                        }
                }
@@ -604,5 +658,4 @@ class CloudComm {
                        super.finalize();
                }
        }
-
 }