X-Git-Url: http://demsky.eecs.uci.edu/git/?a=blobdiff_plain;f=cyclegraph.h;h=f2f30329203c226c5a7a1c6140fa3043bb260613;hb=d70f6f259c9850e5fceb527e3a9541c440c0146b;hp=d9fa631879b361923ea3cf6f9bc21740983b0acf;hpb=61fb4abad48596608278bfb8c3c78c0861a5978b;p=model-checker.git

diff --git a/cyclegraph.h b/cyclegraph.h
index d9fa631..f2f3032 100644
--- a/cyclegraph.h
+++ b/cyclegraph.h
@@ -1,9 +1,13 @@
-/** @file cyclegraph.h @brief Data structure to track ordering
- *  constraints on modification order.  The idea is to see whether a
- *  total order exists that satisfies the ordering constriants.*/
+/**
+ * @file cyclegraph.h
+ * @brief Data structure to track ordering constraints on modification order
+ *
+ * Used to determine whether a total order exists that satisfies the ordering
+ * constraints.
+ */
 
-#ifndef CYCLEGRAPH_H
-#define CYCLEGRAPH_H
+#ifndef __CYCLEGRAPH_H__
+#define __CYCLEGRAPH_H__
 
 #include "hashtable.h"
 #include <vector>
@@ -21,23 +25,24 @@ class CycleGraph {
 	CycleGraph();
 	~CycleGraph();
 	void addEdge(const ModelAction *from, const ModelAction *to);
-	bool checkForCycles();
-	bool checkForRMWViolation();
+	bool checkForCycles() const;
+	bool checkForRMWViolation() const;
 	void addRMWEdge(const ModelAction *from, const ModelAction *rmw);
-	bool checkPromise(const ModelAction *from, Promise *p);
-	bool checkReachable(const ModelAction *from, const ModelAction *to);
+	bool checkPromise(const ModelAction *from, Promise *p) const;
+	bool checkReachable(const ModelAction *from, const ModelAction *to) const;
 	void startChanges();
 	void commitChanges();
 	void rollbackChanges();
 #if SUPPORT_MOD_ORDER_DUMP
-	void dumpNodes(FILE *file);
-	void dumpGraphToFile(const char * filename);
+	void dumpNodes(FILE *file) const;
+	void dumpGraphToFile(const char *filename) const;
 #endif
 
 	SNAPSHOTALLOC
  private:
+	void putNode(const ModelAction *act, CycleNode *node);
 	CycleNode * getNode(const ModelAction *);
-	HashTable<CycleNode *, CycleNode *, uintptr_t, 4, model_malloc, model_calloc, model_free> * discovered;
+	HashTable<CycleNode *, CycleNode *, uintptr_t, 4, model_malloc, model_calloc, model_free> *discovered;
 
 	/** @brief A table for mapping ModelActions to CycleNodes */
 	HashTable<const ModelAction *, CycleNode *, uintptr_t, 4> actionToNode;
@@ -45,7 +50,7 @@ class CycleGraph {
 	std::vector<CycleNode *> nodeList;
 #endif
 
-	bool checkReachable(CycleNode *from, CycleNode *to);
+	bool checkReachable(CycleNode *from, CycleNode *to) const;
 
 	/** @brief A flag: true if this graph contains cycles */
 	bool hasCycles;
@@ -54,26 +59,28 @@ class CycleGraph {
 	bool hasRMWViolation;
 	bool oldRMWViolation;
 
-	std::vector<CycleNode *> rollbackvector;
-	std::vector<CycleNode *> rmwrollbackvector;
+	std::vector< CycleNode *, SnapshotAlloc<CycleNode *> > rollbackvector;
+	std::vector< CycleNode *, SnapshotAlloc<CycleNode *> > rmwrollbackvector;
 };
 
 /** @brief A node within a CycleGraph; corresponds to one ModelAction */
 class CycleNode {
  public:
-	CycleNode(const ModelAction *action);
-	bool addEdge(CycleNode * node);
+	CycleNode(const ModelAction *act);
+	bool addEdge(CycleNode *node);
 	CycleNode * getEdge(unsigned int i) const;
 	unsigned int getNumEdges() const;
+	CycleNode * getBackEdge(unsigned int i) const;
+	unsigned int getNumBackEdges() const;
 	bool setRMW(CycleNode *);
-	CycleNode* getRMW();
-	const ModelAction * getAction() {return action;};
+	CycleNode * getRMW() const;
+	const ModelAction * getAction() const { return action; }
 
 	void popEdge() {
 		edges.pop_back();
-	};
+	}
 	void clearRMW() {
-		hasRMW=NULL;
+		hasRMW = NULL;
 	}
 
 	SNAPSHOTALLOC
@@ -82,11 +89,14 @@ class CycleNode {
 	const ModelAction *action;
 
 	/** @brief The edges leading out from this node */
-	std::vector<CycleNode *, SnapshotAlloc<CycleNode *> > edges;
+	std::vector< CycleNode *, SnapshotAlloc<CycleNode *> > edges;
+
+	/** @brief The edges leading into this node */
+	std::vector< CycleNode *, SnapshotAlloc<CycleNode *> > back_edges;
 
 	/** Pointer to a RMW node that reads from this node, or NULL, if none
 	 * exists */
-	CycleNode * hasRMW;
+	CycleNode *hasRMW;
 };
 
-#endif
+#endif /* __CYCLEGRAPH_H__ */