X-Git-Url: http://demsky.eecs.uci.edu/git/?a=blobdiff_plain;f=docs%2FDeveloperPolicy.html;h=144c55ac0d8a3ca7b4e1981a461f45993355ff8e;hb=ebb5a971d903aa4479bb2a21472597319a9b0086;hp=e5e7b12b5f8703a6db55be9bf21af95eee1e8d34;hpb=7d8012b602ee3456072bf61a10574d8753990eac;p=oota-llvm.git diff --git a/docs/DeveloperPolicy.html b/docs/DeveloperPolicy.html index e5e7b12b5f8..144c55ac0d8 100644 --- a/docs/DeveloperPolicy.html +++ b/docs/DeveloperPolicy.html @@ -15,6 +15,7 @@
This policy is aimed at frequent contributors to LLVM. People interested in @@ -93,16 +94,15 @@
When making a patch for review, the goal is to make it as easy for the reviewer to read it as possible. As such, we recommend that you:
cvs diff -Ntdup -5+
svn diff -x -uor with the utility utils/mkpatch, which makes it easy to read the diff.
Developers should participate in code reviews as both reviewers and reviewees. If someone is kind enough to review your code, you should return the favor for someone else. Note that anyone is welcome to review - and give feedback on a patch, but only people with CVS write access can - approve it.
+ and give feedback on a patch, but only people with Subversion write access + can approve it. + + +The LLVM Project relies on two features of its process to maintain rapid + development in addition to the high quality of its source base: the + combination of code review plus post-commit review for trusted maintainers. + Having both is a great way for the project to take advantage of the fact + that most people do the right thing most of the time, and only commit + patches without pre-commit review when they are confident they are + right.
+ +The trick to this is that the project has to guarantee that all patches + that are committed are reviewed after they go in: you don't want everyone + to assume someone else will review it, allowing the patch to go unreviewed. + To solve this problem, we have a notion of an 'owner' for a piece of the + code. The sole responsibility of a code owner is to ensure that a commit + to their area of the code is appropriately reviewed, either by themself or + by someone else. The current code owners are:
+ +Note that code ownership is completely different than reviewers: anyone can + review a piece of code, and we welcome code review from anyone who is + interested. Code owners are the "last line of defense" to guarantee that + all patches that are committed are actually reviewed.
+ +Being a code owner is a somewhat unglamorous position, but it is incredibly + important for the ongoing success of the project. Because people get busy, + interests change, and unexpected things happen, code ownership is purely + opt-in, and anyone can choose to resign their "title" at any time. For now, + we do not have an official policy on how one gets elected to be a code + owner. +
+ +We grant commit access to contributors with a track record of submitting high -quality patches. If you would like commit access, please send an email to the -LLVM oversight group.
+quality patches. If you would like commit access, please send an email to +Chris with the following information: + +Once you've been granted commit access, you should be able to check out an + LLVM tree with an SVN URL of "https://username@llvm.org/..." instead of the + normal anonymous URL of "http://llvm.org/...". The first time you commit + you'll have to type in your password. Note that you may get a warning from + SVN about an untrusted key, you can ignore this. To verify that your commit + access works, please do a test commit (e.g. change a comment or add a blank + line). Your first commit to a repository may require the autogenerated email + to be approved by a mailing list. This is normal, and will be done when + the mailing list owner has time.
If you have recently been granted commit access, these policies apply:
+In any case, your changes are still subject to code review (either before or after they are committed, depending on the nature of the change). You are encouraged to review other peoples' patches as well, -but your aren't required to.
+but you aren't required to.We believe in correct attribution of contributions to their contributors. However, we do not want the source code to be littered - with random attributions (this is noisy/distracting and revision control - keeps a perfect history of this anyway). As such, we follow these rules:
-Overall, please do not add contributor names to the source base.
Although UIUC may eventually reassign the copyright of the software to another - entity (e.g. a dedicated non-profit "LLVM Organization", or something) + entity (e.g. a dedicated non-profit "LLVM Organization") the intent for the project is to always have a single entity hold the copyrights to LLVM at any given time.
@@ -417,6 +467,7 @@ Changes reduces the managerial burden for any kind of administrative or technical decisions about LLVM. The goal of the LLVM project is to always keep the code open and licensed under a very liberal license. + @@ -430,7 +481,8 @@ ChangesWe have no plans to change the license of LLVM. If you have questions @@ -470,9 +522,11 @@ Changes arbitrary purposes (including commercial use).
When contributing code, we expect contributors to notify us of any potential - for patent-related trouble with their changes. If you own the rights to a + for patent-related trouble with their changes. If you or your employer + own the rights to a patent and would like to contribute code to LLVM that relies on it, we - require that you sign an agreement that allows any other user of LLVM to + require that + the copyright owner sign an agreement that allows any other user of LLVM to freely use your patent. Please contact the oversight group for more details.
@@ -487,6 +541,11 @@ Changes the entire software base can be managed by a single copyright holder. This implies that any contributions can be licensed under the license that the project uses. + +When contributing code, you also affirm that you are legally entitled to + grant this copyright, personally or on behalf of your employer. If the code + belongs to some other entity, please raise this issue with the oversight + group before the code is committed.