X-Git-Url: http://demsky.eecs.uci.edu/git/?a=blobdiff_plain;f=lib%2FVMCore%2FPassRegistry.cpp;h=2df65572c59298caac6065ee583bbc5ed5259a72;hb=4903c15b7d92802a4f0f28928a89bb4c0d5e212f;hp=0b4e59dc0e608385e7365353004f6b373915df91;hpb=b6d760c7d5e8496475a0063c32f87bd6161cb2db;p=oota-llvm.git diff --git a/lib/VMCore/PassRegistry.cpp b/lib/VMCore/PassRegistry.cpp index 0b4e59dc0e6..2df65572c59 100644 --- a/lib/VMCore/PassRegistry.cpp +++ b/lib/VMCore/PassRegistry.cpp @@ -16,16 +16,18 @@ #include "llvm/PassSupport.h" #include "llvm/Support/Compiler.h" #include "llvm/Support/ManagedStatic.h" +#include "llvm/Support/Mutex.h" #include "llvm/ADT/DenseMap.h" #include "llvm/ADT/SmallPtrSet.h" #include "llvm/ADT/StringMap.h" +#include "llvm/Function.h" #include using namespace llvm; // FIXME: We use ManagedStatic to erase the pass registrar on shutdown. // Unfortunately, passes are registered with static ctors, and having -// llvm_shutdown clear this map prevents successful ressurection after +// llvm_shutdown clear this map prevents successful resurrection after // llvm_shutdown is run. Ideally we should find a solution so that we don't // leak the map, AND can still resurrect after shutdown. static ManagedStatic PassRegistryObj; @@ -33,10 +35,13 @@ PassRegistry *PassRegistry::getPassRegistry() { return &*PassRegistryObj; } +static ManagedStatic > Lock; + //===----------------------------------------------------------------------===// // PassRegistryImpl // +namespace { struct PassRegistryImpl { /// PassInfoMap - Keep track of the PassInfo object for each registered pass. typedef DenseMap MapType; @@ -51,8 +56,10 @@ struct PassRegistryImpl { }; DenseMap AnalysisGroupInfoMap; + std::vector ToFree; std::vector Listeners; }; +} // end anonymous namespace void *PassRegistry::getImpl() const { if (!pImpl) @@ -65,18 +72,26 @@ void *PassRegistry::getImpl() const { // PassRegistry::~PassRegistry() { + sys::SmartScopedLock Guard(*Lock); PassRegistryImpl *Impl = static_cast(pImpl); - if (Impl) delete Impl; + + for (std::vector::iterator I = Impl->ToFree.begin(), + E = Impl->ToFree.end(); I != E; ++I) + delete *I; + + delete Impl; pImpl = 0; } const PassInfo *PassRegistry::getPassInfo(const void *TI) const { + sys::SmartScopedLock Guard(*Lock); PassRegistryImpl *Impl = static_cast(getImpl()); PassRegistryImpl::MapType::const_iterator I = Impl->PassInfoMap.find(TI); return I != Impl->PassInfoMap.end() ? I->second : 0; } const PassInfo *PassRegistry::getPassInfo(StringRef Arg) const { + sys::SmartScopedLock Guard(*Lock); PassRegistryImpl *Impl = static_cast(getImpl()); PassRegistryImpl::StringMapType::const_iterator I = Impl->PassInfoStringMap.find(Arg); @@ -87,22 +102,25 @@ const PassInfo *PassRegistry::getPassInfo(StringRef Arg) const { // Pass Registration mechanism // -void PassRegistry::registerPass(const PassInfo &PI) { - sys::SmartScopedLock Guard(Lock); +void PassRegistry::registerPass(const PassInfo &PI, bool ShouldFree) { + sys::SmartScopedLock Guard(*Lock); PassRegistryImpl *Impl = static_cast(getImpl()); bool Inserted = Impl->PassInfoMap.insert(std::make_pair(PI.getTypeInfo(),&PI)).second; - assert(Inserted && "Pass registered multiple times!"); Inserted=Inserted; + assert(Inserted && "Pass registered multiple times!"); + (void)Inserted; Impl->PassInfoStringMap[PI.getPassArgument()] = Π // Notify any listeners. for (std::vector::iterator I = Impl->Listeners.begin(), E = Impl->Listeners.end(); I != E; ++I) (*I)->passRegistered(&PI); + + if (ShouldFree) Impl->ToFree.push_back(&PI); } void PassRegistry::unregisterPass(const PassInfo &PI) { - sys::SmartScopedLock Guard(Lock); + sys::SmartScopedLock Guard(*Lock); PassRegistryImpl *Impl = static_cast(getImpl()); PassRegistryImpl::MapType::iterator I = Impl->PassInfoMap.find(PI.getTypeInfo()); @@ -114,7 +132,7 @@ void PassRegistry::unregisterPass(const PassInfo &PI) { } void PassRegistry::enumerateWith(PassRegistrationListener *L) { - sys::SmartScopedLock Guard(Lock); + sys::SmartScopedLock Guard(*Lock); PassRegistryImpl *Impl = static_cast(getImpl()); for (PassRegistryImpl::MapType::const_iterator I = Impl->PassInfoMap.begin(), E = Impl->PassInfoMap.end(); I != E; ++I) @@ -126,8 +144,8 @@ void PassRegistry::enumerateWith(PassRegistrationListener *L) { void PassRegistry::registerAnalysisGroup(const void *InterfaceID, const void *PassID, PassInfo& Registeree, - bool isDefault) { - sys::SmartScopedLock Guard(Lock); + bool isDefault, + bool ShouldFree) { PassInfo *InterfaceInfo = const_cast(getPassInfo(InterfaceID)); if (InterfaceInfo == 0) { // First reference to Interface, register it now. @@ -142,6 +160,8 @@ void PassRegistry::registerAnalysisGroup(const void *InterfaceID, assert(ImplementationInfo && "Must register pass before adding to AnalysisGroup!"); + sys::SmartScopedLock Guard(*Lock); + // Make sure we keep track of the fact that the implementation implements // the interface. ImplementationInfo->addInterfaceImplemented(InterfaceInfo); @@ -160,16 +180,19 @@ void PassRegistry::registerAnalysisGroup(const void *InterfaceID, InterfaceInfo->setNormalCtor(ImplementationInfo->getNormalCtor()); } } + + PassRegistryImpl *Impl = static_cast(getImpl()); + if (ShouldFree) Impl->ToFree.push_back(&Registeree); } void PassRegistry::addRegistrationListener(PassRegistrationListener *L) { - sys::SmartScopedLock Guard(Lock); + sys::SmartScopedLock Guard(*Lock); PassRegistryImpl *Impl = static_cast(getImpl()); Impl->Listeners.push_back(L); } void PassRegistry::removeRegistrationListener(PassRegistrationListener *L) { - sys::SmartScopedLock Guard(Lock); + sys::SmartScopedLock Guard(*Lock); // NOTE: This is necessary, because removeRegistrationListener() can be called // as part of the llvm_shutdown sequence. Since we have no control over the