X-Git-Url: http://demsky.eecs.uci.edu/git/?a=blobdiff_plain;f=unittests%2FSupport%2FAlignOfTest.cpp;h=40f729585728cc193fff4f3f98151eb13f2a2387;hb=7172b38af7ed5d1c1e2c97fadfb0ae0c19aff816;hp=c413451f9046ef8a4cfb99d8bf142395cc4ac57c;hpb=9755cd600f7a1bbdc080bbfcbd2529a54e1b3aab;p=oota-llvm.git diff --git a/unittests/Support/AlignOfTest.cpp b/unittests/Support/AlignOfTest.cpp index c413451f904..40f72958572 100644 --- a/unittests/Support/AlignOfTest.cpp +++ b/unittests/Support/AlignOfTest.cpp @@ -1,4 +1,4 @@ -//===- llvm/unittest/Support/AlignOfTest.cpp - Alignment utility tests ----===// +//=== - llvm/unittest/Support/AlignOfTest.cpp - Alignment utility tests ----===// // // The LLVM Compiler Infrastructure // @@ -9,39 +9,49 @@ #include "llvm/Support/AlignOf.h" #include "llvm/Support/Compiler.h" - #include "gtest/gtest.h" using namespace llvm; namespace { +// Disable warnings about questionable type definitions. +// We're testing that even questionable types work with the alignment utilities. +#ifdef _MSC_VER +#pragma warning(disable:4584) +#endif + +// Suppress direct base '{anonymous}::S1' inaccessible in '{anonymous}::D9' +// due to ambiguity warning. +// +// Pragma based warning suppression was introduced in GGC 4.2. Additionally +// this warning is "enabled by default". The warning still appears if -Wall is +// suppressed. Apparently GCC suppresses it when -w is specifed, which is odd. +// At any rate, clang on the other hand gripes about -Wunknown-pragma, so +// leaving it out of this. +#if ((__GNUC__ * 100) + __GNUC_MINOR__) >= 402 && !defined(__clang__) +#pragma GCC diagnostic warning "-w" +#endif // Define some fixed alignment types to use in these tests. -#if __cplusplus == 201103L || __has_feature(cxx_alignas) -typedef char alignas(1) A1; -typedef char alignas(2) A2; -typedef char alignas(4) A4; -typedef char alignas(8) A8; -#elif defined(__clang__) || defined(__GNUC__) -typedef char A1 __attribute__((aligned(1))); -typedef char A2 __attribute__((aligned(2))); -typedef char A4 __attribute__((aligned(4))); -typedef char A8 __attribute__((aligned(8))); +#if __has_feature(cxx_alignas) +struct alignas(1) A1 { }; +struct alignas(2) A2 { }; +struct alignas(4) A4 { }; +struct alignas(8) A8 { }; +#elif defined(__GNUC__) +struct A1 { } __attribute__((aligned(1))); +struct A2 { } __attribute__((aligned(2))); +struct A4 { } __attribute__((aligned(4))); +struct A8 { } __attribute__((aligned(8))); #elif defined(_MSC_VER) -typedef __declspec(align(1)) char A1; -typedef __declspec(align(2)) char A2; -typedef __declspec(align(4)) char A4; -typedef __declspec(align(8)) char A8; +__declspec(align(1)) struct A1 { }; +__declspec(align(2)) struct A2 { }; +__declspec(align(4)) struct A4 { }; +__declspec(align(8)) struct A8 { }; #else # error No supported align as directive. #endif -// Wrap the forced aligned types in structs to hack around compiler bugs. -struct SA1 { A1 a; }; -struct SA2 { A2 a; }; -struct SA4 { A4 a; }; -struct SA8 { A8 a; }; - struct S1 {}; struct S2 { char a; }; struct S3 { int x; }; @@ -66,6 +76,17 @@ struct V6 : S1 { virtual ~V6(); }; struct V7 : virtual V2, virtual V6 { virtual ~V7(); }; struct V8 : V5, virtual V6, V7 { double zz; virtual ~V8(); }; +double S6::f() { return 0.0; } +float D2::g() { return 0.0f; } +V1::~V1() {} +V2::~V2() {} +V3::~V3() {} +V4::~V4() {} +V5::~V5() {} +V6::~V6() {} +V7::~V7() {} +V8::~V8() {} + // Ensure alignment is a compile-time constant. char LLVM_ATTRIBUTE_UNUSED test_arr1 [AlignOf::Alignment > 0] @@ -84,11 +105,7 @@ char LLVM_ATTRIBUTE_UNUSED test_arr2 [AlignOf::Alignment > 0] [AlignOf::Alignment > 0] [AlignOf::Alignment > 0] - [AlignOf::Alignment > 0] - [AlignOf::Alignment > 0] - [AlignOf::Alignment > 0] - [AlignOf::Alignment > 0] - [AlignOf::Alignment > 0]; + [AlignOf::Alignment > 0]; char LLVM_ATTRIBUTE_UNUSED test_arr3 [AlignOf::Alignment > 0] [AlignOf::Alignment > 0] @@ -117,20 +134,10 @@ char LLVM_ATTRIBUTE_UNUSED test_arr5 [AlignOf::Alignment > 0]; TEST(AlignOfTest, BasicAlignmentInvariants) { - // For a very strange reason, many compilers do not support this. Both Clang - // and GCC fail to align these properly. - EXPECT_EQ(1u, alignOf()); -#if 0 - EXPECT_EQ(2u, alignOf()); - EXPECT_EQ(4u, alignOf()); - EXPECT_EQ(8u, alignOf()); -#endif - - // But once wrapped in structs, the alignment is correctly managed. - EXPECT_LE(1u, alignOf()); - EXPECT_LE(2u, alignOf()); - EXPECT_LE(4u, alignOf()); - EXPECT_LE(8u, alignOf()); + EXPECT_LE(1u, alignOf()); + EXPECT_LE(2u, alignOf()); + EXPECT_LE(4u, alignOf()); + EXPECT_LE(8u, alignOf()); EXPECT_EQ(1u, alignOf()); EXPECT_LE(alignOf(), alignOf()); @@ -139,7 +146,7 @@ TEST(AlignOfTest, BasicAlignmentInvariants) { EXPECT_LE(alignOf(), alignOf()); EXPECT_LE(alignOf(), alignOf()); EXPECT_LE(alignOf(), alignOf()); - EXPECT_LE(alignOf(), alignOf()); + EXPECT_LE(alignOf(), alignOf()); EXPECT_LE(alignOf(), alignOf()); EXPECT_EQ(alignOf(), alignOf()); EXPECT_LE(alignOf(), alignOf()); @@ -168,85 +175,161 @@ TEST(AlignOfTest, BasicAlignmentInvariants) { } TEST(AlignOfTest, BasicAlignedArray) { - // Note: this code exclusively uses the struct-wrapped arbitrarily aligned - // types because of the bugs mentioned above where GCC and Clang both - // disregard the arbitrary alignment specifier until the type is used to - // declare a member of a struct. - EXPECT_LE(1u, alignOf::union_type>()); - EXPECT_LE(2u, alignOf::union_type>()); - EXPECT_LE(4u, alignOf::union_type>()); - EXPECT_LE(8u, alignOf::union_type>()); - - EXPECT_LE(1u, sizeof(AlignedCharArray::union_type)); - EXPECT_LE(2u, sizeof(AlignedCharArray::union_type)); - EXPECT_LE(4u, sizeof(AlignedCharArray::union_type)); - EXPECT_LE(8u, sizeof(AlignedCharArray::union_type)); - - EXPECT_EQ(1u, (alignOf::union_type>())); - EXPECT_EQ(2u, (alignOf::union_type>())); - EXPECT_EQ(4u, (alignOf::union_type>())); - EXPECT_EQ(8u, (alignOf::union_type>())); - - EXPECT_EQ(1u, sizeof(AlignedCharArray::union_type)); - EXPECT_EQ(2u, sizeof(AlignedCharArray::union_type)); - EXPECT_EQ(4u, sizeof(AlignedCharArray::union_type)); - EXPECT_EQ(8u, sizeof(AlignedCharArray::union_type)); - - EXPECT_EQ(1u, (alignOf::union_type>())); - EXPECT_EQ(2u, (alignOf::union_type>())); - EXPECT_EQ(4u, (alignOf::union_type>())); - EXPECT_EQ(8u, (alignOf::union_type>())); - - EXPECT_EQ(1u, sizeof(AlignedCharArray::union_type)); - EXPECT_EQ(2u, sizeof(AlignedCharArray::union_type)); - EXPECT_EQ(4u, sizeof(AlignedCharArray::union_type)); - EXPECT_EQ(16u, sizeof(AlignedCharArray::union_type)); + EXPECT_LE(1u, alignOf >()); + EXPECT_LE(2u, alignOf >()); + EXPECT_LE(4u, alignOf >()); + EXPECT_LE(8u, alignOf >()); + + EXPECT_LE(1u, sizeof(AlignedCharArrayUnion)); + EXPECT_LE(2u, sizeof(AlignedCharArrayUnion)); + EXPECT_LE(4u, sizeof(AlignedCharArrayUnion)); + EXPECT_LE(8u, sizeof(AlignedCharArrayUnion)); + + EXPECT_EQ(1u, (alignOf >())); + EXPECT_EQ(2u, (alignOf >())); + EXPECT_EQ(4u, (alignOf >())); + EXPECT_EQ(8u, (alignOf >())); + + EXPECT_EQ(1u, sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(2u, sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(4u, sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(8u, sizeof(AlignedCharArrayUnion)); + + EXPECT_EQ(1u, (alignOf >())); + EXPECT_EQ(2u, (alignOf >())); + EXPECT_EQ(4u, (alignOf >())); + EXPECT_EQ(8u, (alignOf >())); + + EXPECT_EQ(1u, sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(2u, sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(4u, sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(16u, sizeof(AlignedCharArrayUnion)); // For other tests we simply assert that the alignment of the union mathes // that of the fundamental type and hope that we have any weird type // productions that would trigger bugs. - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); EXPECT_EQ(alignOf(), - alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); + alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); EXPECT_EQ(alignOf(), - alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); + alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); EXPECT_EQ(alignOf(), - alignOf::union_type>()); + alignOf >()); EXPECT_EQ(alignOf(), - alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); - EXPECT_EQ(alignOf(), alignOf::union_type>()); -} + alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + EXPECT_EQ(alignOf(), alignOf >()); + + // Some versions of MSVC get this wrong somewhat disturbingly. The failure + // appears to be benign: alignOf() produces a preposterous value: 12 +#ifndef _MSC_VER + EXPECT_EQ(alignOf(), alignOf >()); +#endif + EXPECT_EQ(sizeof(char), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(char[1]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(char[2]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(char[3]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(char[4]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(char[5]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(char[8]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(char[13]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(char[16]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(char[21]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(char[32]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(short), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(int), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(long), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(long long), + sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(float), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(double), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(long double), + sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(void *), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(int *), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(double (*)(double)), + sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(double (S6::*)()), + sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(S1), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(S2), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(S3), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(S4), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(S5), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(S6), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D1), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D2), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D3), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D4), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D5), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D6), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D7), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D8), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9[1]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9[2]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9[3]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9[4]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9[5]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9[8]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9[13]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9[16]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9[21]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(D9[32]), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(V1), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(V2), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(V3), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(V4), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(V5), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(V6), sizeof(AlignedCharArrayUnion)); + EXPECT_EQ(sizeof(V7), sizeof(AlignedCharArrayUnion)); + + // Some versions of MSVC also get this wrong. The failure again appears to be + // benign: sizeof(V8) is only 52 bytes, but our array reserves 56. +#ifndef _MSC_VER + EXPECT_EQ(sizeof(V8), sizeof(AlignedCharArrayUnion)); +#endif + + EXPECT_EQ(1u, (alignOf >())); + EXPECT_EQ(2u, (alignOf >())); + EXPECT_EQ(4u, (alignOf >())); + EXPECT_EQ(8u, (alignOf >())); + EXPECT_EQ(16u, (alignOf >())); + + EXPECT_EQ(1u, sizeof(AlignedCharArray<1, 1>)); + EXPECT_EQ(7u, sizeof(AlignedCharArray<1, 7>)); + EXPECT_EQ(2u, sizeof(AlignedCharArray<2, 2>)); + EXPECT_EQ(16u, sizeof(AlignedCharArray<2, 16>)); +} }