net: packet: fix information leak to userland
authorVasiliy Kulikov <segooon@gmail.com>
Wed, 10 Nov 2010 20:09:10 +0000 (12:09 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 7 Jan 2011 21:58:29 +0000 (13:58 -0800)
commit030803563383228d71ff3c4f83e3b6e4314fdc1c
tree43c0af18bffce82cae72f6968616961af1c6f88d
parentb1b27e4a677bc8c92b3c83541b4981c000934bc2
net: packet: fix information leak to userland

[ Upstream commit 67286640f638f5ad41a946b9a3dc75327950248f ]

packet_getname_spkt() doesn't initialize all members of sa_data field of
sockaddr struct if strlen(dev->name) < 13.  This structure is then copied
to userland.  It leads to leaking of contents of kernel stack memory.
We have to fully fill sa_data with strncpy() instead of strlcpy().

The same with packet_getname(): it doesn't initialize sll_pkttype field of
sockaddr_ll.  Set it to zero.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/packet/af_packet.c