projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 496a113) | patch
Fix cancel in ThreadWheelTimeKeeper
authorDave Watson <davejwatson@fb.com>
Wed, 27 May 2015 18:20:40 +0000 (11:20 -0700)
committerPavlo Kushnir <pavlo@fb.com>
Thu, 28 May 2015 00:54:30 +0000 (17:54 -0700)
commit03439afb970453a0ae932cd0fc8f3ad24f40d8e5
treef5d583cb958f38a9b5d9e923398ab93cdeed515atree | snapshot
parent496a11391648ad871f5b6441cf8c9c61f1df74d3commit | diff
Fix cancel in ThreadWheelTimeKeeper

Summary: This is actually a bug, future.cancel() doesn't work with the current THreadWheelTimekeeper, because cancel() only works from the eventBase thread.

Test Plan: added unittest.  Crashes before, passes now

Reviewed By: hans@fb.com

Subscribers: doug, folly-diffs@, jsedgwick, yfeldblum, chalfant

FB internal diff: D2091531

Signature: t1:2091531:1432224024:4aa5dd71de15b1344034a414d47c97ffaba68949
folly/futures/detail/ThreadWheelTimekeeper.cpp diff | blob | history
folly/futures/test/TimekeeperTest.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.