Delete | operator for Subprocess::Options
authorAlexey Spiridonov <lesha@fb.com>
Wed, 12 Apr 2017 21:43:03 +0000 (14:43 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Wed, 12 Apr 2017 21:55:36 +0000 (14:55 -0700)
commit0e5ec48b7d2e3c04b5b0454144b2e183d64e16ac
treea72851edad67f80d3418ca95ca4fa6feab0b96e7
parent6bb90698a194d181f9e0d962cd4eb622a1a5290a
Delete | operator for Subprocess::Options

Summary:
This operator is WRONG. It has not worked correctly for years, e.g. it lacks support for chdir, and several other options.

The operator is not really useful after C++11. Usually, you should just chain setters, e.g. `Subprocess::Options().pipeStdout().pipeStderr()`. If you must repeatedly mutate options in a fixed way, in the C++11 world you can use a lambda instead.

Reviewed By: yfeldblum

Differential Revision: D4862698

fbshipit-source-id: a2d8ace53424b9232e178cf202cf51beb7b59b12
folly/Subprocess.h
folly/test/SubprocessTest.cpp