Make Subprocess movable
Summary:
Subprocess doesn't have any non-movable members, and its implementation does not take addresses of the object, so I think it's safe. Move makes a bunch of code cleaner (you no longer have to wrap it in `std::unique_ptr` with associated clumsiness).
https://phabricator.fb.com/diffusion/FBCODE/browse/master/folly/Subprocess.h
Test Plan:
- unit test
- Searched for `this` in `Subprocess.{h,cpp}`.
- Inspected member variables: `pid_`, `returnCode_`, `pipes_`
- contbuild
Reviewed By: davejwatson@fb.com
Subscribers: folly-diffs@, yfeldblum, chalfant
FB internal diff:
D2079167
Signature: t1:
2079167:
1432048688:
26f96e29310298f47a9a9a7abef22dc863f68942