transportActive and transportInactive
authorJames Sedgwick <jsedgwick@fb.com>
Thu, 14 May 2015 00:43:44 +0000 (17:43 -0700)
committerViswanath Sivakumar <viswanath@fb.com>
Wed, 20 May 2015 17:57:05 +0000 (10:57 -0700)
commit1185881df4c4a6195f5cd99dae703a0ff0a1ec58
tree445ac16a0e09c272f39da275b28dfcec30669e6d
parentf639b4542e084dd4cd5130000b63384a53f50973
transportActive and transportInactive

Summary:
These are equivalents to Netty's channelActive and channelInactive, but we've been calling channels transports so I'm staying consistent.
I skipped integrating this into TAsyncTransportHandler because thrift still does manual CB attachment/detachment and it's unclear how that fits into this model
If my suspicions are correct, it *should* be possible to make attachReadCallback and detachReadCallback private in AsyncSocketHandler, right? And perhaps get rid of the event base modifier methods? What's our use case for those?

Test Plan: unit, employ in telnet server

Reviewed By: davejwatson@fb.com

Subscribers: fugalh, alandau, bmatheny, folly-diffs@, jsedgwick, yfeldblum, chalfant

FB internal diff: D2044520

Signature: t1:2044520:1431551998:af1de358b5dbefcca148814015d8e9f63f458d5d
folly/wangle/bootstrap/ClientBootstrap.h
folly/wangle/bootstrap/ServerBootstrap-inl.h
folly/wangle/channel/AsyncSocketHandler.h
folly/wangle/channel/Handler.h
folly/wangle/channel/HandlerContext-inl.h
folly/wangle/channel/HandlerContext.h
folly/wangle/channel/Pipeline-inl.h
folly/wangle/channel/Pipeline.h
folly/wangle/channel/test/OutputBufferingHandlerTest.cpp
folly/wangle/channel/test/PipelineTest.cpp