Remove try/catch(...) from Win32/Signals.inc.
authorMikhail Glushenkov <foldr@codedgers.com>
Wed, 27 Oct 2010 09:09:04 +0000 (09:09 +0000)
committerMikhail Glushenkov <foldr@codedgers.com>
Wed, 27 Oct 2010 09:09:04 +0000 (09:09 +0000)
commit11d03f690e7fe019c33c3a066a9171c61f6d61f9
tree35890292407708c7f2a6918488ad1e66909a7344
parentd33b77bbb04d8f90e58cd83f695745ba21178d41
Remove try/catch(...) from Win32/Signals.inc.

catch(...) is used in Win32/Signals.inc for catching Win32 structured
exceptions, but according to [1], this is wrong.

We can't simply change try/catch to __try/__finally, since this syntax is not
supported by MinGW. We can use __try/__finally on MSVC and __try1/__except1
macros on MinGW [2], but I think that that solution obfuscates the code too
much.

The use of try/catch(...) in Signals.inc makes it impossible to link
MinGW-compiled libSystem with llvm-gcc compiled executables. I propose that we
just remove try/catch(...) from Signals.inc, since the meaning of the code won't
change.

[1] http://members.cox.net/doug_web/eh.htm
[2] http://article.gmane.org/gmane.comp.compilers.llvm.cvs/81315

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@117442 91177308-0d34-0410-b5e6-96231b3b80d8
lib/System/Makefile
lib/System/Win32/Signals.inc