V4L/DVB (8988): S2API: Allow the properties to call legacy ioctls
authorSteven Toth <stoth@linuxtv.org>
Fri, 5 Sep 2008 00:19:43 +0000 (21:19 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 12 Oct 2008 11:37:03 +0000 (09:37 -0200)
commit13c97bf56724b4f2d3dac139fb4cb081a3c401dc
tree9b644b37993bb665301d147d03cbc045c388ada8
parent5bd1b66359437864e6b46420ba6770c2b1c4362c
V4L/DVB (8988): S2API: Allow the properties to call legacy ioctls

SET_TONE and SET_VOLTAGE were not previously implemented. Two options
existed. Either cut/paste from the previous ioctl handler into the
process_properties function, which is code duplication. Or, split
the current ioctl handler into it's two major pieces.

Piece 1, responsible for input validation and semaphore acquiring
Piece 2 the processing of the previous ioctls

and finally, a new third pieces where the array of properties
is processed, and can freely call the legacy ioctl handler without
having to re-acquire the fepriv->sem semaphore. This is a clean approach
and ensures the existing legacy ioctls are processed as they were previously
(but with an extra function call) and allows the new API to share code
without duplication.

Signed-off-by: Steven Toth <stoth@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/dvb-core/dvb_frontend.c