[media] uvcvideo: fix cropcap v4l2-compliance failure
authorHans Verkuil <hverkuil@xs4all.nl>
Fri, 3 Apr 2015 09:53:42 +0000 (06:53 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 10 Apr 2015 13:26:02 +0000 (10:26 -0300)
commit1461fe7ab6e61c4ad59f54e308872c0bae09d609
tree2beb3957c7edc8c425ed6a5e45f7a2f88e9acae3
parentbefd25a2bd61f1706508280f705e18be8b283e3e
[media] uvcvideo: fix cropcap v4l2-compliance failure

The v4l2-compliance tool expects that if VIDIOC_CROPCAP is defined, then
VIDIOC_G_SELECTION for TGT_CROP_BOUNDS/DEFAULT is also defined (or COMPOSE
in the case of an output device).

In fact, all that a driver has to do to implement cropcap is to support
those two targets since the v4l2 core will implement cropcap and fill in
the pixelaspect to 1/1 by default.

Implementing cropcap is only needed if the pixelaspect isn't square.

So implement g_selection instead of cropcap in uvc to fix the v4l2-compliance
failure.

[Added blank lines for improved readability]

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/uvc/uvc_v4l2.c