bridge: add missing bridge port check for offloads
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Fri, 6 Feb 2015 06:24:45 +0000 (22:24 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 8 Feb 2015 06:49:47 +0000 (22:49 -0800)
commit1fd0bddb618aa970b87e7907a5703682aa119a6f
treed8ed10105a874cdee1f6a7aa290ccc655c22d257
parentd78f802f18ed100c53f331cd59791cd82ccb9438
bridge: add missing bridge port check for offloads

This patch fixes a missing bridge port check caught by smatch.

setlink/dellink of attributes like vlans can come for a bridge device
and there is no need to offload those today. So, this patch adds a bridge
port check. (In these cases however, the BRIDGE_SELF flags will always be set
and we may not hit a problem with the current code).

smatch complaint:

The patch 68e331c785b8: "bridge: offload bridge port attributes to
switch asic if feature flag set" from Jan 29, 2015, leads to the
following Smatch complaint:

net/bridge/br_netlink.c:552 br_setlink()
 error: we previously assumed 'p' could be null (see line 518)

net/bridge/br_netlink.c
   517
   518 if (p && protinfo) {
                    ^
Check for NULL.

Reported-By: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_netlink.c