s390: Replace weird use of PTR_RET.
authorRusty Russell <rusty@rustcorp.com.au>
Mon, 15 Jul 2013 01:51:32 +0000 (11:21 +0930)
committerRusty Russell <rusty@rustcorp.com.au>
Mon, 15 Jul 2013 01:55:02 +0000 (11:25 +0930)
commit228b82211b47b597fa75dff2ac146b40eaaddf18
treefc453094bf34a0159d2d335fbd9c507ba420c968
parent8c6ffba0eddc8c110dbf444f51354ce42069abfc
s390: Replace weird use of PTR_RET.

Saves repeating "(void __force *)__uptr" but it's less clear.  Using
the output of PTR_RET() to determine the error rather than just
testing IS_ERR() is odd.

For example, I *assume* __gptr_to_uptr() never returns NULL?  Because
the __ret would be 0 for the old code.  The new version is clearer, IMHO:
it would try to get_user() on that address.

If you hate this variant, I can just s/PTR_RET/PTR_ERR_OR_ZERO/ instead.

Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
arch/s390/kvm/gaccess.h