projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 713e429) | patch
Fix reliance on the sign of char in fnv32 and fnv64
authorChristopher Dykes <cdykes@fb.com>
Thu, 25 May 2017 19:48:25 +0000 (12:48 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Thu, 25 May 2017 19:55:52 +0000 (12:55 -0700)
commit22d531a8fe503001a51672750dc09daae252fbf6
treef7f118accf1d3b7c6f8d650288206f3ca55afd46tree | snapshot
parent713e429835eb97113f52baa77f59a7787338c32acommit | diff
Fix reliance on the sign of char in fnv32 and fnv64

Summary:
Clearly someone noticed this was an issue before and fixed the other 2 overloads, but never fixed these :(

Specifically, ARM has unsigned chars, so this would be producing the wrong values there.

Reviewed By: yfeldblum, mzlee

Differential Revision: D5122992

fbshipit-source-id: eb71dea82c187c09c2c4496f1f7c99bd01db6dd0
folly/Hash.h diff | blob | history
folly/test/HashTest.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.