ethtool: exit the loop when invalid index occurs
authorJean Sacren <sakiwit@gmail.com>
Sun, 27 Apr 2014 08:20:38 +0000 (02:20 -0600)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Apr 2014 17:28:43 +0000 (13:28 -0400)
commit266a16468432a77f2e1395b3de5df3ca699b1a9a
treea7cc7f9a4b18cb5654d05f9a77b29eb5a3e91c00
parenta49eb42a341f1df8fa0f9dc4449f9dd4a3234a2f
ethtool: exit the loop when invalid index occurs

The commit 3de0b592394d ("ethtool: Support for configurable RSS hash
key") introduced a new function ethtool_copy_validate_indir() with
full iteration of the loop to validate the ring indices, which could
be an overkill. To minimize the impact, we ought to exit the loop as
soon as the invalid index occurs for the very first time. The
remaining loop simply doesn't serve any more purpose.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Cc: Venkata Duvvuru <VenkatKumar.Duvvuru@Emulex.Com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/ethtool.c