ARM: 7803/1: Fix deadlock scenario with smp_send_stop()
authorStephen Boyd <sboyd@codeaurora.org>
Tue, 30 Jul 2013 22:09:46 +0000 (23:09 +0100)
committer黄涛 <huangtao@rock-chips.com>
Mon, 5 May 2014 08:17:08 +0000 (16:17 +0800)
commit28650a80a69861af23ebb212cc1882df1e152b80
treebb0d6351ac77cdeb94e6af6e37a02a249ae63724
parente7d4ec96a96505d1fca0d523623e45e7f0304d78
ARM: 7803/1: Fix deadlock scenario with smp_send_stop()

If one process calls sys_reboot and that process then stops other
CPUs while those CPUs are within a spin_lock() region we can
potentially encounter a deadlock scenario like below.

CPU 0                   CPU 1
-----                   -----
                        spin_lock(my_lock)
smp_send_stop()
 <send IPI>             handle_IPI()
                         disable_preemption/irqs
                          while(1);
 <PREEMPT>
spin_lock(my_lock) <--- Waits forever

We shouldn't attempt to run any other tasks after we send a stop
IPI to a CPU so disable preemption so that this task runs to
completion. We use local_irq_disable() here for cross-arch
consistency with x86.

Reported-by: Sundarajan Srinivasan <sundaraj@codeaurora.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/kernel/process.c