folly/stats/Histogram-defs.h: avoid -Wsign-compare error
Summary:
* folly/stats/Histogram-defs.h (HistogramBuckets): Take the unusual
approach of converting "numBuckets" to signed, because we cannot
cast "max-min" (a known positive value) to an unsigned type --
we don't have an unsigned variant of ValueType.
This avoids the following error from gcc-4.9:
folly/stats/Histogram-defs.h:41:31: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
Test Plan:
Run this and note there are fewer errors than before:
fbconfig --platform-all=gcc-4.9-glibc-2.20 -r folly && fbmake dbgo
Reviewed By: ldbrandy@fb.com
Subscribers: trunkagent, net-systems@, folly-diffs@
FB internal diff:
D1770129
Tasks:
5941250
Signature: t1:
1770129:
1420745311:
c447e59f1730abafdf0b962e70f0886ae1d48db1