Revert "mac80211: allow disable power save in mesh"
authorBob Copeland <me@bobcopeland.com>
Tue, 29 Oct 2013 22:11:59 +0000 (18:11 -0400)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 25 Nov 2013 15:50:00 +0000 (16:50 +0100)
commit2d3db210860f1df099a35b1dd54cca35454e0361
tree2e2dc56a96b43a55db998382f5e56facf2d44032
parent91398a0992c8aa18eb7749060b75761ece5ddc57
Revert "mac80211: allow disable power save in mesh"

This reverts commit ee1f668136b2fb6640ee2d54c2a525ea41f98211.

The aformentioned commit added a check to allow
'iw wlan0 set power_save off' to work for mesh interfaces.

However, this is problematic because it also allows
'iw wlan0 set power_save on', which will crash in short order
because all of the subsequent code manipulates sdata->u.mgd.

The power-saving states for mesh interfaces can be manipulated
through the mesh config, e.g:
'iw wlan0 set mesh_param mesh_power_save=active' (which,
despite the name, actualy disables power saving since the
setting refers to the type of sleep the interface undergoes).

Cc: stable@vger.kernel.org
Fixes: ee1f668136b2 ("mac80211: allow disable power save in mesh")
Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/cfg.c