nfs: fix null checking in nfs_get_option_str()
authorXi Wang <xi.wang@gmail.com>
Fri, 4 Jan 2013 08:22:57 +0000 (03:22 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Jan 2013 17:03:38 +0000 (09:03 -0800)
commit31c4e8cd42eb2f6aedccd13670e113d2ca1db39e
tree6f0ac9410a4a001c60006341ce8b3e8280191d36
parentd6e0c42ccbb489d73ebc3973583474257a028d66
nfs: fix null checking in nfs_get_option_str()

commit e25fbe380c4e3c09afa98bcdcd9d3921443adab8 upstream.

The following null pointer check is broken.

*option = match_strdup(args);
return !option;

The pointer `option' must be non-null, and thus `!option' is always false.
Use `!*option' instead.

The bug was introduced in commit c5cb09b6f8 ("Cleanup: Factor out some
cut-and-paste code.").

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/super.c