thermal: rockchip: fix a impossible condition caused by the warning
authorCaesar Wang <wxt@rock-chips.com>
Sun, 20 Dec 2015 09:06:45 +0000 (17:06 +0800)
committerHuang, Tao <huangtao@rock-chips.com>
Wed, 3 Feb 2016 02:27:49 +0000 (10:27 +0800)
commit3e25ac60e8129cf16566b6942da01a209a8d521f
tree0fa09f7abd77a8ee13e2cf99de2398328a906e2c
parent7d99e9021566d6f5820df40d18650f8ef4e14c8f
thermal: rockchip: fix a impossible condition caused by the warning

As the Dan report the smatch check the thermal driver warning:
drivers/thermal/rockchip_thermal.c:551 rockchip_configure_from_dt()
warn: impossible condition '(thermal->tshut_temp > ((~0 >> 1))) =>
(s32min-s32max > s32max)'

Although The shut_temp read from DT is u32,the temperature is currently
represented as int not long in the thermal driver.
Let's change to make shut_temp instead of the thermal->tshut_temp for
the condition.

Fixes: commit 437df2172e8d
("thermal: rockchip: consistently use int for temperatures")

Change-Id: I7951bf83baec2ef0ae8fe50d5735f992a7d3ed41
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
drivers/thermal/rockchip_thermal.c