Make ProcessReturnCode default-constructible
authorAlexey Spiridonov <lesha@fb.com>
Mon, 27 Jul 2015 02:36:57 +0000 (19:36 -0700)
committerfacebook-github-bot-4 <folly-bot@fb.com>
Mon, 27 Jul 2015 03:22:13 +0000 (20:22 -0700)
commit3f277b37615ce99eeb38e21922053c8b4c8ba2db
treea4068663f1a5a460b5ecb14efe427c2f17e8c6dc
parentb10e3e8663d4d7cb8ca7246db980b5f3e5e7bb97
Make ProcessReturnCode default-constructible

Summary: We have this previously-unused "NOT STARTED" status, which I recently appropriated to denote moved-out `ProcessReturnCode`s.

It's natural to also use this for default-constructed `ProcessReturnCodes`. Lacking a default constructor leads to a bunch of unnecessarily annoying use of `folly::Optional` in my upcoming diff, so I wanted to get rid of that, see e.g.

differential/diff/7657906/

Reviewed By: @tudor

Differential Revision: D2097368
folly/Subprocess.h
folly/test/SubprocessTest.cpp