drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref
authorJesper Juhl <jj@chaosbits.net>
Fri, 23 Mar 2012 00:08:34 +0000 (01:08 +0100)
committerMatthew Garrett <mjg@redhat.com>
Mon, 26 Mar 2012 19:45:32 +0000 (15:45 -0400)
commit41603e9783a24c8c7cce548c0819bdc9e46a585b
treed309d27fd11f922cb20cab809ac3db9096ff2377
parenta979e2e2af7d5b4bb3b20f6a716c627bb23a6753
drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref

In drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() the call
to dmi_first_match() may fail and return NULL. If it does return NULL,
then we'll be dereferencing a NULL pointer in the rfkill_alloc() call
where we do 'system_id->driver_data' --> KABOOM!

Avoid that problem by testing for a NULL return value from
dmi_first_match() and bailing out if it fails.

I was a bit uncertain about what to return in the failure case. In the
end I settled for -ENXIO as the most logical error to return.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/amilo-rfkill.c