usb: gadget: check for accessory device before disconnecting HIDs
authorAmit Pundir <amit.pundir@linaro.org>
Fri, 16 Jan 2015 00:11:10 +0000 (05:41 +0530)
committerBadhri Jagan Sridharan <badhri@google.com>
Mon, 26 Jan 2015 20:29:19 +0000 (20:29 +0000)
commit41ba06281471b7ade8782204079f92633caf7285
tree0c692b96ae9c1a28d346a3c530f3eb1aa442b721
parent0d7c7ba9f6428e694130a40e270516618f27ce14
usb: gadget: check for accessory device before disconnecting HIDs

While disabling ConfigFS Android gadget, android_disconnect() calls
kill_all_hid_devices(), if CONFIG_USB_CONFIGFS_F_ACC is enabled, to free
the registered HIDs without checking whether the USB accessory device
really exist or not. If USB accessory device doesn't exist then we run into
following kernel panic:
----8<----
[  136.724761] Unable to handle kernel NULL pointer dereference at virtual address 00000064
[  136.724809] pgd = c0204000
[  136.731924] [00000064] *pgd=00000000
[  136.737830] Internal error: Oops: 5 [#1] SMP ARM
[  136.738108] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.18.0-rc4-00400-gf75300e-dirty #76
[  136.742788] task: c0fb19d8 ti: c0fa4000 task.ti: c0fa4000
[  136.750890] PC is at _raw_spin_lock_irqsave+0x24/0x60
[  136.756246] LR is at kill_all_hid_devices+0x24/0x114
---->8----

This patch adds a test to check if USB Accessory device exists before freeing HIDs.

Change-Id: Ie229feaf0de3f4f7a151fcaa9a994e34e15ff73b
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
(cherry picked from commit 32a71bce154cb89a549b9b7d28e8cf03b889d849)
drivers/usb/gadget/f_accessory.c