[LPM] Fix a logic error in LICM spotted by inspection.
authorChandler Carruth <chandlerc@gmail.com>
Fri, 24 Jan 2014 02:24:47 +0000 (02:24 +0000)
committerChandler Carruth <chandlerc@gmail.com>
Fri, 24 Jan 2014 02:24:47 +0000 (02:24 +0000)
commit4296ce566202cf00ba2beeb3344db0ea20af0e6f
tree85a39df99b2ceb1cc45835273f8910c586084e2a
parent5950c6fa48fe607e253afab421fa286f5f8e44bf
[LPM] Fix a logic error in LICM spotted by inspection.

We completely skipped promotion in LICM if the loop has a preheader or
dedicated exits, but not *both*. We hoist if there is a preheader, and
sink if there are dedicated exits, but either hoisting or sinking can
move loop invariant code out of the loop!

I have no idea if this has a practical consequence. If anyone has ideas
for a test case, let me know.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199966 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Transforms/Scalar/LICM.cpp