folly: accommodate use of -Wshadow in other projects
authorJim Meyering <meyering@fb.com>
Thu, 13 Jun 2013 16:54:17 +0000 (09:54 -0700)
committerJordan DeLong <jdelong@fb.com>
Wed, 26 Jun 2013 02:45:57 +0000 (19:45 -0700)
commit46de7098b46d000be284450d582c14608cab6f93
treea175e40abf0e0cec1fcd6c7f2aa3d8c8244570f8
parent76ade9184fe7702e0e6547e0bd3553f810304b59
folly: accommodate use of -Wshadow in other projects

Summary:
Without this change, any folly-using project that attempts to enable
gcc's -Wshadow option will be overwhelmed by warnings about violations
in folly's class definitions.  Violations are often due to local
variable or parameter names shadowed by a member function.

Bracket offending content with directives like this:

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wshadow"
...
#pragma GCC diagnostic pop

This set of modified files is the minimal set to allow tao
to use -Wshadow with no folly-related warning.

Test Plan:
fbmake folly/test && fbmake opt

Reviewed By: simpkins@fb.com

FB internal diff: D848455
folly/FBString.h
folly/Format.h
folly/Range.h
folly/experimental/Gen-inl.h
folly/io/IOBuf.h
folly/small_vector.h