projects / folly.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 5eb31cb) | patch
Make NeedleFinderTest::Needles256 actually do things
authorChristopher Dykes <cdykes@fb.com>
Tue, 8 Nov 2016 18:40:14 +0000 (10:40 -0800)
committerFacebook Github Bot <facebook-github-bot-bot@fb.com>
Tue, 8 Nov 2016 18:53:28 +0000 (10:53 -0800)
commit4aa69c20b6b6b1e20eb6e6c1dd072ae8d1b02ac5
tree7226665172a255145dd8bd8dea10f2a0af5ed8batree | snapshot
parent5eb31cb370265933a05d1e162c137f7f0c74a5c8commit | diff
Make NeedleFinderTest::Needles256 actually do things

Summary:
The min value of a `char` is `-128`, but we're initializing our `size_t` i's with it, so, as MSVC quite rightly warns (as C6294) the condition is never true and the loop never loops.
Fix it by signing our i's.

Reviewed By: yfeldblum

Differential Revision: D4145419

fbshipit-source-id: 87591d0f84c54472b1b5847e025d091de3f98bca
folly/test/RangeTest.cpp diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.