hwmon: (gpio-fan) Fix fan_ctrl_init error path
authorAxel Lin <axel.lin@gmail.com>
Tue, 9 Nov 2010 08:41:48 +0000 (08:41 +0000)
committerGuenter Roeck <guenter.roeck@ericsson.com>
Thu, 11 Nov 2010 17:43:51 +0000 (09:43 -0800)
commit4f5b7994f0610fefff0782227ab71469ece54a5b
tree15469190314d8eabd4d15370d57222348f896c74
parentf0030d87be3cb2eb9eac633d09cb5d9f107ed0c6
hwmon: (gpio-fan) Fix fan_ctrl_init error path

In current implementation, the sysfs entries is not removed before return -ENODEV.

Creating the sysfs attribute should be the last thing done by the function,
after all the rest has been successful.
Otherwise there is a small window during which user-space can access the attribute
but the driver isn't ready to deal with the requests.

Fix it by moving sysfs_create_group to be the last thing done by the function.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Simon Guinot <sguinot@lacie.com>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
drivers/hwmon/gpio-fan.c